From patchwork Sat Mar 16 20:09:53 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Eric Dumazet X-Patchwork-Id: 1057406 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=google.com header.i=@google.com header.b="M3h6GYz0"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 44MD7s04qvz9s47 for ; Sun, 17 Mar 2019 07:10:00 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726703AbfCPUJ6 (ORCPT ); Sat, 16 Mar 2019 16:09:58 -0400 Received: from mail-pf1-f201.google.com ([209.85.210.201]:46484 "EHLO mail-pf1-f201.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726549AbfCPUJ6 (ORCPT ); Sat, 16 Mar 2019 16:09:58 -0400 Received: by mail-pf1-f201.google.com with SMTP id j10so14366291pfn.13 for ; Sat, 16 Mar 2019 13:09:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:message-id:mime-version:subject:from:to:cc; bh=t5Sc/u0MLKKX8BegqTiA7Voj7e/vVjBDoKYDztgzvjM=; b=M3h6GYz0jyHBewOhJ1/3frl2DyBgoGmHgmlbsAnbGw1Y20/1ZJRIfennGDtvauDyfB HATz7WEEP2Bc5sDwriUpTdCdm5W7NCZrqjrG6H/46kVXqQPleny1dRMYT11V5YWL2y6Y hDYljxZzImFzfI29T2i1msD3jMMtcyQ4iyTPoGwmkgWFg8LMem1V3yA6inrUPza0SWAy iM072SYv9+sB17690e1wB6dYgP1MVnMJKofvfabydZfVkIqn8epxAlb9n0kcotAm63hc o4LiJp99H5QlbggwBGH0tT66D10ZMBGNQ8ZRbtYfUD4smEwhAU968UrqXWp53/bVS43d x5Gg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:message-id:mime-version:subject:from:to:cc; bh=t5Sc/u0MLKKX8BegqTiA7Voj7e/vVjBDoKYDztgzvjM=; b=WEVxOVCd8b2R3hDrrFaS9SkUjsTsaTloqgW7aDtrSMlarhcidyAUL4BzCXEOtkAQXY iFTPnKnhmoN+YfMYjGgKvL0gH/BBnXcMW+Ev2XurP5M8kiDVFKk0YKHq6o4qU+1FwHh0 fExhkaGqvLH5NzzaomrEHWPmTyosRfmJOBbo84VzDTCr6SBOuQNm1vwaRlfti0jnQ2bp yGvsy9nWqj/xrqZv8f2RErINQ/EaCmbeiM3LxzGcQaqL3SGoZ6mQ3QHbajJirHPsEz1Q lGMBTb88Lbs3Gl82DUCH/oCRZL4yFmYLmtJGF7xAkIyVW5b8/IEkYJG5l6yMC/Q4fii2 snXg== X-Gm-Message-State: APjAAAXL7ydAcNFh2QlimIiH5GfUbjPC5t0OxqQdTeC06vO1aOu4XR0c Rrlv2TOrMIgoQ6ZDPA5zPT9Pfa6fM1izfw== X-Google-Smtp-Source: APXvYqw871lLhEDLvEqb3cDt64Zo+U+IVoGyfvNA5XYftz29PXF14Z3Xabirv4tsAqP+PE/HLMoA5Y4+XZT1ZA== X-Received: by 2002:a17:902:1127:: with SMTP id d36mr3307949pla.127.1552766997301; Sat, 16 Mar 2019 13:09:57 -0700 (PDT) Date: Sat, 16 Mar 2019 13:09:53 -0700 Message-Id: <20190316200953.28881-1-edumazet@google.com> Mime-Version: 1.0 X-Mailer: git-send-email 2.21.0.225.g810b269d1ac-goog Subject: [PATCH net] tun: add a missing rcu_read_unlock() in error path From: Eric Dumazet To: "David S . Miller" Cc: netdev , Eric Dumazet , Eric Dumazet , syzbot Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org In my latest patch I missed one rcu_read_unlock(), in case device is down. Fixes: 4477138fa0ae ("tun: properly test for IFF_UP") Signed-off-by: Eric Dumazet Reported-by: syzbot --- drivers/net/tun.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/tun.c b/drivers/net/tun.c index 0d343359f647ff58fee35462358827e61857c837..e9ca1c088d0b11611e4d80268ced3806db05cffb 100644 --- a/drivers/net/tun.c +++ b/drivers/net/tun.c @@ -1960,6 +1960,7 @@ static ssize_t tun_get_user(struct tun_struct *tun, struct tun_file *tfile, rcu_read_lock(); if (unlikely(!(tun->dev->flags & IFF_UP))) { err = -EIO; + rcu_read_unlock(); goto drop; }