From patchwork Wed Mar 13 21:05:43 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rosen Penev X-Patchwork-Id: 1056221 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=lists.openwrt.org (client-ip=2607:7c80:54:e::133; helo=bombadil.infradead.org; envelope-from=openwrt-devel-bounces+incoming=patchwork.ozlabs.org@lists.openwrt.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="dgdwiucF"; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="pX5k5ISW"; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 44KPXB1QfTz9s6w for ; Thu, 14 Mar 2019 08:06:16 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:List-Subscribe:List-Help: List-Post:List-Archive:List-Unsubscribe:List-Id:Subject:References: In-Reply-To:Message-Id:Date:To:From:Reply-To:Cc:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=s7vF3zGSgrVtpfq/GgCTLsa5E26WQEC0HGHYnEIZgS0=; b=dgdwiucFYEewD5US4ZbfNeXyN2 jAe+5Hbay4J+WGOIZDOhaMz2AEEULgxF4T278wLFoU8YcJlj+5sRj6KjwbKFGRTbFmrVcJkNdLpLo inZWTbXTCNro/oQ6bPcN4nX2r9uF5fYo0bEhubORi7z6DWcRJfrZwFtiebZ1IWY5gxqW6X0tMLg7C Du3TtKo/Icm5Q7JtLC+8p+HLtxKouMNfUZICUDH/zNTmk6+ZZCz1G7OWqlIPa3pJW+btIhBOoVb2f w0eTHyhlteh/BODSeXQrwBdBaAzlRH0KWOAlucKAuRsR4pEb95I9KHaEGp9w0e3c+DEJuoEnxLVo0 TprZ9gbw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h4B4Z-0003xA-0N; Wed, 13 Mar 2019 21:05:59 +0000 Received: from mail-pg1-x544.google.com ([2607:f8b0:4864:20::544]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h4B4Q-0003oV-0p for openwrt-devel@lists.openwrt.org; Wed, 13 Mar 2019 21:05:51 +0000 Received: by mail-pg1-x544.google.com with SMTP id u9so2384769pgo.7 for ; Wed, 13 Mar 2019 14:05:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:in-reply-to:references; bh=vjRiwRJG6d0z9vqoLmFbu+YvvWFr3TRQUfmwIPDcglU=; b=pX5k5ISWjV8mOQcs8Zxe/0h3roceK6eWYZW3Q/8qr+CKf0WJki1YH6cnhqh0nvUeA3 hQsBCP+IpAbrlvZnIRoPw9i0/BaLQfKkuMwDerQ+ZSK5Wv1az0v5ey8Lrd1iacAec/kp ieoGpJ0FckjHPmDIbIt3KDf4IQUNGf+RqfXlecJnVUT/B3EnJuEVK23oEwSQGrwqP8Iu 0erRrkm2Yfyn1geuljnrrw3lVebGCwX0WBBbJW405fXWjxhP/mEEbF1wcCW2EVOkWzCn KxtdjeaQevWLMZFxZNqijhFFPv/usfeu2xbc8zuAvzVQlZ2/AJnbYPMpL17QlqKUahXz R5+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references; bh=vjRiwRJG6d0z9vqoLmFbu+YvvWFr3TRQUfmwIPDcglU=; b=PN5JMPzSUlkMJw8TfaULu41SDXM1Rpu26i3BBik2QxyG6SnUaEC7IersJy2U2Gn8xm gR2UudEdH1w5X4R6ezg/PccQX9nne4PFl+YxJcYWcWDwxIk7l6uMTDlqmtx8iRtYK/V4 fBulCjG23tqZ18qI4Hxg1yPIDe9t6aX2ZVM264yYHR2y6ilLozwhPE91LMDMee8x2liY BplXVxZN1ssxKzZrd5SkbcxzS3c1d6XeL52OXtGJV+bCnt/nql7ljCb+/D0XNBLCdy3H M5/F7ikKnIA/fivbvP+l8Z4gFUrglmG9ksDE7rJH1wmchrpUbGOL8tQITpcJKHYpm7Yi W5MQ== X-Gm-Message-State: APjAAAUuhd4s7lx0OygqVLTxIBPCM4sIoAXUEAw50KYN7f+99j2/KLVl SLgUFjqeiJRFIseTS36sempxRnLm X-Google-Smtp-Source: APXvYqx+cg+Ids/PBdJMxKKYsDeR24Rdzhd4LiyrkhV2fttQAgGoQKuzZvdDEROxVAbYb+eW0aCbbw== X-Received: by 2002:a63:c64c:: with SMTP id x12mr42151800pgg.285.1552511148983; Wed, 13 Mar 2019 14:05:48 -0700 (PDT) Received: from mangix-pc.lan (astound-69-42-18-19.ca.astound.net. [69.42.18.19]) by smtp.gmail.com with ESMTPSA id 70sm30981956pfr.43.2019.03.13.14.05.47 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 13 Mar 2019 14:05:48 -0700 (PDT) From: Rosen Penev To: openwrt-devel@lists.openwrt.org Date: Wed, 13 Mar 2019 14:05:43 -0700 Message-Id: <20190313210544.4872-2-rosenp@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190313210544.4872-1-rosenp@gmail.com> References: <20190313210544.4872-1-rosenp@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190313_140550_058999_23E569C2 X-CRM114-Status: UNSURE ( 9.38 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.2 on bombadil.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2607:f8b0:4864:20:0:0:0:544 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (rosenp[at]gmail.com) -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain Subject: [OpenWrt-Devel] [PATCH 2/3] ramips: ethernet: Fix NAPI weight for non mt7621 devices X-BeenThere: openwrt-devel@lists.openwrt.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: "openwrt-devel" Errors-To: openwrt-devel-bounces+incoming=patchwork.ozlabs.org@lists.openwrt.org My original fix was to make the code do 16 * 4 as 64 is the limit for NAPI weight. However this also reduces the weight for non mt7621 devices. Changed the multiplier to 2 instead. Signed-off-by: Rosen Penev --- .../drivers/net/ethernet/mediatek/mtk_eth_soc.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/target/linux/ramips/files-4.14/drivers/net/ethernet/mediatek/mtk_eth_soc.c b/target/linux/ramips/files-4.14/drivers/net/ethernet/mediatek/mtk_eth_soc.c index d110787731..934ed010bc 100644 --- a/target/linux/ramips/files-4.14/drivers/net/ethernet/mediatek/mtk_eth_soc.c +++ b/target/linux/ramips/files-4.14/drivers/net/ethernet/mediatek/mtk_eth_soc.c @@ -1624,11 +1624,11 @@ static int fe_probe(struct platform_device *pdev) INIT_WORK(&priv->pending_work, fe_pending_work); u64_stats_init(&priv->hw_stats->syncp); - napi_weight = 16; + napi_weight = 32; if (priv->flags & FE_FLAG_NAPI_WEIGHT) { - napi_weight *= 4; - priv->tx_ring.tx_ring_size *= 4; - priv->rx_ring.rx_ring_size *= 4; + napi_weight *= 2; + priv->tx_ring.tx_ring_size *= 2; + priv->rx_ring.rx_ring_size *= 2; } netif_napi_add(netdev, &priv->rx_napi, fe_poll, napi_weight); fe_set_ethtool_ops(netdev); From patchwork Wed Mar 13 21:05:44 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rosen Penev X-Patchwork-Id: 1056222 X-Patchwork-Delegate: blogic@openwrt.org Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=lists.openwrt.org (client-ip=2607:7c80:54:e::133; helo=bombadil.infradead.org; envelope-from=openwrt-devel-bounces+incoming=patchwork.ozlabs.org@lists.openwrt.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="PZDHrlSq"; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="TZHCrxOZ"; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 44KPXD1gLXz9s9N for ; Thu, 14 Mar 2019 08:06:20 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:List-Subscribe:List-Help: List-Post:List-Archive:List-Unsubscribe:List-Id:Subject:References: In-Reply-To:Message-Id:Date:To:From:Reply-To:Cc:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=CVTNzuwghs4s4Aj+LJ/+0o7xAQzUP4hiFFx/VznGqVs=; b=PZDHrlSq547HRxBdnt6P03a04r zEe9fgPrfWYoKNT/pQrQNFOawv1piND2FDZeotlYjdDEoX4ZUSu6BF3Q26QdOUKuZ/wEhf8t7LFip lXUSePfoJi4ahE9EYfrgCMfGOPVjLfpWppq2Jx6joKv3Us44TQUaqrqvNwyclc2nJg+bcjmXsPuHY yE6n2FjRHthmdssyOBgakGqkmM9mG3lLIoXPlWXyL8IZliaCrN/DFGb+fcBAuHg4H1mHc9fI/CCcn C9tdfhIFUOM6zBJBfsaF77be9iYAcX7bYerMJxTDpGsp8Qq0IJ+fj7f0Ud1VqwxYno5XkuiA4eXDK GkS0kIJw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h4B4j-0004FB-Nl; Wed, 13 Mar 2019 21:06:09 +0000 Received: from mail-pg1-x542.google.com ([2607:f8b0:4864:20::542]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h4B4Q-0003oh-Sf for openwrt-devel@lists.openwrt.org; Wed, 13 Mar 2019 21:05:52 +0000 Received: by mail-pg1-x542.google.com with SMTP id h34so2368042pgh.11 for ; Wed, 13 Mar 2019 14:05:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:in-reply-to:references; bh=QQKfRugRh6I0O68CGoQhaM1VWM4HjiqJgqtYMUVwLwM=; b=TZHCrxOZzVdBuy0ZgEbMZ6QOpUANhUmV/ciun5M5oWIKxxDLyFoZI35nIP6jC9Jo+E By/1a2sDLZmq8K8bJYcSYjzDPWnUFEQqRJ9/eT+Gvu+8bvv22hAC48ORwvYi3i5BO4S1 t4sRstqBilQdQBgPS86fgKm5WGmdwOeSfnTrVLivsHnK6dYBNZHb6XRyMli6eEa2FDvq R/Vh7HCFMAHRH08L/YDdbAAtsSBgB+4UhgpmdWgNl/SUsTfNr+mc9mnj3fJgBCLUDaiF tXNqzksJzNxmGLdgJ21jFhFiVEtaTLgx4ch5iyv4VasZxZDQ6ZXt/UQ2h+yeoG0FZI2E eXnQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references; bh=QQKfRugRh6I0O68CGoQhaM1VWM4HjiqJgqtYMUVwLwM=; b=GLO0lqBWHeVVTG9BRPlR9bvTIXoexNG6yD/tCXLbeNF6+phDZAsY+Ua8tyQAbKUa0V A8O3a9BPLMt4NOSwFOL6a9mGhusiZDmMmdhyw1EcrYM2ECYCsbPOVHNGxGCJaBSWB6WB lgEzDSNZ113eadNIaMwhXwkro3iA6FKEdAE79cIrvAxdV/MAW9ZAZi9FnoNCGi849I+2 wL1ZfXiRtcR2A5Lsjpb2MAzOEeg54RKZ5TbCUmBvLLzhKOrVQCCjdopqwVW7l1577an/ GPYI3gz3GecHw6QuwnY2Io8UFggOLolP7aePYP7EDKdb48iyqwgSOQ2jj8xXZQ+RHF9p qjxQ== X-Gm-Message-State: APjAAAXYWWgW9IStLC5lex5/wgMZv6ciu4U7sH3r076SKGrWKZpDU7bu I5myrBZJ3I3WGLNpJZszN+OusAnj X-Google-Smtp-Source: APXvYqxhJ97C5JemyXehnCqAgQKKCfcAG2701HoYShDk7c29uP15dDlaY9KmZjvP+C/Ofk6EmTFrdQ== X-Received: by 2002:a17:902:9341:: with SMTP id g1mr48262501plp.80.1552511150139; Wed, 13 Mar 2019 14:05:50 -0700 (PDT) Received: from mangix-pc.lan (astound-69-42-18-19.ca.astound.net. [69.42.18.19]) by smtp.gmail.com with ESMTPSA id 70sm30981956pfr.43.2019.03.13.14.05.49 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 13 Mar 2019 14:05:49 -0700 (PDT) From: Rosen Penev To: openwrt-devel@lists.openwrt.org Date: Wed, 13 Mar 2019 14:05:44 -0700 Message-Id: <20190313210544.4872-3-rosenp@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190313210544.4872-1-rosenp@gmail.com> References: <20190313210544.4872-1-rosenp@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190313_140550_924664_DFDC28DB X-CRM114-Status: GOOD ( 10.09 ) X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.2 on bombadil.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2607:f8b0:4864:20:0:0:0:542 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (rosenp[at]gmail.com) -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain Subject: [OpenWrt-Devel] [PATCH 3/3] ramips: ethernet: Replace random_ether_addr with eth_hw_addr_random X-BeenThere: openwrt-devel@lists.openwrt.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: "openwrt-devel" Errors-To: openwrt-devel-bounces+incoming=patchwork.ozlabs.org@lists.openwrt.org eth_hw_addr_random additionally sets addr_assign_type to NET_ADDR_RANDOM. Signed-off-by: Rosen Penev --- .../files-4.14/drivers/net/ethernet/mediatek/mtk_eth_soc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/linux/ramips/files-4.14/drivers/net/ethernet/mediatek/mtk_eth_soc.c b/target/linux/ramips/files-4.14/drivers/net/ethernet/mediatek/mtk_eth_soc.c index 934ed010bc..c53421c36a 100644 --- a/target/linux/ramips/files-4.14/drivers/net/ethernet/mediatek/mtk_eth_soc.c +++ b/target/linux/ramips/files-4.14/drivers/net/ethernet/mediatek/mtk_eth_soc.c @@ -1348,7 +1348,7 @@ static int __init fe_init(struct net_device *dev) /* If the mac address is invalid, use random mac address */ if (!is_valid_ether_addr(dev->dev_addr)) { - random_ether_addr(dev->dev_addr); + eth_hw_addr_random(dev); dev_err(priv->dev, "generated random MAC address %pM\n", dev->dev_addr); }