From patchwork Sat Mar 9 05:49:34 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kangjie Lu X-Patchwork-Id: 1053796 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=umn.edu Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=umn.edu header.i=@umn.edu header.b="TSlntLE/"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 44GYNd3H0qz9s7h for ; Sat, 9 Mar 2019 16:49:53 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726110AbfCIFts (ORCPT ); Sat, 9 Mar 2019 00:49:48 -0500 Received: from mta-p8.oit.umn.edu ([134.84.196.208]:33108 "EHLO mta-p8.oit.umn.edu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725786AbfCIFtr (ORCPT ); Sat, 9 Mar 2019 00:49:47 -0500 Received: from localhost (unknown [127.0.0.1]) by mta-p8.oit.umn.edu (Postfix) with ESMTP id 308415B0 for ; Sat, 9 Mar 2019 05:49:46 +0000 (UTC) X-Virus-Scanned: amavisd-new at umn.edu Received: from mta-p8.oit.umn.edu ([127.0.0.1]) by localhost (mta-p8.oit.umn.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id bmZUZnoO3JRA for ; Fri, 8 Mar 2019 23:49:46 -0600 (CST) Received: from mail-it1-f197.google.com (mail-it1-f197.google.com [209.85.166.197]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mta-p8.oit.umn.edu (Postfix) with ESMTPS id 07F0FBD5 for ; Fri, 8 Mar 2019 23:49:46 -0600 (CST) Received: by mail-it1-f197.google.com with SMTP id q192so13618659itb.9 for ; Fri, 08 Mar 2019 21:49:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=umn.edu; s=google; h=from:to:cc:subject:date:message-id; bh=O96fONrE+kQXwreD9x0PMCN0fUD5949Yh6FwwievkFM=; b=TSlntLE/+GUqK+WucPC+CEGjIJw/FRV60NjB80uJZBZyuPU+qDabWSs/iobJbxaLE/ 9uotZzWLaumFnS9WVTvFSKZ4BE+O2PoPXTYsy9yWveeo+1kS93jeqySCgyQS1YvDVCUf wNw6A1wUBPBPSu1u0/qzJhv+1bNRbcUITRjqSGZKey3emE3je85JuIUyclRPJpfLz/pN xWZIHdFfalxXKMv029KDtLytJSDGcsxwFpAGNUO1Ey6hCTT4bb56kIQdJ44HVjXPcUcB c9+6DZY/BvuI1TCaL/yPjhDopUcf2xuV/YiLpwnGcE7D3GR9sg8rw8Q/r4vE8fKHHFOA tKFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=O96fONrE+kQXwreD9x0PMCN0fUD5949Yh6FwwievkFM=; b=nKGqqWYY8d32XJZ4Z+HbOx7u7e8D7fUZM8WfkzMlA3FrdYa22g5mAd+73fFsaTnuWk LtzKtUx/AcOEkBAX0w0Wz6fhABkE8hRo00kUossqsJ9GYK1IaUJzuaBGLe2pror6CG6c WN7BOZsHy9zgR8pkvTZo2pypY57LySEzTTH5zwo5UA40SshzVAbwhb6fQmHFEH5u8N+1 nXbJVej/nrZ4RAfz4v/a16gCtmSMJZKTQOCEnuafHUkvRviHT3D34IfqUZnRNV1FUNaW GiloRVVouBLgBXaJ3Yp+YOnI7eJRAidC3Rm3tQmyYgPxf2w3zthrPISitkraCifRp3Co hv9Q== X-Gm-Message-State: APjAAAUAjeL3/yM5oo7OBE3JIOrP1IMVSz4W5lLpr0+rwgt6nfik7MRH BqIHUWUTSyFE8q9XVdfhn35TAnTzB5B/llzHtHvRkCM/lO4MMoW5AXHAW7d1CirUWmbdWIVf14r IS/iVuxWb6VdUVuRznjOH X-Received: by 2002:a6b:7112:: with SMTP id q18mr1360928iog.5.1552110585579; Fri, 08 Mar 2019 21:49:45 -0800 (PST) X-Google-Smtp-Source: APXvYqw0tMc8yAMoN0xHl9fs33DHGhKeXLxXJ8rCkhoSlFMxaDAOuU1YRnm1AYZD62hkc8X+ojlgsQ== X-Received: by 2002:a6b:7112:: with SMTP id q18mr1360921iog.5.1552110585374; Fri, 08 Mar 2019 21:49:45 -0800 (PST) Received: from bee.dtc.umn.edu (cs-bee-u.cs.umn.edu. [128.101.106.63]) by smtp.gmail.com with ESMTPSA id b20sm4068924ioj.12.2019.03.08.21.49.44 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 08 Mar 2019 21:49:44 -0800 (PST) From: Kangjie Lu To: kjlu@umn.edu Cc: pakki001@umn.edu, Karsten Keil , "David S. Miller" , "Gustavo A. R. Silva" , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] isdn: mISDNinfineon: fix potential NULL pointer dereference Date: Fri, 8 Mar 2019 23:49:34 -0600 Message-Id: <20190309054936.24784-1-kjlu@umn.edu> X-Mailer: git-send-email 2.17.1 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org In case ioremap fails, the fix returns -ENOMEM to avoid NULL pointer dereference. Signed-off-by: Kangjie Lu --- drivers/isdn/hardware/mISDN/mISDNinfineon.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/isdn/hardware/mISDN/mISDNinfineon.c b/drivers/isdn/hardware/mISDN/mISDNinfineon.c index 3e01012be4ab..0fe6ddcb3fdc 100644 --- a/drivers/isdn/hardware/mISDN/mISDNinfineon.c +++ b/drivers/isdn/hardware/mISDN/mISDNinfineon.c @@ -712,8 +712,11 @@ setup_io(struct inf_hw *hw) (ulong)hw->addr.start, (ulong)hw->addr.size); return err; } - if (hw->ci->addr_mode == AM_MEMIO) + if (hw->ci->addr_mode == AM_MEMIO) { hw->addr.p = ioremap(hw->addr.start, hw->addr.size); + if (unlikely(!hw->addr.p)) + return -ENOMEM; + } hw->addr.mode = hw->ci->addr_mode; if (debug & DEBUG_HW) pr_notice("%s: IO addr %lx (%lu bytes) mode%d\n",