From patchwork Thu Mar 7 15:56:35 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sudarsana Reddy Kalluru X-Patchwork-Id: 1053042 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=marvell.com Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 44Fb0K4q38z9sD4 for ; Fri, 8 Mar 2019 02:58:57 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726692AbfCGP6z (ORCPT ); Thu, 7 Mar 2019 10:58:55 -0500 Received: from mail-eopbgr770082.outbound.protection.outlook.com ([40.107.77.82]:23603 "EHLO NAM02-SN1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726518AbfCGP6y (ORCPT ); Thu, 7 Mar 2019 10:58:54 -0500 Received: from DM6PR07CA0009.namprd07.prod.outlook.com (2603:10b6:5:94::22) by DM5PR07MB3003.namprd07.prod.outlook.com (2603:10b6:3:e3::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1686.18; Thu, 7 Mar 2019 15:58:52 +0000 Received: from BY2NAM05FT048.eop-nam05.prod.protection.outlook.com (2a01:111:f400:7e52::201) by DM6PR07CA0009.outlook.office365.com (2603:10b6:5:94::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.1686.16 via Frontend Transport; Thu, 7 Mar 2019 15:58:52 +0000 Authentication-Results: spf=fail (sender IP is 199.233.58.38) smtp.mailfrom=marvell.com; vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=fail action=none header.from=marvell.com; Received-SPF: Fail (protection.outlook.com: domain of marvell.com does not designate 199.233.58.38 as permitted sender) receiver=protection.outlook.com; client-ip=199.233.58.38; helo=CAEXCH02.caveonetworks.com; Received: from CAEXCH02.caveonetworks.com (199.233.58.38) by BY2NAM05FT048.mail.protection.outlook.com (10.152.100.185) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA) id 15.20.1686.5 via Frontend Transport; Thu, 7 Mar 2019 15:58:51 +0000 Received: from dut1171.mv.qlogic.com (10.112.88.18) by CAEXCH02.caveonetworks.com (10.67.98.110) with Microsoft SMTP Server (TLS) id 14.2.347.0; Thu, 7 Mar 2019 07:56:39 -0800 Received: from dut1171.mv.qlogic.com (localhost [127.0.0.1]) by dut1171.mv.qlogic.com (8.14.7/8.14.7) with ESMTP id x27FucQD014005; Thu, 7 Mar 2019 07:56:38 -0800 Received: (from root@localhost) by dut1171.mv.qlogic.com (8.14.7/8.14.7/Submit) id x27FubSv014004; Thu, 7 Mar 2019 07:56:37 -0800 From: Sudarsana Reddy Kalluru To: CC: , , Subject: [PATCH net 1/1] qede: Fix internal loopback failure with jumbo mtu configuration Date: Thu, 7 Mar 2019 07:56:35 -0800 Message-ID: <20190307155635.13968-1-skalluru@marvell.com> X-Mailer: git-send-email 2.12.0 MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-Matching-Connectors: 131964479320720897; (abac79dc-c90b-41ba-8033-08d666125e47); (abac79dc-c90b-41ba-8033-08d666125e47) X-Forefront-Antispam-Report: CIP:199.233.58.38; IPV:CAL; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(346002)(136003)(39860400002)(376002)(396003)(2980300002)(1110001)(1109001)(339900001)(189003)(199004)(42186006)(48376002)(26826003)(4326008)(50226002)(16586007)(8936002)(6862004)(305945005)(47776003)(81156014)(81166006)(107886003)(8676002)(498600001)(51416003)(68736007)(316002)(50466002)(26005)(1076003)(53936002)(126002)(97736004)(476003)(2906002)(105606002)(36906005)(54906003)(36756003)(86362001)(356004)(2616005)(80596001)(336012)(85426001)(87636003)(5660300002)(69596002)(486006)(106466001)(2351001); DIR:OUT; SFP:1101; SCL:1; SRVR:DM5PR07MB3003; H:CAEXCH02.caveonetworks.com; FPR:; SPF:Fail; LANG:en; PTR:InfoDomainNonexistent; MX:1; A:1; X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: a5bdbf1f-3173-493a-a059-08d6a315cb4a X-Microsoft-Antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(5600127)(711020)(4605104)(2017052603328); SRVR:DM5PR07MB3003; X-MS-TrafficTypeDiagnostic: DM5PR07MB3003: X-Microsoft-Antispam-PRVS: X-Forefront-PRVS: 096943F07A X-Microsoft-Exchange-Diagnostics: 1; DM5PR07MB3003; 23:RLQmnjzmgFpM0Zr2RvedcM7lH/OjR8ilca/13yozgFO6XqdD0UQZRAtjNKkLUfUWeR7TA/+3e9GrUG1la6KlQUtKgX7FgSM8oTOB3Lh4gEz5z8F3XjF1SN0zGOetnqiwkMoz/Cn2CuUZqWIcM4DDYZj63OD062E6lDC6KBsnCJ0ZXKc08/tD9amkI0INRTDbtrVVzHxF66gmKUFXmXJRbjpponHZ0z0Evd96SMLDNZs4jjHP+hroe2KUqyneBEru9T/A10xogdY5b3EPBeIBhMkKXRNQAApp8uv1jJKnJa5GN1CB7US7Vzqv+CHSzL5hQphuFtk49BCwtkaBlY/iM4lUPw2E86kCOiODHhcT0/Jq0JRT7CeYi0exy815HerEkelLotMvKf17mUwenpGMFSLqHsmWte33dzs6z9vFdOz5v6pDTUxWvWlP2rre9AJ95NA+h3P7lAGxXxUmK6EIaah5ceyoJWiox/OZ6bEbVAoaKh8gqNifWGcio0UjYZpga4CuaW7zeOf88K9s9xxjkT6nCCDpP2F7NlHxBzFAdmBx2sqdCNJ0Ful5am+ceDZS2NpOH3VsooXDf60fkNQFg8EBDMUA1rbVPQ+gXW7IuqnBS66obih70vWvFSYkuw6exeQocespO4SDveqdwNnkIe9xuZ218xlHqM0E5pIQ6XUA2oJfZRssmHnFyMXwl4d3v8V/jtKZsGqEIDfsqOmdKTgto7md0XErzk+1sqrCs6YIIJYIbYHhuEwY7AnCEmFpdGTVwLWKwFGHBeX87WCo205WZg3JAsoordYoKytC4gvIlalqVWFDRKWsxou833o+XVkCATRyrBs2n9cqbQC8wecH0E0N1379IlstHOfAGraUwLEmukY5v309VFVFEq+F26B4zvdJYfYbSuQZ4ShOgY4QVIzle16pzSC+JWMD4R6i6ungOqFNIXWy7DxzXs6ys0PUexbWWAeWj/lh0m34U3wrWqwzDctgs3hbFDZOENxfsTQhr7+op7UqIKjleuLiTU0/zj6pyMXsjwKPNWqP8Hkr1fP+f1xJZAcfJAKnrh3xzsDTdJ4a1qkQmoMsqQVI04I9PXdrKsUObZ9AUhDVyqNwUX4Xa3WrID40Lpq26ul8f3YmDzeeSuXSUVV6MLUIS/VL83aZ0M7VSkbVzGmbBA+HABO1ykVNR86q4y0jUx/uUvIX5hiBy55lr7sRhjkZ X-Microsoft-Antispam-Message-Info: ig0+UThs4uGOwYzXQ3g1TL9cMDitQCDGG2q7X8by0vfOF3W02DnsXfxlmaUH+iOFLqfZ49BZ/o0r6CtrmB7g7DSoSvXizzT/AdY1UDW96pmFF/DQM+FRt9A2tLqx1PP4ALWmsJcbQXF7r4tBMRO+fpNLCaLXdyP8NgaVLEh/kmviu9yrkOSHlNZSq4NLT3Z2DQZNz0zhfGiPnM73WWYkgheFYWZB15GYnRqRO2yo51nY37nPI1CH4rB/ril7YTBMCK0S2wRukhBAR4qbgYwsyYhKH1JSQDrc5KsEsYyeI3UBPBO+Y8+su3IjHegyTz0TYrwjBkJq4WOPNYIzysT2XESOqXnza/4SxczN0zT2UDgPfGaJqVP9tK0VeP2sy8LQnmqH0eaOeNS2EsG1WDI36goosZTb7zx3jSba63PUQGk= X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Mar 2019 15:58:51.7248 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: a5bdbf1f-3173-493a-a059-08d6a315cb4a X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[199.233.58.38]; Helo=[CAEXCH02.caveonetworks.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR07MB3003 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Driver uses port-mtu as packet-size for the loopback traffic. This patch limits the max packet size to 1.5K to avoid data being split over multiple buffer descriptors (BDs) in cases where MTU > PAGE_SIZE. Signed-off-by: Sudarsana Reddy Kalluru Signed-off-by: Ariel Elior --- drivers/net/ethernet/qlogic/qede/qede_ethtool.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/qlogic/qede/qede_ethtool.c b/drivers/net/ethernet/qlogic/qede/qede_ethtool.c index 16331c6..3ec2de4 100644 --- a/drivers/net/ethernet/qlogic/qede/qede_ethtool.c +++ b/drivers/net/ethernet/qlogic/qede/qede_ethtool.c @@ -1654,8 +1654,11 @@ static int qede_selftest_run_loopback(struct qede_dev *edev, u32 loopback_mode) /* Wait for loopback configuration to apply */ msleep_interruptible(500); - /* prepare the loopback packet */ - pkt_size = edev->ndev->mtu + ETH_HLEN; + /* Setting max packet size to 1.5K to avoid data being split over + * multiple BDs in cases where MTU > PAGE_SIZE. + */ + pkt_size = (((edev->ndev->mtu < ETH_DATA_LEN) ? + edev->ndev->mtu : ETH_DATA_LEN) + ETH_HLEN); skb = netdev_alloc_skb(edev->ndev, pkt_size); if (!skb) {