From patchwork Sat Mar 2 22:44:06 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heinrich Schuchardt X-Patchwork-Id: 1050739 X-Patchwork-Delegate: xypron.glpk@gmx.de Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.denx.de (client-ip=81.169.180.215; helo=lists.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=gmx.de Received: from lists.denx.de (dione.denx.de [81.169.180.215]) by ozlabs.org (Postfix) with ESMTP id 44BhDV4xmgz9s4V for ; Sun, 3 Mar 2019 09:44:24 +1100 (AEDT) Received: by lists.denx.de (Postfix, from userid 105) id 9363CC21D65; Sat, 2 Mar 2019 22:44:18 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=FREEMAIL_FROM autolearn=unavailable autolearn_force=no version=3.4.0 Received: from lists.denx.de (localhost [IPv6:::1]) by lists.denx.de (Postfix) with ESMTP id BA605C21C4A; Sat, 2 Mar 2019 22:44:15 +0000 (UTC) Received: by lists.denx.de (Postfix, from userid 105) id 3159CC21C3F; Sat, 2 Mar 2019 22:44:14 +0000 (UTC) Received: from mout.gmx.net (mout.gmx.net [212.227.15.15]) by lists.denx.de (Postfix) with ESMTPS id D7FC0C21C38 for ; Sat, 2 Mar 2019 22:44:13 +0000 (UTC) Received: from workstation4.fritz.box ([84.118.159.3]) by mail.gmx.com (mrgmx002 [212.227.17.184]) with ESMTPSA (Nemesis) id 0MFMIO-1goA870jpc-00ENrB; Sat, 02 Mar 2019 23:44:11 +0100 From: Heinrich Schuchardt To: AKASHI Takahiro Date: Sat, 2 Mar 2019 23:44:06 +0100 Message-Id: <20190302224406.19374-1-xypron.glpk@gmx.de> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 X-Provags-ID: V03:K1:JZkmLs8ZwYzlMdTNBp7v255OcM7bY6eyagGS9C6D0l9cUQQs9cY ETDd7TaemTvgDgd2I5p7LzS7SKglMpmNuvbMc/wD6V8JQqQARq5zE+iKQ7EK7ld/dgR8xzN +uuehyeYrbSt4Ih0V2gY0i1hw/l5iwtDmllzMwI8PAK03b2knD9K1pj0bflVSOTy921HDBn c9VHiFOSUWIKyDMHka2bQ== X-UI-Out-Filterresults: notjunk:1; V03:K0:dKOEfEK3GPs=:UX03xqu7l2DCSeibkbAU9E 4Eoi6aO9nh8xZxoqjlVHiwpOg0Iro/o8Y6MOWvqBC8sxZOoG5d/Vmdi72oWAgjB0c5D0jeDBw /ambAA5wW5V50MpVRcWHhL+eKHoPHE3ATkdytr9OWMptiUsqSD8wcc1h87HMRzu5pEcRKeOtm BsFBEKPoiI69mm1hsYUAc4avtsM1XWUVOClJKAfixAtZmqHFtbvTn34rK53rk8rQpUhBCLcqd ISQ5GsKpDQuhPGyg0mClXbCJt6H/4GGZrxTf0sHI/iySyfIfmZWTZj8Zw2qCJ8tDgXvSaOjhd 123hze3HOM9Btgx7+8hX2hGNaF9QRzzYlKGlGFYvH38B3f16OJ1guF2kL92nhDFBDRpGfW4cA EklhR8RA9E3glV3wk8BT+QL7JLuKFLrJOAchsNlqIwW6pKMQ4KGTXMr5RuOnjBUQYGb9v3jGt y6LimBVA3TPAubHeuS68Ha8RDka+Iif3FwA949dwM2z1OlzxAg08bJzDUgHejFaJSSGv9z7qx 9gugBt5cHt8fSmCZIpMidlF5FzKgs8rupAHRnBsJXwVjmkhYpSg+HVJQs9OqyUEyvlvFrxqr0 tB2OpnL7aMKmX6SuSpeNCwcB4Xy5DkBUKRKHl1UH7+frcFikLHvgpWkq8R0W5Z5FxCpyHDgQV wFU8nfpP9tvLNtP+ri9ntqYmyGIeuUCbofTSvYNa6RVAHa7nJFtP0wO2fim+x+TivHlVvbuSg Xy3W3nJhzs131qN7/t+W28xH0TvghN/6PwPjDEf2tkMjuaLUSp301GSxNXGn6SyY7vY2K49Ns F5X/lAxaHfS5vjQgtfB/QbOpben1Q6Bovcwl7N2UvMMoDOXuAqqkHwXiB9DeD/vaIdlXYZenc 0LouTvZQvaO8xD/1KkKnq6gyZt4FGt1VLq4k/iCdoUU7rTdw0L0dzk9uYvQaDj Cc: u-boot@lists.denx.de, Alexander Graf , Heinrich Schuchardt Subject: [U-Boot] [PATCH v3 1/1] efi_loader: HII protocols: debug messages X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.18 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" When package types are not supported by our implementation of the HII database protocol supported error messages are displayed. Essentially the output is only needed for debugging. By using EFI_PRINT() the messages are only written for in debug mode and with correct indentation. Signed-off-by: Heinrich Schuchardt --- v3 Use EFI_PRINT() and add no further prefix. v2 Use "EFI HII:" as prefix. --- lib/efi_loader/efi_hii.c | 36 ++++++++++++++++++------------------ 1 file changed, 18 insertions(+), 18 deletions(-) diff --git a/lib/efi_loader/efi_hii.c b/lib/efi_loader/efi_hii.c index 0ed4b19633..3a966fa4df 100644 --- a/lib/efi_loader/efi_hii.c +++ b/lib/efi_loader/efi_hii.c @@ -388,7 +388,7 @@ add_packages(struct efi_hii_packagelist *hii, (struct efi_hii_guid_package *)package); break; case EFI_HII_PACKAGE_FORMS: - printf("\tForm package not supported\n"); + EFI_PRINT("Form package not supported\n"); ret = EFI_INVALID_PARAMETER; break; case EFI_HII_PACKAGE_STRINGS: @@ -396,19 +396,19 @@ add_packages(struct efi_hii_packagelist *hii, (struct efi_hii_strings_package *)package); break; case EFI_HII_PACKAGE_FONTS: - printf("\tFont package not supported\n"); + EFI_PRINT("Font package not supported\n"); ret = EFI_INVALID_PARAMETER; break; case EFI_HII_PACKAGE_IMAGES: - printf("\tImage package not supported\n"); + EFI_PRINT("Image package not supported\n"); ret = EFI_INVALID_PARAMETER; break; case EFI_HII_PACKAGE_SIMPLE_FONTS: - printf("\tSimple font package not supported\n"); + EFI_PRINT("Simple font package not supported\n"); ret = EFI_INVALID_PARAMETER; break; case EFI_HII_PACKAGE_DEVICE_PATH: - printf("\tDevice path package not supported\n"); + EFI_PRINT("Device path package not supported\n"); ret = EFI_INVALID_PARAMETER; break; case EFI_HII_PACKAGE_KEYBOARD_LAYOUT: @@ -416,7 +416,7 @@ add_packages(struct efi_hii_packagelist *hii, (struct efi_hii_keyboard_package *)package); break; case EFI_HII_PACKAGE_ANIMATIONS: - printf("\tAnimation package not supported\n"); + EFI_PRINT("Animation package not supported\n"); ret = EFI_INVALID_PARAMETER; break; case EFI_HII_PACKAGE_END: @@ -522,33 +522,33 @@ update_package_list(const struct efi_hii_database_protocol *this, remove_guid_package(hii); break; case EFI_HII_PACKAGE_FORMS: - printf("\tForm package not supported\n"); + EFI_PRINT("Form package not supported\n"); ret = EFI_INVALID_PARAMETER; break; case EFI_HII_PACKAGE_STRINGS: remove_strings_package(hii); break; case EFI_HII_PACKAGE_FONTS: - printf("\tFont package not supported\n"); + EFI_PRINT("Font package not supported\n"); ret = EFI_INVALID_PARAMETER; break; case EFI_HII_PACKAGE_IMAGES: - printf("\tImage package not supported\n"); + EFI_PRINT("Image package not supported\n"); ret = EFI_INVALID_PARAMETER; break; case EFI_HII_PACKAGE_SIMPLE_FONTS: - printf("\tSimple font package not supported\n"); + EFI_PRINT("Simple font package not supported\n"); ret = EFI_INVALID_PARAMETER; break; case EFI_HII_PACKAGE_DEVICE_PATH: - printf("\tDevice path package not supported\n"); + EFI_PRINT("Device path package not supported\n"); ret = EFI_INVALID_PARAMETER; break; case EFI_HII_PACKAGE_KEYBOARD_LAYOUT: remove_keyboard_package(hii); break; case EFI_HII_PACKAGE_ANIMATIONS: - printf("\tAnimation package not supported\n"); + EFI_PRINT("Animation package not supported\n"); ret = EFI_INVALID_PARAMETER; break; case EFI_HII_PACKAGE_END: @@ -609,7 +609,7 @@ list_package_lists(const struct efi_hii_database_protocol *this, break; continue; case EFI_HII_PACKAGE_FORMS: - printf("\tForm package not supported\n"); + EFI_PRINT("Form package not supported\n"); ret = EFI_INVALID_PARAMETER; continue; case EFI_HII_PACKAGE_STRINGS: @@ -617,19 +617,19 @@ list_package_lists(const struct efi_hii_database_protocol *this, break; continue; case EFI_HII_PACKAGE_FONTS: - printf("\tFont package not supported\n"); + EFI_PRINT("Font package not supported\n"); ret = EFI_INVALID_PARAMETER; continue; case EFI_HII_PACKAGE_IMAGES: - printf("\tImage package not supported\n"); + EFI_PRINT("Image package not supported\n"); ret = EFI_INVALID_PARAMETER; continue; case EFI_HII_PACKAGE_SIMPLE_FONTS: - printf("\tSimple font package not supported\n"); + EFI_PRINT("Simple font package not supported\n"); ret = EFI_INVALID_PARAMETER; continue; case EFI_HII_PACKAGE_DEVICE_PATH: - printf("\tDevice path package not supported\n"); + EFI_PRINT("Device path package not supported\n"); ret = EFI_INVALID_PARAMETER; continue; case EFI_HII_PACKAGE_KEYBOARD_LAYOUT: @@ -637,7 +637,7 @@ list_package_lists(const struct efi_hii_database_protocol *this, break; continue; case EFI_HII_PACKAGE_ANIMATIONS: - printf("\tAnimation package not supported\n"); + EFI_PRINT("Animation package not supported\n"); ret = EFI_INVALID_PARAMETER; continue; case EFI_HII_PACKAGE_END: