From patchwork Mon Feb 25 19:09:55 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Leslie Monis X-Patchwork-Id: 1047954 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="Zzta/els"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 447Wjp5x5Dz9sC3 for ; Tue, 26 Feb 2019 06:10:22 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727021AbfBYTKV (ORCPT ); Mon, 25 Feb 2019 14:10:21 -0500 Received: from mail-pf1-f194.google.com ([209.85.210.194]:34543 "EHLO mail-pf1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727023AbfBYTKU (ORCPT ); Mon, 25 Feb 2019 14:10:20 -0500 Received: by mail-pf1-f194.google.com with SMTP id u9so4937855pfn.1 for ; Mon, 25 Feb 2019 11:10:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=v4vvOsadFEYfE7QeTmKrYRnfTPa9+lYwDywImjl1IJg=; b=Zzta/elsqcaRGEpvzQ9f4O+JRzj7WLHa1DgJQZs0iaQ94+6wwTd0zUyKgb7WLKzGJl UiJdKJH3zK7SAeRhvbrO2HQGMpveIAH1bX1IxtT2vE+j1O/NbyQmoCFqdHIpPqFigmWI drxg6XKpUlQAOTNK1XghMw5LZIbgXe5iXU1nk+HZuYxt8BsowK3Ora1HTCHH+0kI3VFt h31wwwQCSyk0UmgYeEbZaG6B/7SZjE/Cwhw9xbSRijxbaGLMtVHyPWZ1VDVx3gHW2gv9 HYYIHfZhFVVzhLfNEsz0ETPH/8L8NYgmERvUPnZFWUuVGlvZLeeeHBl/sCAAD5oSqCw0 qj9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=v4vvOsadFEYfE7QeTmKrYRnfTPa9+lYwDywImjl1IJg=; b=XK/KBpwDX5uk8rTKVFlW3zeOAITHwsjQP21uWQ/hGsoEuiMTt5WNeNiQ5N1XtJimj+ /HvNJ467UByDQxe8BXNZw2/WDJXqVKb7sTquqzYeO0kEyZayqRGOxt0L20bTuDheVsc5 o9Fc7T58DtekiMNpKPor3swUD68yMf+H9U9m9ia4mOyAiccwPqwCPHCizPxRjHAl6bzb h3AO+CWPwP5FKyw+9e2mTCUsB09Z+Jzku9OTy//yYdVdvu3g9m6cMW1ZMc2JbFzj+sfj 2auoVBmStz21IzJz20wGQZFtis5zDyfeV9aTKPpZ/g3yKtF+zGneX3pPpL7lnWc8EzCZ MPsQ== X-Gm-Message-State: AHQUAubUj3OVkhLVemiEaXdaBY9sPj1ECu4wus4QXrViUBYVg30lDuSS XkTBBt8Mg2EJk+lyPvBHnQk= X-Google-Smtp-Source: AHgI3IbRKqWLCewZCAMMfPbvdVcb4NB8zD3mzgi9Ap6B+QBgwZaHNH+iIOIZetfYczJITLevk/7pOQ== X-Received: by 2002:a63:3dc8:: with SMTP id k191mr19332576pga.368.1551121819916; Mon, 25 Feb 2019 11:10:19 -0800 (PST) Received: from localhost.localdomain ([106.216.180.155]) by smtp.gmail.com with ESMTPSA id g15sm13296394pfo.35.2019.02.25.11.10.15 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 25 Feb 2019 11:10:19 -0800 (PST) From: Leslie Monis To: davem@davemloft.net Cc: netdev@vger.kernel.org, "Mohit P. Tahiliani" , Dave Taht , Jamal Hadi Salim , Dhaval Khandla , Hrishikesh Hiraskar , Manish Kumar B , "Sachin D . Patil" , Leslie Monis Subject: [PATCH net-next v3 1/7] net: sched: pie: change value of QUEUE_THRESHOLD Date: Tue, 26 Feb 2019 00:39:55 +0530 Message-Id: <20190225191001.26797-2-lesliemonis@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190225191001.26797-1-lesliemonis@gmail.com> References: <20190225191001.26797-1-lesliemonis@gmail.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: "Mohit P. Tahiliani" RFC 8033 recommends a value of 16384 bytes for the queue threshold. Signed-off-by: Mohit P. Tahiliani Signed-off-by: Dhaval Khandla Signed-off-by: Hrishikesh Hiraskar Signed-off-by: Manish Kumar B Signed-off-by: Sachin D. Patil Signed-off-by: Leslie Monis Acked-by: Dave Taht Acked-by: Jamal Hadi Salim --- net/sched/sch_pie.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/sched/sch_pie.c b/net/sched/sch_pie.c index d1429371592f..7778eff6cdb7 100644 --- a/net/sched/sch_pie.c +++ b/net/sched/sch_pie.c @@ -31,7 +31,7 @@ #include #include -#define QUEUE_THRESHOLD 10000 +#define QUEUE_THRESHOLD 16384 #define DQCOUNT_INVALID -1 #define MAX_PROB 0xffffffff #define PIE_SCALE 8 From patchwork Mon Feb 25 19:09:56 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Leslie Monis X-Patchwork-Id: 1047955 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="TIMoID4s"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 447Wjv2B3rz9sBr for ; Tue, 26 Feb 2019 06:10:27 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727031AbfBYTK0 (ORCPT ); Mon, 25 Feb 2019 14:10:26 -0500 Received: from mail-pg1-f195.google.com ([209.85.215.195]:42783 "EHLO mail-pg1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726895AbfBYTKZ (ORCPT ); Mon, 25 Feb 2019 14:10:25 -0500 Received: by mail-pg1-f195.google.com with SMTP id b2so4910922pgl.9 for ; Mon, 25 Feb 2019 11:10:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=twDi1kf21HZoUaxXQwYc91nsnOlsDMAjG4a7s1DG+fE=; b=TIMoID4syl39xznnCPeK7zN9d+QsbtcDaiIcdTf6TT8tDzA62yDpuNv9HqkajtSVoS se/dd3J9AZ4pJQMJ9ITXoBhbPGTkRIHsXo0wFzHi0zSAB10pNWSy2AF0XXYMEaj++u8t cSuKqaXENjVyNNty9GSsx+gsRYYmlej9vuLJMu1u24+8pAzitW4w0hulBKNIgbZTQitD yF2lQFOK9hJ6P/CX3FSRc7kHAgWBW77wEIgXhxbCAwdCtd1FRgl9zK8hjjBeh6MtYGVA IyZCFA4SbS/fXWefQkxKfLp/YY8lF/J25ZMOEFoM25iM68Ou8USu8Kc3TNPV4bPvjofu B31Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=twDi1kf21HZoUaxXQwYc91nsnOlsDMAjG4a7s1DG+fE=; b=UMrsHDGBh8wIHtNv97XkUB+xc0rZxyGtRq/HVOHb3/aiWlMFb53RjXdS5XIqgLaI0K JqrgdemWwLw+Is4Yh3OY0Jv0QGsNnAFLqZtypBQq3pHuAIP2NeK3s7g0OGCfwAHStXnY FaVU7oJCKCqZUlR8IoqNZ6CFgQwU1+cOaytgZ/Y3wKB8KXkPdNHhRgpblfD6m1A7HfPT zFsnVd8b3Vg9frQ+mcl0jKtE+qRaPsO+I0o/qJ3w7eIt4Gp7S+XaA+XWCXfbn6CbNuzi lKTyh0MSVI9upYjptbxRb80bj5oW7VVD0K+Z33Sx0JKbYUP44kWBGVF4zf28p+sQ0mKZ Vk1Q== X-Gm-Message-State: AHQUAubOf55CuzVVFOdjU08hBYQNrI7pzFW+D1h1cKJB4g2lbbBcogr7 Mlx5E2tYif5uCcn92zpgRyA= X-Google-Smtp-Source: AHgI3IZeDYlsxvfeEU8EzaHD8fF2NG+sOmimxtyoKG+s/2dcmdbfeIzwXL8zSLaiI2eMxHdxvJXUbQ== X-Received: by 2002:a63:20a:: with SMTP id 10mr12831770pgc.346.1551121824399; Mon, 25 Feb 2019 11:10:24 -0800 (PST) Received: from localhost.localdomain ([106.216.180.155]) by smtp.gmail.com with ESMTPSA id g15sm13296394pfo.35.2019.02.25.11.10.20 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 25 Feb 2019 11:10:23 -0800 (PST) From: Leslie Monis To: davem@davemloft.net Cc: netdev@vger.kernel.org, "Mohit P. Tahiliani" , Dave Taht , Jamal Hadi Salim , Dhaval Khandla , Hrishikesh Hiraskar , Manish Kumar B , "Sachin D . Patil" , Leslie Monis Subject: [PATCH net-next v3 2/7] net: sched: pie: change default value of pie_params->target Date: Tue, 26 Feb 2019 00:39:56 +0530 Message-Id: <20190225191001.26797-3-lesliemonis@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190225191001.26797-1-lesliemonis@gmail.com> References: <20190225191001.26797-1-lesliemonis@gmail.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: "Mohit P. Tahiliani" RFC 8033 suggests a default value of 15 milliseconds for the target queue delay. Signed-off-by: Mohit P. Tahiliani Signed-off-by: Dhaval Khandla Signed-off-by: Hrishikesh Hiraskar Signed-off-by: Manish Kumar B Signed-off-by: Sachin D. Patil Signed-off-by: Leslie Monis Acked-by: Dave Taht Acked-by: Jamal Hadi Salim --- net/sched/sch_pie.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/sched/sch_pie.c b/net/sched/sch_pie.c index 7778eff6cdb7..91af9bf19852 100644 --- a/net/sched/sch_pie.c +++ b/net/sched/sch_pie.c @@ -83,7 +83,7 @@ static void pie_params_init(struct pie_params *params) params->beta = 20; params->tupdate = usecs_to_jiffies(30 * USEC_PER_MSEC); /* 30 ms */ params->limit = 1000; /* default of 1000 packets */ - params->target = PSCHED_NS2TICKS(20 * NSEC_PER_MSEC); /* 20 ms */ + params->target = PSCHED_NS2TICKS(15 * NSEC_PER_MSEC); /* 15 ms */ params->ecn = false; params->bytemode = false; } From patchwork Mon Feb 25 19:09:57 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Leslie Monis X-Patchwork-Id: 1047956 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="fEi4vOFw"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 447Wjz74nBz9sBr for ; Tue, 26 Feb 2019 06:10:31 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727077AbfBYTKa (ORCPT ); Mon, 25 Feb 2019 14:10:30 -0500 Received: from mail-pl1-f193.google.com ([209.85.214.193]:34578 "EHLO mail-pl1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726888AbfBYTKa (ORCPT ); Mon, 25 Feb 2019 14:10:30 -0500 Received: by mail-pl1-f193.google.com with SMTP id d15so4945114plr.1 for ; Mon, 25 Feb 2019 11:10:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=5TiLZhHO1wem4Bj2xyIxIMwRMAUAPM57jdbBgfG9Ozk=; b=fEi4vOFwJLHVXXseVP1OhLG8gwmntvi8I1mIR5MLwPo28S2W/iyyMtOWynfjIeGplp 699IPTojpfIWBXKohyfKMeBU5ZhADXBkF5DdVCe3YHjdds5xPYjPXxRgR7Xog4hhs4m8 wPRxDJ9UR+ZNvvjcHPgq/qA3drm0TPgGK0Ko2ooSIQRuJKs3eQIq72vRnmpo6z1CCUwX JsyFPg2RvOlFlF/LCk7M4gkzNS0cIbMSsNumS5hKAHOkbrXuJoJvph8iYSfGxs991ste M8pEFk4tC2hE+WrAuvlY4dRHSCw8aa4WQTZoZlTD9c6lrPfgrvL6g8n65zvk9IgD2rzd 2mMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=5TiLZhHO1wem4Bj2xyIxIMwRMAUAPM57jdbBgfG9Ozk=; b=IqU2zZS2pqfzW+qUOJAN6pZvK0FuCeG2T9NZgKGLXMpEpU9h4G6t4p++F9rCAMJH5x 78UQHZ+nvzonC+KSuJ8A6Sb5pIWh0fVEmLu9s1WwCJ/5UgTzwW0bFw/ZRcV3LlNw0dw1 E49oqceTtjn6ZZznule8jwxBFDE3byGeHhYJHdfDeSPUQ7NL8zRJDXCTXyeBMQ+aIRzV DfwMASEIUodqNnYvRiFGLGOeuqcgL7ti5dPVFgG19nBZTAofxIDHRCAuj2glWCAvyfET wiU6vhko9psPjxkku0HNWayxCSe7QK1n5dokQr9VAoDq4XuvprHDQL41+Em7X8/r4VBu 5KyA== X-Gm-Message-State: AHQUAuY4sJB4EgR3uNB7+4mQ/mpERjfhX3F48M3S4CHd3OIBReeUlqoZ qBG19SWpK7TiZSYkqcgVC1A= X-Google-Smtp-Source: AHgI3IbCXBoPBCrLd4if3oCYwLXuszDHKSx1j0wQJ3MlG0yk47KJOhx2wL4Ct01S194WotXLkUdOug== X-Received: by 2002:a17:902:6a2:: with SMTP id 31mr9174944plh.129.1551121829866; Mon, 25 Feb 2019 11:10:29 -0800 (PST) Received: from localhost.localdomain ([106.216.180.155]) by smtp.gmail.com with ESMTPSA id g15sm13296394pfo.35.2019.02.25.11.10.25 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 25 Feb 2019 11:10:29 -0800 (PST) From: Leslie Monis To: davem@davemloft.net Cc: netdev@vger.kernel.org, "Mohit P. Tahiliani" , Dave Taht , Jamal Hadi Salim , Dhaval Khandla , Hrishikesh Hiraskar , Manish Kumar B , "Sachin D . Patil" , Leslie Monis Subject: [PATCH net-next v3 3/7] net: sched: pie: change default value of pie_params->tupdate Date: Tue, 26 Feb 2019 00:39:57 +0530 Message-Id: <20190225191001.26797-4-lesliemonis@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190225191001.26797-1-lesliemonis@gmail.com> References: <20190225191001.26797-1-lesliemonis@gmail.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: "Mohit P. Tahiliani" RFC 8033 suggests a default value of 15 milliseconds for the update interval. Signed-off-by: Mohit P. Tahiliani Signed-off-by: Dhaval Khandla Signed-off-by: Hrishikesh Hiraskar Signed-off-by: Manish Kumar B Signed-off-by: Sachin D. Patil Signed-off-by: Leslie Monis Acked-by: Dave Taht Acked-by: Jamal Hadi Salim --- net/sched/sch_pie.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/sched/sch_pie.c b/net/sched/sch_pie.c index 91af9bf19852..702f75afc312 100644 --- a/net/sched/sch_pie.c +++ b/net/sched/sch_pie.c @@ -81,7 +81,7 @@ static void pie_params_init(struct pie_params *params) { params->alpha = 2; params->beta = 20; - params->tupdate = usecs_to_jiffies(30 * USEC_PER_MSEC); /* 30 ms */ + params->tupdate = usecs_to_jiffies(15 * USEC_PER_MSEC); /* 15 ms */ params->limit = 1000; /* default of 1000 packets */ params->target = PSCHED_NS2TICKS(15 * NSEC_PER_MSEC); /* 15 ms */ params->ecn = false; From patchwork Mon Feb 25 19:09:58 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Leslie Monis X-Patchwork-Id: 1047957 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="eRYN2eEp"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 447Wk44Kbyz9sBr for ; Tue, 26 Feb 2019 06:10:36 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727113AbfBYTKf (ORCPT ); Mon, 25 Feb 2019 14:10:35 -0500 Received: from mail-pl1-f195.google.com ([209.85.214.195]:45340 "EHLO mail-pl1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726950AbfBYTKf (ORCPT ); Mon, 25 Feb 2019 14:10:35 -0500 Received: by mail-pl1-f195.google.com with SMTP id r14so4910164pls.12 for ; Mon, 25 Feb 2019 11:10:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=8KWrgXDFEkJPk7S6GvYNkq4Pbbh+A9Zay9uXfDyDtjw=; b=eRYN2eEpsp/mFkT5/FGW8eU8pfup3xjTg354uhw2bdteXrQHpwRX+JHmHKTT7302/c fYWEYJgQm+HYrltB8PgUhSEvhPuXY1r7khUNPhHcT34vm0nzRCxm4n0pQWl5IHgZIkKb 7riKOkwTo1yfFfC1KixBm896lyDmpW/cKctoS49aZQdcJ/vcr7t50Kw/R1wNxdkq4/B1 N2wRVYRqy8tROF9kwhhHfNJcmx9+3XI3Fs7RUhEex7yK2Uvn6VttprPUojf3gcdb1zy5 yKtNxfyL3Xwoc58JAQX/DvuvBZOAKR4jAt4XIdPzCuhgwwSw8U1m2Ar/t9KtQi3Dm8TM VCWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=8KWrgXDFEkJPk7S6GvYNkq4Pbbh+A9Zay9uXfDyDtjw=; b=kIajD1u2ksc+AvsM8o6gKB5oNHo2f4aV8aFqBFC4jm0/p/wIEoHeUGW4L3laMts7HZ nC3ZYGNfQtKs3lrS0Pb2soj9GFJpfa+1OyvJkGwSMIeSj0em6t+dQyeneHjWmvyOHZ7h 0nTzj5YNvwr71ZFsL46ZpT+kIKQJ6TXucgwTdB3XIYG3f1NEnoeHRpQdJFc8+K+9wU9d sfXkNke8XXeF/Q1YCiC8jfsjOYZn1aunR3QCB9TeQa99Wclln98HORHswK7yDkxZbl/L ZXV7A3oEbY2r8yJFQBNiuHTpcFdjmRT8tnmVQFzsPwRlpXgB62lSlHMCmogg/Td42IPN wAmA== X-Gm-Message-State: AHQUAuY1cNG8+UbxJSUKKYJPTUwEgksbqCu9uBYQOJrsTvWNPcOHwnfV Giw1stGT1WHf1EP41ZFDGIM= X-Google-Smtp-Source: AHgI3Ias8AEHsOZ0G3hyjtYU7m5opaBxJElSwipns35hBfVcnT7wl1Cn7KpSQtZJTpi1RoZuU//BeA== X-Received: by 2002:a17:902:c23:: with SMTP id 32mr22210769pls.183.1551121834407; Mon, 25 Feb 2019 11:10:34 -0800 (PST) Received: from localhost.localdomain ([106.216.180.155]) by smtp.gmail.com with ESMTPSA id g15sm13296394pfo.35.2019.02.25.11.10.30 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 25 Feb 2019 11:10:33 -0800 (PST) From: Leslie Monis To: davem@davemloft.net Cc: netdev@vger.kernel.org, "Mohit P. Tahiliani" , Dave Taht , Jamal Hadi Salim , Dhaval Khandla , Hrishikesh Hiraskar , Manish Kumar B , "Sachin D . Patil" , Leslie Monis Subject: [PATCH net-next v3 4/7] net: sched: pie: change initial value of pie_vars->burst_time Date: Tue, 26 Feb 2019 00:39:58 +0530 Message-Id: <20190225191001.26797-5-lesliemonis@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190225191001.26797-1-lesliemonis@gmail.com> References: <20190225191001.26797-1-lesliemonis@gmail.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: "Mohit P. Tahiliani" RFC 8033 suggests an initial value of 150 milliseconds for the maximum time allowed for a burst of packets. Signed-off-by: Mohit P. Tahiliani Signed-off-by: Dhaval Khandla Signed-off-by: Hrishikesh Hiraskar Signed-off-by: Manish Kumar B Signed-off-by: Sachin D. Patil Signed-off-by: Leslie Monis Acked-by: Dave Taht Acked-by: Jamal Hadi Salim --- net/sched/sch_pie.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/sched/sch_pie.c b/net/sched/sch_pie.c index 702f75afc312..d88ab53593b3 100644 --- a/net/sched/sch_pie.c +++ b/net/sched/sch_pie.c @@ -92,8 +92,8 @@ static void pie_vars_init(struct pie_vars *vars) { vars->dq_count = DQCOUNT_INVALID; vars->avg_dq_rate = 0; - /* default of 100 ms in pschedtime */ - vars->burst_time = PSCHED_NS2TICKS(100 * NSEC_PER_MSEC); + /* default of 150 ms in pschedtime */ + vars->burst_time = PSCHED_NS2TICKS(150 * NSEC_PER_MSEC); } static bool drop_early(struct Qdisc *sch, u32 packet_size) From patchwork Mon Feb 25 19:09:59 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Leslie Monis X-Patchwork-Id: 1047958 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="fu6WOU4s"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 447Wk95Hr4z9sBr for ; Tue, 26 Feb 2019 06:10:41 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727183AbfBYTKk (ORCPT ); Mon, 25 Feb 2019 14:10:40 -0500 Received: from mail-pf1-f193.google.com ([209.85.210.193]:36843 "EHLO mail-pf1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726481AbfBYTKk (ORCPT ); Mon, 25 Feb 2019 14:10:40 -0500 Received: by mail-pf1-f193.google.com with SMTP id n22so4937866pfa.3 for ; Mon, 25 Feb 2019 11:10:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=tUss4pV2DQe9No72fLGwesiL9LjPz3k1RtuDRheAl7U=; b=fu6WOU4sk5ZiZcOTzsMX8wsJM0Ffcv5stAVUdbaSt7fuGyTwYELWbYnw0k7usr5SJE O4Wg4cKyNdo1kgj8o5S/yOPocCNggOPAl0c0LpXgwvzLxwH6uQIjo3A3GbAP9KBJdQmj QTmXpGQtaou2ULLJhC8dh2YlolBMTRUhq3YeKmqt6sCX6OGZ55M4Sx74ONM3LgjAfUME iH/F7uSCyxXqx1wEVeiarYVFeQP3uZ1OgAIcLLd9pqOMCGk+5MIvdYyDKFmXDrzR/Aju jx1tFGPie8kYaBGqUbXsKns56vcFjtLhkyzypTT63eHs+KFjdh/YvTbKxxqjjb+WFvEf 7Azw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=tUss4pV2DQe9No72fLGwesiL9LjPz3k1RtuDRheAl7U=; b=oAaiMu2yMj1oEk8wBk7fAKgUBTH+2vTnmrvg0sknMnFGmWzZ1YwdTvodBQhaawZ5t/ wUWFXRXX1gNy3Jjm+K9+GliZLWjksunAj+zSYmcW90fn5LPUHLyXs+OMx8YJDD9RaoJe zBmu4Kz0UUF9uKzVtpOb8cS5q0uEjto2wt4Pt77waOY8kRjP0yq17bqebG4VgNzwLkcH ks0K/C4nfBRVuGuL70dkBLO26VK1z8vNQKm4wqVnCmawa68JZzNGBbuDe2vG6cYwNCEL WtVSZJp5Om+TVxusUo6DNyB6cQder3U7IJbtahu4rTVsi7LM7wgGTvO/Huai6m2KTkKm 7lig== X-Gm-Message-State: AHQUAua+jsQ/afkTS7wFlYXT94IqFpi/nZwrtFWYOfXOi7963UVffvb9 iQQZIPtdddcpRPmiqLprjSI= X-Google-Smtp-Source: AHgI3Ia9qEPGvKBlH5Xlx48tcAmjzOGpL6FIAdqkpc50B4OFg19hSWGd7pvWCtAsqx+gtSUIhFxZoA== X-Received: by 2002:a63:1060:: with SMTP id 32mr16273754pgq.126.1551121839093; Mon, 25 Feb 2019 11:10:39 -0800 (PST) Received: from localhost.localdomain ([106.216.180.155]) by smtp.gmail.com with ESMTPSA id g15sm13296394pfo.35.2019.02.25.11.10.34 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 25 Feb 2019 11:10:38 -0800 (PST) From: Leslie Monis To: davem@davemloft.net Cc: netdev@vger.kernel.org, "Mohit P. Tahiliani" , Dave Taht , Jamal Hadi Salim , Dhaval Khandla , Hrishikesh Hiraskar , Manish Kumar B , "Sachin D . Patil" , Leslie Monis Subject: [PATCH net-next v3 5/7] net: sched: pie: add more cases to auto-tune alpha and beta Date: Tue, 26 Feb 2019 00:39:59 +0530 Message-Id: <20190225191001.26797-6-lesliemonis@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190225191001.26797-1-lesliemonis@gmail.com> References: <20190225191001.26797-1-lesliemonis@gmail.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: "Mohit P. Tahiliani" The current implementation scales the local alpha and beta variables in the calculate_probability function by the same amount for all values of drop probability below 1%. RFC 8033 suggests using additional cases for auto-tuning alpha and beta when the drop probability is less than 1%. In order to add more auto-tuning cases, MAX_PROB must be scaled by u64 instead of u32 to prevent underflow when scaling the local alpha and beta variables in the calculate_probability function. Signed-off-by: Mohit P. Tahiliani Signed-off-by: Dhaval Khandla Signed-off-by: Hrishikesh Hiraskar Signed-off-by: Manish Kumar B Signed-off-by: Sachin D. Patil Signed-off-by: Leslie Monis Acked-by: Dave Taht Acked-by: Jamal Hadi Salim --- include/uapi/linux/pkt_sched.h | 2 +- net/sched/sch_pie.c | 65 +++++++++++++++++----------------- 2 files changed, 33 insertions(+), 34 deletions(-) diff --git a/include/uapi/linux/pkt_sched.h b/include/uapi/linux/pkt_sched.h index 0d18b1d1fbbc..1eb572ef3f27 100644 --- a/include/uapi/linux/pkt_sched.h +++ b/include/uapi/linux/pkt_sched.h @@ -954,7 +954,7 @@ enum { #define TCA_PIE_MAX (__TCA_PIE_MAX - 1) struct tc_pie_xstats { - __u32 prob; /* current probability */ + __u64 prob; /* current probability */ __u32 delay; /* current delay in ms */ __u32 avg_dq_rate; /* current average dq_rate in bits/pie_time */ __u32 packets_in; /* total number of packets enqueued */ diff --git a/net/sched/sch_pie.c b/net/sched/sch_pie.c index d88ab53593b3..30f158582499 100644 --- a/net/sched/sch_pie.c +++ b/net/sched/sch_pie.c @@ -33,7 +33,7 @@ #define QUEUE_THRESHOLD 16384 #define DQCOUNT_INVALID -1 -#define MAX_PROB 0xffffffff +#define MAX_PROB 0xffffffffffffffff #define PIE_SCALE 8 /* parameters used */ @@ -49,7 +49,7 @@ struct pie_params { /* variables used */ struct pie_vars { - u32 prob; /* probability but scaled by u32 limit. */ + u64 prob; /* probability but scaled by u64 limit. */ psched_time_t burst_time; psched_time_t qdelay; psched_time_t qdelay_old; @@ -99,8 +99,8 @@ static void pie_vars_init(struct pie_vars *vars) static bool drop_early(struct Qdisc *sch, u32 packet_size) { struct pie_sched_data *q = qdisc_priv(sch); - u32 rnd; - u32 local_prob = q->vars.prob; + u64 rnd; + u64 local_prob = q->vars.prob; u32 mtu = psched_mtu(qdisc_dev(sch)); /* If there is still burst allowance left skip random early drop */ @@ -124,11 +124,11 @@ static bool drop_early(struct Qdisc *sch, u32 packet_size) * probablity. Smaller packets will have lower drop prob in this case */ if (q->params.bytemode && packet_size <= mtu) - local_prob = (local_prob / mtu) * packet_size; + local_prob = (u64)packet_size * div_u64(local_prob, mtu); else local_prob = q->vars.prob; - rnd = prandom_u32(); + prandom_bytes(&rnd, 8); if (rnd < local_prob) return true; @@ -317,9 +317,10 @@ static void calculate_probability(struct Qdisc *sch) u32 qlen = sch->qstats.backlog; /* queue size in bytes */ psched_time_t qdelay = 0; /* in pschedtime */ psched_time_t qdelay_old = q->vars.qdelay; /* in pschedtime */ - s32 delta = 0; /* determines the change in probability */ - u32 oldprob; - u32 alpha, beta; + s64 delta = 0; /* determines the change in probability */ + u64 oldprob; + u64 alpha, beta; + u32 power; bool update_prob = true; q->vars.qdelay_old = q->vars.qdelay; @@ -339,38 +340,36 @@ static void calculate_probability(struct Qdisc *sch) * value for alpha as 0.125. In this implementation, we use values 0-32 * passed from user space to represent this. Also, alpha and beta have * unit of HZ and need to be scaled before they can used to update - * probability. alpha/beta are updated locally below by 1) scaling them - * appropriately 2) scaling down by 16 to come to 0-2 range. - * Please see paper for details. - * - * We scale alpha and beta differently depending on whether we are in - * light, medium or high dropping mode. + * probability. alpha/beta are updated locally below by scaling down + * by 16 to come to 0-2 range. */ - if (q->vars.prob < MAX_PROB / 100) { - alpha = - (q->params.alpha * (MAX_PROB / PSCHED_TICKS_PER_SEC)) >> 7; - beta = - (q->params.beta * (MAX_PROB / PSCHED_TICKS_PER_SEC)) >> 7; - } else if (q->vars.prob < MAX_PROB / 10) { - alpha = - (q->params.alpha * (MAX_PROB / PSCHED_TICKS_PER_SEC)) >> 5; - beta = - (q->params.beta * (MAX_PROB / PSCHED_TICKS_PER_SEC)) >> 5; - } else { - alpha = - (q->params.alpha * (MAX_PROB / PSCHED_TICKS_PER_SEC)) >> 4; - beta = - (q->params.beta * (MAX_PROB / PSCHED_TICKS_PER_SEC)) >> 4; + alpha = ((u64)q->params.alpha * (MAX_PROB / PSCHED_TICKS_PER_SEC)) >> 4; + beta = ((u64)q->params.beta * (MAX_PROB / PSCHED_TICKS_PER_SEC)) >> 4; + + /* We scale alpha and beta differently depending on how heavy the + * congestion is. Please see RFC 8033 for details. + */ + if (q->vars.prob < MAX_PROB / 10) { + alpha >>= 1; + beta >>= 1; + + power = 100; + while (q->vars.prob < div_u64(MAX_PROB, power) && + power <= 1000000) { + alpha >>= 2; + beta >>= 2; + power *= 10; + } } /* alpha and beta should be between 0 and 32, in multiples of 1/16 */ - delta += alpha * ((qdelay - q->params.target)); - delta += beta * ((qdelay - qdelay_old)); + delta += alpha * (u64)(qdelay - q->params.target); + delta += beta * (u64)(qdelay - qdelay_old); oldprob = q->vars.prob; /* to ensure we increase probability in steps of no more than 2% */ - if (delta > (s32)(MAX_PROB / (100 / 2)) && + if (delta > (s64)(MAX_PROB / (100 / 2)) && q->vars.prob >= MAX_PROB / 10) delta = (MAX_PROB / 100) * 2; From patchwork Mon Feb 25 19:10:00 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Leslie Monis X-Patchwork-Id: 1047959 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="a2FUpo2Q"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 447WkJ62S9z9sC3 for ; Tue, 26 Feb 2019 06:10:48 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727277AbfBYTKq (ORCPT ); Mon, 25 Feb 2019 14:10:46 -0500 Received: from mail-pf1-f193.google.com ([209.85.210.193]:41257 "EHLO mail-pf1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726950AbfBYTKo (ORCPT ); Mon, 25 Feb 2019 14:10:44 -0500 Received: by mail-pf1-f193.google.com with SMTP id d25so4925916pfn.8 for ; Mon, 25 Feb 2019 11:10:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=bbbifAdEYBM445FndubE8vpyZcAmIVRNnZ/uXVxeiEo=; b=a2FUpo2QS7dTekhdnRkYvGfWSxzIbyMjYfhwn8j7gG2Q66KZUVxWehUL95FAkbCawA b1voJDOBFDcXZCV7/zNuUvRBxmvPJoC8T6ATsDx2GKgPXdKCyG2u3sYSWPMydPsMwMGq NT19IusWJEVMrEzDTH3ulUlS3/i0AlBLdJkHbVYN7teNDxXeTs3G+YOrsMYBRLVp49as tq9/IDJN5Do6iA3U6TdEqt70eietOvqG+EB882lI065xW+wtfHeIIHQpd4/tKL2Rsj63 aDGvIjKsCLU0bRWjrUH23FSWmNon8eZDEulf8/7mKUxPnjRtQX4gBuPiYEsu+UCdO8hd PErw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=bbbifAdEYBM445FndubE8vpyZcAmIVRNnZ/uXVxeiEo=; b=lFG7+CIgF8TS5mUbQOEU0Kgbawsc1fFJro11pmvkYyaQi2RNzWTZfEfWQuB5+PdVCZ dXNrM5L+XBkME3L2dG7BP87B5B0zhtFnzfh09jRe/0claeKCepwxOowQfmnHGGUWpWfK CaUBWBgLEgmyCEqWAx8HS6f8k07dKyu5ZT9BlniSYwNuKDipeA1wqUkpbEgeNmaBO595 WEVFRWGqsdH3tTCXWHaRPhY045Ip93ZLUbRZIrxe6lr3Z/ZM4Zdi9a/1OMOYcpMKlnYl knhWUnK98ZflcRMrNAiIF44QTL94VYqYUdgcyBR5KpEoTWPlZBIx0wL7Trle5+HxxS7G nAKg== X-Gm-Message-State: AHQUAuZXS51oxG26mrJXQzvqxOHuMCjOPV/N+YVNZ3l9UMVbiENvHVWR emWLvWHwXkCROCaQUsahwZE= X-Google-Smtp-Source: AHgI3IYV2zhzZvGZK4FdWLn6TFcetp/U8ngWE9jhBkmlkeSVK3TVnzIHJ+AiJFW09z0q3dgFamghNQ== X-Received: by 2002:a62:ae04:: with SMTP id q4mr19616421pff.213.1551121843801; Mon, 25 Feb 2019 11:10:43 -0800 (PST) Received: from localhost.localdomain ([106.216.180.155]) by smtp.gmail.com with ESMTPSA id g15sm13296394pfo.35.2019.02.25.11.10.39 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 25 Feb 2019 11:10:43 -0800 (PST) From: Leslie Monis To: davem@davemloft.net Cc: netdev@vger.kernel.org, "Mohit P. Tahiliani" , Dave Taht , Jamal Hadi Salim , Dhaval Khandla , Hrishikesh Hiraskar , Manish Kumar B , "Sachin D . Patil" , Leslie Monis Subject: [PATCH net-next v3 6/7] net: sched: pie: add derandomization mechanism Date: Tue, 26 Feb 2019 00:40:00 +0530 Message-Id: <20190225191001.26797-7-lesliemonis@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190225191001.26797-1-lesliemonis@gmail.com> References: <20190225191001.26797-1-lesliemonis@gmail.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: "Mohit P. Tahiliani" Random dropping of packets to achieve latency control may introduce outlier situations where packets are dropped too close to each other or too far from each other. This can cause the real drop percentage to temporarily deviate from the intended drop probability. In certain scenarios, such as a small number of simultaneous TCP flows, these deviations can cause significant deviations in link utilization and queuing latency. RFC 8033 suggests using a derandomization mechanism to avoid these deviations. Signed-off-by: Mohit P. Tahiliani Signed-off-by: Dhaval Khandla Signed-off-by: Hrishikesh Hiraskar Signed-off-by: Manish Kumar B Signed-off-by: Sachin D. Patil Signed-off-by: Leslie Monis Acked-by: Dave Taht Acked-by: Jamal Hadi Salim --- net/sched/sch_pie.c | 28 +++++++++++++++++++++++++++- 1 file changed, 27 insertions(+), 1 deletion(-) diff --git a/net/sched/sch_pie.c b/net/sched/sch_pie.c index 30f158582499..916b878d3491 100644 --- a/net/sched/sch_pie.c +++ b/net/sched/sch_pie.c @@ -55,8 +55,10 @@ struct pie_vars { psched_time_t qdelay_old; u64 dq_count; /* measured in bytes */ psched_time_t dq_tstamp; /* drain rate */ + u64 accu_prob; /* accumulated drop probability */ u32 avg_dq_rate; /* bytes per pschedtime tick,scaled */ u32 qlen_old; /* in bytes */ + u8 accu_prob_overflows; /* overflows of accu_prob */ }; /* statistics gathering */ @@ -91,9 +93,11 @@ static void pie_params_init(struct pie_params *params) static void pie_vars_init(struct pie_vars *vars) { vars->dq_count = DQCOUNT_INVALID; + vars->accu_prob = 0; vars->avg_dq_rate = 0; /* default of 150 ms in pschedtime */ vars->burst_time = PSCHED_NS2TICKS(150 * NSEC_PER_MSEC); + vars->accu_prob_overflows = 0; } static bool drop_early(struct Qdisc *sch, u32 packet_size) @@ -128,9 +132,29 @@ static bool drop_early(struct Qdisc *sch, u32 packet_size) else local_prob = q->vars.prob; + if (local_prob == 0) { + q->vars.accu_prob = 0; + q->vars.accu_prob_overflows = 0; + } + + if (local_prob > MAX_PROB - q->vars.accu_prob) + q->vars.accu_prob_overflows++; + + q->vars.accu_prob += local_prob; + + if (q->vars.accu_prob_overflows == 0 && + q->vars.accu_prob < (MAX_PROB / 100) * 85) + return false; + if (q->vars.accu_prob_overflows == 8 && + q->vars.accu_prob >= MAX_PROB / 2) + return true; + prandom_bytes(&rnd, 8); - if (rnd < local_prob) + if (rnd < local_prob) { + q->vars.accu_prob = 0; + q->vars.accu_prob_overflows = 0; return true; + } return false; } @@ -168,6 +192,8 @@ static int pie_qdisc_enqueue(struct sk_buff *skb, struct Qdisc *sch, out: q->stats.dropped++; + q->vars.accu_prob = 0; + q->vars.accu_prob_overflows = 0; return qdisc_drop(skb, sch, to_free); } From patchwork Mon Feb 25 19:10:01 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Leslie Monis X-Patchwork-Id: 1047960 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="SelN6NnN"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 447WkL6wWFz9sC3 for ; Tue, 26 Feb 2019 06:10:50 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727328AbfBYTKt (ORCPT ); Mon, 25 Feb 2019 14:10:49 -0500 Received: from mail-pg1-f196.google.com ([209.85.215.196]:34290 "EHLO mail-pg1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727280AbfBYTKt (ORCPT ); Mon, 25 Feb 2019 14:10:49 -0500 Received: by mail-pg1-f196.google.com with SMTP id i130so4929961pgd.1 for ; Mon, 25 Feb 2019 11:10:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=TYBzCLbRK03i2rrZHaTV8NHlCN4exhOO4qEG6c9Rayk=; b=SelN6NnNEdtt3NL+QYkWxN4lILsIWtEbx6PvUREHmGOoXWZuTL5g2fvQ1I3cOQsVoM 7P7W5+K5yjEaN+VMu4B9UXuviRGUmlpwE/1BAROTTvakKqYm/Yu9/Cwr9k0NnWPC/WOa FxAeRxHyXTmLXcAseaU3X1UEfkT+OYzLAQY6E6SOCOtKpzqkjpdj1oFJGxLMO6ugXGmq /0NwsyUGPrSS8nhLDjoyRFQ2Wds+iff+PDKQYoBEA+/MFeZaqLI6i56LByhYCKnN/MWs 5JiPPhwQiU8oguPGri8NEniPm1K8Ee/lK2DuX/cyXeGw6scr/Ao3tQuwMNIAWNTvyajq jFvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=TYBzCLbRK03i2rrZHaTV8NHlCN4exhOO4qEG6c9Rayk=; b=K6y0x+23aYn6Z4uaeA+WHm54cL9AsHBMqNkUlILc0Pxm2110ugSQhFK5hNOV/EPJpb CM++tjnZ6OaJ03QRsnX2lX0XFbiTs6w/TpqU/QWoI4B07LoAnkEFEnXQ2QmMzZHGmAHz YKPxejzaQB1Vy2RV/h5TKMLkh2XZXdfn4WAKtFS7QSkkpd8KoCX4ufGYZ719yRH16yhQ 2IGDmq9GOEfOLWcaeRpYrskPAhY48sGo6S9ktpqVfxVlaW3vG22v6Po7Z0u3HFWvPxxq qOKhgGpIFDLOv4iWuYRZOihdQeK+wjngzBRJ6OWAHh7szcgGfN9/354b0qTnfh03C88M H0HQ== X-Gm-Message-State: AHQUAuZD9TjA7FRt1e6y6oVBXAVSijRTlEsCIAXVM83xOx7XbKLjCNG7 J1RvsQQRfaOtekdPylQMxc4kFMOAXj4= X-Google-Smtp-Source: AHgI3IYpuMOcH3w9PmEerSycnpF3qLOkXonCBd9/hO1cgkKBghv+2oTh6AcyK2mw4lOtDtyDaaoCRA== X-Received: by 2002:aa7:8597:: with SMTP id w23mr21284201pfn.87.1551121848618; Mon, 25 Feb 2019 11:10:48 -0800 (PST) Received: from localhost.localdomain ([106.216.180.155]) by smtp.gmail.com with ESMTPSA id g15sm13296394pfo.35.2019.02.25.11.10.44 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 25 Feb 2019 11:10:47 -0800 (PST) From: Leslie Monis To: davem@davemloft.net Cc: netdev@vger.kernel.org, "Mohit P. Tahiliani" , Dave Taht , Jamal Hadi Salim , Dhaval Khandla , Hrishikesh Hiraskar , Manish Kumar B , "Sachin D . Patil" , Leslie Monis Subject: [PATCH net-next v3 7/7] net: sched: pie: update references Date: Tue, 26 Feb 2019 00:40:01 +0530 Message-Id: <20190225191001.26797-8-lesliemonis@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190225191001.26797-1-lesliemonis@gmail.com> References: <20190225191001.26797-1-lesliemonis@gmail.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: "Mohit P. Tahiliani" RFC 8033 replaces the IETF draft for PIE Signed-off-by: Mohit P. Tahiliani Signed-off-by: Dhaval Khandla Signed-off-by: Hrishikesh Hiraskar Signed-off-by: Manish Kumar B Signed-off-by: Sachin D. Patil Signed-off-by: Leslie Monis Acked-by: Dave Taht Acked-by: Jamal Hadi Salim --- net/sched/sch_pie.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/net/sched/sch_pie.c b/net/sched/sch_pie.c index 916b878d3491..f8314a14a256 100644 --- a/net/sched/sch_pie.c +++ b/net/sched/sch_pie.c @@ -17,9 +17,7 @@ * University of Oslo, Norway. * * References: - * IETF draft submission: http://tools.ietf.org/html/draft-pan-aqm-pie-00 - * IEEE Conference on High Performance Switching and Routing 2013 : - * "PIE: A * Lightweight Control Scheme to Address the Bufferbloat Problem" + * RFC 8033: https://tools.ietf.org/html/rfc8034 */ #include