From patchwork Mon Feb 25 10:20:45 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Leslie Monis X-Patchwork-Id: 1047646 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="Izj401Pt"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 447J2N5f2jz9ryj for ; Mon, 25 Feb 2019 21:23:56 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726700AbfBYKXz (ORCPT ); Mon, 25 Feb 2019 05:23:55 -0500 Received: from mail-pl1-f193.google.com ([209.85.214.193]:38914 "EHLO mail-pl1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726617AbfBYKXy (ORCPT ); Mon, 25 Feb 2019 05:23:54 -0500 Received: by mail-pl1-f193.google.com with SMTP id b65so1279574plb.6 for ; Mon, 25 Feb 2019 02:23:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=u765pCIWeyyZruBqrLei4iidvFeF9Zb5BoNKQKAVT+Y=; b=Izj401PthOyjy4YhnGjPn1pEh6h5kiH3ythuO3EoN4SQyW5pK2bRFmFoh5l+7aCZ/K gedFBHnypBTgyfrntC3utubBpUXuNQSJNrz/8CJO3nMq5pUgS4XKG1OEBMgr5QRpH2Ax MDk/iJuev1UMlYRyvdJLeFb1sf2l27LzV1ZGE03j7Q8bkvCMUg6tOfXfVS1QOOO+65FA PDySV/M/UUckpOx0zzj6l8YnwWscE/1gBMoXBSOPtvzQUF730NBSCk8U/at8hCQjT5zf nWzfMlv4WPCqpXhWpZWARwM4VgDe21IAh0uMKgsIfGWUgYzDgnkvUqMgEs6brva1HH+t VtyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=u765pCIWeyyZruBqrLei4iidvFeF9Zb5BoNKQKAVT+Y=; b=tbmx2DFu6gcHJYK368WAHI+6Wo2JZvW5267naF57grzhcbS0uPqnRCEoJnF5f+7ZRb +9NoP9y5H0SpzBda8CqWk56MplUM9TQ6Lymdg/oWA/r6jXCxwQpI2Gtw90lFHV74rnRr WrAAhNwTc0nc3fN6I0ZHf3U0KoNTw57uovwmWZpy9UttFdS1HPbhPt8IG6I/VrYM4y+1 Yl1mPTJBuf2LTI9Fj+yKEbvMORg8BHPLfq0whQ9YRLYhdiNnFwS3IXB5L0/v47u1MFrj qZw82L0fEZyklLsV7aObICeqvunTvLssoAoZi5PZodzC2hZUluHWIEU3tLMWmtIbZGNO ObWQ== X-Gm-Message-State: AHQUAuYjtXyGj8O6OK0fJ1GWgiQ3i3uXN+77E6FeKbz+ZjVyAobeoDS4 2o+5ckFXUdo3AtwQ7Sx5O17NxHd6rM4= X-Google-Smtp-Source: AHgI3IY/XJP9h9g1a4K74KKd9oK3N7weX5OBeFEx4u8Bl/TYy2QHC6704Zep6D6hl2NWhOnrzJFa+w== X-Received: by 2002:a17:902:e409:: with SMTP id ci9mr19228981plb.221.1551090234200; Mon, 25 Feb 2019 02:23:54 -0800 (PST) Received: from localhost.localdomain ([106.216.180.155]) by smtp.gmail.com with ESMTPSA id q28sm13657439pgl.35.2019.02.25.02.23.48 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 25 Feb 2019 02:23:53 -0800 (PST) From: Leslie Monis To: jhs@mojatatu.com Cc: netdev@vger.kernel.org, dave@taht.net, "Mohit P. Tahiliani" , Dhaval Khandla , Hrishikesh Hiraskar , Manish Kumar B , "Sachin D . Patil" , Leslie Monis Subject: [PATCH net-next v2 1/7] net: sched: pie: change value of QUEUE_THRESHOLD Date: Mon, 25 Feb 2019 15:50:45 +0530 Message-Id: <20190225102051.12268-2-lesliemonis@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190225102051.12268-1-lesliemonis@gmail.com> References: <20190225102051.12268-1-lesliemonis@gmail.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: "Mohit P. Tahiliani" RFC 8033 recommends a value of 16384 bytes for the queue threshold. Signed-off-by: Mohit P. Tahiliani Signed-off-by: Dhaval Khandla Signed-off-by: Hrishikesh Hiraskar Signed-off-by: Manish Kumar B Signed-off-by: Sachin D. Patil Signed-off-by: Leslie Monis --- net/sched/sch_pie.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/sched/sch_pie.c b/net/sched/sch_pie.c index d1429371592f..7778eff6cdb7 100644 --- a/net/sched/sch_pie.c +++ b/net/sched/sch_pie.c @@ -31,7 +31,7 @@ #include #include -#define QUEUE_THRESHOLD 10000 +#define QUEUE_THRESHOLD 16384 #define DQCOUNT_INVALID -1 #define MAX_PROB 0xffffffff #define PIE_SCALE 8 From patchwork Mon Feb 25 10:20:46 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Leslie Monis X-Patchwork-Id: 1047647 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="M1Pu0ZxF"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 447J2V271rz9ryj for ; Mon, 25 Feb 2019 21:24:02 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726711AbfBYKYB (ORCPT ); Mon, 25 Feb 2019 05:24:01 -0500 Received: from mail-pf1-f195.google.com ([209.85.210.195]:40777 "EHLO mail-pf1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726617AbfBYKYA (ORCPT ); Mon, 25 Feb 2019 05:24:00 -0500 Received: by mail-pf1-f195.google.com with SMTP id h1so4295662pfo.7 for ; Mon, 25 Feb 2019 02:24:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=DTgheFekCpCwy3+Nf12cMHMp1hfI3JYfJdfXZX4zojU=; b=M1Pu0ZxFMLejGt6Tw7tKgRi9+L/UNuzGQ4HrFb+OEes+ZBrKcjehf/KTfRe+kJhCon egoD4I4hm4N60Q+dwaDHnZkdMxdt1QqiFJ+V6nTcQxJBOyVtbb5LznqeHDWHZ1rELYQD LXmdNZpwdaqu/ZThQ1cGfz5gQFXM7o8fw1Ktyr0eCGoHeFhmFA+tu+lfIsK0/gfAPkX/ cKWg9G1oUuu9+d6oeIiIz6a4W8wZR/p8Vhj56cEbeUGblbcaDLoTkpQO3yuyFoSuaUoT /V0Q2Ygu6NQxI+oe4RbHdSmD3WU5rWpOhtCCNvIN7xD1CJZrYL9v6gf8ERuJjzoGm7kH deTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=DTgheFekCpCwy3+Nf12cMHMp1hfI3JYfJdfXZX4zojU=; b=CfFg5Ikonmmd5Q/05a05Q1OIYu3zor7Ip0swo9+hDUEJpuqmPp0csDXYJXN+O6ELKR 34atWeEQo9bjUz8Zfu2CaN/X3Xeh/0SOc2mLg4h+mWv7rh+BuGSsB8oDa3zqW4GFlCSU PVr6D2E7r6/yqNVncTW6aSGBCFxZrz5T1GG4djKvPEto+XXVhPqJFfop7LrfANUJKqOf pc8qKrC5ARBqSVaaQ8D60m7S9hr2pTLPm4NcNGY3igqOnvTwEUv56M6CVU99JC/iIpMX 7VdzyQ9dowWPSxEbUYNt/MqsHD2wcQMcUi2k2awYvDrS7id75R7FvV7cM8RrIf1LtSoS WCpw== X-Gm-Message-State: AHQUAuaLytUgL4WwlSC1oyEUlbqwxoY3jW4Zy/pfiBV3R4AK3I1/kMUq w8xNd16a1386jdVJhzPhEMUjI+JhWBs= X-Google-Smtp-Source: AHgI3IZnvkc67Ravmf5UjCCDcRi6BHO54Ealeta0AGxVodBYCxqFyAAYHsqCCvHqz83WzTPS/q0jQA== X-Received: by 2002:a63:4247:: with SMTP id p68mr9600773pga.30.1551090240144; Mon, 25 Feb 2019 02:24:00 -0800 (PST) Received: from localhost.localdomain ([106.216.180.155]) by smtp.gmail.com with ESMTPSA id q28sm13657439pgl.35.2019.02.25.02.23.56 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 25 Feb 2019 02:23:59 -0800 (PST) From: Leslie Monis To: jhs@mojatatu.com Cc: netdev@vger.kernel.org, dave@taht.net, "Mohit P. Tahiliani" , Dhaval Khandla , Hrishikesh Hiraskar , Manish Kumar B , "Sachin D . Patil" , Leslie Monis Subject: [PATCH net-next v2 2/7] net: sched: pie: change default value of pie_params->target Date: Mon, 25 Feb 2019 15:50:46 +0530 Message-Id: <20190225102051.12268-3-lesliemonis@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190225102051.12268-1-lesliemonis@gmail.com> References: <20190225102051.12268-1-lesliemonis@gmail.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: "Mohit P. Tahiliani" RFC 8033 suggests a default value of 15 milliseconds for the target queue delay. Signed-off-by: Mohit P. Tahiliani Signed-off-by: Dhaval Khandla Signed-off-by: Hrishikesh Hiraskar Signed-off-by: Manish Kumar B Signed-off-by: Sachin D. Patil Signed-off-by: Leslie Monis --- net/sched/sch_pie.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/sched/sch_pie.c b/net/sched/sch_pie.c index 7778eff6cdb7..91af9bf19852 100644 --- a/net/sched/sch_pie.c +++ b/net/sched/sch_pie.c @@ -83,7 +83,7 @@ static void pie_params_init(struct pie_params *params) params->beta = 20; params->tupdate = usecs_to_jiffies(30 * USEC_PER_MSEC); /* 30 ms */ params->limit = 1000; /* default of 1000 packets */ - params->target = PSCHED_NS2TICKS(20 * NSEC_PER_MSEC); /* 20 ms */ + params->target = PSCHED_NS2TICKS(15 * NSEC_PER_MSEC); /* 15 ms */ params->ecn = false; params->bytemode = false; } From patchwork Mon Feb 25 10:20:47 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Leslie Monis X-Patchwork-Id: 1047648 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="pSqg9QrX"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 447J2b05Ssz9ryj for ; Mon, 25 Feb 2019 21:24:07 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726720AbfBYKYG (ORCPT ); Mon, 25 Feb 2019 05:24:06 -0500 Received: from mail-pl1-f194.google.com ([209.85.214.194]:33878 "EHLO mail-pl1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726617AbfBYKYF (ORCPT ); Mon, 25 Feb 2019 05:24:05 -0500 Received: by mail-pl1-f194.google.com with SMTP id d15so4318758plr.1 for ; Mon, 25 Feb 2019 02:24:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=AIQIbLgZNniugN1NIdeF7a/D8tcvk16SdDjHG3j4ERc=; b=pSqg9QrXbkuNquQDIO1SYbMCX7Zi2jUXMLE9iTHchJGEhe8XoiY2KxSRI2Lf5iYHrB q+O7NK4EPRFgWq0xwZRkviBkxaWD6Pp3fML8G+s0MQlLmSWiTElZI1aw/9oWzHqFYhWE Db8sO2vAEhzNNY6/5Z7Hd67AMjwB3ZKW5+b0D/tvMzbl1fYfk/9g9M79WgZMmefwXPDg MnIhP3khH3fYZlFkfeksWd+Iux//Z6JyOOPivg2t66m3bGbGKfOGdZyWeDWpJWM7mPwd zY747p0tK+7W7mR8srxBzaBIu2ko/XJwDoVhQsY7LBLYQT9PENIJqZRMGUtsSYWWdhb5 9rog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=AIQIbLgZNniugN1NIdeF7a/D8tcvk16SdDjHG3j4ERc=; b=XgpJQIhEYd21nS9dAIpZuj/+N03gvmgWOxCEkzmtXoWgKnsjGn9s2W2RE4axaLNudC 0VAQKMmKNPM87kGxyzUTIfLZEmI0QoRMnZANvYFeTnBv6UlgfnS37CQbJoqMzoK3SvAV mPyd+ZueKAlI0tK9soRk42SE+GZ88v6/uAALcsuXC+Mx/KsJ0v9FZFxudzMJB/5Cfr94 rf0TirtRsIsKovXS/NYFR62aoctqO962bq0P7evEpxHuKO0XgWV4R8SGZfN5O60MeBTc KTeKoNUi7ZJKrVKyYmRtA/zxDy1g9tZsh5MuhKgT0LJpqkVZ0caunCf3KmoYYX8NeRX1 VBoA== X-Gm-Message-State: AHQUAuYEgS9puOrLQ4YCbiJ3f+TmElUXgv7NtJQ0nt8YvgWPM5qJq7s3 yraMleMkNpbxQUctHW5Uhco= X-Google-Smtp-Source: AHgI3Ib69qjctW08P9B5O4LyeUjvnpgTtikFZBKA0eVwVqZlgUCUhE/QAH3xdiODWRjy1HnyTpE/gQ== X-Received: by 2002:a17:902:848f:: with SMTP id c15mr19293467plo.119.1551090245139; Mon, 25 Feb 2019 02:24:05 -0800 (PST) Received: from localhost.localdomain ([106.216.180.155]) by smtp.gmail.com with ESMTPSA id q28sm13657439pgl.35.2019.02.25.02.24.01 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 25 Feb 2019 02:24:04 -0800 (PST) From: Leslie Monis To: jhs@mojatatu.com Cc: netdev@vger.kernel.org, dave@taht.net, "Mohit P. Tahiliani" , Dhaval Khandla , Hrishikesh Hiraskar , Manish Kumar B , "Sachin D . Patil" , Leslie Monis Subject: [PATCH net-next v2 3/7] net: sched: pie: change default value of pie_params->tupdate Date: Mon, 25 Feb 2019 15:50:47 +0530 Message-Id: <20190225102051.12268-4-lesliemonis@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190225102051.12268-1-lesliemonis@gmail.com> References: <20190225102051.12268-1-lesliemonis@gmail.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: "Mohit P. Tahiliani" RFC 8033 suggests a default value of 15 milliseconds for the update interval. Signed-off-by: Mohit P. Tahiliani Signed-off-by: Dhaval Khandla Signed-off-by: Hrishikesh Hiraskar Signed-off-by: Manish Kumar B Signed-off-by: Sachin D. Patil Signed-off-by: Leslie Monis --- net/sched/sch_pie.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/sched/sch_pie.c b/net/sched/sch_pie.c index 91af9bf19852..702f75afc312 100644 --- a/net/sched/sch_pie.c +++ b/net/sched/sch_pie.c @@ -81,7 +81,7 @@ static void pie_params_init(struct pie_params *params) { params->alpha = 2; params->beta = 20; - params->tupdate = usecs_to_jiffies(30 * USEC_PER_MSEC); /* 30 ms */ + params->tupdate = usecs_to_jiffies(15 * USEC_PER_MSEC); /* 15 ms */ params->limit = 1000; /* default of 1000 packets */ params->target = PSCHED_NS2TICKS(15 * NSEC_PER_MSEC); /* 15 ms */ params->ecn = false; From patchwork Mon Feb 25 10:20:48 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Leslie Monis X-Patchwork-Id: 1047649 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="chbzlW/s"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 447J2h5KSbz9ryj for ; Mon, 25 Feb 2019 21:24:12 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726729AbfBYKYL (ORCPT ); Mon, 25 Feb 2019 05:24:11 -0500 Received: from mail-pf1-f193.google.com ([209.85.210.193]:44525 "EHLO mail-pf1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726617AbfBYKYL (ORCPT ); Mon, 25 Feb 2019 05:24:11 -0500 Received: by mail-pf1-f193.google.com with SMTP id a3so4283797pff.11 for ; Mon, 25 Feb 2019 02:24:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=JZ+wNJk/J4zdUC+DaOB4/xoqeykLd13oWxDtQH3XrcM=; b=chbzlW/sXFVN3tSbeMMYk1wgX577mUduPcBcq4Ja3Ap23wtQlmbUGjpp2rLyHR44u7 QEhgjDOz1Mpdk9MD8T8vkRmBq53EAZ5HB7GglWnuqfvbkc7yKBoznQ/cwBLN5eV+5Lw+ eIus3xl3j+J8XOzB5VqRby1ZKjYDyYlw8ttvldnkctFNDNB+WwHCVeuS7B0liJDxK15m u1CkMhWr9EC8X/W8mhxzRUIB/kVYRk8DmR5E3IfiWC5nKLhENTaMDRszoM5gw7pgHhuT NqfzFwKyP4tULbns/8ipjhwuRsDx6XcusidbCtUb5xM/+uSy/Ut86LA/y/vtkLPYXiV3 wvZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=JZ+wNJk/J4zdUC+DaOB4/xoqeykLd13oWxDtQH3XrcM=; b=pmy5XguIKJOxafCl6GYv00tleurFpedK0JHodekxelAmy++Rru66lGEx/H5JTXLyVt J126P0/xZZ5xw50lsD47fsP/WufTpqVIDk0PQujNw7uo05hSamfXX5sag6garZJ30HVr GV2MFayxc3aLIn1QKxnZ5099NPjvMAES/xvsMqAWIQlBi5/KFlamnyep2AbgXy0dWkFL +dbitinELovMCQ/EuyUdYWa38yynX0nfuy5uD5ZqDfqKdd1osrGtyPqimsUrmOmPfHOd YjNJ2pa8jrZK8Z1VbaV1Jt33/B11J29eXAk8G9Te22wkaFOMmGURFpYti/24A6O19JE6 mbYw== X-Gm-Message-State: AHQUAuYqEbj46RkT8cWz4oN64IiXSpX1tx3uNVhyhZaJkOS33ry1WOkU Oj2/1LuZEb6jjMEZAzaycQg= X-Google-Smtp-Source: AHgI3IbeN2jAMBAtq0rLIJvTsdJf53mpAHB6avrh7uvWj6oG0ZcpuA6p7bXetvDPsqztNu2sbBI4yw== X-Received: by 2002:a65:6483:: with SMTP id e3mr18280527pgv.273.1551090250639; Mon, 25 Feb 2019 02:24:10 -0800 (PST) Received: from localhost.localdomain ([106.216.180.155]) by smtp.gmail.com with ESMTPSA id q28sm13657439pgl.35.2019.02.25.02.24.06 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 25 Feb 2019 02:24:10 -0800 (PST) From: Leslie Monis To: jhs@mojatatu.com Cc: netdev@vger.kernel.org, dave@taht.net, "Mohit P. Tahiliani" , Dhaval Khandla , Hrishikesh Hiraskar , Manish Kumar B , "Sachin D . Patil" , Leslie Monis Subject: [PATCH net-next v2 4/7] net: sched: pie: change initial value of pie_vars->burst_time Date: Mon, 25 Feb 2019 15:50:48 +0530 Message-Id: <20190225102051.12268-5-lesliemonis@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190225102051.12268-1-lesliemonis@gmail.com> References: <20190225102051.12268-1-lesliemonis@gmail.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: "Mohit P. Tahiliani" RFC 8033 suggests an initial value of 150 milliseconds for the maximum time allowed for a burst of packets. Signed-off-by: Mohit P. Tahiliani Signed-off-by: Dhaval Khandla Signed-off-by: Hrishikesh Hiraskar Signed-off-by: Manish Kumar B Signed-off-by: Sachin D. Patil Signed-off-by: Leslie Monis --- net/sched/sch_pie.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/sched/sch_pie.c b/net/sched/sch_pie.c index 702f75afc312..d88ab53593b3 100644 --- a/net/sched/sch_pie.c +++ b/net/sched/sch_pie.c @@ -92,8 +92,8 @@ static void pie_vars_init(struct pie_vars *vars) { vars->dq_count = DQCOUNT_INVALID; vars->avg_dq_rate = 0; - /* default of 100 ms in pschedtime */ - vars->burst_time = PSCHED_NS2TICKS(100 * NSEC_PER_MSEC); + /* default of 150 ms in pschedtime */ + vars->burst_time = PSCHED_NS2TICKS(150 * NSEC_PER_MSEC); } static bool drop_early(struct Qdisc *sch, u32 packet_size) From patchwork Mon Feb 25 10:20:49 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Leslie Monis X-Patchwork-Id: 1047650 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="ir1yfHGP"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 447J2q1dPfz9s6w for ; Mon, 25 Feb 2019 21:24:19 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726761AbfBYKYR (ORCPT ); Mon, 25 Feb 2019 05:24:17 -0500 Received: from mail-pl1-f194.google.com ([209.85.214.194]:41099 "EHLO mail-pl1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726617AbfBYKYR (ORCPT ); Mon, 25 Feb 2019 05:24:17 -0500 Received: by mail-pl1-f194.google.com with SMTP id y5so4300075plk.8 for ; Mon, 25 Feb 2019 02:24:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=L52rnRwdcVBrzbMrQBVaimfDnLTTRYE68e1l696Kcvo=; b=ir1yfHGPi9r7CqoJUfC9n/WdPG8mnrWh5pAEARhsG3NbwWZm1D7BR+CfLQvzfMWoUE 7Tu8plGd1tnzpBs5115bhHX+mJVOvT3SUSwlBhhRvLkSTTHLhlslZSpwoRHc7eB/DAuC ymqDugWv1hek3Cu0SqErr30sSptcAKxRjZVeI4Mj1eQWUwF2XEOwjWJYBTq4Z35Uxvx8 CktPouM34Ti4QFcvKaYbEuTFwuhydMrciTkkBgZ5m9RyP/P7koUj49vTIBVhV13AmDpt QfmDE5HGhhmGadxW3n9KHH8gYLdbBsSbBv228HjxnE16VaFvMe2CV3J1J/JZ6+0O6X1V PF/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=L52rnRwdcVBrzbMrQBVaimfDnLTTRYE68e1l696Kcvo=; b=BFRQYLgil1dvbOG+YULv1gvNxdogYM677tUK/ODOcdjP5ovuCzGLn/pbyp28eAkS0X LKmtc18J/laJi9hvz+xhWoKwG61IIoqt5KavCqOgEv79QvXpU0F6Or4jhgcJ5z5ovHbY p5v/5ECtCMF+tTl8yClKo+eUZwesrqMoDnBmIDbfOs3ytOU9E7lcRorRkbABmnKL39qT YIcSzoNzZrb0PhVyATzuA/xDlFaLYsFGcIu1gnlyo2NvZ11eK2yNZ3HY25a2lv0K5Mu7 w7q379MU50xSKm5HY9aTqiGNWjsL3Iey0Wnh0ovZnAfmmXmZ0uLuDcxZ8OIMekAksnUs T7rw== X-Gm-Message-State: AHQUAuaBOorG2A5s0WrdQdlSt4EeV70pfVC2zZUTWDKXGstCVbyl/Hwh g28gPXwCKbGvKVEaT6aUafE= X-Google-Smtp-Source: AHgI3IYb96RhhoADIhhSP5sF8fmcRNzrxAOMoqlHt/8vmtrj5Kgsolrduq/ZrATdjlMYyyvlPEClBw== X-Received: by 2002:a17:902:c23:: with SMTP id 32mr20009175pls.183.1551090256320; Mon, 25 Feb 2019 02:24:16 -0800 (PST) Received: from localhost.localdomain ([106.216.180.155]) by smtp.gmail.com with ESMTPSA id q28sm13657439pgl.35.2019.02.25.02.24.12 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 25 Feb 2019 02:24:15 -0800 (PST) From: Leslie Monis To: jhs@mojatatu.com Cc: netdev@vger.kernel.org, dave@taht.net, "Mohit P. Tahiliani" , Dhaval Khandla , Hrishikesh Hiraskar , Manish Kumar B , "Sachin D . Patil" , Leslie Monis Subject: [PATCH net-next v2 5/7] net: sched: pie: add more cases to auto-tune alpha and beta Date: Mon, 25 Feb 2019 15:50:49 +0530 Message-Id: <20190225102051.12268-6-lesliemonis@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190225102051.12268-1-lesliemonis@gmail.com> References: <20190225102051.12268-1-lesliemonis@gmail.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: "Mohit P. Tahiliani" The current implementation scales the local alpha and beta variables in the calculate_probability function by the same amount for all values of drop probability below 1%. RFC 8033 suggests using additional cases for auto-tuning alpha and beta when the drop probability is less than 1%. In order to add more auto-tuning cases, MAX_PROB must be scaled by u64 instead of u32 to prevent underflow when scaling the local alpha and beta variables in the calculate_probability function. Signed-off-by: Mohit P. Tahiliani Signed-off-by: Dhaval Khandla Signed-off-by: Hrishikesh Hiraskar Signed-off-by: Manish Kumar B Signed-off-by: Sachin D. Patil Signed-off-by: Leslie Monis --- include/uapi/linux/pkt_sched.h | 2 +- net/sched/sch_pie.c | 65 +++++++++++++++++----------------- 2 files changed, 33 insertions(+), 34 deletions(-) diff --git a/include/uapi/linux/pkt_sched.h b/include/uapi/linux/pkt_sched.h index 0d18b1d1fbbc..1eb572ef3f27 100644 --- a/include/uapi/linux/pkt_sched.h +++ b/include/uapi/linux/pkt_sched.h @@ -954,7 +954,7 @@ enum { #define TCA_PIE_MAX (__TCA_PIE_MAX - 1) struct tc_pie_xstats { - __u32 prob; /* current probability */ + __u64 prob; /* current probability */ __u32 delay; /* current delay in ms */ __u32 avg_dq_rate; /* current average dq_rate in bits/pie_time */ __u32 packets_in; /* total number of packets enqueued */ diff --git a/net/sched/sch_pie.c b/net/sched/sch_pie.c index d88ab53593b3..b9f586cfb51c 100644 --- a/net/sched/sch_pie.c +++ b/net/sched/sch_pie.c @@ -33,7 +33,7 @@ #define QUEUE_THRESHOLD 16384 #define DQCOUNT_INVALID -1 -#define MAX_PROB 0xffffffff +#define MAX_PROB 0xffffffffffffffff #define PIE_SCALE 8 /* parameters used */ @@ -49,7 +49,7 @@ struct pie_params { /* variables used */ struct pie_vars { - u32 prob; /* probability but scaled by u32 limit. */ + u64 prob; /* probability but scaled by u64 limit. */ psched_time_t burst_time; psched_time_t qdelay; psched_time_t qdelay_old; @@ -99,8 +99,8 @@ static void pie_vars_init(struct pie_vars *vars) static bool drop_early(struct Qdisc *sch, u32 packet_size) { struct pie_sched_data *q = qdisc_priv(sch); - u32 rnd; - u32 local_prob = q->vars.prob; + u64 rnd; + u64 local_prob = q->vars.prob; u32 mtu = psched_mtu(qdisc_dev(sch)); /* If there is still burst allowance left skip random early drop */ @@ -124,11 +124,11 @@ static bool drop_early(struct Qdisc *sch, u32 packet_size) * probablity. Smaller packets will have lower drop prob in this case */ if (q->params.bytemode && packet_size <= mtu) - local_prob = (local_prob / mtu) * packet_size; + local_prob = (local_prob / (u64)mtu) * (u64)packet_size; else local_prob = q->vars.prob; - rnd = prandom_u32(); + prandom_bytes(&rnd, 8); if (rnd < local_prob) return true; @@ -317,9 +317,10 @@ static void calculate_probability(struct Qdisc *sch) u32 qlen = sch->qstats.backlog; /* queue size in bytes */ psched_time_t qdelay = 0; /* in pschedtime */ psched_time_t qdelay_old = q->vars.qdelay; /* in pschedtime */ - s32 delta = 0; /* determines the change in probability */ - u32 oldprob; - u32 alpha, beta; + s64 delta = 0; /* determines the change in probability */ + u64 oldprob; + u64 alpha, beta; + u32 power; bool update_prob = true; q->vars.qdelay_old = q->vars.qdelay; @@ -339,38 +340,36 @@ static void calculate_probability(struct Qdisc *sch) * value for alpha as 0.125. In this implementation, we use values 0-32 * passed from user space to represent this. Also, alpha and beta have * unit of HZ and need to be scaled before they can used to update - * probability. alpha/beta are updated locally below by 1) scaling them - * appropriately 2) scaling down by 16 to come to 0-2 range. - * Please see paper for details. - * - * We scale alpha and beta differently depending on whether we are in - * light, medium or high dropping mode. + * probability. alpha/beta are updated locally below by scaling down + * by 16 to come to 0-2 range. */ - if (q->vars.prob < MAX_PROB / 100) { - alpha = - (q->params.alpha * (MAX_PROB / PSCHED_TICKS_PER_SEC)) >> 7; - beta = - (q->params.beta * (MAX_PROB / PSCHED_TICKS_PER_SEC)) >> 7; - } else if (q->vars.prob < MAX_PROB / 10) { - alpha = - (q->params.alpha * (MAX_PROB / PSCHED_TICKS_PER_SEC)) >> 5; - beta = - (q->params.beta * (MAX_PROB / PSCHED_TICKS_PER_SEC)) >> 5; - } else { - alpha = - (q->params.alpha * (MAX_PROB / PSCHED_TICKS_PER_SEC)) >> 4; - beta = - (q->params.beta * (MAX_PROB / PSCHED_TICKS_PER_SEC)) >> 4; + alpha = ((u64)q->params.alpha * (MAX_PROB / PSCHED_TICKS_PER_SEC)) >> 4; + beta = ((u64)q->params.beta * (MAX_PROB / PSCHED_TICKS_PER_SEC)) >> 4; + + /* We scale alpha and beta differently depending on how heavy the + * congestion is. Please see RFC 8033 for details. + */ + if (q->vars.prob < MAX_PROB / 10) { + alpha >>= 1; + beta >>= 1; + + power = 100; + while (q->vars.prob < MAX_PROB / (u64)power && + power <= 1000000) { + alpha >>= 2; + beta >>= 2; + power *= 10; + } } /* alpha and beta should be between 0 and 32, in multiples of 1/16 */ - delta += alpha * ((qdelay - q->params.target)); - delta += beta * ((qdelay - qdelay_old)); + delta += alpha * (u64)(qdelay - q->params.target); + delta += beta * (u64)(qdelay - qdelay_old); oldprob = q->vars.prob; /* to ensure we increase probability in steps of no more than 2% */ - if (delta > (s32)(MAX_PROB / (100 / 2)) && + if (delta > (s64)(MAX_PROB / (100 / 2)) && q->vars.prob >= MAX_PROB / 10) delta = (MAX_PROB / 100) * 2; From patchwork Mon Feb 25 10:20:50 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Leslie Monis X-Patchwork-Id: 1047651 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="VFUAz7HG"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 447J2w36Cqz9ryj for ; Mon, 25 Feb 2019 21:24:24 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726766AbfBYKYX (ORCPT ); Mon, 25 Feb 2019 05:24:23 -0500 Received: from mail-pf1-f196.google.com ([209.85.210.196]:44543 "EHLO mail-pf1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726617AbfBYKYX (ORCPT ); Mon, 25 Feb 2019 05:24:23 -0500 Received: by mail-pf1-f196.google.com with SMTP id a3so4284007pff.11 for ; Mon, 25 Feb 2019 02:24:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=BF4261GS/DITgP9ORlcqD0UoIK3lVA36V4n3kfhZP1w=; b=VFUAz7HGDgmpcEqYuwcO9dumkYXc2UaPiQVTC0DKaPH6M6V2x7Mpe/EppOZeuVLIuP NfuZXG6BmbMUt6Pd1dMjD9iDpVradEQfeK/A7v71iZ6/vpbe3MYHxmtro3xyipuIiLTa oHfSEDplYTuhgOCYABW9Wn07IxIyUvezVgvLZAx769nVX5pRVi8cEAPswTSNb5xt9Dit tyJpG/tz4aUP3IOAX8fB10ql03UE4HoAG2k9wfC6tRajIYXqwjOYL1zYn95xKxduraS9 lwBniwcL4D7qHSbvVGQIqrgLEcFB6neI/57RIx/4n5gmWlq+w3seivn8laish3a6ANCb MZeA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=BF4261GS/DITgP9ORlcqD0UoIK3lVA36V4n3kfhZP1w=; b=Ab6ooHM4hjmi7K97ZS4qHAkjzg1s9ebZBwid7AaquO4YZzKya6bLoCHgyOpp/jtqa6 t7DSB8k+ggXUc18WZn8IhHuUp/Bsx46PyM8PFDs+Q/fppTUvzhph1BLKzX3VUfUM5/8m 2+NRIgBqYCFGstC+X9SB8+ePmbe/VfBUmOEg9f10c9M9W5sLwoFeE75fz3hcVPdGmRN9 WoO0Cj7/2WmJ5Ayiyv/aoheBEd2vFgKlwcIIr9yPuRlVyFLFFtLpob+0JggMx+6pTx+u Gsat5AKt4YoHe/CwEuzoUjUmWATLlegKOZGJk2sFNi0uYf54jRgt6kCYuqZBQbK4c24P jgBA== X-Gm-Message-State: AHQUAuZaklqy3kMqclDcS3r7Ap77uVUDhps5GgasprrmQAEhyiRf0iGk PZLYmZKQWcE1v11bnfTX5U8= X-Google-Smtp-Source: AHgI3IbcyfIf5mkxUi2k/ZF7EZtYmyDIblz+X3ePXrNro6bJZGq0e82+7W4NEDj4pAGq9Cgsoez9gg== X-Received: by 2002:a62:6f49:: with SMTP id k70mr19452708pfc.7.1551090261752; Mon, 25 Feb 2019 02:24:21 -0800 (PST) Received: from localhost.localdomain ([106.216.180.155]) by smtp.gmail.com with ESMTPSA id q28sm13657439pgl.35.2019.02.25.02.24.17 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 25 Feb 2019 02:24:21 -0800 (PST) From: Leslie Monis To: jhs@mojatatu.com Cc: netdev@vger.kernel.org, dave@taht.net, "Mohit P. Tahiliani" , Dhaval Khandla , Hrishikesh Hiraskar , Manish Kumar B , "Sachin D . Patil" , Leslie Monis Subject: [PATCH net-next v2 6/7] net: sched: pie: add derandomization mechanism Date: Mon, 25 Feb 2019 15:50:50 +0530 Message-Id: <20190225102051.12268-7-lesliemonis@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190225102051.12268-1-lesliemonis@gmail.com> References: <20190225102051.12268-1-lesliemonis@gmail.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: "Mohit P. Tahiliani" Random dropping of packets to achieve latency control may introduce outlier situations where packets are dropped too close to each other or too far from each other. This can cause the real drop percentage to temporarily deviate from the intended drop probability. In certain scenarios, such as a small number of simultaneous TCP flows, these deviations can cause significant deviations in link utilization and queuing latency. RFC 8033 suggests using a derandomization mechanism to avoid these deviations. Signed-off-by: Mohit P. Tahiliani Signed-off-by: Dhaval Khandla Signed-off-by: Hrishikesh Hiraskar Signed-off-by: Manish Kumar B Signed-off-by: Sachin D. Patil Signed-off-by: Leslie Monis --- net/sched/sch_pie.c | 28 +++++++++++++++++++++++++++- 1 file changed, 27 insertions(+), 1 deletion(-) diff --git a/net/sched/sch_pie.c b/net/sched/sch_pie.c index b9f586cfb51c..8bfd8ca500f9 100644 --- a/net/sched/sch_pie.c +++ b/net/sched/sch_pie.c @@ -55,8 +55,10 @@ struct pie_vars { psched_time_t qdelay_old; u64 dq_count; /* measured in bytes */ psched_time_t dq_tstamp; /* drain rate */ + u64 accu_prob; /* accumulated drop probability */ u32 avg_dq_rate; /* bytes per pschedtime tick,scaled */ u32 qlen_old; /* in bytes */ + u8 accu_prob_overflows; /* overflows of accu_prob */ }; /* statistics gathering */ @@ -91,9 +93,11 @@ static void pie_params_init(struct pie_params *params) static void pie_vars_init(struct pie_vars *vars) { vars->dq_count = DQCOUNT_INVALID; + vars->accu_prob = 0; vars->avg_dq_rate = 0; /* default of 150 ms in pschedtime */ vars->burst_time = PSCHED_NS2TICKS(150 * NSEC_PER_MSEC); + vars->accu_prob_overflows = 0; } static bool drop_early(struct Qdisc *sch, u32 packet_size) @@ -128,9 +132,29 @@ static bool drop_early(struct Qdisc *sch, u32 packet_size) else local_prob = q->vars.prob; + if (local_prob == 0) { + q->vars.accu_prob = 0; + q->vars.accu_prob_overflows = 0; + } + + if (local_prob > MAX_PROB - q->vars.accu_prob) + q->vars.accu_prob_overflows++; + + q->vars.accu_prob += local_prob; + + if (q->vars.accu_prob_overflows == 0 && + q->vars.accu_prob < (MAX_PROB / 100) * 85) + return false; + if (q->vars.accu_prob_overflows == 8 && + q->vars.accu_prob >= MAX_PROB / 2) + return true; + prandom_bytes(&rnd, 8); - if (rnd < local_prob) + if (rnd < local_prob) { + q->vars.accu_prob = 0; + q->vars.accu_prob_overflows = 0; return true; + } return false; } @@ -168,6 +192,8 @@ static int pie_qdisc_enqueue(struct sk_buff *skb, struct Qdisc *sch, out: q->stats.dropped++; + q->vars.accu_prob = 0; + q->vars.accu_prob_overflows = 0; return qdisc_drop(skb, sch, to_free); } From patchwork Mon Feb 25 10:20:51 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Leslie Monis X-Patchwork-Id: 1047652 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="SOphgAe4"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 447J316Sd5z9ryj for ; Mon, 25 Feb 2019 21:24:29 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726772AbfBYKY2 (ORCPT ); Mon, 25 Feb 2019 05:24:28 -0500 Received: from mail-pl1-f195.google.com ([209.85.214.195]:38966 "EHLO mail-pl1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726617AbfBYKY2 (ORCPT ); Mon, 25 Feb 2019 05:24:28 -0500 Received: by mail-pl1-f195.google.com with SMTP id b65so1280277plb.6 for ; Mon, 25 Feb 2019 02:24:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=A8lkwHeZQUhC0aWGr+AyLdM8o4Hl5IEguUHn5HLplSs=; b=SOphgAe45f0HZitVsdWm5Kfg8lSGyewc/NP0URtB0VI7ETSkbn4T3yTXmXBtQa6oOc XvUhAqdth4+v4iRah6TTYOUl/QS7BZ46STp5SqfJIeQMl3wRXuZlWW7nrNcOTEcSy3MX F6JZECpAdxPzSoyl0DkCHcf/s8QPaxBBgFzvfnaN31K7nQFIwFc1Nvvex3PAu5TScd4D zjGYsvPDCJEVjhwW5mwhm0VEX2IldBvvO3tYyZaSziDLPlC6Nmamb2ANCgdOZtfMmS09 YlRsmN2kw9hL5nHZ9T4BGzP4Fj0lxtq6nWXIagn7LVEAzEEieWiZZtEbNa+eupdz7kcj 46KA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=A8lkwHeZQUhC0aWGr+AyLdM8o4Hl5IEguUHn5HLplSs=; b=Ph11WuZkDrEzqUd2BE2WsUkouAcwiOo65q5FJEDIa0ItU96+k/UiNvUrBOfQfe4UsI AacUZt1B8AGlcCcHpGWt0W6kawWs4Nkt8I8FIt6fGHWLe78AsUIwi19XZaL/aPV3mKbn fTFZ0iLWXJtIsS2AnxpaPnXeI7Yk2iG1UbSLpe86oh84RbzEfgHtWhE/Q8EzL5FnbOLI 9ePt/QPQvRjDa2UEnlmr0cr8BW8pe0hybkOH0kaGgLIPLpoVIj+/90pHcl887ybzVUUB VHIPPbsfQr3KFsjAPL9GXYoDrNbhTNREXXTQP24Wj5oA/4vik7JsZCJ9MT4RqX5xG0Nk +LZg== X-Gm-Message-State: AHQUAuZsTfZggmH678fjOEu/qD/JJcXUUwZXKiu00FsGkviP1TirCd7E Qi80+uAWuPieHHsl+wT4fH8= X-Google-Smtp-Source: AHgI3Ibid26PZwg2hzLh/3gnIv+SsIlj0iPmzbYgbqenlbOoK/5Qvqf1DU1Lswq1u3p6I+X1GFKKOw== X-Received: by 2002:a17:902:264:: with SMTP id 91mr19884639plc.108.1551090267731; Mon, 25 Feb 2019 02:24:27 -0800 (PST) Received: from localhost.localdomain ([106.216.180.155]) by smtp.gmail.com with ESMTPSA id q28sm13657439pgl.35.2019.02.25.02.24.23 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 25 Feb 2019 02:24:27 -0800 (PST) From: Leslie Monis To: jhs@mojatatu.com Cc: netdev@vger.kernel.org, dave@taht.net, "Mohit P. Tahiliani" , Dhaval Khandla , Hrishikesh Hiraskar , Manish Kumar B , "Sachin D . Patil" , Leslie Monis Subject: [PATCH net-next v2 7/7] net: sched: pie: update references Date: Mon, 25 Feb 2019 15:50:51 +0530 Message-Id: <20190225102051.12268-8-lesliemonis@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190225102051.12268-1-lesliemonis@gmail.com> References: <20190225102051.12268-1-lesliemonis@gmail.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: "Mohit P. Tahiliani" RFC 8033 replaces the IETF draft for PIE Signed-off-by: Mohit P. Tahiliani Signed-off-by: Dhaval Khandla Signed-off-by: Hrishikesh Hiraskar Signed-off-by: Manish Kumar B Signed-off-by: Sachin D. Patil Signed-off-by: Leslie Monis --- net/sched/sch_pie.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/net/sched/sch_pie.c b/net/sched/sch_pie.c index 8bfd8ca500f9..78658080fcc4 100644 --- a/net/sched/sch_pie.c +++ b/net/sched/sch_pie.c @@ -17,9 +17,7 @@ * University of Oslo, Norway. * * References: - * IETF draft submission: http://tools.ietf.org/html/draft-pan-aqm-pie-00 - * IEEE Conference on High Performance Switching and Routing 2013 : - * "PIE: A * Lightweight Control Scheme to Address the Bufferbloat Problem" + * RFC 8033: https://tools.ietf.org/html/rfc8034 */ #include