From patchwork Wed Feb 20 12:53:18 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Florian Weimer X-Patchwork-Id: 1045336 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=sourceware.org (client-ip=209.132.180.131; helo=sourceware.org; envelope-from=libc-alpha-return-100163-incoming=patchwork.ozlabs.org@sourceware.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.b="ZHf+d1DI"; dkim-atps=neutral Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 444HbH5G2sz9s1B for ; Wed, 20 Feb 2019 23:53:30 +1100 (AEDT) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:subject:date:message-id:mime-version :content-type; q=dns; s=default; b=sEzvWp5AN+InHmY6fpb5XNURzT6Cx qL9QdpUkFuEFOP0/UuGah8SOdy/bogltI8jtynRVpw4PyK+37JnFPwWGf0TbcVpm 5fM0YSF7/6tZWjirHUUMpQyWyfUgskuFspIjQYnnZzdoqok3cEDr+N5j7POxOjC0 51xj3Z00/CSNQI= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:subject:date:message-id:mime-version :content-type; s=default; bh=WtcT+O/UZef5t4w4v2+83dnZGeI=; b=ZHf +d1DI90toojW8thQjI/1ANrLAFLamXwf5YjH2Dl7dqCKIgwJbsnrLFlDT97Xo1nD yqaslRd0sqogt8AL8GMJn0w1fGALuZHqaFQ9Vms+eW+rd8oNxJ9nxnabmzBkoOKW yH104PwwSPFObPi3bxNKP/ZtWjAUBqjhDbIWlW/M= Received: (qmail 108230 invoked by alias); 20 Feb 2019 12:53:24 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 108217 invoked by uid 89); 20 Feb 2019 12:53:23 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, KAM_SHORT, SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Hx-spam-relays-external:sk:dhcp-19, H*RU:sk:dhcp-19, H*r:sk:dhcp-19, attr-ifunc-4.c X-HELO: mx1.redhat.com From: Florian Weimer To: libc-alpha@sourceware.org Subject: [PATCH] elf: Add tests with a local IFUNC resolver [BZ #23937] Date: Wed, 20 Feb 2019 13:53:18 +0100 Message-ID: <87mumqei4h.fsf@oldenburg2.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 The existing tests all use global symbols (but with different visibility). Local symbols could be treated differently by the compiler and linker (as was the case on POWER ELFv2, causing bug 23937), and we did not have test coverage for this. Tested on x86-64 and POWER ELFv2 little-endian, with and without --disable-multi-arch. On POWER, the test cases elf/ifuncmain9, elf/ifuncmain9pic, elf/ifuncmain9pie reproduce bug 23937 with older binutils. 2019-02-20 Florian Weimer [BZ #23937] elf: Add test with a local IFUNC resolver. * elf/ifuncmain9.c: New file. * elf/ifuncmain9pic.c: Likewise. * elf/ifuncmain9picstatic.c: Likewise. * elf/ifuncmain9pie.c: Likewise. * elf/ifuncmain9static.c: Likewise. * elf/Makefile [multi-arch] (tests-ifuncstatic): Add ifuncmain9static, ifuncmain9picstatic. * elf/Makefile [multi-arch && build-shared] (tests-internal): Add ifuncmain9, ifuncmain9pic. * elf/Makefile [multi-arch && build-shared && have-fpie] (ifunc-pie-tests): Add ifuncmain9pie. (CFLAGS-ifuncmain9pic.c): Add $(pic-ccflag). (CFLAGS-ifuncmain9picstatic.c): Likewise. (CFLAGS-ifuncmain9pie.c): Add $(pie-ccflag). diff --git a/elf/Makefile b/elf/Makefile index faec577d1c..fbb159f9a6 100644 --- a/elf/Makefile +++ b/elf/Makefile @@ -326,23 +326,26 @@ tests-ifuncstatic := ifuncmain1static ifuncmain1picstatic \ ifuncmain2static ifuncmain2picstatic \ ifuncmain4static ifuncmain4picstatic \ ifuncmain5static ifuncmain5picstatic \ - ifuncmain7static ifuncmain7picstatic + ifuncmain7static ifuncmain7picstatic \ + ifuncmain9static ifuncmain9picstatic tests-static += $(tests-ifuncstatic) tests-internal += $(tests-ifuncstatic) ifeq (yes,$(build-shared)) +# Note: sysdeps/x86_64/ifuncmain8.c uses ifuncmain8. tests-internal += \ ifuncmain1 ifuncmain1pic ifuncmain1vis ifuncmain1vispic \ ifuncmain1staticpic \ ifuncmain2 ifuncmain2pic ifuncmain3 ifuncmain4 \ ifuncmain5 ifuncmain5pic ifuncmain5staticpic \ - ifuncmain7 ifuncmain7pic + ifuncmain7 ifuncmain7pic \ + ifuncmain9 ifuncmain9pic ifunc-test-modules = ifuncdep1 ifuncdep1pic ifuncdep2 ifuncdep2pic \ ifuncdep5 ifuncdep5pic extra-test-objs += $(ifunc-test-modules:=.o) test-internal-extras += $(ifunc-test-modules) ifeq (yes,$(have-fpie)) ifunc-pie-tests = ifuncmain1pie ifuncmain1vispie ifuncmain1staticpie \ - ifuncmain5pie ifuncmain6pie ifuncmain7pie + ifuncmain5pie ifuncmain6pie ifuncmain7pie ifuncmain9pie ifeq (yes,$(have-textrel_ifunc)) ifunc-pie-tests += tst-ifunc-textrel endif @@ -1276,6 +1279,8 @@ CFLAGS-ifuncmain5staticpic.c += $(pic-ccflag) CFLAGS-ifuncdep5pic.c += $(pic-ccflag) CFLAGS-ifuncmain7pic.c += $(pic-ccflag) CFLAGS-ifuncmain7picstatic.c += $(pic-ccflag) +CFLAGS-ifuncmain9pic.c += $(pic-ccflag) +CFLAGS-ifuncmain9picstatic.c += $(pic-ccflag) LDFLAGS-ifuncmain3 = -Wl,-export-dynamic @@ -1285,6 +1290,7 @@ CFLAGS-ifuncmain1staticpie.c += $(pie-ccflag) CFLAGS-ifuncmain5pie.c += $(pie-ccflag) CFLAGS-ifuncmain6pie.c += $(pie-ccflag) CFLAGS-ifuncmain7pie.c += $(pie-ccflag) +CFLAGS-ifuncmain9pie.c += $(pie-ccflag) CFLAGS-tst-ifunc-textrel.c += $(pic-ccflag) $(objpfx)ifuncmain1pie: $(objpfx)ifuncmod1.so diff --git a/elf/ifuncmain9.c b/elf/ifuncmain9.c new file mode 100644 index 0000000000..a8a9c49dd1 --- /dev/null +++ b/elf/ifuncmain9.c @@ -0,0 +1,107 @@ +/* Test for IFUNC handling with local definitions. + Copyright (C) 2019 Free Software Foundation, Inc. + This file is part of the GNU C Library. + + The GNU C Library is free software; you can redistribute it and/or + modify it under the terms of the GNU Lesser General Public + License as published by the Free Software Foundation; either + version 2.1 of the License, or (at your option) any later version. + + The GNU C Library is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + Lesser General Public License for more details. + + You should have received a copy of the GNU Lesser General Public + License along with the GNU C Library; if not, see + . */ + +/* This test is based on gcc.dg/attr-ifunc-4.c. */ + +#include + +#ifdef HAVE_GCC_IFUNC + +# include +# include + +/* Do not use the test framework, so that the process setup is not + disturbed. */ + +static volatile int implementation_called; +static volatile int resolver_called; + +/* Just a random constant, to check that we called the right + function. */ +enum { random_constant = 0x3a88d66d }; + +static int +implementation (void) +{ + ++implementation_called; + return random_constant; +} + +static __typeof__ (implementation) * +resolver (void) +{ + ++resolver_called; + return implementation; +} + +static int magic (void) __attribute__ ((ifunc ("resolver"))); + +int +main (void) +{ + bool errors = false; + + if (implementation_called != 0) + { + printf ("error: initial value of implementation_called is not zero:" + " %d\n", implementation_called); + errors = true; + } + + /* This can be zero if the reference is bound lazily. */ + printf ("info: initial value of resolver_called: %d\n", resolver_called); + + int magic_value = magic (); + if (magic_value != random_constant) + { + printf ("error: invalid magic value: 0x%x\n", magic_value); + errors = true; + } + + printf ("info: resolver_called value: %d\n", resolver_called); + if (resolver_called == 0) + { + /* In theory, the resolver could be called multiple times if + several relocations are needed. */ + puts ("error: invalid resolver_called value (must not be zero)"); + errors = true; + } + + printf ("info: implementation_called value: %d\n", implementation_called); + if (implementation_called != 1) + { + puts ("error: invalid implementation_called value (must be 1)"); + errors = true; + } + + return errors; +} + +#else /* !HAVE_GCC_IFUNC */ + +# include + +static int +do_test (void) +{ + FAIL_UNSUPPORTED ("GCC does not support the ifunc attribute"); + return 1; /* Not reachable. */ +} + +# include +#endif diff --git a/elf/ifuncmain9pic.c b/elf/ifuncmain9pic.c new file mode 100644 index 0000000000..6151a45e88 --- /dev/null +++ b/elf/ifuncmain9pic.c @@ -0,0 +1 @@ +#include "ifuncmain9.c" diff --git a/elf/ifuncmain9picstatic.c b/elf/ifuncmain9picstatic.c new file mode 100644 index 0000000000..6151a45e88 --- /dev/null +++ b/elf/ifuncmain9picstatic.c @@ -0,0 +1 @@ +#include "ifuncmain9.c" diff --git a/elf/ifuncmain9pie.c b/elf/ifuncmain9pie.c new file mode 100644 index 0000000000..6151a45e88 --- /dev/null +++ b/elf/ifuncmain9pie.c @@ -0,0 +1 @@ +#include "ifuncmain9.c" diff --git a/elf/ifuncmain9static.c b/elf/ifuncmain9static.c new file mode 100644 index 0000000000..6151a45e88 --- /dev/null +++ b/elf/ifuncmain9static.c @@ -0,0 +1 @@ +#include "ifuncmain9.c"