From patchwork Wed Feb 20 09:02:47 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Juerg Haefliger X-Patchwork-Id: 1045220 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.ubuntu.com (client-ip=91.189.94.19; helo=huckleberry.canonical.com; envelope-from=kernel-team-bounces@lists.ubuntu.com; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=canonical.com Received: from huckleberry.canonical.com (huckleberry.canonical.com [91.189.94.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 444BTH4XY9z9s70; Wed, 20 Feb 2019 20:02:59 +1100 (AEDT) Received: from localhost ([127.0.0.1] helo=huckleberry.canonical.com) by huckleberry.canonical.com with esmtp (Exim 4.86_2) (envelope-from ) id 1gwNmI-00078u-2V; Wed, 20 Feb 2019 09:02:54 +0000 Received: from youngberry.canonical.com ([91.189.89.112]) by huckleberry.canonical.com with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.86_2) (envelope-from ) id 1gwNmF-00078l-Mo for kernel-team@lists.ubuntu.com; Wed, 20 Feb 2019 09:02:51 +0000 Received: from mail-wm1-f72.google.com ([209.85.128.72]) by youngberry.canonical.com with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.76) (envelope-from ) id 1gwNmF-00054h-AU for kernel-team@lists.ubuntu.com; Wed, 20 Feb 2019 09:02:51 +0000 Received: by mail-wm1-f72.google.com with SMTP id p9so1402378wmi.0 for ; Wed, 20 Feb 2019 01:02:51 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:mime-version :content-transfer-encoding; bh=csQm/MsZhy3JFvDNlXYTIBUz2LhQnl9crrpVStUEobg=; b=VHNBLg/DRBa+RgD5ZPf+VWVoqgAwKO+bVM52cB1t9O/dflDpnPv7qwEJLQdU9PDxJu FsYb7utowKTeJcAb2PX0jajDu5+kV5AKva1pcTg3Vh4TAbJ1Eo2/9EarGscYvKUrxy+4 ctbZxAVInHMhBZQ57aQfI13nuWbDCvA3XNYsoDjAwTCsAyrB47LrsAvjg7rSD8mbIVvS xTw9/dIen0/q2+90nINMQx6y85vK+F6Z7aDHRypTvoFZmREArUapdWjgxUG8+80aubMG Wqi+7+G8isCoxQDSMCY88WsBGiM/5XK5bxXGM1I8r/ot6gUr25HYyATuNT4ZtnEBmdlR xRnQ== X-Gm-Message-State: AHQUAuZAkHqdzzKEdJxLvWRlJ9gd92kbGiIy//QUSoZNkAxcqWehErs2 LHjerOvMB8sQD593+XCiAwCkfHxAnO/663ulUO+53k0CJQSYZnEqkzsaVB0ZsuUlGa9o76CuqZQ WO4uMzMl8CT7ioH2F62O8zpQBRP9hJwIlKYfLRVI5fA== X-Received: by 2002:adf:ec10:: with SMTP id x16mr24093185wrn.171.1550653370785; Wed, 20 Feb 2019 01:02:50 -0800 (PST) X-Google-Smtp-Source: AHgI3IYQSr2i2iY38YtfXlFkgVCES68uEaaL9tbMVxlgCOdtPF+4r68aR1RTO3V9UPJdPEvv4mTPAw== X-Received: by 2002:adf:ec10:: with SMTP id x16mr24093167wrn.171.1550653370491; Wed, 20 Feb 2019 01:02:50 -0800 (PST) Received: from localhost.localdomain ([194.158.46.138]) by smtp.gmail.com with ESMTPSA id y139sm6981726wmd.22.2019.02.20.01.02.49 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 20 Feb 2019 01:02:49 -0800 (PST) From: Juerg Haefliger X-Google-Original-From: Juerg Haefliger To: kernel-team@lists.ubuntu.com Subject: [Unstable][PATCH] Revert "selftests/tls: Add test for recv(PEEK) spanning across multiple records" Date: Wed, 20 Feb 2019 10:02:47 +0100 Message-Id: <20190220090247.7932-1-juergh@canonical.com> X-Mailer: git-send-email 2.19.1 MIME-Version: 1.0 X-BeenThere: kernel-team@lists.ubuntu.com X-Mailman-Version: 2.1.20 Precedence: list List-Id: Kernel team discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: kernel-team-bounces@lists.ubuntu.com Sender: "kernel-team" BugLink: https://bugs.launchpad.net/bugs/1816716 This reverts commit c2ad647c6442cf6730ffd86cbadbbce101dea937. The selftest that was added by the above commit never passed since it tests a feature (multi-record socket PEEK) that is not fully/properly implemented yet. So lets remove the test to prevent bogus failures. Signed-off-by: Juerg Haefliger --- tools/testing/selftests/net/tls.c | 23 ----------------------- 1 file changed, 23 deletions(-) diff --git a/tools/testing/selftests/net/tls.c b/tools/testing/selftests/net/tls.c index fac68d710f35..df9f76aae5f5 100644 --- a/tools/testing/selftests/net/tls.c +++ b/tools/testing/selftests/net/tls.c @@ -551,29 +551,6 @@ TEST_F(tls, recv_peek_multiple_records) EXPECT_EQ(memcmp(test_str, buf, len), 0); } -TEST_F(tls, recv_peek_large_buf_mult_recs) -{ - char const *test_str = "test_read_peek_mult_recs"; - char const *test_str_first = "test_read_peek"; - char const *test_str_second = "_mult_recs"; - int len; - char buf[64]; - - len = strlen(test_str_first); - EXPECT_EQ(send(self->fd, test_str_first, len, 0), len); - - len = strlen(test_str_second) + 1; - EXPECT_EQ(send(self->fd, test_str_second, len, 0), len); - - len = sizeof(buf); - memset(buf, 0, len); - EXPECT_NE(recv(self->cfd, buf, len, MSG_PEEK), -1); - - len = strlen(test_str) + 1; - EXPECT_EQ(memcmp(test_str, buf, len), 0); -} - - TEST_F(tls, pollin) { char const *test_str = "test_poll";