From patchwork Tue Feb 19 19:12:53 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bjorn Andersson X-Patchwork-Id: 1044864 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=linux-gpio-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="SrulZOWa"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 443r3840Twz9s21 for ; Wed, 20 Feb 2019 06:12:36 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726342AbfBSTMf (ORCPT ); Tue, 19 Feb 2019 14:12:35 -0500 Received: from mail-pl1-f196.google.com ([209.85.214.196]:38163 "EHLO mail-pl1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726225AbfBSTMe (ORCPT ); Tue, 19 Feb 2019 14:12:34 -0500 Received: by mail-pl1-f196.google.com with SMTP id e5so10881983plb.5 for ; Tue, 19 Feb 2019 11:12:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=VHWMlfMrTM94H6bRgK8jtWQ5WLwGNoqEAx6AZJOMxRg=; b=SrulZOWaIyBv5yIc5mXmO3mFbboC90sxAkEqy69UQ6rSsYIjntnb5L1FSFvvIOZPBy WH0b24VW/e78Gr/mdQLXp2Cz+gCjOAEN55VLNUmhzauyfAE851KM9N4Ls1PXQMxttUn6 kBMLFDEvxIKE8K5cYzfcgIpj0Qohm9BLuIX+Q0AqWnZusR9hjcn4ly8GULAY0h196Sdf kBbYxNetwDYiIRYjxw2T1Q6Dw5XJbXxkctWy6C1r7b2JhJwOcXxhjKFVbpGTCTmd4Eeg ga1Ih3NI252JzZTYxtRaUUcUWuoi0PUoJQkUMOOBYV+/uh1gfuEBcp1rr1MIQTbadx3X dfug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=VHWMlfMrTM94H6bRgK8jtWQ5WLwGNoqEAx6AZJOMxRg=; b=UenR9Wzem66DdQ92ukJlHmGP9SkEl7r1UZq78C3ReKmjC+yfnV5GfJujtl/x13Qd5S IASQAnDt59gJJxPjjZJ/0ishKLipdWc2yxfBRLZyA1Xd9/4ZJ2IrpcB1ThOrTSNtk5fN VrqqMs0Kg47KK7gKOaPx1eEb9VTpgMJE8P3g4ecZhr1jLO42myEwbwzCCOpGWwKx2STb RwR04bU/DXssqhhV49dRq4nKKdHYYtdL1Xhe/ix6NXPwVofvDuwUeVbilXe3q6kKmbkO rFfN+il456BK7qv2B8ccxqrPTrc/IiKZSfWEKA0wpwQZQ7LB3Z4+l0zqtW7MuVaNuieJ srdw== X-Gm-Message-State: AHQUAub7rilK0f7VdjXsw/OIDjWIqgbgAay5P35cK6YHI87hLjXuuLrJ prK2C4YeP2X0/fWdMsjDP7AlNI2+O9Q= X-Google-Smtp-Source: AHgI3Ia3b6ZJlhKBY1BcA9LcZZe9n2aMztSYcGq1/yrdTjXG5zxg37y4BCsv61wBENeYZjCzBG1pyA== X-Received: by 2002:a17:902:bc88:: with SMTP id bb8mr32864928plb.12.1550603553928; Tue, 19 Feb 2019 11:12:33 -0800 (PST) Received: from localhost.localdomain (104-188-17-28.lightspeed.sndgca.sbcglobal.net. [104.188.17.28]) by smtp.gmail.com with ESMTPSA id h64sm24910009pfc.142.2019.02.19.11.12.32 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 19 Feb 2019 11:12:33 -0800 (PST) From: Bjorn Andersson To: Bjorn Andersson , Linus Walleij Cc: Andy Gross , David Brown , linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] pinctrl: qcom: spmi-gpio: Reorder debug print Date: Tue, 19 Feb 2019 11:12:53 -0800 Message-Id: <20190219191253.21712-1-bjorn.andersson@linaro.org> X-Mailer: git-send-email 2.18.0 Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org It's reasonable to expect that people turn to the "gpio" debugfs file to first and foremost learn about the direction and value of a gpio, and second to that about it's pinconf. So reorder the value so each line reads: gpioN: direction value ... This also makes it consistent with the TLMM pinctrl driver's output in the same dump. Signed-off-by: Bjorn Andersson --- drivers/pinctrl/qcom/pinctrl-spmi-gpio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c b/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c index cb512c7a5251..76e57ae2f6e8 100644 --- a/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c +++ b/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c @@ -675,11 +675,11 @@ static void pmic_gpio_config_dbg_show(struct pinctrl_dev *pctldev, else seq_printf(s, " %-4s", pad->output_enabled ? "out" : "in"); + seq_printf(s, " %-4s", pad->out_value ? "high" : "low"); seq_printf(s, " %-7s", pmic_gpio_functions[function]); seq_printf(s, " vin-%d", pad->power_source); seq_printf(s, " %-27s", biases[pad->pullup]); seq_printf(s, " %-10s", buffer_types[pad->buffer_type]); - seq_printf(s, " %-4s", pad->out_value ? "high" : "low"); seq_printf(s, " %-7s", strengths[pad->strength]); seq_printf(s, " atest-%d", pad->atest); seq_printf(s, " dtest-%d", pad->dtest_buffer);