From patchwork Mon Feb 18 19:28:54 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heiner Kallweit X-Patchwork-Id: 1044287 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="Es1B8ZVf"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 443DTg5d7fz9s3x for ; Tue, 19 Feb 2019 06:29:59 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726505AbfBRT35 (ORCPT ); Mon, 18 Feb 2019 14:29:57 -0500 Received: from mail-wr1-f67.google.com ([209.85.221.67]:44399 "EHLO mail-wr1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726363AbfBRT35 (ORCPT ); Mon, 18 Feb 2019 14:29:57 -0500 Received: by mail-wr1-f67.google.com with SMTP id w2so5020813wrt.11 for ; Mon, 18 Feb 2019 11:29:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:from:to:cc:references:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=WCRP33z4rflWo915rLjgkWpefjsg1vz0BQZlXoRF/vI=; b=Es1B8ZVfsaEKR4D4E/qB6GR/aCo+SDzZZGZzO32pm+774L8UG2nI8GyHprn9Pq4ciu JD1OFWxHX2Spci/7yePJmIfrcGwFb4U0olwEgOFTqW4VZrMc7VLfaWYezMVWL7hWxudr d2IgibDhpwz2kLo2h4LxpYFJMNqKtvgdh74KvBCJHM3R4UeCRi6a0Xr4H6eJezLOy2+3 ommf1dJ6LOWk6juK3O1G6zVrWjwMCD0PdRxR/LLt7+Bf3HoqCNjelWCrOdVDkrQOPSdg CvaYTw72NgeNQEgZGYQLbMLaAYN8+kTvnxzC70S7ZaMdekdqYlb//9neNkeG4Vby9y+P xhRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:from:to:cc:references:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=WCRP33z4rflWo915rLjgkWpefjsg1vz0BQZlXoRF/vI=; b=fEfmxgsP2sH21YUpdt0KwcdQk3Y0u29YgFcs5eOHxbcCNB+NHj0pKpsmbqBrJR7oPe 3gpbuvlb+dmiYj+EzJ8f9Vdt0lpgJvlGIzNKdAlxkhQzDFTwuDq33a2vASBytGVGxnvm 9aB4u/c6FzWUC+G7iRoFRyc7mmOIfulGcMy1EfhXqbwfNMdHcETbp1hW9HkW2KsrBD2m MsLGCqC7BOwF6Hegkxkv9S4L+qYcViTGMs6NDFmLASVtkAh3mWsiAg9U/laFG1XK/m5X neo/KW8JtCUh6PvHDHHypRQvzJDshJM0kjc0THg5t+OBZDU2Ld68Dyuf4F1o1d5Gd1hg xRhQ== X-Gm-Message-State: AHQUAuY5Te1Qglol0BO+5i24IAaN2VbOCya/g/5B8rYGZU5Wi+g2ol+C yXZ8oA8MgHR7IZItPaJgx22LaK1H X-Google-Smtp-Source: AHgI3IYj/Ne/FqwUvqo/PLDpqePxUq78cpAhyCx/odFKMl3meNof9r7vWwGTp1tdTBRdfCF/BZASeg== X-Received: by 2002:a5d:668b:: with SMTP id l11mr17452387wru.116.1550518195598; Mon, 18 Feb 2019 11:29:55 -0800 (PST) Received: from ?IPv6:2003:ea:8bf1:e200:71d7:c708:89b6:a86? (p200300EA8BF1E20071D7C70889B60A86.dip0.t-ipconnect.de. [2003:ea:8bf1:e200:71d7:c708:89b6:a86]) by smtp.googlemail.com with ESMTPSA id f4sm9453994wrx.68.2019.02.18.11.29.54 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 18 Feb 2019 11:29:55 -0800 (PST) Subject: [PATCH net-next 1/2] net: phy: remove orphaned register read in genphy_read_status From: Heiner Kallweit To: Andrew Lunn , Florian Fainelli , David Miller Cc: "netdev@vger.kernel.org" References: <1a948543-0dc6-d5df-d50a-49134a2a4118@gmail.com> Message-ID: Date: Mon, 18 Feb 2019 20:28:54 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.5.1 MIME-Version: 1.0 In-Reply-To: <1a948543-0dc6-d5df-d50a-49134a2a4118@gmail.com> Content-Language: en-US Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org After recent changes to genphy_read_status() this orphaned register read remained as leftover. So remove it. Signed-off-by: Heiner Kallweit --- drivers/net/phy/phy_device.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/net/phy/phy_device.c b/drivers/net/phy/phy_device.c index 7e71124bb..803197fdd 100644 --- a/drivers/net/phy/phy_device.c +++ b/drivers/net/phy/phy_device.c @@ -1785,10 +1785,6 @@ int genphy_read_status(struct phy_device *phydev) mii_lpa_mod_linkmode_lpa_t(phydev->lp_advertising, lpa); - adv = phy_read(phydev, MII_ADVERTISE); - if (adv < 0) - return adv; - phydev->speed = SPEED_10; phydev->duplex = DUPLEX_HALF; phydev->pause = 0; From patchwork Mon Feb 18 19:29:36 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heiner Kallweit X-Patchwork-Id: 1044288 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="ovKUi1Ly"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 443DTl1nCVz9s3x for ; Tue, 19 Feb 2019 06:30:03 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726523AbfBRTaB (ORCPT ); Mon, 18 Feb 2019 14:30:01 -0500 Received: from mail-wr1-f67.google.com ([209.85.221.67]:44401 "EHLO mail-wr1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726363AbfBRT37 (ORCPT ); Mon, 18 Feb 2019 14:29:59 -0500 Received: by mail-wr1-f67.google.com with SMTP id w2so5020875wrt.11 for ; Mon, 18 Feb 2019 11:29:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:from:to:cc:references:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=7QnLK1S7kwT6QFpA6pxxuQTQh9oq7PFQ4ICA5p74DIo=; b=ovKUi1LyyHUD51aea/ceHpLoeAMGbahmElxNiH/YXeYARN9N+uLd8CTw5GOsxbFQDB V7KL2Wd918D1X/DURD62hzVUX061sdSmkRV2T91yPY/tCrbczFCmdwpfuTdYvw5OuFsk iFvy+TzmmEkysGcjUDeFIZfhRTD24qcIAsgQhjxv/nQHLZVnkS1W3XfH22xcqFah5g96 MK9KmDLjDpfyn6TfUa+/BoZyfaROR/fGErziGc2YFXoqbiJCl5+nkCgYdP3Pyf/E7gWt izoUyV+uIe4zxDa6cCgGX/Q38BTE+PbTN9bTCz1No3/oCJobV5k7/zsAGz+GHkFQSRSG c8Lg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:from:to:cc:references:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=7QnLK1S7kwT6QFpA6pxxuQTQh9oq7PFQ4ICA5p74DIo=; b=ZUfkjQaSEWWz0gjZ7PY95MRxcZ8HEf62nJQCmtZTsx2/cSQvgvHh6xqT2qoEe9QlZl +md2eOFamHFGZeAcMtJB6wnd9hBKPfiK1LtqGYczSO/YBE3iZYJ4pPmr9t3NgJHqecB0 r6ZdtKMT+eW8jikJ7H6/deJ7YdiCr/V4CigbRqg8j61z26QnEynnb4Hn2bqWe8xA+thK eA84gbf8ZxC64+cOYliXxh1g7m36dsnVv+phyvD6k9nKNA0Nz/zVacdnOIsEFHZwFl3j QXEgk/bngBK5evs1widNxK8ZPmtABWjqUXqvHDDLVX3k2oMc74TJhw1gbQK3VKXwoHdD yhng== X-Gm-Message-State: AHQUAubiCdnCLJk9i8eQpXPk+PnLcBUbxJ8wuSNnnbMx1hc2lNWJFN3I 6PDGhCW6uRSnTELh543Q+0xQIcvW X-Google-Smtp-Source: AHgI3IZ6rFi7qnVqT2VqelkbsEONDoK0bJLpd7diX0ilenefim0WyJtV6Bt05kGt2SAVvMOEgmSVGg== X-Received: by 2002:a5d:6846:: with SMTP id o6mr17501402wrw.160.1550518197063; Mon, 18 Feb 2019 11:29:57 -0800 (PST) Received: from ?IPv6:2003:ea:8bf1:e200:71d7:c708:89b6:a86? (p200300EA8BF1E20071D7C70889B60A86.dip0.t-ipconnect.de. [2003:ea:8bf1:e200:71d7:c708:89b6:a86]) by smtp.googlemail.com with ESMTPSA id 62sm31519221wra.46.2019.02.18.11.29.56 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 18 Feb 2019 11:29:56 -0800 (PST) Subject: [PATCH net-next 2/2] net: phy: don't use 10BaseT/half as default in genphy_read_status From: Heiner Kallweit To: Andrew Lunn , Florian Fainelli , David Miller Cc: "netdev@vger.kernel.org" References: <1a948543-0dc6-d5df-d50a-49134a2a4118@gmail.com> Message-ID: Date: Mon, 18 Feb 2019 20:29:36 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.5.1 MIME-Version: 1.0 In-Reply-To: <1a948543-0dc6-d5df-d50a-49134a2a4118@gmail.com> Content-Language: en-US Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org If link partner and we can't agree on any mode, then it doesn't make sense to pretend we would have agreed on 10/half. Therefore set a proper default. Signed-off-by: Heiner Kallweit Reviewed-by: Florian Fainelli --- drivers/net/phy/phy_device.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/phy/phy_device.c b/drivers/net/phy/phy_device.c index 803197fdd..4bb3b6c28 100644 --- a/drivers/net/phy/phy_device.c +++ b/drivers/net/phy/phy_device.c @@ -1785,8 +1785,8 @@ int genphy_read_status(struct phy_device *phydev) mii_lpa_mod_linkmode_lpa_t(phydev->lp_advertising, lpa); - phydev->speed = SPEED_10; - phydev->duplex = DUPLEX_HALF; + phydev->speed = SPEED_UNKNOWN; + phydev->duplex = DUPLEX_UNKNOWN; phydev->pause = 0; phydev->asym_pause = 0;