From patchwork Fri Feb 15 18:16:16 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jann Horn X-Patchwork-Id: 1043121 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=google.com header.i=@google.com header.b="VUd0vBaW"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 441M0f42XCz9sML for ; Sat, 16 Feb 2019 05:16:50 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732247AbfBOSQr (ORCPT ); Fri, 15 Feb 2019 13:16:47 -0500 Received: from mail-qt1-f201.google.com ([209.85.160.201]:53732 "EHLO mail-qt1-f201.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727067AbfBOSQq (ORCPT ); Fri, 15 Feb 2019 13:16:46 -0500 Received: by mail-qt1-f201.google.com with SMTP id k37so9746315qtb.20 for ; Fri, 15 Feb 2019 10:16:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:message-id:mime-version:subject:from:to:cc; bh=itwLbsehldOHq4BvzPhFpRMdV9CEOHnEXNws1hWrhOE=; b=VUd0vBaWN4gjiuRFzqX5KcYMN3W5psj+AA5mje6U8Ozc0VXNvvoqX0Z6FeEmUB3D/x a6vMHQkmm54nK4QmNCzpb/vuYWHI3NX7kPgaJD4fB2n35NHIrXCXyBed3e49vXoZn/Wp +OFooR1I+yPqeAtFHEFly8bwNxXApGh5qjBYTdw5pETFON4Naik3DQ2xQxFmFC4AEARB teNiP8k1ONjmSUfy4/MQOlXUVkA3zDJo0dJ6djjsC5yn25u3x94OYZM7RVCopRPvsJor Bz5uDcNEmpDZapi0adxRxoypBowMkHlirmY2VkSwn64ZrCiBgSb/syp6FiTymtqt8T6a w1XA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:message-id:mime-version:subject:from:to:cc; bh=itwLbsehldOHq4BvzPhFpRMdV9CEOHnEXNws1hWrhOE=; b=kMyOdmq4MakqcXmoVg4HftOjVA/jxnvYdi8L2Y1n91MY0vg1xyJ6/e2trGtb5VqhNh ZLQ5mZG9EKYKJnDdRUy04vqHFnqECFgL3SofGoXr3SLdcfz5EiDKsuLPuq5IXzB8lKQw SGZmSIFrBc8g9GE6u0GezXgm9vdX9NC/p8c8NSGAUt4n4TMOxa0UX83n4/vDEZGgEsQV Rg4tngdkAtcPP0NKSTP40imAcV4gUrsg90URKPblmX2/1EoJoxWgn00yErtzWySVloSW 5IBX/MXEdKBK+T7I0hwThJ+r592P89qgmA+OEBsfQBa8+Coil87fO7IPuQZC9MBg93L2 4h/Q== X-Gm-Message-State: AHQUAuY0QnHe4LD5z4PK/SNmVLw5tq3XSQePWpdK6Ejbvx/HTRTlijUx WBNQPGkWw67Y+j2cxabqgYuHM7xspg== X-Google-Smtp-Source: AHgI3IakPg+6M72bjwxImV0q5P/GiVeypaAn2r8Q1w7Lr7oD0DCMX6REkHdRxNzl01HJIOcBklgaxOO9Eg== X-Received: by 2002:a0c:ae1d:: with SMTP id y29mr6067413qvc.12.1550254605689; Fri, 15 Feb 2019 10:16:45 -0800 (PST) Date: Fri, 15 Feb 2019 19:16:16 +0100 Message-Id: <20190215181616.151855-1-jannh@google.com> Mime-Version: 1.0 X-Mailer: git-send-email 2.21.0.rc0.258.g878e2cd30e-goog Subject: [PATCH] visornic: use skb_put_zero() instead of open-coded version From: Jann Horn To: David Kershner , sparmaintainer@unisys.com, jannh@google.com Cc: Greg Kroah-Hartman , linux-kernel@vger.kernel.org, netdev@vger.kernel.org Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Replace an open-coded version of skb_put_zero() with a call to the helper. This is a cleanup and is also useful for potentially adding KASAN integration to SKBs in the future. Signed-off-by: Jann Horn --- drivers/staging/unisys/visornic/visornic_main.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/staging/unisys/visornic/visornic_main.c b/drivers/staging/unisys/visornic/visornic_main.c index 5eeb4b93b45b..1c1a470d2e50 100644 --- a/drivers/staging/unisys/visornic/visornic_main.c +++ b/drivers/staging/unisys/visornic/visornic_main.c @@ -896,9 +896,7 @@ static netdev_tx_t visornic_xmit(struct sk_buff *skb, struct net_device *netdev) ((skb_end_pointer(skb) - skb->data) >= ETH_MIN_PACKET_SIZE)) { /* pad the packet out to minimum size */ padlen = ETH_MIN_PACKET_SIZE - len; - memset(&skb->data[len], 0, padlen); - skb->tail += padlen; - skb->len += padlen; + skb_put_zero(skb, padlen); len += padlen; firstfraglen += padlen; }