From patchwork Fri Feb 15 08:22:53 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rundong Ge X-Patchwork-Id: 1042673 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="XT/mPfsD"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 4415qX3KDzz9s7T for ; Fri, 15 Feb 2019 19:23:04 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2404152AbfBOIW7 (ORCPT ); Fri, 15 Feb 2019 03:22:59 -0500 Received: from mail-it1-f196.google.com ([209.85.166.196]:36879 "EHLO mail-it1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2403860AbfBOIW7 (ORCPT ); Fri, 15 Feb 2019 03:22:59 -0500 Received: by mail-it1-f196.google.com with SMTP id l131so21335414ita.2; Fri, 15 Feb 2019 00:22:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=rNN8ycMkfIDlILiOoDG6JxU5FPIMQ8gR3UP9GLcGRlM=; b=XT/mPfsDFeI0dkV2jm1ERLqN4NVtL0OMs1yTjFmwgTU5525tGVbpCDTcB9m2mdijfE oUNtpDIgHEANqNJ6zlQmRYz3Kt6kfyORYgfDAGYNyQcT5nqbyg9lguO3aFTxuQc/OYF+ 3jxeG6CC6xuo2iaCPuc7mafR3YmZ0MRtsT9MyGzr4N1eiFod3SD1DDtggBZbXbaV+2ux EHhWYqhGpo9L3n6FDs3TbvtoBYPgYnCggx2yIUoX+0AqZSkWx/fCsa0o8Er8OP/7Gvo1 xGA5fj4pOXoARlkMNKYAwVCSmNiznkDUCvQ4nlPyK9vs+aVUhhRqyG8R2UI25xZt8UW6 E8EA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=rNN8ycMkfIDlILiOoDG6JxU5FPIMQ8gR3UP9GLcGRlM=; b=R0eMTxL33WU/+IsOAr8N1r9SCb5NUTtEUVIqPN/YTdl8IiLOtmH7gZx75/EdgzF7Ty X79d/nHl2f5UyHXI6l22UNjqS/JVi5Z4L80yZ2rM5ZgaXAcBIHHDn6NzW+W6iLFBHmh2 BrKq82AAxpjt+cFTZiN3zl39IuLEMgtdNZtkapZ4oSaKJo56GNhRhP+GmZec83H/tPQQ +Fi88E4Wwt9ZSmGtxHHR81aygqd7Eu+5FaH4uc7EuQzaKcdBFuuODpT4dWsI+YQiaiFZ nvsAY1Fd/IpeLCq7WYWqqNm97iqTgP/N+SfnbYw9TL1QXY4fM5/KaMeYvWEoMyP2OHhD 7sGg== X-Gm-Message-State: AHQUAuZIwx9C1edWVbDjvp0P7gUEbGizOsR9ixjrsfT2T30LtdRDyIb/ /i7cSXAUTWzS1/wZ/uxTag== X-Google-Smtp-Source: AHgI3IZ2Uc8/S5ovLLKhgtHkgPheZ+vkXdOxttS65RZl/eM5ofGIWboq9XuR3jrX9hMYDeC83KaZAw== X-Received: by 2002:a05:660c:814:: with SMTP id j20mr3979684itk.20.1550218978051; Fri, 15 Feb 2019 00:22:58 -0800 (PST) Received: from ip-172-31-35-247.us-east-2.compute.internal (ec2-52-15-165-154.us-east-2.compute.amazonaws.com. [52.15.165.154]) by smtp.gmail.com with ESMTPSA id m25sm370619iti.16.2019.02.15.00.22.57 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 15 Feb 2019 00:22:57 -0800 (PST) From: Rundong Ge To: andrew@lunn.ch Cc: vivien.didelot@gmail.com, f.fainelli@gmail.com, davem@davemloft.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, rdong.ge@gmail.com Subject: [PATCH] net: dsa: Implement flow_dissect callback for tag_dsa. Date: Fri, 15 Feb 2019 08:22:53 +0000 Message-Id: <20190215082253.2682-1-rdong.ge@gmail.com> X-Mailer: git-send-email 2.17.1 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org RPS not work for DSA devices since the 'skb_get_hash' will always get the invalid hash for dsa tagged packets. "[PATCH] tag_mtk: add flow_dissect callback to the ops struct" introduced the flow_dissect callback to get the right hash for MTK tagged packet. And tag_dsa also needs to implement the callback. Signed-off-by: Rundong Ge --- net/dsa/tag_dsa.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/net/dsa/tag_dsa.c b/net/dsa/tag_dsa.c index 8b2f92e..67ff3fa 100644 --- a/net/dsa/tag_dsa.c +++ b/net/dsa/tag_dsa.c @@ -146,8 +146,17 @@ static struct sk_buff *dsa_rcv(struct sk_buff *skb, struct net_device *dev, return skb; } +static int dsa_tag_flow_dissect(const struct sk_buff *skb, __be16 *proto, + int *offset) +{ + *offset = 4; + *proto = ((__be16 *)skb->data)[1]; + return 0; +} + const struct dsa_device_ops dsa_netdev_ops = { .xmit = dsa_xmit, .rcv = dsa_rcv, + .flow_dissect = dsa_tag_flow_dissect, .overhead = DSA_HLEN, };