From patchwork Tue Feb 12 16:57:06 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Nazzareno Trimarchi X-Patchwork-Id: 1040712 X-Patchwork-Delegate: jagannadh.teki@gmail.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.denx.de (client-ip=81.169.180.215; helo=lists.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=amarulasolutions.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=amarulasolutions.com header.i=@amarulasolutions.com header.b="XCJTaGQU"; dkim-atps=neutral Received: from lists.denx.de (dione.denx.de [81.169.180.215]) by ozlabs.org (Postfix) with ESMTP id 43zTNF5ZDVz9s3x for ; Wed, 13 Feb 2019 03:57:17 +1100 (AEDT) Received: by lists.denx.de (Postfix, from userid 105) id 822FFC22095; Tue, 12 Feb 2019 16:57:14 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=RCVD_IN_DNSWL_BLOCKED, RCVD_IN_MSPIKE_H2, T_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.0 Received: from lists.denx.de (localhost [IPv6:::1]) by lists.denx.de (Postfix) with ESMTP id E52AAC21E76; Tue, 12 Feb 2019 16:57:12 +0000 (UTC) Received: by lists.denx.de (Postfix, from userid 105) id 5D63AC21E76; Tue, 12 Feb 2019 16:57:11 +0000 (UTC) Received: from mail-wr1-f67.google.com (mail-wr1-f67.google.com [209.85.221.67]) by lists.denx.de (Postfix) with ESMTPS id EF3DDC21E31 for ; Tue, 12 Feb 2019 16:57:10 +0000 (UTC) Received: by mail-wr1-f67.google.com with SMTP id t27so3478980wra.6 for ; Tue, 12 Feb 2019 08:57:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=from:to:cc:subject:date:message-id; bh=ddTBfasdS09KC6uzRTbnPw2vqE0/axCAU9Wdflj5go0=; b=XCJTaGQU+K2DRwzoCmy7u3FP3SV2bmyH6DG/Y5yE0VSuXVRL6DTCK7FqFSXR3xAbjv JUkiO/XB46uGAvT6hHFEVA8KBAv0jrVQ62vHB7vi5GuNwSp2l9lKdzjyAmDFcTfoD263 jdmAcMazqftqvXyztSufXnIaP2mmlWBDIB5Ac= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=ddTBfasdS09KC6uzRTbnPw2vqE0/axCAU9Wdflj5go0=; b=YjunxBw1iX6C23fOT2f/4nXej9g57QnRXvUQtvpiMTOM7YzZu1pWYJgnQ79qmES+e6 Zkw5N4IRudUS/y/c/zUBm4Rt5We2HDaQwzorITbiDgJ3s91soH5eqAvfSxKvmDQMp42R LaSrmrwPYski79BM87VhDc0/ieXniw5JgQO4tKV6sGPHyFwy1CwTQdoMWcD9FrMzZTFt EMTRikLjacElJUtM07y025XS8pjXUxlnEVRWRuHXMFIEZNchB4f4DlovsWFDzo70VpwX Jq+lF3ofNWqWDBxQCLLhRZJj5kAfbKmZlxVTEWpCl7sU+oiEJ4SN6zm/1La2nHukfdgi CA4w== X-Gm-Message-State: AHQUAuaugk5dqJ/ooLlG3Trr/mAcj+oyjbCDjeWCd4JTi7RkbMpQxw1Y t6j7P8IrArU/02J6ZCHaAmrUrg== X-Google-Smtp-Source: AHgI3IZV47C/5VGddmJDAYddmVm8HP5uM7AeTYSUh0TnVfHgU4BeTdWZZytERLZKQnkZ2kb2UT5EdQ== X-Received: by 2002:a5d:4608:: with SMTP id t8mr3812004wrq.186.1549990630288; Tue, 12 Feb 2019 08:57:10 -0800 (PST) Received: from localhost.localdomain (ip-172-226.sn3.clouditalia.com. [213.136.172.226]) by smtp.gmail.com with ESMTPSA id 2sm35947300wrj.27.2019.02.12.08.57.09 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 12 Feb 2019 08:57:09 -0800 (PST) From: Michael Trimarchi To: Maxime Ripard , Jagan Teki Date: Tue, 12 Feb 2019 17:57:06 +0100 Message-Id: <20190212165708.23040-1-michael@amarulasolutions.com> X-Mailer: git-send-email 2.17.1 Cc: andre.przywara@arm.com, u-boot@lists.denx.de Subject: [U-Boot] [RFC PATCH 1/3] sunxi: Use clrsetbits_le32 instead of multiple instruction X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.18 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" Signed-off-by: Michael Trimarchi --- arch/arm/mach-sunxi/dram_sun8i_a33.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/arch/arm/mach-sunxi/dram_sun8i_a33.c b/arch/arm/mach-sunxi/dram_sun8i_a33.c index 1da2727f98..83212aaddf 100644 --- a/arch/arm/mach-sunxi/dram_sun8i_a33.c +++ b/arch/arm/mach-sunxi/dram_sun8i_a33.c @@ -148,12 +148,8 @@ static void auto_set_timing_para(struct dram_para *para) reg_val = (tcksrx << 24) | (tcksre << 16) | (tckesr << 8) | (tcke << 0); writel(reg_val, &mctl_ctl->dramtmg5); /* Set two rank timing and exit self-refresh timing */ - reg_val = readl(&mctl_ctl->dramtmg8); - reg_val &= ~(0xff << 8); - reg_val &= ~(0xff << 0); - reg_val |= (0x33 << 8); - reg_val |= (0x8 << 0); - writel(reg_val, &mctl_ctl->dramtmg8); + clrsetbits_le32(&mctl_ctl->dramtmg8, (0xff << 8) | (0xff << 0), + 0x33 << 8 | (0x8 << 0)); /* Set phy interface time */ reg_val = (0x2 << 24) | (t_rdata_en << 16) | (0x1 << 8) | (wr_latency << 0); From patchwork Tue Feb 12 16:57:07 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Nazzareno Trimarchi X-Patchwork-Id: 1040713 X-Patchwork-Delegate: jagannadh.teki@gmail.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.denx.de (client-ip=81.169.180.215; helo=lists.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=amarulasolutions.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=amarulasolutions.com header.i=@amarulasolutions.com header.b="HCSi1oLD"; dkim-atps=neutral Received: from lists.denx.de (dione.denx.de [81.169.180.215]) by ozlabs.org (Postfix) with ESMTP id 43zTNl2xKwz9s3x for ; Wed, 13 Feb 2019 03:57:43 +1100 (AEDT) Received: by lists.denx.de (Postfix, from userid 105) id 115C6C22099; Tue, 12 Feb 2019 16:57:29 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=RCVD_IN_DNSWL_BLOCKED, T_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.0 Received: from lists.denx.de (localhost [IPv6:::1]) by lists.denx.de (Postfix) with ESMTP id 58E54C21E31; Tue, 12 Feb 2019 16:57:13 +0000 (UTC) Received: by lists.denx.de (Postfix, from userid 105) id A84F9C21E76; Tue, 12 Feb 2019 16:57:12 +0000 (UTC) Received: from mail-wm1-f68.google.com (mail-wm1-f68.google.com [209.85.128.68]) by lists.denx.de (Postfix) with ESMTPS id 4AA68C21E31 for ; Tue, 12 Feb 2019 16:57:12 +0000 (UTC) Received: by mail-wm1-f68.google.com with SMTP id r17so3722184wmh.5 for ; Tue, 12 Feb 2019 08:57:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=DUfH1lMJghgGQeapOk6pR+UnHJBe8TNzrbmL2naRx/s=; b=HCSi1oLDrEpbWVTbHoy5vchmJpT6G6ZbyrsvEWB6FV026sgb3lPOnquYMjsukhlvrN v2xEtdRHYZaJWbEMZaTr3JL5Gk2Dzt2UfjbLhs/hvm3czLEi4uJY8t/L72GtF5mb/C2o i8r8+mi6z1DFg1/HGdSS4o7Ij/cfMXpy+lHio= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=DUfH1lMJghgGQeapOk6pR+UnHJBe8TNzrbmL2naRx/s=; b=q3tNy0BrfFOgFAyNfCQHsh/rGhQphlxAumdLZ3dQZgISSA4G44fs2bTQcO1T/v5H/h PbcIRpdrcVnx2CCGkXc0Y1Y1YX4pD4AVJS7GVgRWW8gc4w8CzNAG1VFahzNP145q4vXt x63HpPbYQSOeCcLgCX9CbDlbU9XWbx4+SRd9Z6axmChF+82qZNUJQWtM8X7IPh0ihmyj 2cC6LxpOhYz2nyMNOBWbyVWbuHVSHDGyScEBpxc4hdJaQrkrhGWSgrJLcR6e/NyptAXN fYZG2dfwEzELYAIe2mHWqX31ibx5/U3HZs5/zYXHvf2dbmYCDyQZegQIv+17MNCINmSr a86w== X-Gm-Message-State: AHQUAubC9+RFOIVbj1cOcIrxPEtt5f7UWXueEY+ex9HapTIHGEJ7PDnD IDbmQBoVeEXD/LzhV1GE/rUmnA== X-Google-Smtp-Source: AHgI3IY2qGKHSvHtY+xd3wxLcxUlW3tSe33ZPiPDeVuBgm0UWpQB0t9SoQFasd98XUcKnVUQfUACVA== X-Received: by 2002:a1c:9acd:: with SMTP id c196mr3818193wme.145.1549990631701; Tue, 12 Feb 2019 08:57:11 -0800 (PST) Received: from localhost.localdomain (ip-172-226.sn3.clouditalia.com. [213.136.172.226]) by smtp.gmail.com with ESMTPSA id 2sm35947300wrj.27.2019.02.12.08.57.10 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 12 Feb 2019 08:57:10 -0800 (PST) From: Michael Trimarchi To: Maxime Ripard , Jagan Teki Date: Tue, 12 Feb 2019 17:57:07 +0100 Message-Id: <20190212165708.23040-2-michael@amarulasolutions.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190212165708.23040-1-michael@amarulasolutions.com> References: <20190212165708.23040-1-michael@amarulasolutions.com> Cc: andre.przywara@arm.com, u-boot@lists.denx.de Subject: [U-Boot] [RFC PATCH 2/3] sunxi: Don't change the rank in dram size detection in A33 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.18 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" Change the size create a glitch in the clke signal on second bank. The glitch can generate problem in memory initialiazation Signed-off-by: Michael Trimarchi --- arch/arm/mach-sunxi/dram_sun8i_a33.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/arch/arm/mach-sunxi/dram_sun8i_a33.c b/arch/arm/mach-sunxi/dram_sun8i_a33.c index 83212aaddf..d73a93a132 100644 --- a/arch/arm/mach-sunxi/dram_sun8i_a33.c +++ b/arch/arm/mach-sunxi/dram_sun8i_a33.c @@ -45,14 +45,12 @@ static void mctl_set_cr(struct dram_para *para) static void auto_detect_dram_size(struct dram_para *para) { - u8 orig_rank = para->rank; int rows, columns; /* Row detect */ para->page_size = 512; para->seq = 1; para->rows = 16; - para->rank = 1; mctl_set_cr(para); for (rows = 11 ; rows < 16 ; rows++) { if (mctl_mem_matches(1 << (rows + 9))) /* row-column */ @@ -69,7 +67,6 @@ static void auto_detect_dram_size(struct dram_para *para) } para->seq = 0; - para->rank = orig_rank; para->rows = rows; para->page_size = 1 << columns; mctl_set_cr(para); From patchwork Tue Feb 12 16:57:08 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Nazzareno Trimarchi X-Patchwork-Id: 1040715 X-Patchwork-Delegate: jagannadh.teki@gmail.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.denx.de (client-ip=81.169.180.215; helo=lists.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=amarulasolutions.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=amarulasolutions.com header.i=@amarulasolutions.com header.b="Z6RFbo1P"; dkim-atps=neutral Received: from lists.denx.de (dione.denx.de [81.169.180.215]) by ozlabs.org (Postfix) with ESMTP id 43zTPd1jG2z9sMp for ; Wed, 13 Feb 2019 03:58:29 +1100 (AEDT) Received: by lists.denx.de (Postfix, from userid 105) id F138DC220C8; Tue, 12 Feb 2019 16:57:42 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=RCVD_IN_DNSWL_BLOCKED, RCVD_IN_MSPIKE_H2, T_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.0 Received: from lists.denx.de (localhost [IPv6:::1]) by lists.denx.de (Postfix) with ESMTP id C9137C2208E; Tue, 12 Feb 2019 16:57:20 +0000 (UTC) Received: by lists.denx.de (Postfix, from userid 105) id 8EFFCC2209E; Tue, 12 Feb 2019 16:57:17 +0000 (UTC) Received: from mail-wr1-f68.google.com (mail-wr1-f68.google.com [209.85.221.68]) by lists.denx.de (Postfix) with ESMTPS id AEEA0C22089 for ; Tue, 12 Feb 2019 16:57:13 +0000 (UTC) Received: by mail-wr1-f68.google.com with SMTP id i12so3530225wrw.0 for ; Tue, 12 Feb 2019 08:57:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=mHIydUf4rMwJYZc3vM8VB3URIuAgQlLUSgQMTs9MrtQ=; b=Z6RFbo1PME/4nLJfwsNkdSRlb+51TEGyw4i6m20VqFRpeg+KFPYUtKr1RANX3P80TU U+hXb3GmHs3vF1jCOS+F6CFwike4aYYEhN8QTUwgvGyBFqopqIqwHb2e0RtNZ/DTUXVi IDLpp2nUHCIV+O+V6masw1f/ycd9Mjxl8W7VA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=mHIydUf4rMwJYZc3vM8VB3URIuAgQlLUSgQMTs9MrtQ=; b=nQaE1xkvmdser12VwUC6VaDuMaQCBXqfk0zR+BX0bn//sMHU938vdFwv0ijJVH6YrT TaIyjFcjo5Aq/jWeSkmtLTkXdN63cOGhkEEcv/aVKvufcHMci1x5joHM1iMDx2S0WV2q /KBgJ2ioBT4fzPhNRyW6xDdtfxRBpVkh231rVc/0+V0naZ9IHYio39qUqNLlEUsFfHfr PzsOL8VUnBWlHt/mIvCGCJQZU/xw7U2vMRp7jAy26CWin+7ZZUuIQiozJJaT+FF35kqs 10x56UXRp86hEguer9L4Ug1z5sdQ0MI4X2wfZHkqVY9w6LGiqx5oKtR7s3TmMdrLDagF 6LSQ== X-Gm-Message-State: AHQUAuaoIyqomlPMqI7AWJRVtXmyXfbYJkzrSV7Gek4ojv+HKAf4uTJq NZ6udsTEIuDYNIn3J9yMgW5Kbg== X-Google-Smtp-Source: AHgI3Ibjt6NreeRhmRczHhNczfU4yyFCm/GkqtvMyjelHi6XPxN91t0BHYDsE4hrBUiWJxbHfVGPxg== X-Received: by 2002:a5d:6542:: with SMTP id z2mr3581133wrv.237.1549990633130; Tue, 12 Feb 2019 08:57:13 -0800 (PST) Received: from localhost.localdomain (ip-172-226.sn3.clouditalia.com. [213.136.172.226]) by smtp.gmail.com with ESMTPSA id 2sm35947300wrj.27.2019.02.12.08.57.11 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 12 Feb 2019 08:57:12 -0800 (PST) From: Michael Trimarchi To: Maxime Ripard , Jagan Teki Date: Tue, 12 Feb 2019 17:57:08 +0100 Message-Id: <20190212165708.23040-3-michael@amarulasolutions.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190212165708.23040-1-michael@amarulasolutions.com> References: <20190212165708.23040-1-michael@amarulasolutions.com> Cc: andre.przywara@arm.com, u-boot@lists.denx.de Subject: [U-Boot] [RFC PATCH 3/3] sunxi: Fix A33 memory initialization X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.18 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" Set two rank timing and exit self-refresh timing seems not done properly. We know use the same write that we are using on H5 silicon. Signed-off-by: Michael Trimarchi --- arch/arm/mach-sunxi/dram_sun8i_a33.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/mach-sunxi/dram_sun8i_a33.c b/arch/arm/mach-sunxi/dram_sun8i_a33.c index d73a93a132..355fe30aba 100644 --- a/arch/arm/mach-sunxi/dram_sun8i_a33.c +++ b/arch/arm/mach-sunxi/dram_sun8i_a33.c @@ -146,7 +146,7 @@ static void auto_set_timing_para(struct dram_para *para) writel(reg_val, &mctl_ctl->dramtmg5); /* Set two rank timing and exit self-refresh timing */ clrsetbits_le32(&mctl_ctl->dramtmg8, (0xff << 8) | (0xff << 0), - 0x33 << 8 | (0x8 << 0)); + 0x33 << 8 | (0x10 << 0)); /* Set phy interface time */ reg_val = (0x2 << 24) | (t_rdata_en << 16) | (0x1 << 8) | (wr_latency << 0);