From patchwork Tue Feb 12 16:29:51 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ido Schimmel X-Patchwork-Id: 1040692 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=mellanox.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=Mellanox.com header.i=@Mellanox.com header.b="dLb33oRl"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 43zSmm1ZRjz9s4Z for ; Wed, 13 Feb 2019 03:30:00 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731133AbfBLQ37 (ORCPT ); Tue, 12 Feb 2019 11:29:59 -0500 Received: from mail-eopbgr10041.outbound.protection.outlook.com ([40.107.1.41]:30784 "EHLO EUR02-HE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1731027AbfBLQ36 (ORCPT ); Tue, 12 Feb 2019 11:29:58 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=sgWkYfn0K44r96PTVYP931S7T2/PkMjmskIXgWLBwYI=; b=dLb33oRlO6TDJ7sqrvDg3TA3t/jmUrXknuWMrwW5lUMusWhgq8Q+B23atXzkmbHoJS10rfDBOFKSnPXt2qje55xvXN5lfYwOBpU1y8m/J9QNqCp16/c3+ai/UhLN1RWw4czkQK3z7ExLMdPHYuwmc/EgWt1oUKWonQQS1q00rS0= Received: from AM6PR05MB5240.eurprd05.prod.outlook.com (20.177.196.214) by AM6PR05MB6597.eurprd05.prod.outlook.com (20.179.2.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1601.19; Tue, 12 Feb 2019 16:29:51 +0000 Received: from AM6PR05MB5240.eurprd05.prod.outlook.com ([fe80::3542:889c:3a85:3866]) by AM6PR05MB5240.eurprd05.prod.outlook.com ([fe80::3542:889c:3a85:3866%5]) with mapi id 15.20.1601.023; Tue, 12 Feb 2019 16:29:51 +0000 From: Ido Schimmel To: "netdev@vger.kernel.org" CC: "davem@davemloft.net" , Jiri Pirko , Nir Dotan , mlxsw , Ido Schimmel Subject: [PATCH net-next 1/4] mlxsw: spectrum: Set LAG port collector only when active Thread-Topic: [PATCH net-next 1/4] mlxsw: spectrum: Set LAG port collector only when active Thread-Index: AQHUwvAtVxUBej/HRkmsLqaLfiG5rQ== Date: Tue, 12 Feb 2019 16:29:51 +0000 Message-ID: <20190212162924.29777-2-idosch@mellanox.com> References: <20190212162924.29777-1-idosch@mellanox.com> In-Reply-To: <20190212162924.29777-1-idosch@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: LO2P265CA0277.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a1::25) To AM6PR05MB5240.eurprd05.prod.outlook.com (2603:10a6:20b:64::22) authentication-results: spf=none (sender IP is ) smtp.mailfrom=idosch@mellanox.com; x-ms-exchange-messagesentrepresentingtype: 1 x-mailer: git-send-email 2.20.1 x-originating-ip: [193.47.165.251] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; AM6PR05MB6597; 6:iH8cMpliFCA9rRYgD8iUu3g4kHK96CYemwOOOh3MurrOkTy1I7gnXZzcF+i5OsqzNL1RE9XONOqvbc03UbtqIgpzSso4HeyP3RAJaUbdM6DdrPMSwcsKKK/p8CoDH5mCconooV1MbmmAdBPBrryis5wpWjRFHKC0KPgajpFJ4XnKimoewnD0iw9OfDizyL2XBQgWCTbKkgrVO53ZDMfRfQrpouOGdmjUNdXgGj8BcvPXDgfoEQxjCmyZCM3YBRR/TbZLg5qWYzi9iJN4xNZ/SqqDOweV83QPLq2rHjdfpBzlp4u9WWpk9W9URhIxWFJYRYI3IY8oG5x5Ru9FgOn2gmXh5zBIigKlB+C0NQg0htTdm+7UzJ+xcOSmseWbLuSfYLswUDcAtomR+tqjzWyUqIK8R8xfTRzjGWq8v4JuyAwrY2YPRkpQ4lc0D9UcX7ALRlmJr3ZtLJ4+/EjSBTbp5w==; 5:uaAxeRv4//hyZzVuJBhcjxPy5/HzuWTDPGQOk8suw2w8kG59c8NVkeJTUb5dX7ptJb0Xwl7Fz9ityKHfg86SM2dmDPfdpPtGKnXgumNboHIXEX7GlDDewZKyuSHUFmVPAAkrwE9kxlhLsg0elq+xspZDKsJSPx4SMlc2pCEvCzMpREVhE+q04X7v93M7psEvZF/KFDWgGyx9rfnxMRJBiA==; 7:OvL6Vr4MzbPcb4bA4UFzCxoOTIgJOhiZVwZntcfuBAspErHnn4s2Zqpuu94G34hi2a0RMrXAq0xP4yHc8yghAf2YOEUL1hst51P/POiiXqiyR73o3wwOAjDTFJcy5af3iuiBKEi1XhbgqhNy0+BCyQ== x-ms-office365-filtering-correlation-id: 6af9688b-fd49-46aa-8ede-08d691074fae x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600110)(711020)(4605077)(4618075)(2017052603328)(7153060)(7193020); SRVR:AM6PR05MB6597; x-ms-traffictypediagnostic: AM6PR05MB6597: x-microsoft-antispam-prvs: x-forefront-prvs: 0946DC87A1 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(346002)(376002)(136003)(39860400002)(366004)(396003)(189003)(199004)(478600001)(2351001)(36756003)(14454004)(6506007)(386003)(76176011)(99286004)(71190400001)(71200400001)(256004)(7736002)(97736004)(2906002)(305945005)(316002)(8676002)(54906003)(81156014)(8936002)(1730700003)(81166006)(6436002)(107886003)(50226002)(6116002)(53936002)(3846002)(25786009)(5640700003)(6486002)(6916009)(446003)(86362001)(6512007)(2616005)(4326008)(476003)(486006)(105586002)(106356001)(2501003)(68736007)(52116002)(186003)(66066001)(26005)(102836004)(11346002)(1076003); DIR:OUT; SFP:1101; SCL:1; SRVR:AM6PR05MB6597; H:AM6PR05MB5240.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: hnd7DaLGWNG7Lvzn5QD90PSfZOqEQk8EJRQN+VxYJHVrDK5qrtXSvVZrEgKc+gAPJMuvH8telcXslsF+t0bm/wHvVKnCGaP6RTMsevq2vAr5JmD6R0OU/ZqcflMy+UQfVCSIJKcTutuwA0S2hKwTSYExMZOXjBEfR9CATA/LoZf1YNsxH/mxLGNPujTFzYjjEs0tshY3xcMTuwq9JuVwWeV/Ky+HoXrhBhyMZCe014+cR+EFzKMD7i0k2pWgGFhSdNK9Kqe/SNfpI6sGFqB2GMzj8daRMsiNXsvOrSK85UPAV3MXP99scFIZpRPaRIPwKNOVQ1t2urdvr+SDfBDv3IWIsZMxU5bsNOv8pcqTMBuWTSULdF3ua1+8XVB/B3N5Dugn6H2a8/suee2HHZRfF5m8boASkPJ7Mriw4PY37o0= MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6af9688b-fd49-46aa-8ede-08d691074fae X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Feb 2019 16:29:50.1348 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR05MB6597 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Nir Dotan The LAG port collecting (receive) function was mistakenly set when the port was registered as a LAG member, while it should be set only when the port collection state is set to true. Set LAG port to collecting when it is set to distributing, as described in the IEEE link aggregation standard coupled control mux machine state diagram. Signed-off-by: Nir Dotan Acked-by: Jiri Pirko Signed-off-by: Ido Schimmel --- .../net/ethernet/mellanox/mlxsw/spectrum.c | 62 ++++++++++++++----- 1 file changed, 45 insertions(+), 17 deletions(-) diff --git a/drivers/net/ethernet/mellanox/mlxsw/spectrum.c b/drivers/net/ethernet/mellanox/mlxsw/spectrum.c index 7c9745cecbbd..9686d3822b92 100644 --- a/drivers/net/ethernet/mellanox/mlxsw/spectrum.c +++ b/drivers/net/ethernet/mellanox/mlxsw/spectrum.c @@ -4771,9 +4771,6 @@ static int mlxsw_sp_port_lag_join(struct mlxsw_sp_port *mlxsw_sp_port, err = mlxsw_sp_lag_col_port_add(mlxsw_sp_port, lag_id, port_index); if (err) goto err_col_port_add; - err = mlxsw_sp_lag_col_port_enable(mlxsw_sp_port, lag_id); - if (err) - goto err_col_port_enable; mlxsw_core_lag_mapping_set(mlxsw_sp->core, lag_id, port_index, mlxsw_sp_port->local_port); @@ -4787,8 +4784,6 @@ static int mlxsw_sp_port_lag_join(struct mlxsw_sp_port *mlxsw_sp_port, return 0; -err_col_port_enable: - mlxsw_sp_lag_col_port_remove(mlxsw_sp_port, lag_id); err_col_port_add: if (!lag->ref_count) mlxsw_sp_lag_destroy(mlxsw_sp, lag_id); @@ -4807,7 +4802,6 @@ static void mlxsw_sp_port_lag_leave(struct mlxsw_sp_port *mlxsw_sp_port, lag = mlxsw_sp_lag_get(mlxsw_sp, lag_id); WARN_ON(lag->ref_count == 0); - mlxsw_sp_lag_col_port_disable(mlxsw_sp_port, lag_id); mlxsw_sp_lag_col_port_remove(mlxsw_sp_port, lag_id); /* Any VLANs configured on the port are no longer valid */ @@ -4852,21 +4846,56 @@ static int mlxsw_sp_lag_dist_port_remove(struct mlxsw_sp_port *mlxsw_sp_port, return mlxsw_reg_write(mlxsw_sp->core, MLXSW_REG(sldr), sldr_pl); } -static int mlxsw_sp_port_lag_tx_en_set(struct mlxsw_sp_port *mlxsw_sp_port, - bool lag_tx_enabled) +static int +mlxsw_sp_port_lag_col_dist_enable(struct mlxsw_sp_port *mlxsw_sp_port) { - if (lag_tx_enabled) - return mlxsw_sp_lag_dist_port_add(mlxsw_sp_port, - mlxsw_sp_port->lag_id); - else - return mlxsw_sp_lag_dist_port_remove(mlxsw_sp_port, - mlxsw_sp_port->lag_id); + int err; + + err = mlxsw_sp_lag_col_port_enable(mlxsw_sp_port, + mlxsw_sp_port->lag_id); + if (err) + return err; + + err = mlxsw_sp_lag_dist_port_add(mlxsw_sp_port, mlxsw_sp_port->lag_id); + if (err) + goto err_dist_port_add; + + return 0; + +err_dist_port_add: + mlxsw_sp_lag_col_port_disable(mlxsw_sp_port, mlxsw_sp_port->lag_id); + return err; +} + +static int +mlxsw_sp_port_lag_col_dist_disable(struct mlxsw_sp_port *mlxsw_sp_port) +{ + int err; + + err = mlxsw_sp_lag_dist_port_remove(mlxsw_sp_port, + mlxsw_sp_port->lag_id); + if (err) + return err; + + err = mlxsw_sp_lag_col_port_disable(mlxsw_sp_port, + mlxsw_sp_port->lag_id); + if (err) + goto err_col_port_disable; + + return 0; + +err_col_port_disable: + mlxsw_sp_lag_dist_port_add(mlxsw_sp_port, mlxsw_sp_port->lag_id); + return err; } static int mlxsw_sp_port_lag_changed(struct mlxsw_sp_port *mlxsw_sp_port, struct netdev_lag_lower_state_info *info) { - return mlxsw_sp_port_lag_tx_en_set(mlxsw_sp_port, info->tx_enabled); + if (info->tx_enabled) + return mlxsw_sp_port_lag_col_dist_enable(mlxsw_sp_port); + else + return mlxsw_sp_port_lag_col_dist_disable(mlxsw_sp_port); } static int mlxsw_sp_port_stp_set(struct mlxsw_sp_port *mlxsw_sp_port, @@ -5089,8 +5118,7 @@ static int mlxsw_sp_netdevice_port_upper_event(struct net_device *lower_dev, err = mlxsw_sp_port_lag_join(mlxsw_sp_port, upper_dev); } else { - mlxsw_sp_port_lag_tx_en_set(mlxsw_sp_port, - false); + mlxsw_sp_port_lag_col_dist_disable(mlxsw_sp_port); mlxsw_sp_port_lag_leave(mlxsw_sp_port, upper_dev); } From patchwork Tue Feb 12 16:29:52 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ido Schimmel X-Patchwork-Id: 1040693 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=mellanox.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=Mellanox.com header.i=@Mellanox.com header.b="tFieWkMN"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 43zSmq2Rm0z9s4Z for ; Wed, 13 Feb 2019 03:30:03 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730744AbfBLQaC (ORCPT ); Tue, 12 Feb 2019 11:30:02 -0500 Received: from mail-eopbgr10041.outbound.protection.outlook.com ([40.107.1.41]:30784 "EHLO EUR02-HE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1731078AbfBLQaB (ORCPT ); Tue, 12 Feb 2019 11:30:01 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=msJc5xXIsumfssVFQ0JfFHoRvOo97IqU5UZ3wzY1+gk=; b=tFieWkMNvmpxo2pmYkJTviLXi3o6F0pDFCR+Fe6jTWrNp21j8sk8hrA+8AqyNM+qITteOSRtL+w8Apv0QOOpoiDFj/cevHAS6tXiYMFDCAyBJy+4gd0b3P7MKK1vrWPZCCY0LRoAft6v39PNTXDwDOsoA8ICxKCw4P61C5KnwDA= Received: from AM6PR05MB5240.eurprd05.prod.outlook.com (20.177.196.214) by AM6PR05MB6597.eurprd05.prod.outlook.com (20.179.2.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1601.19; Tue, 12 Feb 2019 16:29:53 +0000 Received: from AM6PR05MB5240.eurprd05.prod.outlook.com ([fe80::3542:889c:3a85:3866]) by AM6PR05MB5240.eurprd05.prod.outlook.com ([fe80::3542:889c:3a85:3866%5]) with mapi id 15.20.1601.023; Tue, 12 Feb 2019 16:29:52 +0000 From: Ido Schimmel To: "netdev@vger.kernel.org" CC: "davem@davemloft.net" , Jiri Pirko , Nir Dotan , mlxsw , Ido Schimmel Subject: [PATCH net-next 2/4] mlxsw: spectrum_router: Drop unnecessary WARN_ON_ONCE() Thread-Topic: [PATCH net-next 2/4] mlxsw: spectrum_router: Drop unnecessary WARN_ON_ONCE() Thread-Index: AQHUwvAul5wvl5YJBE2Lo0lo0Gtmeg== Date: Tue, 12 Feb 2019 16:29:52 +0000 Message-ID: <20190212162924.29777-3-idosch@mellanox.com> References: <20190212162924.29777-1-idosch@mellanox.com> In-Reply-To: <20190212162924.29777-1-idosch@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: LO2P265CA0277.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a1::25) To AM6PR05MB5240.eurprd05.prod.outlook.com (2603:10a6:20b:64::22) authentication-results: spf=none (sender IP is ) smtp.mailfrom=idosch@mellanox.com; x-ms-exchange-messagesentrepresentingtype: 1 x-mailer: git-send-email 2.20.1 x-originating-ip: [193.47.165.251] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; AM6PR05MB6597; 6:ZTJgGEd1g1YqYFUxiQ43m7yIwqz1JqJBU6wc0ZXGme3pQlagxxhoQtl8dRdj99+qHOmvktx4pshi7MMtegBthdejKFPruq4ZC7fky4v/JxBaimJ9SI9JuXkGQBDqlwS25OFF6EyhVO/8x6XdvaobMj51g0y3JfnCrASMXhoJDM5z6rIyDYhz1A/dEbKI0cSq7CN4Ls1hiTN7nsZuxMqZGXHYqwfxVsEUdSf8kibDDHk8AlcKXUzWRMUDxYmIwuvQMx/ARklBvkG1kExZnwXm7mcT/ARDdcr3AscmUebQpcIYW6sohcfaHDk2mUkoU6GQnhYEUO3iZlSQ9v5rSL/93EzcNN1TLcTz2ncAEhP1PQlM04jgTkyS0qzKvMRBX80sNieSYMsu8r7iFvnR5K3ByawSVNu5cHADyCkQ+iJlWn/UA5+VYkn/ghfBtmnYKZdWnicudkk37Z1jwigEeOnEBg==; 5:9/99Ny4cvd0t+T4w7+Z3b2fIPoxm7umxLv0x5zSlT2jUnXAjBuWMuZ7iewVxo55Y0fClhUS6W6jcYSjFGUihYKmeZovIRFkhgzXgwIPApafq/W9QwwTuBxeHMXnNru9LzEX1Ah4L8fTgHuyw3As2NP3SBfP8ydyDTq9dEIKf7FMvuptCUTW3VeopLxIdCnndCxZYGW6j8e6Vye0YYS4+Ag==; 7:3O5A/oZVeeqjDp8T6Ic/9kxnuEZM6iXsreTsmBY+rJg0aXRsc8Cti9O1jj0NLAiDiqjNZW5ZjknXPcJ826FM3wHgVzMdUrYI8r+I0XT7W2pUfGFw2wbfv3uQhY8CGg2DjaSHgKtiiV6umqfZBUQsnQ== x-ms-office365-filtering-correlation-id: 01fd35aa-e9b4-41a4-46e0-08d6910750b4 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600110)(711020)(4605077)(4618075)(2017052603328)(7153060)(7193020); SRVR:AM6PR05MB6597; x-ms-traffictypediagnostic: AM6PR05MB6597: x-microsoft-antispam-prvs: x-forefront-prvs: 0946DC87A1 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(346002)(376002)(136003)(39860400002)(366004)(396003)(189003)(52314003)(199004)(478600001)(2351001)(36756003)(14454004)(6506007)(386003)(76176011)(99286004)(4744005)(71190400001)(14444005)(71200400001)(256004)(7736002)(97736004)(2906002)(305945005)(316002)(8676002)(54906003)(81156014)(8936002)(1730700003)(81166006)(6436002)(107886003)(50226002)(6116002)(53936002)(3846002)(25786009)(5640700003)(6486002)(6916009)(446003)(86362001)(6512007)(2616005)(4326008)(476003)(486006)(105586002)(106356001)(2501003)(68736007)(52116002)(186003)(66066001)(26005)(102836004)(11346002)(1076003)(66574012); DIR:OUT; SFP:1101; SCL:1; SRVR:AM6PR05MB6597; H:AM6PR05MB5240.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: NcsIo9fWCs0x+yITt7QDxcBDpiAqvuQddP47LGKV9SDSJ9C3Iyd9RnbTg0xjanbl7TxffeYJciPwCNZAk3UOReuNMczyu5PMKMOE7ZFUHJdHO01Cn1pVbqC3jeJPFpj85AD7/37YwUMBkitX5/JXUWkpivMq+X8UaxeqxDxFQZAYhx1tgsElCl8b/RhiUT6upd3c9fPNVnRASuBGoEOIFkA4m8ivdQcjDAdPE7H6+Bx7nSC3bkZDJUmp1sB3kyiEOCc2/xJk8BtT8Bxk+5fA/Yzjq8B42PidbNdFK2xly66PNtIZ4/VPoL24D12pMFEQ+PcUhAMqpryYEAVSlA4OsIAJfHQ6BmoxypDGw0BXaUUmfjGUkkP5qp7KQIWWmFJDJHuDXrL8rhtK4QXuGY2xld36He+rYMTJ+g+vmXe+dNo= MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 01fd35aa-e9b4-41a4-46e0-08d6910750b4 X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Feb 2019 16:29:51.5338 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR05MB6597 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org In case the register access failed an error would be logged anyway, so we can drop the warning. Signed-off-by: Ido Schimmel Acked-by: Jiri Pirko --- drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c b/drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c index 818040ce4d68..52fed8c7bf1e 100644 --- a/drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c +++ b/drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c @@ -6142,7 +6142,7 @@ static int mlxsw_sp_router_rif_disable(struct mlxsw_sp *mlxsw_sp, u16 rif) mlxsw_reg_ritr_rif_pack(ritr_pl, rif); err = mlxsw_reg_query(mlxsw_sp->core, MLXSW_REG(ritr), ritr_pl); - if (WARN_ON_ONCE(err)) + if (err) return err; mlxsw_reg_ritr_enable_set(ritr_pl, false); From patchwork Tue Feb 12 16:29:53 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ido Schimmel X-Patchwork-Id: 1040694 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=mellanox.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=Mellanox.com header.i=@Mellanox.com header.b="HZBPMZ9R"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 43zSmt0kZpz9s4Z for ; Wed, 13 Feb 2019 03:30:06 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730764AbfBLQaF (ORCPT ); Tue, 12 Feb 2019 11:30:05 -0500 Received: from mail-eopbgr10041.outbound.protection.outlook.com ([40.107.1.41]:30784 "EHLO EUR02-HE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1730717AbfBLQaD (ORCPT ); Tue, 12 Feb 2019 11:30:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LV9CTOi4YFZSqeGIEn8I/UoVjvUnRHzbALgqJHWtWHs=; b=HZBPMZ9RiK88RHiLraiAhOoFWOCrV8wkIv+bB+rvFHDT8UfuB2WlsX6AMnJn235Hnf96dyPVOplISz8Bg6dpJUSQtC87wOvW/fg4wG52F8ITmThAKfT5Z+7+wG8FUeB4dwRn+ZIg8VAgaOPpXC9OBr27AENW5nJHRgHegzshtWI= Received: from AM6PR05MB5240.eurprd05.prod.outlook.com (20.177.196.214) by AM6PR05MB6597.eurprd05.prod.outlook.com (20.179.2.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1601.19; Tue, 12 Feb 2019 16:29:54 +0000 Received: from AM6PR05MB5240.eurprd05.prod.outlook.com ([fe80::3542:889c:3a85:3866]) by AM6PR05MB5240.eurprd05.prod.outlook.com ([fe80::3542:889c:3a85:3866%5]) with mapi id 15.20.1601.023; Tue, 12 Feb 2019 16:29:54 +0000 From: Ido Schimmel To: "netdev@vger.kernel.org" CC: "davem@davemloft.net" , Jiri Pirko , Nir Dotan , mlxsw , Ido Schimmel , Pablo Neira Ayuso Subject: [PATCH net-next 3/4] mlxsw: spectrum_flower: Fix VLAN modify action support Thread-Topic: [PATCH net-next 3/4] mlxsw: spectrum_flower: Fix VLAN modify action support Thread-Index: AQHUwvAvc5D88Bfgy0G6xz80aZ1aJQ== Date: Tue, 12 Feb 2019 16:29:53 +0000 Message-ID: <20190212162924.29777-4-idosch@mellanox.com> References: <20190212162924.29777-1-idosch@mellanox.com> In-Reply-To: <20190212162924.29777-1-idosch@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: LO2P265CA0277.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a1::25) To AM6PR05MB5240.eurprd05.prod.outlook.com (2603:10a6:20b:64::22) authentication-results: spf=none (sender IP is ) smtp.mailfrom=idosch@mellanox.com; x-ms-exchange-messagesentrepresentingtype: 1 x-mailer: git-send-email 2.20.1 x-originating-ip: [193.47.165.251] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; AM6PR05MB6597; 6:KFOKv6Jo+xWFT7u66m7THAeCzpXa7vSs8XyNx+ItYP5ZRBcSO8PHE0qLVpRPe2yIrD3n3PKEMG9o+Ykbx7F2M+FXn2gPG2XQ9k8SdF6sV46i9ouZVVI2lITgi10mhVnaK/aIiWBu05glI9GLdvK51MrUGxusWptPG9RxaEAOJ53Am620ycSdVS+Pz60S3SE2K6kdd54qNxy7MyasWL18+G9G/VEMUZvbyqlQiGwsTHNe/Wmr6rDqwypvT7TTGupGCCpJkaEEexm08rNDyUlhsX8ibd43XPsO6RtYf3QF0wHqZqKAYqLDSyjszN/Qnxfol+46hmamlNtL3SWCMmvwPxwiN0honmDyfn0Z1LmkJWBWcXClca9jZoVfSy70McZDhQNFEUjphiwe94UrydoKP29sxxNWejr2PuHX2En69vBNr5m9gvjFwdzXsnztdCJXrXPM1diKLMD0HJbzwRxLYw==; 5:mDbnBPC4hTXkZOiJNACPPvDthWr/iaCT6VuIuWa9E07Ip/ksmrFStUciKlWSW14HfQJ3CHAEIbo5gSxQRjfjlZBW0Tki1EkpKhEjFC9Qph47lputTgLQ86LTb35QzGCmhxS+a6RPhq+yfpB68TnMVbWavVaQXG+6JL/41+DU2Fh77V7hBVaHJrPnZZeiaHgFny8XakumPNoNmdMYo5BATw==; 7:gOthNIvvjkwbzW6joozUub6PnOGdQ3bdm6QLw8B9TdXskNmr5XVzk8qQim2BrFjYP3BmEYXHAcLP2wuglmKoXGDcYKK7AvD3eh0iNSZc23+u7hhFr/Hyrg/hu3QbctbdinHbgiwdn2VqLZNmsnvjTQ== x-ms-office365-filtering-correlation-id: 5d71195d-1ee0-4a63-e810-08d69107515f x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600110)(711020)(4605077)(4618075)(2017052603328)(7153060)(7193020); SRVR:AM6PR05MB6597; x-ms-traffictypediagnostic: AM6PR05MB6597: x-microsoft-antispam-prvs: x-forefront-prvs: 0946DC87A1 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(346002)(376002)(136003)(39860400002)(366004)(396003)(189003)(199004)(478600001)(2351001)(36756003)(14454004)(6506007)(386003)(76176011)(99286004)(4744005)(71190400001)(71200400001)(256004)(7736002)(97736004)(2906002)(305945005)(316002)(8676002)(54906003)(81156014)(8936002)(1730700003)(81166006)(6436002)(50226002)(6116002)(53936002)(3846002)(25786009)(5640700003)(6486002)(6916009)(446003)(86362001)(6512007)(2616005)(4326008)(476003)(486006)(105586002)(106356001)(2501003)(68736007)(52116002)(186003)(66066001)(26005)(102836004)(11346002)(1076003); DIR:OUT; SFP:1101; SCL:1; SRVR:AM6PR05MB6597; H:AM6PR05MB5240.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: yl5Z+o3lvXOCBfG55prbpv1FWLw7j+9tbZjs7SHrkHQWS+3pEFInHy20iHvvrU9dmc2g5Sr1JSidibd/B0Y60Bp0lnde4YIU4yuTcd1w9X8VBvUr6O71Ua6UHJFYCd8rUhaf8MGkVjAJlccLV+Y9LtzzBWZnmwsFcEfgk+yr4rFch6YMsUYVEppjHCgpZJSutukUR6Wyqs7zh7oCS5R3y9aEojNGbHil0VAchYeNcYbe2nH6PbcfNurQP7HFkdPscInW5gFIVq8bT/U5RO1puQElQiSnQdW68cjYxa92caAAnqEun/+O4+TPyAUkcHo7ltgDQnvOjJvCnS0Ww6jLSiN4tFjR665EFyOGyXh9RsvzCK+r2TmcHH8/6Df0+4FuQFU7rGU+giqH4pmjdCOtlPP39x+otU9JE7/HpFqo6Uc= MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5d71195d-1ee0-4a63-e810-08d69107515f X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Feb 2019 16:29:52.9057 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR05MB6597 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org The driver does not support VLAN push and pop, but only VLAN modify. Fixes: 738678817573 ("drivers: net: use flow action infrastructure") Signed-off-by: Ido Schimmel Acked-by: Jiri Pirko Cc: Pablo Neira Ayuso Acked-by: Pablo Neira Ayuso --- drivers/net/ethernet/mellanox/mlxsw/spectrum_flower.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/ethernet/mellanox/mlxsw/spectrum_flower.c b/drivers/net/ethernet/mellanox/mlxsw/spectrum_flower.c index 9af9f5c1b25c..15f804453cd6 100644 --- a/drivers/net/ethernet/mellanox/mlxsw/spectrum_flower.c +++ b/drivers/net/ethernet/mellanox/mlxsw/spectrum_flower.c @@ -102,8 +102,7 @@ static int mlxsw_sp_flower_parse_actions(struct mlxsw_sp *mlxsw_sp, return err; } break; - case FLOW_ACTION_VLAN_PUSH: - case FLOW_ACTION_VLAN_POP: { + case FLOW_ACTION_VLAN_MANGLE: { u16 proto = be16_to_cpu(act->vlan.proto); u8 prio = act->vlan.prio; u16 vid = act->vlan.vid; From patchwork Tue Feb 12 16:29:54 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ido Schimmel X-Patchwork-Id: 1040695 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=mellanox.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=Mellanox.com header.i=@Mellanox.com header.b="yRAiU+X9"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 43zSmw5XQ4z9s4Z for ; Wed, 13 Feb 2019 03:30:08 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731027AbfBLQaH (ORCPT ); Tue, 12 Feb 2019 11:30:07 -0500 Received: from mail-eopbgr10041.outbound.protection.outlook.com ([40.107.1.41]:30784 "EHLO EUR02-HE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1730851AbfBLQaH (ORCPT ); Tue, 12 Feb 2019 11:30:07 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RpJDI0iN3EBEL/cWeAbDTW536ZEXuYDJvqgKfdjo9GM=; b=yRAiU+X9JQXpRt7LfG/+NMwgjNYqeJ1fk2lCg4LLxKzMze7gfT7eUEb7PY2C5p48p5xD06JAPqHNK8DSaNjTP/dniUCReLVNFfem6mZb87gw4MtNfyvEK2YyfqR4iJ2CKyGKQLeqwHg9aV9Ab7CNM/ReDRCJ2OQc+5b+x2Q3ufo= Received: from AM6PR05MB5240.eurprd05.prod.outlook.com (20.177.196.214) by AM6PR05MB6597.eurprd05.prod.outlook.com (20.179.2.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1601.19; Tue, 12 Feb 2019 16:29:55 +0000 Received: from AM6PR05MB5240.eurprd05.prod.outlook.com ([fe80::3542:889c:3a85:3866]) by AM6PR05MB5240.eurprd05.prod.outlook.com ([fe80::3542:889c:3a85:3866%5]) with mapi id 15.20.1601.023; Tue, 12 Feb 2019 16:29:55 +0000 From: Ido Schimmel To: "netdev@vger.kernel.org" CC: "davem@davemloft.net" , Jiri Pirko , Nir Dotan , mlxsw , Ido Schimmel Subject: [PATCH net-next 4/4] selftests: mlxsw: avoid double sourcing of lib.sh Thread-Topic: [PATCH net-next 4/4] selftests: mlxsw: avoid double sourcing of lib.sh Thread-Index: AQHUwvAvEKYUcjK0u0a5iK3K2Zrljw== Date: Tue, 12 Feb 2019 16:29:54 +0000 Message-ID: <20190212162924.29777-5-idosch@mellanox.com> References: <20190212162924.29777-1-idosch@mellanox.com> In-Reply-To: <20190212162924.29777-1-idosch@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: LO2P265CA0277.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a1::25) To AM6PR05MB5240.eurprd05.prod.outlook.com (2603:10a6:20b:64::22) authentication-results: spf=none (sender IP is ) smtp.mailfrom=idosch@mellanox.com; x-ms-exchange-messagesentrepresentingtype: 1 x-mailer: git-send-email 2.20.1 x-originating-ip: [193.47.165.251] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; AM6PR05MB6597; 6:R9MfKAaKu53WvJBq0QrszGeIHxxV7hRmu3Z2iOhvBS0hhBybZsIFPEyKgyWiW93kDNYmxYtMBtqjLKh+tHhjLPbV47U25pPQuS+4vy1uA9HmS9bzZKZfLp05vLeXUCJu1di07KP19dyM6ja7EDAHhleT8v68S15Ixty+lqWPS7xqfY50YR38+7mknWLOMi5QVJa2bndlfkBJpVvUj1s9feECl3YNIjkb/o/U/3FphCukfp0PDxhMCqcCGhmdigyFZN9TWqBYxHQGjK3apKaPNmznlo8jA8AKFXBdSYoFNuSqlM6ZSdyzt3qt8uMi+M50K55pdJW7bERzFQHkYaBjygftaPGYxP/DvHETdjaNR56tpsUo+5+l5qvJFN/EeGZMJBwPSy8u9eQxwFNx0B990OWBKPfsx/gGW/54DHn/agnDc4yUJ13ul4q7KwP09anSkLe5QKNJ25a0q6WZkbqmBw==; 5:iazoMcCg2xSXZgV4Hdxz7b0R0FHF2y9/ozVzdhubNeXTdjS39zsBnYN7/VMROgAYnnuNkSJ4mkSzg4+SpWooox4ohPmi8MdwX8nDWf4aJJHi8+HYTlb/bwhWw5UpGcnD3ObjiCtsBVpTC2DehFtBO/j485YmLmn0cS2dQCGZ3KXHvgWJLMR70lxwzZMKL6drd5ldq7ZcY3CHAyitdXBeYQ==; 7:oda8gHVhrY5eOtr7lGs/WNpb37MRa33QG8WnpQHQ8AMlxOz64/aMTMdQRREdH/DWPP2DUbe8nbfEHqr1WBetjTB9zbfVWULWeEmX3Wy9FZ2jQOJNElc8pjSYz2EouTe3lQkhnUUZk7MnmzZPfJV0yw== x-ms-office365-filtering-correlation-id: a8f1c88b-83f5-4afb-3112-08d691075206 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600110)(711020)(4605077)(4618075)(2017052603328)(7153060)(7193020); SRVR:AM6PR05MB6597; x-ms-traffictypediagnostic: AM6PR05MB6597: x-microsoft-antispam-prvs: x-forefront-prvs: 0946DC87A1 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(346002)(376002)(136003)(39860400002)(366004)(396003)(189003)(199004)(478600001)(2351001)(36756003)(14454004)(6506007)(386003)(76176011)(99286004)(4744005)(71190400001)(14444005)(71200400001)(256004)(7736002)(97736004)(2906002)(305945005)(316002)(8676002)(54906003)(81156014)(8936002)(1730700003)(81166006)(6436002)(107886003)(50226002)(6116002)(53936002)(3846002)(25786009)(5640700003)(6486002)(6916009)(446003)(86362001)(6512007)(2616005)(4326008)(476003)(486006)(105586002)(106356001)(2501003)(68736007)(52116002)(186003)(66066001)(26005)(102836004)(11346002)(1076003); DIR:OUT; SFP:1101; SCL:1; SRVR:AM6PR05MB6597; H:AM6PR05MB5240.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: FJQKbXP7Jy7MhoeiWM7MZ8CVDidVDYOrw5gK6rQ5pEw57hfrw3YTcn1xEZi+DC+7XwlyP/UJ4Oq2JqgdOzg3PnDKZEal/ajLQmLc9RO2Sty07CpjKICygiEcpBtsqL4thFh+F3R9bvaqpEjxA2A9zisF+nizMRMax//FbSlm6BomRnarnYgvCmhnMhqG8XCjlk5nKJWpObnQtDTKj6KV+tEq+x5irOafTchJBqTrniBlUwp1ptPWr3m/eYdK/GjH9q3tPkWAydOZpz44SjowpEltySFAlHRg9hM6EXMBYNXq7lZVbd6Jyyx0oaL7nWodFo7iOlB4WASB0tzBN+i7udS4X87JUCrfgJCCMm5sctS4LnyMLPNwINZVN0ZuEmfMqa6Gwn3Zk97S7GLVUmrpmCAQy9LWLzEbn2Vx+SmmM9I= MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: a8f1c88b-83f5-4afb-3112-08d691075206 X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Feb 2019 16:29:54.0525 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR05MB6597 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Jiri Pirko Don't source lib.sh 2 times and make the script work with ifnames passed on the command line. Signed-off-by: Jiri Pirko Signed-off-by: Ido Schimmel --- .../selftests/drivers/net/mlxsw/spectrum/resource_scale.sh | 1 - 1 file changed, 1 deletion(-) diff --git a/tools/testing/selftests/drivers/net/mlxsw/spectrum/resource_scale.sh b/tools/testing/selftests/drivers/net/mlxsw/spectrum/resource_scale.sh index a0a80e1a69e8..e7ffc79561b7 100755 --- a/tools/testing/selftests/drivers/net/mlxsw/spectrum/resource_scale.sh +++ b/tools/testing/selftests/drivers/net/mlxsw/spectrum/resource_scale.sh @@ -2,7 +2,6 @@ # SPDX-License-Identifier: GPL-2.0 NUM_NETIFS=6 -source ../../../../net/forwarding/lib.sh source ../../../../net/forwarding/tc_common.sh source devlink_lib_spectrum.sh