From patchwork Tue Feb 12 15:56:00 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yang Wei X-Patchwork-Id: 1040672 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=163.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=163.com header.i=@163.com header.b="XHdlf08X"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 43zS1j2CtNz9s4Z for ; Wed, 13 Feb 2019 02:56:09 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730722AbfBLP4I (ORCPT ); Tue, 12 Feb 2019 10:56:08 -0500 Received: from m12-15.163.com ([220.181.12.15]:40629 "EHLO m12-15.163.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728347AbfBLP4H (ORCPT ); Tue, 12 Feb 2019 10:56:07 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-Id; bh=90M3wPVXzHtMGZwoyN jSuH4twrzjlIgzYPRFisSSaYQ=; b=XHdlf08XHBzRwV/porEsF1SHZzsAFSeG8t KZEbclSkYrd55/n6J5SrtBjUy+MOz5KmkoGxV03cJvy2ORU/zJiqxpo71j+4Kekw Pk0LKCpNf8OEnhcschmMlULCr6CSocJ5RENO7PQZXXoE2J1ISahkYLzprk01NO1c 3WiaoQn58= Received: from yangwei-T440.lan (unknown [125.69.43.124]) by smtp11 (Coremail) with SMTP id D8CowADHOFCS7GJcUYlYCw--.52903S3; Tue, 12 Feb 2019 23:56:03 +0800 (CST) From: Yang Wei To: netdev@vger.kernel.org Cc: davem@davemloft.net, keescook@chromium.org, yang.wei9@zte.com.cn, albin_yang@163.com Subject: [PATCH net] net: moxa: replace dev_kfree_skb_irq by dev_consume_skb_irq for drop profiles Date: Tue, 12 Feb 2019 23:56:00 +0800 Message-Id: <1549986960-5031-1-git-send-email-albin_yang@163.com> X-Mailer: git-send-email 2.7.4 X-CM-TRANSID: D8CowADHOFCS7GJcUYlYCw--.52903S3 X-Coremail-Antispam: 1Uf129KBjvdXoWrtrWDKF1xAw4xAr43try3twb_yoWftrb_Wr 12gF1Iv3y5J345Cw1Yk3WYva4I9rn8Zrs5ZFy0gay3Za47Kr18Jr1DWrnrWwn7Wr4fuF9r tF1xuFZrA3yjyjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7IUjI387UUUUU== X-Originating-IP: [125.69.43.124] X-CM-SenderInfo: pdoex0xb1d0wi6rwjhhfrp/1tbiSgdZolPAC9yO6gABsX Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Yang Wei dev_consume_skb_irq() should be called in moxart_tx_finished() when skb xmit done. It makes drop profiles(dropwatch, perf) more friendly. Signed-off-by: Yang Wei --- drivers/net/ethernet/moxa/moxart_ether.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/moxa/moxart_ether.c b/drivers/net/ethernet/moxa/moxart_ether.c index b34055a..b966815 100644 --- a/drivers/net/ethernet/moxa/moxart_ether.c +++ b/drivers/net/ethernet/moxa/moxart_ether.c @@ -298,7 +298,7 @@ static void moxart_tx_finished(struct net_device *ndev) ndev->stats.tx_packets++; ndev->stats.tx_bytes += priv->tx_skb[tx_tail]->len; - dev_kfree_skb_irq(priv->tx_skb[tx_tail]); + dev_consume_skb_irq(priv->tx_skb[tx_tail]); priv->tx_skb[tx_tail] = NULL; tx_tail = TX_NEXT(tx_tail);