From patchwork Sat Feb 9 22:54:04 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 1039302 X-Patchwork-Delegate: promsoft@gmail.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.denx.de (client-ip=81.169.180.215; helo=lists.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="xuoKNGGE"; dkim-atps=neutral Received: from lists.denx.de (dione.denx.de [81.169.180.215]) by ozlabs.org (Postfix) with ESMTP id 43xnSR4HlFz9s5c for ; Sun, 10 Feb 2019 09:55:03 +1100 (AEDT) Received: by lists.denx.de (Postfix, from userid 105) id 358C5C22047; Sat, 9 Feb 2019 22:54:40 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=KHOP_BIG_TO_CC, T_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.0 Received: from lists.denx.de (localhost [IPv6:::1]) by lists.denx.de (Postfix) with ESMTP id 58F77C21FE4; Sat, 9 Feb 2019 22:54:36 +0000 (UTC) Received: by lists.denx.de (Postfix, from userid 105) id 94964C21FE4; Sat, 9 Feb 2019 22:54:29 +0000 (UTC) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by lists.denx.de (Postfix) with ESMTPS id 06D44C22007 for ; Sat, 9 Feb 2019 22:54:26 +0000 (UTC) Received: from localhost.localdomain (unknown [194.230.155.153]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id BA29121934; Sat, 9 Feb 2019 22:54:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1549752864; bh=S5h0JAQBAaT5lOE302FuxgB39RNimwGh593UUtq2388=; h=From:To:Subject:Date:In-Reply-To:References:From; b=xuoKNGGE4aWL0YNWAFCVTCHIBhVMGGg3+zhAh1ybg+2gD2DzjnYymoaRFZ5/9Yx5A BMOmPcEXxnV28qt/8SyMYQE8IEMhOEtlFfFMwyHHXvU9syEHCXvPljiWuP0Vsyv3OP enoBjKjMbpx4Ns5QZOnYBoeiKYJe0gQO0zBYekAk= From: Krzysztof Kozlowski To: Albert Aribaud , Jaehoon Chung , Krzysztof Kozlowski , Simon Glass , Minkyu Kang , Marek Szyprowski , Lukasz Majewski , Dirk Meul , Patrice Chotard , Felix Brack , Jack Mitchell , Patrick Delaunay , Lokesh Vutla , u-boot@lists.denx.de Date: Sat, 9 Feb 2019 23:54:04 +0100 Message-Id: <20190209225411.32756-2-krzk@kernel.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190209225411.32756-1-krzk@kernel.org> References: <20190209225411.32756-1-krzk@kernel.org> Subject: [U-Boot] [RFT 1/8] exynos: Redo detection of revision when all resources are ready X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.18 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" Detection of board type is done early - before power setup. In case of Odroid XU3/XU4/HC1 family, the detection is done using ADC which is supplied by LDO4/VDD_ADC regulator. This regulator could be turned off (e.g. by kernel before reboot); If ADC is used early, the regulators are not yet available and the detection won't work. Try to detect the revision again, once power is brought up. This is necessary to fix the detection of Odroid HC1 after reboot, if kernel turned off the LDO4 regulator. Otherwise the board is not detected.... Signed-off-by: Krzysztof Kozlowski --- board/samsung/common/board.c | 19 ++++++++++++++++++- 1 file changed, 18 insertions(+), 1 deletion(-) diff --git a/board/samsung/common/board.c b/board/samsung/common/board.c index 6fd26a3a9198..1e2dabe68d11 100644 --- a/board/samsung/common/board.c +++ b/board/samsung/common/board.c @@ -147,6 +147,11 @@ int board_early_init_f(void) { int err; #ifdef CONFIG_BOARD_TYPES + /* + * It is done early so power might not be set up yet. In such case + * specific revision detection with ADC might not work and need to me + * redone later. + */ set_board_type(); #endif err = board_uart_init(); @@ -166,9 +171,21 @@ int board_early_init_f(void) #if defined(CONFIG_POWER) || defined(CONFIG_DM_PMIC) int power_init_board(void) { + int ret; + set_ps_hold_ctrl(); - return exynos_power_init(); + ret = exynos_power_init(); + +#ifdef CONFIG_BOARD_TYPES + /* + * Since power is on, redo the board detection (external peripherals + * are on). + */ + set_board_type(); +#endif + + return ret; } #endif From patchwork Sat Feb 9 22:54:05 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 1039303 X-Patchwork-Delegate: promsoft@gmail.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.denx.de (client-ip=81.169.180.215; helo=lists.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="z0k0IVQG"; dkim-atps=neutral Received: from lists.denx.de (dione.denx.de [81.169.180.215]) by ozlabs.org (Postfix) with ESMTP id 43xnT72t2Nz9s5c for ; Sun, 10 Feb 2019 09:55:38 +1100 (AEDT) Received: by lists.denx.de (Postfix, from userid 105) id 68011C21F3E; Sat, 9 Feb 2019 22:55:09 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=KHOP_BIG_TO_CC, T_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.0 Received: from lists.denx.de (localhost [IPv6:::1]) by lists.denx.de (Postfix) with ESMTP id 77CC4C22026; Sat, 9 Feb 2019 22:54:51 +0000 (UTC) Received: by lists.denx.de (Postfix, from userid 105) id 44AD1C22049; Sat, 9 Feb 2019 22:54:32 +0000 (UTC) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by lists.denx.de (Postfix) with ESMTPS id 8D02AC21FFA for ; Sat, 9 Feb 2019 22:54:29 +0000 (UTC) Received: from localhost.localdomain (unknown [194.230.155.153]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 4AD3A2192C; Sat, 9 Feb 2019 22:54:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1549752868; bh=iOcRyGZg82RQhMX1yZfqK95/vS26gtxrOZPGWLDaEtY=; h=From:To:Subject:Date:In-Reply-To:References:From; b=z0k0IVQGgX6cTie8hBGVZENONZbTQRbqTbPEhVGRTtkVB815x0Ci9W6igxHNk2H5b y/WVFPfZpb7ZwRvENNLcTg/T5fbtHccWtQF4plnZ7rInuAf7URm2F2EmLr8yzjtZqX 8x2e9plfCTO/1Qh3gUi8fQ8hSMkk6OyXto9FIe50= From: Krzysztof Kozlowski To: Albert Aribaud , Jaehoon Chung , Krzysztof Kozlowski , Simon Glass , Minkyu Kang , Marek Szyprowski , Lukasz Majewski , Dirk Meul , Patrice Chotard , Felix Brack , Jack Mitchell , Patrick Delaunay , Lokesh Vutla , u-boot@lists.denx.de Date: Sat, 9 Feb 2019 23:54:05 +0100 Message-Id: <20190209225411.32756-3-krzk@kernel.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190209225411.32756-1-krzk@kernel.org> References: <20190209225411.32756-1-krzk@kernel.org> Subject: [U-Boot] [RFT 2/8] exynos: Wait till ADC stabilizes before checking Odroid HC1 revision X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.18 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" Fix detection of Odroid HC1 (Exynos5422) after reboot if kernel disabled the LDO4/VDD_ADC regulator. The LDO4 supplies both ADC block and the ADC input AIN9. Voltage on AIN9 will rise slowly, so be patient and wait for it to stabilize. First reads on Odroid HC1 return 305, 1207, 1297 and finally 1308 (reference value is 1309). Signed-off-by: Krzysztof Kozlowski --- board/samsung/common/exynos5-dt-types.c | 34 ++++++++++++++++++++++++- 1 file changed, 33 insertions(+), 1 deletion(-) diff --git a/board/samsung/common/exynos5-dt-types.c b/board/samsung/common/exynos5-dt-types.c index 7a86e9187768..ba8584f1a5d8 100644 --- a/board/samsung/common/exynos5-dt-types.c +++ b/board/samsung/common/exynos5-dt-types.c @@ -57,12 +57,44 @@ static unsigned int odroid_get_rev(void) return 0; } +/* + * Read ADC at least twice and check the resuls. If regulator providing voltage + * on to measured point was just turned on, first reads might require time + * to stabilize. + */ +static int odroid_get_adc_val(unsigned int *adcval) +{ + unsigned int adcval_prev = 0; + int ret, retries = 20; + + ret = adc_channel_single_shot("adc", CONFIG_ODROID_REV_AIN, + &adcval_prev); + if (ret) + return ret; + + while (retries--) { + mdelay(5); + + ret = adc_channel_single_shot("adc", CONFIG_ODROID_REV_AIN, + adcval); + if (ret) + return ret; + + if ((100 * abs(*adcval - adcval_prev) / adcval_prev) < 3) + return ret; + + adcval_prev = *adcval; + } + + return ret; +} + static int odroid_get_board_type(void) { unsigned int adcval; int ret, i; - ret = adc_channel_single_shot("adc", CONFIG_ODROID_REV_AIN, &adcval); + ret = odroid_get_adc_val(&adcval); if (ret) goto rev_default; From patchwork Sat Feb 9 22:54:06 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 1039304 X-Patchwork-Delegate: promsoft@gmail.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.denx.de (client-ip=81.169.180.215; helo=lists.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="FX6/wx8e"; dkim-atps=neutral Received: from lists.denx.de (dione.denx.de [81.169.180.215]) by ozlabs.org (Postfix) with ESMTP id 43xnTM4yBmz9s5c for ; Sun, 10 Feb 2019 09:55:51 +1100 (AEDT) Received: by lists.denx.de (Postfix, from userid 105) id 23002C21FF6; Sat, 9 Feb 2019 22:54:55 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=KHOP_BIG_TO_CC, T_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.0 Received: from lists.denx.de (localhost [IPv6:::1]) by lists.denx.de (Postfix) with ESMTP id 039A2C22051; Sat, 9 Feb 2019 22:54:43 +0000 (UTC) Received: by lists.denx.de (Postfix, from userid 105) id 8F580C2204F; Sat, 9 Feb 2019 22:54:36 +0000 (UTC) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by lists.denx.de (Postfix) with ESMTPS id D32F4C2202A for ; Sat, 9 Feb 2019 22:54:32 +0000 (UTC) Received: from localhost.localdomain (unknown [194.230.155.153]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B0EE9218D2; Sat, 9 Feb 2019 22:54:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1549752871; bh=yp3Q1bL+KJ7TAQMrlCeejKPok81K/Jq61WERezNMbiY=; h=From:To:Subject:Date:In-Reply-To:References:From; b=FX6/wx8eOFIniHWyvzepXSnE+2WwLt5GC5ieQAJzFBr4PPPn/h7HfMphwrHxa9aEj kr/2DKCtyKzWGH9BM/kmlBYR5rFbj5CCU24CoTpYuTuOdgXYo7VgEUlz58CsPESX/F ztTLTFhlZWbR4oELNcZ9C02cU+j2AgGHCmNBzVYU= From: Krzysztof Kozlowski To: Albert Aribaud , Jaehoon Chung , Krzysztof Kozlowski , Simon Glass , Minkyu Kang , Marek Szyprowski , Lukasz Majewski , Dirk Meul , Patrice Chotard , Felix Brack , Jack Mitchell , Patrick Delaunay , Lokesh Vutla , u-boot@lists.denx.de Date: Sat, 9 Feb 2019 23:54:06 +0100 Message-Id: <20190209225411.32756-4-krzk@kernel.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190209225411.32756-1-krzk@kernel.org> References: <20190209225411.32756-1-krzk@kernel.org> Subject: [U-Boot] [RFT 3/8] adc: exynos-adc: Fix wrong bit operation used to stop the ADC X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.18 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" When stopping the ADC_V2_CON1_STC_EN should be cleared. Signed-off-by: Krzysztof Kozlowski --- drivers/adc/exynos-adc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/adc/exynos-adc.c b/drivers/adc/exynos-adc.c index d33e3d632afc..12c49fc8cefb 100644 --- a/drivers/adc/exynos-adc.c +++ b/drivers/adc/exynos-adc.c @@ -62,7 +62,7 @@ int exynos_adc_stop(struct udevice *dev) /* Stop conversion */ cfg = readl(®s->con1); - cfg |= ~ADC_V2_CON1_STC_EN; + cfg &= ~ADC_V2_CON1_STC_EN; writel(cfg, ®s->con1); From patchwork Sat Feb 9 22:54:07 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 1039307 X-Patchwork-Delegate: promsoft@gmail.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.denx.de (client-ip=81.169.180.215; helo=lists.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="L1pK9FtY"; dkim-atps=neutral Received: from lists.denx.de (dione.denx.de [81.169.180.215]) by ozlabs.org (Postfix) with ESMTP id 43xnVw30ssz9s5c for ; Sun, 10 Feb 2019 09:57:12 +1100 (AEDT) Received: by lists.denx.de (Postfix, from userid 105) id DB997C22051; Sat, 9 Feb 2019 22:56:01 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=KHOP_BIG_TO_CC, T_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.0 Received: from lists.denx.de (localhost [IPv6:::1]) by lists.denx.de (Postfix) with ESMTP id C9435C22033; Sat, 9 Feb 2019 22:55:22 +0000 (UTC) Received: by lists.denx.de (Postfix, from userid 105) id B27C7C22027; Sat, 9 Feb 2019 22:54:40 +0000 (UTC) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by lists.denx.de (Postfix) with ESMTPS id 5BD17C2202A for ; Sat, 9 Feb 2019 22:54:36 +0000 (UTC) Received: from localhost.localdomain (unknown [194.230.155.153]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 205182192C; Sat, 9 Feb 2019 22:54:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1549752875; bh=MaDRMpeRYtmSsiyZCB/9Dib7e5vhZ6XlDh/E0b5g+10=; h=From:To:Subject:Date:In-Reply-To:References:From; b=L1pK9FtYIqlsVeOGRr7fNCmi+z5x9vmPbOX2zEYJaxcYJbePXv19VvNucWP3X4YOr HrzKZzs01p2656qF2+arpQWlYjf8VDm1znH+bI5TNSb9xwQxj6ROpprFSM1c1507SV DwZNEWAPYDKUi68nfGJvh2puoFIUc3EnJ9tA0QuM= From: Krzysztof Kozlowski To: Albert Aribaud , Jaehoon Chung , Krzysztof Kozlowski , Simon Glass , Minkyu Kang , Marek Szyprowski , Lukasz Majewski , Dirk Meul , Patrice Chotard , Felix Brack , Jack Mitchell , Patrick Delaunay , Lokesh Vutla , u-boot@lists.denx.de Date: Sat, 9 Feb 2019 23:54:07 +0100 Message-Id: <20190209225411.32756-5-krzk@kernel.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190209225411.32756-1-krzk@kernel.org> References: <20190209225411.32756-1-krzk@kernel.org> Subject: [U-Boot] [RFT 4/8] regulator: Add support for ramp delay X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.18 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" Changing voltage and enabling regulator might require delays so the regulator stabilizes at expected level. Add support for "regulator-ramp-delay" binding which can introduce required time to both enabling the regulator and to changing the voltage. Signed-off-by: Krzysztof Kozlowski --- drivers/power/regulator/regulator-uclass.c | 45 +++++++++++++++++++++- include/power/regulator.h | 2 + 2 files changed, 45 insertions(+), 2 deletions(-) diff --git a/drivers/power/regulator/regulator-uclass.c b/drivers/power/regulator/regulator-uclass.c index 39e46279d533..4119f244c74b 100644 --- a/drivers/power/regulator/regulator-uclass.c +++ b/drivers/power/regulator/regulator-uclass.c @@ -35,10 +35,22 @@ int regulator_get_value(struct udevice *dev) return ops->get_value(dev); } +static void regulator_set_value_delay(struct udevice *dev, int old_uV, + int new_uV, unsigned int ramp_delay) +{ + int delay = DIV_ROUND_UP(abs(new_uV - old_uV), ramp_delay); + + debug("regulator %s: delay %u us (%d uV -> %d uV)\n", dev->name, + delay, old_uV, new_uV); + + udelay(delay); +} + int regulator_set_value(struct udevice *dev, int uV) { const struct dm_regulator_ops *ops = dev_get_driver_ops(dev); struct dm_regulator_uclass_platdata *uc_pdata; + int ret, old_uV = uV; uc_pdata = dev_get_uclass_platdata(dev); if (uc_pdata->min_uV != -ENODATA && uV < uc_pdata->min_uV) @@ -49,7 +61,18 @@ int regulator_set_value(struct udevice *dev, int uV) if (!ops || !ops->set_value) return -ENOSYS; - return ops->set_value(dev, uV); + if (uc_pdata->ramp_delay) + old_uV = regulator_get_value(dev); + + ret = ops->set_value(dev, uV); + + if (!ret) { + if (uc_pdata->ramp_delay && old_uV > 0) + regulator_set_value_delay(dev, old_uV, uV, + uc_pdata->ramp_delay); + } + + return ret; } /* @@ -107,6 +130,7 @@ int regulator_set_enable(struct udevice *dev, bool enable) { const struct dm_regulator_ops *ops = dev_get_driver_ops(dev); struct dm_regulator_uclass_platdata *uc_pdata; + int ret, old_enable = 0; if (!ops || !ops->set_enable) return -ENOSYS; @@ -115,7 +139,22 @@ int regulator_set_enable(struct udevice *dev, bool enable) if (!enable && uc_pdata->always_on) return 0; - return ops->set_enable(dev, enable); + if (uc_pdata->ramp_delay) + old_enable = regulator_get_enable(dev); + + ret = ops->set_enable(dev, enable); + if (!ret) { + if (uc_pdata->ramp_delay && !old_enable) { + int uV = regulator_get_value(dev); + + if (uV > 0) { + regulator_set_value_delay(dev, 0, uV, + uc_pdata->ramp_delay); + } + } + } + + return ret; } int regulator_get_mode(struct udevice *dev) @@ -324,6 +363,8 @@ static int regulator_pre_probe(struct udevice *dev) -ENODATA); uc_pdata->always_on = dev_read_bool(dev, "regulator-always-on"); uc_pdata->boot_on = dev_read_bool(dev, "regulator-boot-on"); + uc_pdata->ramp_delay = dev_read_u32_default(dev, "regulator-ramp-delay", + 0); /* Those values are optional (-ENODATA if unset) */ if ((uc_pdata->min_uV != -ENODATA) && diff --git a/include/power/regulator.h b/include/power/regulator.h index 5318ab3acece..c13fa1f336e5 100644 --- a/include/power/regulator.h +++ b/include/power/regulator.h @@ -149,6 +149,7 @@ enum regulator_flag { * @max_uA* - maximum amperage (micro Amps) * @always_on* - bool type, true or false * @boot_on* - bool type, true or false + * @ramp_delay - Time to settle down after voltage change (unit: uV/us) * TODO(sjg@chromium.org): Consider putting the above two into @flags * @flags: - flags value (see REGULATOR_FLAG_...) * @name** - fdt regulator name - should be taken from the device tree @@ -169,6 +170,7 @@ struct dm_regulator_uclass_platdata { int max_uV; int min_uA; int max_uA; + unsigned int ramp_delay; bool always_on; bool boot_on; const char *name; From patchwork Sat Feb 9 22:54:08 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 1039306 X-Patchwork-Delegate: promsoft@gmail.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.denx.de (client-ip=81.169.180.215; helo=lists.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="ylkX9l/Y"; dkim-atps=neutral Received: from lists.denx.de (dione.denx.de [81.169.180.215]) by ozlabs.org (Postfix) with ESMTP id 43xnVs27Vwz9s5c for ; Sun, 10 Feb 2019 09:57:09 +1100 (AEDT) Received: by lists.denx.de (Postfix, from userid 105) id 01F0FC22051; Sat, 9 Feb 2019 22:55:36 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=KHOP_BIG_TO_CC, T_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.0 Received: from lists.denx.de (localhost [IPv6:::1]) by lists.denx.de (Postfix) with ESMTP id A988DC22055; Sat, 9 Feb 2019 22:55:15 +0000 (UTC) Received: by lists.denx.de (Postfix, from userid 105) id 1731EC21FF3; Sat, 9 Feb 2019 22:54:44 +0000 (UTC) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by lists.denx.de (Postfix) with ESMTPS id D097BC2201B for ; Sat, 9 Feb 2019 22:54:39 +0000 (UTC) Received: from localhost.localdomain (unknown [194.230.155.153]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8CC1B218D2; Sat, 9 Feb 2019 22:54:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1549752878; bh=KX7+SppqBVHXusb/vv0PfgBGwP9hoDjCj+8NIsq1GLQ=; h=From:To:Subject:Date:In-Reply-To:References:From; b=ylkX9l/YVbRkii42kEUL1LOiwKiLHPkFrit+PNo0Zyv9eLPpUTkpA+jZOw3kZNK0L kfcWu3Fd1/Ihel5FP/7yiJi8kFg5B4+hLTD44VpGl9U2u4MdL8Bc32PUI+J6KPqMXI s/NSmUuK5uNUEAe6sy1dJzqJfEehMVeP34jvAwRI= From: Krzysztof Kozlowski To: Albert Aribaud , Jaehoon Chung , Krzysztof Kozlowski , Simon Glass , Minkyu Kang , Marek Szyprowski , Lukasz Majewski , Dirk Meul , Patrice Chotard , Felix Brack , Jack Mitchell , Patrick Delaunay , Lokesh Vutla , u-boot@lists.denx.de Date: Sat, 9 Feb 2019 23:54:08 +0100 Message-Id: <20190209225411.32756-6-krzk@kernel.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190209225411.32756-1-krzk@kernel.org> References: <20190209225411.32756-1-krzk@kernel.org> Subject: [U-Boot] [RFT 5/8] power: regulator: s2mps11: Fix step for LDO27 and LDO35 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.18 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" LDO27 and LDO35 have 25 mV step, not 50 mV. Signed-off-by: Krzysztof Kozlowski --- drivers/power/regulator/s2mps11_regulator.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/power/regulator/s2mps11_regulator.c b/drivers/power/regulator/s2mps11_regulator.c index ced504eb1476..723d27f67c9a 100644 --- a/drivers/power/regulator/s2mps11_regulator.c +++ b/drivers/power/regulator/s2mps11_regulator.c @@ -346,6 +346,8 @@ static int s2mps11_ldo_hex2volt(int ldo, int hex) case 11: case 22: case 23: + case 27: + case 35: uV = hex * S2MPS11_LDO_STEP + S2MPS11_LDO_UV_MIN; break; default: @@ -366,6 +368,8 @@ static int s2mps11_ldo_volt2hex(int ldo, int uV) case 11: case 22: case 23: + case 27: + case 35: hex = (uV - S2MPS11_LDO_UV_MIN) / S2MPS11_LDO_STEP; break; default: From patchwork Sat Feb 9 22:54:09 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 1039308 X-Patchwork-Delegate: promsoft@gmail.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.denx.de (client-ip=81.169.180.215; helo=lists.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="in7rXuBI"; dkim-atps=neutral Received: from lists.denx.de (dione.denx.de [81.169.180.215]) by ozlabs.org (Postfix) with ESMTP id 43xnWB2ZJSz9s5c for ; Sun, 10 Feb 2019 09:57:26 +1100 (AEDT) Received: by lists.denx.de (Postfix, from userid 105) id 1B331C22059; Sat, 9 Feb 2019 22:55:23 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=KHOP_BIG_TO_CC, T_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.0 Received: from lists.denx.de (localhost [IPv6:::1]) by lists.denx.de (Postfix) with ESMTP id 06B47C22051; Sat, 9 Feb 2019 22:55:04 +0000 (UTC) Received: by lists.denx.de (Postfix, from userid 105) id 40D23C22018; Sat, 9 Feb 2019 22:54:46 +0000 (UTC) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by lists.denx.de (Postfix) with ESMTPS id 5EC97C21FE1 for ; Sat, 9 Feb 2019 22:54:43 +0000 (UTC) Received: from localhost.localdomain (unknown [194.230.155.153]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 23C4D2192C; Sat, 9 Feb 2019 22:54:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1549752882; bh=h3lrcoif1nWN8lLlcR3vifZuW+rOS67Y2k6tWR8eBO4=; h=From:To:Subject:Date:In-Reply-To:References:From; b=in7rXuBI5JSgStEUNCzXUr0/UzgxOZ0Jm0riV+gifXb8ZD4kTCvvFE1iPcBuI4xAI gasZlsMBn6BzaRvQpc/8jaVK3VdA4VMX6nvqohTMN/udozt8+2geHG4QMt7FGkwtFV ntkhVQBFdBvzWLScch9DWdnzPsZG2Ok6CI46gczE= From: Krzysztof Kozlowski To: Albert Aribaud , Jaehoon Chung , Krzysztof Kozlowski , Simon Glass , Minkyu Kang , Marek Szyprowski , Lukasz Majewski , Dirk Meul , Patrice Chotard , Felix Brack , Jack Mitchell , Patrick Delaunay , Lokesh Vutla , u-boot@lists.denx.de Date: Sat, 9 Feb 2019 23:54:09 +0100 Message-Id: <20190209225411.32756-7-krzk@kernel.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190209225411.32756-1-krzk@kernel.org> References: <20190209225411.32756-1-krzk@kernel.org> Subject: [U-Boot] [RFT 6/8] power: regulator: s2mps11: Add enable delay X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.18 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" According to datasheet, the output on LDO regulators will start appearing after 10-15 us. Signed-off-by: Krzysztof Kozlowski --- drivers/power/regulator/s2mps11_regulator.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/drivers/power/regulator/s2mps11_regulator.c b/drivers/power/regulator/s2mps11_regulator.c index 723d27f67c9a..1f1581852ee2 100644 --- a/drivers/power/regulator/s2mps11_regulator.c +++ b/drivers/power/regulator/s2mps11_regulator.c @@ -551,7 +551,14 @@ static int ldo_get_enable(struct udevice *dev) static int ldo_set_enable(struct udevice *dev, bool enable) { - return s2mps11_ldo_enable(dev, PMIC_OP_SET, &enable); + int ret; + + ret = s2mps11_ldo_enable(dev, PMIC_OP_SET, &enable); + + /* Wait the "enable delay" for voltage to start to rise */ + udelay(15); + + return ret; } static int ldo_get_mode(struct udevice *dev) From patchwork Sat Feb 9 22:54:10 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 1039309 X-Patchwork-Delegate: promsoft@gmail.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.denx.de (client-ip=81.169.180.215; helo=lists.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="AeSG2HTy"; dkim-atps=neutral Received: from lists.denx.de (dione.denx.de [81.169.180.215]) by ozlabs.org (Postfix) with ESMTP id 43xnWH6qVQz9s5c for ; Sun, 10 Feb 2019 09:57:31 +1100 (AEDT) Received: by lists.denx.de (Postfix, from userid 105) id 9E446C2201B; Sat, 9 Feb 2019 22:55:48 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=KHOP_BIG_TO_CC, T_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.0 Received: from lists.denx.de (localhost [IPv6:::1]) by lists.denx.de (Postfix) with ESMTP id 4CEDAC22047; Sat, 9 Feb 2019 22:55:21 +0000 (UTC) Received: by lists.denx.de (Postfix, from userid 105) id 70937C2201B; Sat, 9 Feb 2019 22:54:50 +0000 (UTC) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by lists.denx.de (Postfix) with ESMTPS id A0C71C22049 for ; Sat, 9 Feb 2019 22:54:46 +0000 (UTC) Received: from localhost.localdomain (unknown [194.230.155.153]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8115F21934; Sat, 9 Feb 2019 22:54:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1549752885; bh=DZNWaXlIS7u5YN6nivKgijVmgWRpMjve9rAJzTi84cA=; h=From:To:Subject:Date:In-Reply-To:References:From; b=AeSG2HTymUNrvFmv86EZO14LxT/qQa2rxlxfUUDNOl5XAfW4zQp4Kfm0VwKq1rdmb Duf9+g2K42qof2lUasQFyv0j5t/R/07lrIZ4R5JqRjNlcQsw01Lmj5mDbYL2IBEqLy hQNxRfVi3dwFYTaGBzyr3AfNQNhtEz7ZOke+76u0= From: Krzysztof Kozlowski To: Albert Aribaud , Jaehoon Chung , Krzysztof Kozlowski , Simon Glass , Minkyu Kang , Marek Szyprowski , Lukasz Majewski , Dirk Meul , Patrice Chotard , Felix Brack , Jack Mitchell , Patrick Delaunay , Lokesh Vutla , u-boot@lists.denx.de Date: Sat, 9 Feb 2019 23:54:10 +0100 Message-Id: <20190209225411.32756-8-krzk@kernel.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190209225411.32756-1-krzk@kernel.org> References: <20190209225411.32756-1-krzk@kernel.org> Subject: [U-Boot] [RFT 7/8] arm: dts: exynos: Add supply for ADC block to Odroid XU3 family X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.18 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" The ADC block requires VDD supply to be on so provide one. Signed-off-by: Krzysztof Kozlowski --- arch/arm/dts/exynos5422-odroidxu3.dts | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/dts/exynos5422-odroidxu3.dts b/arch/arm/dts/exynos5422-odroidxu3.dts index e859dd1b981a..9dfae90667cf 100644 --- a/arch/arm/dts/exynos5422-odroidxu3.dts +++ b/arch/arm/dts/exynos5422-odroidxu3.dts @@ -32,6 +32,7 @@ adc@12D10000 { u-boot,dm-pre-reloc; + vdd-supply = <&ldo4_reg>; status = "okay"; }; From patchwork Sat Feb 9 22:54:11 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 1039305 X-Patchwork-Delegate: promsoft@gmail.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.denx.de (client-ip=81.169.180.215; helo=lists.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="ai4MY68j"; dkim-atps=neutral Received: from lists.denx.de (dione.denx.de [81.169.180.215]) by ozlabs.org (Postfix) with ESMTP id 43xnVK16lLz9s5c for ; Sun, 10 Feb 2019 09:56:41 +1100 (AEDT) Received: by lists.denx.de (Postfix, from userid 105) id C9F33C21FE0; Sat, 9 Feb 2019 22:56:23 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=KHOP_BIG_TO_CC, T_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.0 Received: from lists.denx.de (localhost [IPv6:::1]) by lists.denx.de (Postfix) with ESMTP id ABCF2C22026; Sat, 9 Feb 2019 22:56:21 +0000 (UTC) Received: by lists.denx.de (Postfix, from userid 105) id 19E0FC22010; Sat, 9 Feb 2019 22:54:54 +0000 (UTC) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by lists.denx.de (Postfix) with ESMTPS id 2E172C22046 for ; Sat, 9 Feb 2019 22:54:50 +0000 (UTC) Received: from localhost.localdomain (unknown [194.230.155.153]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E138C21939; Sat, 9 Feb 2019 22:54:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1549752888; bh=7gAJTdmBewF/RmohDxQpejsbmJWDUfL+9wh1+NQl3lI=; h=From:To:Subject:Date:In-Reply-To:References:From; b=ai4MY68jwftgWvGW9X9NAXxJ/02R8OfiuXig+dZcF4U6gcoWlhkmzRyNIYBKA6yro uoWuIqb2PPF1PZ/Yd3VoH1iJ5nETd4IaY8FYNrfnCSaDbrX1hkpndFjEYqlgbNrOUl XaQUzNCcxGUGtimMotepRw7u53QAX+4+0zz+0vfM= From: Krzysztof Kozlowski To: Albert Aribaud , Jaehoon Chung , Krzysztof Kozlowski , Simon Glass , Minkyu Kang , Marek Szyprowski , Lukasz Majewski , Dirk Meul , Patrice Chotard , Felix Brack , Jack Mitchell , Patrick Delaunay , Lokesh Vutla , u-boot@lists.denx.de Date: Sat, 9 Feb 2019 23:54:11 +0100 Message-Id: <20190209225411.32756-9-krzk@kernel.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190209225411.32756-1-krzk@kernel.org> References: <20190209225411.32756-1-krzk@kernel.org> Subject: [U-Boot] [RFT 8/8] arm: dts: exynos: Add ramp delay property to LDO regulators to Odroid XU3 family X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.18 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" Add startup time to LDO regulators of S2MPS11 PMIC on Odroid XU3/XU4/HC1 family of boards to be sure the voltage is proper before relying on the regulator. The datasheet for all the S2MPS1x family is inconsistent here and does not specify unambiguously the value of ramp delay for LDO. It mentions 30 mV/us in one timing diagram but then omits it completely in LDO regulator characteristics table (it is specified for bucks). However the vendor kernels for Galaxy S5 and Odroid XU3 use values of 12 mV/us or 24 mV/us. Without the ramp delay value the consumers do not wait for voltage settle after changing it. Although the proper value of ramp delay for LDOs is unknown, it seems safer to use at least some value from reference kernel than to leave it unset. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Lukasz Majewski --- arch/arm/dts/exynos5422-odroidxu3.dts | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) diff --git a/arch/arm/dts/exynos5422-odroidxu3.dts b/arch/arm/dts/exynos5422-odroidxu3.dts index 9dfae90667cf..04ecc404f907 100644 --- a/arch/arm/dts/exynos5422-odroidxu3.dts +++ b/arch/arm/dts/exynos5422-odroidxu3.dts @@ -45,6 +45,7 @@ regulator-name = "vdd_ldo1"; regulator-min-microvolt = <1000000>; regulator-max-microvolt = <1000000>; + regulator-ramp-delay = <12000>; regulator-always-on; }; @@ -52,18 +53,21 @@ regulator-name = "vddq_mmc0"; regulator-min-microvolt = <1800000>; regulator-max-microvolt = <1800000>; + regulator-ramp-delay = <12000>; }; ldo4_reg: LDO4 { regulator-name = "vdd_adc"; regulator-min-microvolt = <1800000>; regulator-max-microvolt = <1800000>; + regulator-ramp-delay = <12000>; }; ldo5_reg: LDO5 { regulator-name = "vdd_ldo5"; regulator-min-microvolt = <1800000>; regulator-max-microvolt = <1800000>; + regulator-ramp-delay = <12000>; regulator-always-on; }; @@ -71,6 +75,7 @@ regulator-name = "vdd_ldo6"; regulator-min-microvolt = <1000000>; regulator-max-microvolt = <1000000>; + regulator-ramp-delay = <12000>; regulator-always-on; }; @@ -78,6 +83,7 @@ regulator-name = "vdd_ldo7"; regulator-min-microvolt = <1800000>; regulator-max-microvolt = <1800000>; + regulator-ramp-delay = <12000>; regulator-always-on; }; @@ -85,6 +91,7 @@ regulator-name = "vdd_ldo8"; regulator-min-microvolt = <1800000>; regulator-max-microvolt = <1800000>; + regulator-ramp-delay = <12000>; regulator-always-on; }; @@ -92,6 +99,7 @@ regulator-name = "vdd_ldo9"; regulator-min-microvolt = <3000000>; regulator-max-microvolt = <3000000>; + regulator-ramp-delay = <12000>; regulator-always-on; }; @@ -99,6 +107,7 @@ regulator-name = "vdd_ldo10"; regulator-min-microvolt = <1800000>; regulator-max-microvolt = <1800000>; + regulator-ramp-delay = <12000>; regulator-always-on; }; @@ -106,6 +115,7 @@ regulator-name = "vdd_ldo11"; regulator-min-microvolt = <1000000>; regulator-max-microvolt = <1000000>; + regulator-ramp-delay = <12000>; regulator-always-on; }; @@ -113,6 +123,7 @@ regulator-name = "vdd_ldo12"; regulator-min-microvolt = <1800000>; regulator-max-microvolt = <1800000>; + regulator-ramp-delay = <12000>; regulator-always-on; }; @@ -120,12 +131,14 @@ regulator-name = "vddq_mmc2"; regulator-min-microvolt = <2800000>; regulator-max-microvolt = <2800000>; + regulator-ramp-delay = <12000>; }; ldo15_reg: LDO15 { regulator-name = "vdd_ldo15"; regulator-min-microvolt = <3300000>; regulator-max-microvolt = <3300000>; + regulator-ramp-delay = <12000>; regulator-always-on; }; @@ -133,6 +146,7 @@ regulator-name = "vdd_ldo16"; regulator-min-microvolt = <2200000>; regulator-max-microvolt = <2200000>; + regulator-ramp-delay = <12000>; regulator-always-on; }; @@ -140,6 +154,7 @@ regulator-name = "vdd_ldo17"; regulator-min-microvolt = <3300000>; regulator-max-microvolt = <3300000>; + regulator-ramp-delay = <12000>; regulator-always-on; }; @@ -147,18 +162,21 @@ regulator-name = "vdd_emmc_1V8"; regulator-min-microvolt = <1800000>; regulator-max-microvolt = <1800000>; + regulator-ramp-delay = <12000>; }; ldo19_reg: LDO19 { regulator-name = "vdd_sd"; regulator-min-microvolt = <2800000>; regulator-max-microvolt = <2800000>; + regulator-ramp-delay = <12000>; }; ldo24_reg: LDO24 { regulator-name = "tsp_io"; regulator-min-microvolt = <2800000>; regulator-max-microvolt = <2800000>; + regulator-ramp-delay = <12000>; regulator-always-on; }; @@ -166,6 +184,7 @@ regulator-name = "vdd_ldo26"; regulator-min-microvolt = <3000000>; regulator-max-microvolt = <3000000>; + regulator-ramp-delay = <12000>; regulator-always-on; };