From patchwork Fri Feb 8 12:21:12 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Wahren X-Patchwork-Id: 1038605 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=linux-gpio-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=i2se.com Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 43wvRv6z3pz9sBZ for ; Fri, 8 Feb 2019 23:21:31 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726568AbfBHMVb (ORCPT ); Fri, 8 Feb 2019 07:21:31 -0500 Received: from mout.kundenserver.de ([212.227.17.10]:45499 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726522AbfBHMVb (ORCPT ); Fri, 8 Feb 2019 07:21:31 -0500 Received: from localhost.localdomain ([37.4.249.100]) by mrelayeu.kundenserver.de (mreue106 [212.227.15.183]) with ESMTPSA (Nemesis) id 1MtwlO-1h6SH40ZTw-00uIBT; Fri, 08 Feb 2019 13:21:18 +0100 From: Stefan Wahren To: Linus Walleij , Bartosz Golaszewski , Eric Anholt Cc: Peter Robinson , Lukas Wunner , linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Stefan Wahren Subject: [PATCH RESEND V3 1/2] pinctrl: bcm2835: declare pin config as generic Date: Fri, 8 Feb 2019 13:21:12 +0100 Message-Id: <1549628473-4485-2-git-send-email-stefan.wahren@i2se.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1549628473-4485-1-git-send-email-stefan.wahren@i2se.com> References: <1549628473-4485-1-git-send-email-stefan.wahren@i2se.com> X-Provags-ID: V03:K1:aG6w6q9G2UXSjev252HYWUBp5SyLBtNod/NOmJbXrJaKjOlW6OU QdPYmRsUT76lx1WIdjJfLcN7a9TtW8oa/IBuY0IoD2Hk45Ekw393F4/rZx/AI5H5CpkFYGZ Zsv85Ndpdf/LnX7OxDnEk2VVr+NoJic3xVnxB1sMLKT2gK1UOgw8Yc54ZwPKwLWcERjhgHF m7R9NqzVAGeNPImzwqjTA== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1; V03:K0:8/LdylsVJZ8=:7rnOZWNUB/kX8CYvmrv4+x AoNWc8rfGjllbqltNFEKq5McydnQWL6FSc8shm+eFFI/HzYyzmG+t6nfPtnAuOgQyAyCAQJmn kwCabNJAp7P6aI6laFtgh65g9m5Bmn0bK4JcAJFylUYGmdSslZ6jbYwLS8Pq6Uq/j3/uNL0nS IgiInyIH5LZ2PJgF53TcCVEkjAOs9PrFgoDC2Xa6KLQty6W8FOMJT4MioV9x+bAOcKPG2JCmY FZt+rWPz6A+zAQsyx4fdrR5Yhtr/b5sSxZDFAqxe80Ezhzv3d3OxBAWz3JHN4OVel3+Li5lmj thZgmgPkf15c9MzJhhUTAEOV7j1PPJl2AOb1mtYsOxX93awygY2pjdmnLmILTTe4kSoL5DKtN kLnp1RMCkeJpoaBGqsmwO2Xk2xrbb9BvWtA9GzWVGZf6t8CkJK+3lz1RH7xyZMNRHujf55Jgn u5pJq/Va3NvVyYC2Txto2C5MZmkFvEwpXg9Jqqq9ZqS8NOL299pvnLgJW/wEjYX1JRnzvM2tn mCLvutmmDqUVZQMLRWwQHWjEavGqnTIGmSP8Mcw54rF7Eq9uM6zydFtTLM0shekBZn17sjyPP 1KDN/cxcXTEAnNrlb3F+M4PQRk7FqJ7wfhgwFc+ji13NQOdQknKkbuqMC7EzY76okAwYNKeit HC/d+DMVwW29aea/iy+0aV8DCL6hDsD0Ur9NDfJKe0O7z++c7cmFK4Wxx9Of4tWljp2hns+m0 EIfvCBDrmnLLv46JuV4C4P16KSWAd/tzHkwKCH3NrM3dRvjOIJ186Oj13e8= Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org Since commit 0de704955ee44 ("pinctrl: bcm2835: Add support for generic pinctrl binding") this driver is capable to use the generic interface. So declare this accordingly. Signed-off-by: Stefan Wahren --- drivers/pinctrl/bcm/pinctrl-bcm2835.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/pinctrl/bcm/pinctrl-bcm2835.c b/drivers/pinctrl/bcm/pinctrl-bcm2835.c index f180aa4..19eb4fd 100644 --- a/drivers/pinctrl/bcm/pinctrl-bcm2835.c +++ b/drivers/pinctrl/bcm/pinctrl-bcm2835.c @@ -969,6 +969,7 @@ static int bcm2835_pinconf_set(struct pinctrl_dev *pctldev, } static const struct pinconf_ops bcm2835_pinconf_ops = { + .is_generic = true, .pin_config_get = bcm2835_pinconf_get, .pin_config_set = bcm2835_pinconf_set, }; From patchwork Fri Feb 8 12:21:13 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Wahren X-Patchwork-Id: 1038607 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=linux-gpio-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=i2se.com Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 43wvRy2s5Nz9sBZ for ; Fri, 8 Feb 2019 23:21:34 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726585AbfBHMVc (ORCPT ); Fri, 8 Feb 2019 07:21:32 -0500 Received: from mout.kundenserver.de ([212.227.17.13]:51243 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726230AbfBHMVc (ORCPT ); Fri, 8 Feb 2019 07:21:32 -0500 Received: from localhost.localdomain ([37.4.249.100]) by mrelayeu.kundenserver.de (mreue106 [212.227.15.183]) with ESMTPSA (Nemesis) id 1MFbiK-1gtgdU1rYs-00H7fx; Fri, 08 Feb 2019 13:21:18 +0100 From: Stefan Wahren To: Linus Walleij , Bartosz Golaszewski , Eric Anholt Cc: Peter Robinson , Lukas Wunner , linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Stefan Wahren Subject: [PATCH RESEND V3 2/2] pinctrl: bcm2835: Direct GPIO config changes to generic pinctrl Date: Fri, 8 Feb 2019 13:21:13 +0100 Message-Id: <1549628473-4485-3-git-send-email-stefan.wahren@i2se.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1549628473-4485-1-git-send-email-stefan.wahren@i2se.com> References: <1549628473-4485-1-git-send-email-stefan.wahren@i2se.com> X-Provags-ID: V03:K1:RhGv0flQUBQtEYAjfa5Ht7rZVZ/VHte+tz3fXU85yPSKsmvNuns dge3M6MlxlY2Lmr3p8rxZlUEBI8pn3kQuv3XNtxwpnjldeTPV3s8MMu68Ewo9SxM7CtjKom yWoe30XsIfCFT77j0bidgyxjaOaD4jnx85+1r3/aIaZlOzOnMc4/YJi0wtMuUF1QahnHwxF JUZPrqF4GL+1eLXmWuoiw== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1; V03:K0:HI/CnvdLlE0=:OomwtQh3nS7myJf3Iuexxn ewwbg+YpEONFRpAbXCO8HJryD7I5j4FDUuBRmGn4Yps9FDMeVAatjrm6Iz81CLwdaCkg7t0g4 OLMyxqHrRa0wLV9lfy60BqG74+PIr6/rg+xcztxaCDETaGsV8dC+fuFKUQsRCeXvN470C8fqR 6a07yPit9Ts397ob4r0fHx59eqq97Ipse0NfpwtzKVPsWW3aVRJuTylFOmGsRRPQkaZxG/3pD 8V34u9cvT8Xkw2eUUDzho1LIox9Eq71GMSrYRYl6+IJKED6deumSLEmjuZsGMTddtjZa0RMfC cVQaiNOdVOtKvE3CmZRwy+gldtjiRJUpb6jlVeUBFHFUgnt6AUbSy1lpopC8bV3GLR5UiHhb9 5m85w+I72A+ZIellIEVc8SJj4xe1nmc1Q++ENra+VOEPfICPHyTvOm8+89l96pjQvcH0JIDTU +Mq95+fstMAzoIqs/a4Y1W2CFnL+8OTeg/9Fj/HeRDUEOWjm1aMZbkAzizQsPQPHWv0+XJbjY aOaodcYrJhYRP5TEat6jXj+emd1KnXnB9V41J7N6sb2GbHtQ0wPNHiUhFudGRBy17GOMOWY+q TpjfoZwZkGcWxUbtpidcWkpLXAJF5T2va6BoIHT8P8krDMBijCtsoyOAALM5xgdcyr8axndmf r0/XzD3ivMEaCjRYF9AUgXvnHOoCd6xwyrc4W8n/4+Lbvse9b3ljt27bPMtWcT4q0C9M2DQ5q Ze72QPbD/FZD/lkMHppuSPBaC4pP6zsvi3zDfuOiXjWBxcf4xMOUscuVpAY= Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org In order to support GPIO config changes direct these to the generic pinctrl. This also requires an adjust of the return code for unsupported parameter otherwise gpiod_configure_flags wont work as expected. Signed-off-by: Stefan Wahren --- drivers/pinctrl/bcm/pinctrl-bcm2835.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/pinctrl/bcm/pinctrl-bcm2835.c b/drivers/pinctrl/bcm/pinctrl-bcm2835.c index 19eb4fd..183d1ff 100644 --- a/drivers/pinctrl/bcm/pinctrl-bcm2835.c +++ b/drivers/pinctrl/bcm/pinctrl-bcm2835.c @@ -341,6 +341,7 @@ static const struct gpio_chip bcm2835_gpio_chip = { .get_direction = bcm2835_gpio_get_direction, .get = bcm2835_gpio_get, .set = bcm2835_gpio_set, + .set_config = gpiochip_generic_config, .base = -1, .ngpio = BCM2835_NUM_GPIOS, .can_sleep = false, @@ -960,7 +961,7 @@ static int bcm2835_pinconf_set(struct pinctrl_dev *pctldev, break; default: - return -EINVAL; + return -ENOTSUPP; } /* switch param type */ } /* for each config */