From patchwork Thu Feb 7 20:38:04 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tokunori Ikegami X-Patchwork-Id: 1038346 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=lists.openwrt.org (client-ip=2607:7c80:54:e::133; helo=bombadil.infradead.org; envelope-from=openwrt-devel-bounces+incoming=patchwork.ozlabs.org@lists.openwrt.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=yahoo.co.jp Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="tJfFsmt6"; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=yahoo.co.jp header.i=@yahoo.co.jp header.b="iPR2+fVb"; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 43wVX44HYjz9sML for ; Fri, 8 Feb 2019 07:38:44 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Subject:References: In-Reply-To:Message-Id:Date:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=LqdBL/bzGmQXmtxRqzf1H67f9yR52TOXTauM/ppKwjs=; b=tJfFsmt6yPisDJ z4Q5AhNVjG4KT0ng7bJaah3tAc1G9n58vfu1bmBYo3Lfm4r92wHtyqBWO0atRRAJWsq39AGy4fwtF xle0zzrlA7w3gKWbi8ujP/OM5NS20uDsV49Zfw0equJKsGreNmXEgd1QZeD1mD53Qr24lHNPAtTQF Y2xbdi5pVTPKSnSXW54NTbfxD5dlvKMjxrfwYf/hGB0hELKpnwTAofUr5fFgNHZuRedRd6NJKPO+1 Wxc7JcdFEQPxPwYAnoUwp2Tla/3jM7XSnEpFjTieHRRHwBmMq7vEZEv2O9ENRbfimUNuHBf6ILjoM 2Ugf0vAbrD+xrPL80V9g==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1grqRH-0002R7-5m; Thu, 07 Feb 2019 20:38:27 +0000 Received: from nh504-vm4.bullet.mail.kks.yahoo.co.jp ([183.79.57.90]) by bombadil.infradead.org with smtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1grqRD-0002QD-GP for openwrt-devel@lists.openwrt.org; Thu, 07 Feb 2019 20:38:25 +0000 Received: from [183.79.100.138] by nh504.bullet.mail.kks.yahoo.co.jp with NNFMP; 07 Feb 2019 20:38:15 -0000 Received: from [183.79.100.137] by t501.bullet.mail.kks.yahoo.co.jp with NNFMP; 07 Feb 2019 20:38:15 -0000 Received: from [127.0.0.1] by omp506.mail.kks.yahoo.co.jp with NNFMP; 07 Feb 2019 20:38:15 -0000 X-Yahoo-Newman-Property: ymail-3 X-Yahoo-Newman-Id: 701908.40514.bm@omp506.mail.kks.yahoo.co.jp Received: (qmail 769 invoked by alias); 7 Feb 2019 20:38:15 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.co.jp; s=yj20110701; t=1549571895; bh=F7XJuWxbhH2wzJZq62fz46SZe6fJ9myVGmMJtfCWNXo=; h=Received:X-YMail-JAS:X-Apparently-From:X-YMail-OSG:From:To:Cc:Subject:Date:Message-Id:X-Mailer:In-Reply-To:References; b=iPR2+fVbbXaBiMyODncO7dsD0jY8J8x2slkP4QCPa7zTCbFMjG75Xd3GGvc62OG7OclWSlxeYRGUjnrQSG3biAFG6DGTpKNGOtoPeOpXzpxD5YLR+AzoFt1DPRAWndHqRqg3XUb0TQI3Nz8uDXfWb6r5RZ0Bxyh6qLji8WLurZQ= DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=yj20110701; d=yahoo.co.jp; h=Received:X-YMail-JAS:X-Apparently-From:X-YMail-OSG:From:To:Cc:Subject:Date:Message-Id:X-Mailer:In-Reply-To:References; b=Ve7ilGa/7V4NPoI/UyACQkbzEvl0CuJTT2uEiI3uf288RvFUjc3GxFpsTFMQ3EHMRG3mHuFCBWGmsFrfVRMJJiqKSDzWgUBUH72TCy33O0I/fV/NnbqXXfU8QW5tSckdbGNPM0VeDxRzslIzQzsItK6kaz2+DZolYNui/bWadvY= ; Received: from unknown (HELO localhost.localdomain) (106.72.39.32 with login) by smtp5001.mail.kks.ynwp.yahoo.co.jp with SMTP; 7 Feb 2019 20:38:15 -0000 X-YMail-JAS: O_ltnQ0VM1m3SgKBoHUakWg5AoPQZS66BihTDFhFNsVTC_plgO067xqOy6u8B_dtE_c0MTfE6H_AdPDTYTzFnMe0u10tjVzsyDOUsiCGIeUxGThWVk06w2nD0YKP2Kv6NYrD8sSazg-- X-Apparently-From: X-YMail-OSG: LP.nA7sVM1mLG4keTux.TkTC4glYvmGZbfPZiY9TyhUaVTZ mfzD7jsFh0av4FoRV1yx0A8jcdmGP_fbisQezrWxjIIXTjq17Thwm84fREjo HPKr.ROd7wxvcjhLnpnm4.hvbATq8qDq__XVPuqo3Hrq4xFIbEhOeTaRETxJ .qsY0I9Djz95CR_LLBtyOCIxCdN8VEYBwoUlK83n8.YAob6iE6b1ltP0J_L4 zybTHZD_kw4k5zAHT4CbcJMVKsaDoXh0n0JBujRc_6Fn.ltG2qtzEto8znMl pr5MaKwYvAcGiEU7sFkc4BZaiTscTnnAvIubqt_TKb4dMNLV4i.CN8UClqQB RxUKfXDzM2Hsz6e_tgfi.2S0rMyv_g2plLUORfok5vV9p4MSgT_Gz2c_U6cl FC1VuprzeZulKSdMWJ0riXkdTNBteA9zD_S0gRgQX.VyhgPPBTRm.1nVv9Ej 5quEY7i2QnOXnOi9doAikQEcYg.o9WOOrSvGObv2EzUJW0FFiPZquWTFddpI S1XF0KD214ymhzJ2IEhDXj1SN7LrVeo3OjG8JRzCS7lEXdOyK_QYdOa2Y8LT UDRaqN2.QoVBLLqzsTGU1CHEr4zutbGAq_w5ncOaKevMqjg-- From: Tokunori Ikegami To: Koen Vandeputte Date: Fri, 8 Feb 2019 05:38:04 +0900 Message-Id: <20190207203804.18210-2-ikegami_to@yahoo.co.jp> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20190207203804.18210-1-ikegami_to@yahoo.co.jp> References: <20190207203804.18210-1-ikegami_to@yahoo.co.jp> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190207_123823_921145_627DD021 X-CRM114-Status: UNSURE ( 9.85 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.2 on bombadil.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [183.79.57.90 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (ikegami_to[at]yahoo.co.jp) -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature Subject: [OpenWrt-Devel] [PATCH v2 1/1] ar71xx: Remove mtd cfi_cmdset_0002 force word write patch X-BeenThere: openwrt-devel@lists.openwrt.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tokunori Ikegami , openwrt-devel@lists.openwrt.org, Felix Fietkau MIME-Version: 1.0 Sender: "openwrt-devel" Errors-To: openwrt-devel-bounces+incoming=patchwork.ozlabs.org@lists.openwrt.org Currently the buffer write works as same with word write correctly. So it looks that it is not necessary to force word write. Also the write performance will be improved by the change to buffer write. Signed-off-by: Tokunori Ikegami Cc: Felix Fietkau Cc: openwrt-devel@lists.openwrt.org --- .../411-mtd-cfi_cmdset_0002-force-word-write.patch | 61 ---------------------- 1 file changed, 61 deletions(-) delete mode 100644 target/linux/ar71xx/patches-4.14/411-mtd-cfi_cmdset_0002-force-word-write.patch diff --git a/target/linux/ar71xx/patches-4.14/411-mtd-cfi_cmdset_0002-force-word-write.patch b/target/linux/ar71xx/patches-4.14/411-mtd-cfi_cmdset_0002-force-word-write.patch deleted file mode 100644 index 3862dfd14b..0000000000 --- a/target/linux/ar71xx/patches-4.14/411-mtd-cfi_cmdset_0002-force-word-write.patch +++ /dev/null @@ -1,61 +0,0 @@ ---- a/drivers/mtd/chips/cfi_cmdset_0002.c -+++ b/drivers/mtd/chips/cfi_cmdset_0002.c -@@ -40,7 +40,7 @@ - #include - - #define AMD_BOOTLOC_BUG --#define FORCE_WORD_WRITE 0 -+#define FORCE_WORD_WRITE 1 - - #define MAX_RETRIES 3 - -@@ -51,7 +51,9 @@ - - static int cfi_amdstd_read (struct mtd_info *, loff_t, size_t, size_t *, u_char *); - static int cfi_amdstd_write_words(struct mtd_info *, loff_t, size_t, size_t *, const u_char *); -+#if !FORCE_WORD_WRITE - static int cfi_amdstd_write_buffers(struct mtd_info *, loff_t, size_t, size_t *, const u_char *); -+#endif - static int cfi_amdstd_erase_chip(struct mtd_info *, struct erase_info *); - static int cfi_amdstd_erase_varsize(struct mtd_info *, struct erase_info *); - static void cfi_amdstd_sync (struct mtd_info *); -@@ -202,6 +204,7 @@ static void fixup_amd_bootblock(struct m - } - #endif - -+#if !FORCE_WORD_WRITE - static void fixup_use_write_buffers(struct mtd_info *mtd) - { - struct map_info *map = mtd->priv; -@@ -211,6 +214,7 @@ static void fixup_use_write_buffers(stru - mtd->_write = cfi_amdstd_write_buffers; - } - } -+#endif /* !FORCE_WORD_WRITE */ - - /* Atmel chips don't use the same PRI format as AMD chips */ - static void fixup_convert_atmel_pri(struct mtd_info *mtd) -@@ -1794,6 +1798,7 @@ static int cfi_amdstd_write_words(struct - /* - * FIXME: interleaved mode not tested, and probably not supported! - */ -+#if !FORCE_WORD_WRITE - static int __xipram do_write_buffer(struct map_info *map, struct flchip *chip, - unsigned long adr, const u_char *buf, - int len) -@@ -1922,7 +1927,6 @@ static int __xipram do_write_buffer(stru - return ret; - } - -- - static int cfi_amdstd_write_buffers(struct mtd_info *mtd, loff_t to, size_t len, - size_t *retlen, const u_char *buf) - { -@@ -1997,6 +2001,7 @@ static int cfi_amdstd_write_buffers(stru - - return 0; - } -+#endif /* !FORCE_WORD_WRITE */ - - /* - * Wait for the flash chip to become ready to write data