From patchwork Mon Feb 4 15:28:20 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jakub Kicinski X-Patchwork-Id: 1036007 X-Patchwork-Delegate: dsahern@gmail.com Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=netronome.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=netronome-com.20150623.gappssmtp.com header.i=@netronome-com.20150623.gappssmtp.com header.b="s9UG1gRN"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 43tWnW4VnSz9s6w for ; Tue, 5 Feb 2019 02:28:31 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729749AbfBDP23 (ORCPT ); Mon, 4 Feb 2019 10:28:29 -0500 Received: from mail-qt1-f193.google.com ([209.85.160.193]:40820 "EHLO mail-qt1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727571AbfBDP23 (ORCPT ); Mon, 4 Feb 2019 10:28:29 -0500 Received: by mail-qt1-f193.google.com with SMTP id k12so262960qtf.7 for ; Mon, 04 Feb 2019 07:28:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netronome-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=FjGSzvKKBaeimbWsBF08/J8VydCZXzGqmyETleCzeSw=; b=s9UG1gRNLlVJkWzPNGNB7LUe7nQzglZyHRmnT8zhAdSaRmf5oxQgrvdSklPtVaWL9R p2A1znJyXjIzqAHpxGLsGBbwtg6C/0eIu980x3+eLEQ23JPTfzGWrRPewz+jAbKkOsC2 Km7y8M9gSHr7To6Ikb2hT5vcpStFdcJUtJFepI6wPzlOBBLgjlPFZ5gEHqEe4858G3NX f39T1x378/4Caas2Kkis42I7sUk1P1QW+G1wF5lkTKwxHJyXOPUnY0UhV8m6oAtwhKel Qx36KR3+FpkbvURNMO0FeROlSaxoYPNr8gP6Y83/YCzcWZs7Ax33wL1+5E/N69CSY9Zn RVew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=FjGSzvKKBaeimbWsBF08/J8VydCZXzGqmyETleCzeSw=; b=mXazFtL5Mh6exgD4Jkr585FlSwCjYOdsgF6hyFN1s7q5nx3hKrfMhMWFw/fQESNqJy D1zCRr+YiH7wYXuSZaIEL8w/asVFjpKfS6bDj5oOBcDM7B3avNrV+6s1D6gQya2elRb7 m5HXZdMoJo7OarXmDTMJ436vQYc9Zu9ZLCMFAJM+/6KuZODeL0QydxezYYGDKq1zgL7Q x3s4JFXMQT9Tier+pzEeB5yL7cJr0a/WerYMDrDrd4yPqCzr05wox7c81434zNZsOSi0 fdhom6Ao0IJCM+4QW0TfNkpTaDTVE3g5/VmCI70rlfxYzbqFoEspGNq7ALY39yPWDa4d K5wQ== X-Gm-Message-State: AJcUukcSb3lkYpBG0saS+JYxXI977DwrhBXw2eSNjEfgdRJJPdPVWQQn PD9/eqx/xoaePRn3bvKC6VrvkA== X-Google-Smtp-Source: ALg8bN7TyzLfPuI8K7R2dBfHgHBht0rIsSTGZy/rB4YKHtsrNa6rjk0Kv4Eut0MW/yhpTJj5MbXIeg== X-Received: by 2002:a0c:91e8:: with SMTP id r37mr47529161qvr.141.1549294108187; Mon, 04 Feb 2019 07:28:28 -0800 (PST) Received: from jkicinski-Precision-T1700.netronome.com ([66.60.152.14]) by smtp.gmail.com with ESMTPSA id w34sm4256775qtb.23.2019.02.04.07.28.26 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 04 Feb 2019 07:28:27 -0800 (PST) From: Jakub Kicinski To: jiri@resnulli.us, dsahern@gmail.com Cc: stephen@networkplumber.org, netdev@vger.kernel.org, oss-drivers@netronome.com, Jakub Kicinski Subject: [PATCH iproute2-next v4] devlink: add info subcommand Date: Mon, 4 Feb 2019 07:28:20 -0800 Message-Id: <20190204152820.6607-1-jakub.kicinski@netronome.com> X-Mailer: git-send-email 2.19.2 MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Add support for reading the device serial number, driver name and various versions. Example: $ devlink dev info pci/0000:82:00.0 pci/0000:82:00.0: driver nfp serial_number 16240145 versions: fixed: board.id AMDA0081-0001 board.rev 15 board.vendor SMA board.model hydrogen running: fw.mgmt 010181.010181.0101d4 fw.cpld 0x1030000 fw.app abm-d372b6 fw.undi 0.0.2 chip.init AMDA-0081-0001 20160318164536 stored: fw.mgmt 010181.010181.0101d4 fw.app abm-d372b6 fw.undi 0.0.2 chip.init AMDA-0081-0001 20160318164536 $ devlink -jp dev info pci/0000:82:00.0 { "info": { "pci/0000:82:00.0": { "driver": "nfp", "serial_number": "16240145", "versions": { "fixed": { "board.id": "AMDA0081-0001", "board.rev": "15", "board.vendor": "SMA", "board.model": "hydrogen" }, "running": { "fw.mgmt": "010181.010181.0101d4", "fw.cpld": "0x1030000", "fw.app": "abm-d372b6", "fw.undi": "0.0.2", "chip.init": "AMDA-0081-0001 20160318164536" }, "stored": { "fw.mgmt": "010181.010181.0101d4", "fw.app": "abm-d372b6", "fw.undi": "0.0.2", "chip.init": "AMDA-0081-0001 20160318164536" } } } } } v4: - more commit message improvements. v3: - show up-to-date output in the commit message. v2 (Jiri): - remove filtering; - add example in the commit message. RFCv2: - make info subcommand of dev. Signed-off-by: Jakub Kicinski --- devlink/devlink.c | 169 +++++++++++++++++++++++++++++++++++++++++ man/man8/devlink-dev.8 | 26 +++++++ 2 files changed, 195 insertions(+) diff --git a/devlink/devlink.c b/devlink/devlink.c index 3651e90c1159..fc4b18d1b613 100644 --- a/devlink/devlink.c +++ b/devlink/devlink.c @@ -383,6 +383,13 @@ static const enum mnl_attr_data_type devlink_policy[DEVLINK_ATTR_MAX + 1] = { [DEVLINK_ATTR_REGION_CHUNK_DATA] = MNL_TYPE_BINARY, [DEVLINK_ATTR_REGION_CHUNK_ADDR] = MNL_TYPE_U64, [DEVLINK_ATTR_REGION_CHUNK_LEN] = MNL_TYPE_U64, + [DEVLINK_ATTR_INFO_DRIVER_NAME] = MNL_TYPE_STRING, + [DEVLINK_ATTR_INFO_SERIAL_NUMBER] = MNL_TYPE_STRING, + [DEVLINK_ATTR_INFO_VERSION_FIXED] = MNL_TYPE_NESTED, + [DEVLINK_ATTR_INFO_VERSION_RUNNING] = MNL_TYPE_NESTED, + [DEVLINK_ATTR_INFO_VERSION_STORED] = MNL_TYPE_NESTED, + [DEVLINK_ATTR_INFO_VERSION_NAME] = MNL_TYPE_STRING, + [DEVLINK_ATTR_INFO_VERSION_VALUE] = MNL_TYPE_STRING, }; static int attr_cb(const struct nlattr *attr, void *data) @@ -1443,6 +1450,7 @@ static void cmd_dev_help(void) pr_err(" devlink dev param set DEV name PARAMETER value VALUE cmode { permanent | driverinit | runtime }\n"); pr_err(" devlink dev param show [DEV name PARAMETER]\n"); pr_err(" devlink dev reload DEV\n"); + pr_err(" devlink dev info [ DEV ]\n"); } static bool cmp_arr_last_handle(struct dl *dl, const char *bus_name, @@ -1775,6 +1783,30 @@ static void pr_out_array_end(struct dl *dl) } } +static void pr_out_object_start(struct dl *dl, const char *name) +{ + if (dl->json_output) { + jsonw_name(dl->jw, name); + jsonw_start_object(dl->jw); + } else { + __pr_out_indent_inc(); + __pr_out_newline(); + pr_out("%s:", name); + __pr_out_indent_inc(); + __pr_out_newline(); + } +} + +static void pr_out_object_end(struct dl *dl) +{ + if (dl->json_output) { + jsonw_end_object(dl->jw); + } else { + __pr_out_indent_dec(); + __pr_out_indent_dec(); + } +} + static void pr_out_entry_start(struct dl *dl) { if (dl->json_output) @@ -2415,6 +2447,140 @@ static int cmd_dev_reload(struct dl *dl) return _mnlg_socket_sndrcv(dl->nlg, nlh, NULL, NULL); } +static void pr_out_versions_single(struct dl *dl, const struct nlmsghdr *nlh, + const char *name, int type) +{ + struct nlattr *version; + + mnl_attr_for_each(version, nlh, sizeof(struct genlmsghdr)) { + struct nlattr *tb[DEVLINK_ATTR_MAX + 1] = {}; + const char *ver_value; + const char *ver_name; + int err; + + if (mnl_attr_get_type(version) != type) + continue; + + err = mnl_attr_parse_nested(version, attr_cb, tb); + if (err != MNL_CB_OK) + continue; + + if (!tb[DEVLINK_ATTR_INFO_VERSION_NAME] || + !tb[DEVLINK_ATTR_INFO_VERSION_VALUE]) + continue; + + if (name) { + pr_out_object_start(dl, name); + name = NULL; + } + + ver_name = mnl_attr_get_str(tb[DEVLINK_ATTR_INFO_VERSION_NAME]); + ver_value = mnl_attr_get_str(tb[DEVLINK_ATTR_INFO_VERSION_VALUE]); + + pr_out_str(dl, ver_name, ver_value); + if (!dl->json_output) + __pr_out_newline(); + } + + if (!name) + pr_out_object_end(dl); +} + +static void pr_out_info(struct dl *dl, const struct nlmsghdr *nlh, + struct nlattr **tb, bool has_versions) +{ + __pr_out_handle_start(dl, tb, true, false); + + __pr_out_indent_inc(); + if (tb[DEVLINK_ATTR_INFO_DRIVER_NAME]) { + struct nlattr *nla_drv = tb[DEVLINK_ATTR_INFO_DRIVER_NAME]; + + __pr_out_newline(); + pr_out_str(dl, "driver", mnl_attr_get_str(nla_drv)); + } + + if (tb[DEVLINK_ATTR_INFO_SERIAL_NUMBER]) { + struct nlattr *nla_sn = tb[DEVLINK_ATTR_INFO_SERIAL_NUMBER]; + + __pr_out_newline(); + pr_out_str(dl, "serial_number", mnl_attr_get_str(nla_sn)); + } + __pr_out_indent_dec(); + + if (has_versions) { + pr_out_object_start(dl, "versions"); + + pr_out_versions_single(dl, nlh, "fixed", + DEVLINK_ATTR_INFO_VERSION_FIXED); + pr_out_versions_single(dl, nlh, "running", + DEVLINK_ATTR_INFO_VERSION_RUNNING); + pr_out_versions_single(dl, nlh, "stored", + DEVLINK_ATTR_INFO_VERSION_STORED); + + pr_out_object_end(dl); + } + + pr_out_handle_end(dl); +} + +static int cmd_versions_show_cb(const struct nlmsghdr *nlh, void *data) +{ + struct genlmsghdr *genl = mnl_nlmsg_get_payload(nlh); + struct nlattr *tb[DEVLINK_ATTR_MAX + 1] = {}; + bool has_versions, has_info; + struct dl *dl = data; + + mnl_attr_parse(nlh, sizeof(*genl), attr_cb, tb); + + if (!tb[DEVLINK_ATTR_BUS_NAME] || !tb[DEVLINK_ATTR_DEV_NAME]) + return MNL_CB_ERROR; + + has_versions = tb[DEVLINK_ATTR_INFO_VERSION_FIXED] || + tb[DEVLINK_ATTR_INFO_VERSION_RUNNING] || + tb[DEVLINK_ATTR_INFO_VERSION_STORED]; + has_info = tb[DEVLINK_ATTR_INFO_DRIVER_NAME] || + tb[DEVLINK_ATTR_INFO_SERIAL_NUMBER] || + has_versions; + + if (has_info) + pr_out_info(dl, nlh, tb, has_versions); + + return MNL_CB_OK; +} + +static void cmd_dev_info_help(void) +{ + pr_err("Usage: devlink dev info [ DEV ]\n"); +} + +static int cmd_dev_info(struct dl *dl) +{ + struct nlmsghdr *nlh; + uint16_t flags = NLM_F_REQUEST | NLM_F_ACK; + int err; + + if (dl_argv_match(dl, "help")) { + cmd_dev_info_help(); + return 0; + } + + if (dl_argc(dl) == 0) + flags |= NLM_F_DUMP; + + nlh = mnlg_msg_prepare(dl->nlg, DEVLINK_CMD_INFO_GET, flags); + + if (dl_argc(dl) > 0) { + err = dl_argv_parse_put(nlh, dl, DL_OPT_HANDLE, 0); + if (err) + return err; + } + + pr_out_section_start(dl, "info"); + err = _mnlg_socket_sndrcv(dl->nlg, nlh, cmd_versions_show_cb, dl); + pr_out_section_end(dl); + return err; +} + static int cmd_dev(struct dl *dl) { if (dl_argv_match(dl, "help")) { @@ -2433,6 +2599,9 @@ static int cmd_dev(struct dl *dl) } else if (dl_argv_match(dl, "param")) { dl_arg_inc(dl); return cmd_dev_param(dl); + } else if (dl_argv_match(dl, "info")) { + dl_arg_inc(dl); + return cmd_dev_info(dl); } pr_err("Command \"%s\" not found\n", dl_argv(dl)); return -ENOENT; diff --git a/man/man8/devlink-dev.8 b/man/man8/devlink-dev.8 index d985da172aa0..47838371fecd 100644 --- a/man/man8/devlink-dev.8 +++ b/man/man8/devlink-dev.8 @@ -63,6 +63,12 @@ devlink-dev \- devlink device configuration .BR "devlink dev reload" .IR DEV +.ti -8 +.BR "devlink dev info" +.RI "[ " +.IR DEV +.RI "]" + .SH "DESCRIPTION" .SS devlink dev show - display devlink device attributes @@ -151,6 +157,26 @@ If this argument is omitted all parameters supported by devlink devices are list .I "DEV" - Specifies the devlink device to reload. +.SS devlink dev info - display device information. +Display device information provided by the driver. This command can be used +to query versions of the hardware components or device components which +can't be updated ( +.I fixed +) as well as device firmware which can be updated. For firmware components +.I running +displays the versions of firmware currently loaded into the device, while +.I stored +reports the versions in device's flash. +.I Running +and +.I stored +versions may differ after flash has been updated, but before reboot. + +.PP +.I "DEV" +- specifies the devlink device to show. +If this argument is omitted all devices are listed. + .SH "EXAMPLES" .PP devlink dev show