From patchwork Wed Jan 30 08:59:54 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Catherine Ho X-Patchwork-Id: 1033556 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="QHhc0X/n"; dkim-atps=neutral Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 43qPpP2SZpz9sBZ for ; Thu, 31 Jan 2019 00:48:29 +1100 (AEDT) Received: from localhost ([127.0.0.1]:38553 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1goqE7-0004HH-0E for incoming@patchwork.ozlabs.org; Wed, 30 Jan 2019 08:48:27 -0500 Received: from eggs.gnu.org ([209.51.188.92]:33177) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1golms-00086o-DX for qemu-devel@nongnu.org; Wed, 30 Jan 2019 04:04:05 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1golml-0000BA-Pq for qemu-devel@nongnu.org; Wed, 30 Jan 2019 04:04:02 -0500 Received: from mail-pf1-x444.google.com ([2607:f8b0:4864:20::444]:43637) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1golml-0000AU-Hz for qemu-devel@nongnu.org; Wed, 30 Jan 2019 04:03:55 -0500 Received: by mail-pf1-x444.google.com with SMTP id w73so11109901pfk.10 for ; Wed, 30 Jan 2019 01:03:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=vHCEIgYnNxdFaQKiaBdqmRi9VvP1ZmFlqdxdwE9xxQQ=; b=QHhc0X/n+TvX/jfP/Xx23TNWAvaa9nqhMC/2MwnD3YRLRFbOFicV2/9UwgJptmm3k8 5Qj6Vp8/KuTb55AM4vgaEEl1S8pqcaaHG3iMbDu46j2SVn10G2UmRlbGryDw9cqDN4Nj h2O+Ws0XRwl5oXKYEbWTsjM+LuOEAFEmIU+uD2SBwaCgrX5+GLej9kVQX1k/mUTJh9Fp kAlLsd9FXUxGwbUImoEN8IxXTkd+A1oaEHcZLCe8INT40ukKi/8+iDQv6YthK6M5FL3u sUY08Qo/aTH+jPpm0VdnK3pIX7y/gUIIOiZfP/k0rRqWiTXrPfY9y5wkUPsjsPLqdsNx Nf9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=vHCEIgYnNxdFaQKiaBdqmRi9VvP1ZmFlqdxdwE9xxQQ=; b=hrjcC8rLP8cEKRhuxcZUDhlMUfgzsJKI7Y9rAHjZEBvwixo+xgTb/9wv43OKTGGjAv kkt4oigjl/ame6/3rJKTaPvmoPyHZDLtYWfM1UfKKZ1OfdqhXZYd6MJbAXqbjHuFLxG+ ssS2tF/9tkuWakIdDZAaYZm2ixfMXkvD6h6+2W/UECR+LdSjG4tCNYYNjxL67Hh1qK1U esFPYIebWzNAOpUp4ak2Sfvc03Uo984n7QwL5hXq/WuYaVpWPM/GW1rPesi2rTCryxuW S0S/aUxvxhsEjEXanWDmlYeIhqVJqWCsKszqwg42NgMEoHzgkSAC8nchaCHBTx3PLHlO 6gGQ== X-Gm-Message-State: AJcUukcmM/PpPIVGyobwwONJtiKmS8mJcdEVPURbWwvtstU8A3MGUDzB oqUxvUPi+zMhmoTNfstG1+k= X-Google-Smtp-Source: ALg8bN5C9t4G8bcKrcYLJgLNCsWBo3pjKSG6sRkhjGTi1w0XO6/6QQ6jMzvsy+tK0gm4sJNYjDSM4A== X-Received: by 2002:a63:ac1a:: with SMTP id v26mr27210055pge.293.1548839033881; Wed, 30 Jan 2019 01:03:53 -0800 (PST) Received: from host.localdomain (96.45.178.72.16clouds.com. [96.45.178.72]) by smtp.gmail.com with ESMTPSA id r80sm2057502pfa.111.2019.01.30.01.03.52 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 30 Jan 2019 01:03:52 -0800 (PST) From: Catherine Ho To: Richard Henderson , "Emilio G. Cota" Date: Wed, 30 Jan 2019 03:59:54 -0500 Message-Id: <1548838794-23757-1-git-send-email-catherine.hecx@gmail.com> X-Mailer: git-send-email 1.7.1 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::444 X-Mailman-Approved-At: Wed, 30 Jan 2019 08:47:20 -0500 Subject: [Qemu-devel] [PATCH] tcg: add early clober modifier in atomic16_cmpxchg on aarch64 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-devel@nongnu.org, Catherine Ho Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" Without this patch, gcc might up the Input/Output registers and cause unpredictable error. Fixes: 1ec182c33379 ("target/arm: Convert to HAVE_CMPXCHG128") Signed-off-by: Catherine Ho --- include/qemu/atomic128.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/qemu/atomic128.h b/include/qemu/atomic128.h index a6af22ff10..ddd0d55d31 100644 --- a/include/qemu/atomic128.h +++ b/include/qemu/atomic128.h @@ -68,7 +68,7 @@ static inline Int128 atomic16_cmpxchg(Int128 *ptr, Int128 cmp, Int128 new) "cbnz %w[tmp], 0b\n" "1:" : [mem] "+m"(*ptr), [tmp] "=&r"(tmp), - [oldl] "=&r"(oldl), [oldh] "=r"(oldh) + [oldl] "=&r"(oldl), [oldh] "=&r"(oldh) : [cmpl] "r"(cmpl), [cmph] "r"(cmph), [newl] "r"(newl), [newh] "r"(newh) : "memory", "cc");