From patchwork Sat Jan 19 09:00:26 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sam Ravnborg X-Patchwork-Id: 1027893 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=linux-rtc-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=ravnborg.org Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="MViwAQh/"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 43hWyf40B2z9sBn for ; Sat, 19 Jan 2019 20:01:46 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727710AbfASJBF (ORCPT ); Sat, 19 Jan 2019 04:01:05 -0500 Received: from mail-lf1-f67.google.com ([209.85.167.67]:42222 "EHLO mail-lf1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725910AbfASJBF (ORCPT ); Sat, 19 Jan 2019 04:01:05 -0500 Received: by mail-lf1-f67.google.com with SMTP id l10so12180584lfh.9; Sat, 19 Jan 2019 01:01:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=O6Cnu+m+ozyRU5A39kDFMLt2HxoGeNZAQCbCcxf5biY=; b=MViwAQh/6eA/Mg54qq3L+V9EpSw6021BNFbuAOw2TuxXLJJODcWMRptPuzG6Xprinb ox4DSVDR04RCyV8mouWRkwh0VXMbDH0wmv+ZThvnRNF6G+Xbrg7FRKBIxWS2RpPEX7LI 5KIquE0hkbtu0PC+cZtvpL27TqkHmRQ5jJgpHUt48PJ5Vmml3q0xeE+9byr6BA+P/tV8 BGwojQ5ZRFemBIsoEDY6xH8XQbt5aTvbkH0lh3x1r0cYnbj2Og3FG+u3nVeB6rIlpL1z P7ul9+LR1mT2uVzW6lwxU9G9UQlqe09N7zKdh7Tofmtjlxs+BI5OqFeFKcjAIikuGqBf 3YZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=O6Cnu+m+ozyRU5A39kDFMLt2HxoGeNZAQCbCcxf5biY=; b=XrbktLzBAaLeDYg27L9+lGWhdqhpl4PuPeHXQ7ybZfEIDXnK/j6G1tOpKo0bQcH0l1 4Gzo1ujElotINUPIoNU1OY+v6tC4wtob0bbb1yw/+Xf6uWZ4ZIdN4V/KfMD+pHCZsI+6 q7aeKe8W2+iNnLbP7JvRFxsy7E1ftIK5KBQ5RKro0qFoklTx+fivSE4AqflWg6HbZfeX HB0uNioBpUmOHbbz9ooDgfj7iS31X2PKmv+wY36D6Syktu5ErfscB4/hbnOtFvf6XOyg g66UKtP0GseryzcvDueQNTSsFY37QAIP52rvN5W4Dq/4uyjAnCvVvQoQiMdtcsh2eslP K0cQ== X-Gm-Message-State: AJcUukc4MjbITiNsy5vrC+xuo1bsD3g1/5+J8wF7KXzrH3PXSLNO3h5f hICX0UOn1UI6G2Dr9rWifyg= X-Google-Smtp-Source: ALg8bN7GJdiedYOk2gqvMd+qObZmk2S1LCgEfdB5TopilMw3gcbIu4bjqOWi/m1qZ7Abspg+Rqazgg== X-Received: by 2002:a19:2d16:: with SMTP id k22mr14033501lfj.12.1547888462780; Sat, 19 Jan 2019 01:01:02 -0800 (PST) Received: from jupiter.lan (18.158-248-194.customer.lyse.net. [158.248.194.18]) by smtp.gmail.com with ESMTPSA id h22-v6sm1254995lji.45.2019.01.19.01.01.01 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 19 Jan 2019 01:01:02 -0800 (PST) From: Sam Ravnborg To: Alexandre Belloni Cc: Alessandro Zummo , Andrew Jeffery , Fabio Estevam , Joel Stanley , Mark Rutland , Rob Herring , Russell King , Sascha Hauer , =?utf-8?q?Urs_F=C3=A4ssler?= , Shawn Guo , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rtc@vger.kernel.org, Sam Ravnborg Subject: [PATCH v3 1/6] devicetree: property-units: Add femtofarads unit Date: Sat, 19 Jan 2019 10:00:26 +0100 Message-Id: <20190119090031.29147-2-sam@ravnborg.org> X-Mailer: git-send-email 2.12.0 In-Reply-To: <20190119090031.29147-1-sam@ravnborg.org> References: <20190119090031.29147-1-sam@ravnborg.org> Sender: linux-rtc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rtc@vger.kernel.org When dealing with capacitance of 0.5 pF then a smaller unit is preferred. Add femtofarads to deal with this. Signed-off-by: Sam Ravnborg Reviewed-by: Rob Herring Cc: Mark Rutland Cc: Alessandro Zummo Cc: Alexandre Belloni --- Documentation/devicetree/bindings/property-units.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/property-units.txt b/Documentation/devicetree/bindings/property-units.txt index 45ce054d844d..bfd33734faca 100644 --- a/Documentation/devicetree/bindings/property-units.txt +++ b/Documentation/devicetree/bindings/property-units.txt @@ -31,6 +31,7 @@ Electricity -microwatt-hours: micro Watt-hours -microvolt : micro volts -picofarads : picofarads +-femtofarads : femtofarads Temperature ---------------------------------------- From patchwork Sat Jan 19 09:00:27 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sam Ravnborg X-Patchwork-Id: 1027890 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=linux-rtc-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=ravnborg.org Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="Tw6X/Uc0"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 43hWyb4sRQz9sBQ for ; Sat, 19 Jan 2019 20:01:43 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727764AbfASJBG (ORCPT ); Sat, 19 Jan 2019 04:01:06 -0500 Received: from mail-lj1-f194.google.com ([209.85.208.194]:42552 "EHLO mail-lj1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727699AbfASJBG (ORCPT ); Sat, 19 Jan 2019 04:01:06 -0500 Received: by mail-lj1-f194.google.com with SMTP id l15-v6so13586138lja.9; Sat, 19 Jan 2019 01:01:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=3OMj0V3WJlVkkkCXQcxklvPa9pcGHx9O1wUkkzb/B9s=; b=Tw6X/Uc0MUuK+PT73msgsRYGPY+ozTfKqL1QOFm9Cn1I+w5Pplr+NUSCWafA+9TXC2 3YPBGa1ID9agIZPoXCcsWz7RVW7/RoB8K9JayCe/XbHRqFDHsVGlarq1NRRTm4K50oCX Gql/oy8Oz5ArBD3xNR+7NYHS3Ard/u2TgCW+d2s03c92ZmbAq8aZQ6bwBOawP0H+DDa+ xVinIVy6tG1aZrCz2lxiS3s0ccDcco06Jnr0GPrnZYXu9+jB4oFEw0tmsELxmTC4pXUH W5H0hnGfpjYBNK/t9tzYZLdYuEBga9XourFMY64dhvjMb9fExP++LdVBSdcWX4r/EyRs LP6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=3OMj0V3WJlVkkkCXQcxklvPa9pcGHx9O1wUkkzb/B9s=; b=mdAhaEz29gYZ8pgsAtBoDCEL+XgTVw22BPy/BXOaZficAfJZDuwGC4SJqCGfBUCJOz 5GDmO+S7YvTjdWl161+er552q+rfDA2al52B3+joVb8U3NyjlotTPFzbCzvXW+mKr276 yr2np/IC3GCKf7+tjxo0MQWem00S5Kk2LPXuBaf4mGpxFXMiE1A6rtLbnuuSMSyEAt0d sxAEgsE/N9MMbVvu3Bw4PWx1T2npvIa3HfgIEfjr2qW9KuPa++CERYJ87o5pldg6C88P 82mx1C55LPS9WWmXj1yScMVTuArfir06BHXYAQMCZkVvKXAJd1Dp9O+vIbolzxmN6DVG 2EzA== X-Gm-Message-State: AJcUukfTDHhTrguBhSp9NBcuqTMicarWxNTyHYK6UFZpbeOIyPJF+Ibo yybM+kEd86BLFuCRw/bc1k8= X-Google-Smtp-Source: ALg8bN75d8KF6zxVqbHsI+CxWM2wPItbUYip48+WFfPJZvUf0l+8fJTi7R6wWv+PSPdWNHFFYEz44w== X-Received: by 2002:a2e:5152:: with SMTP id b18-v6mr12418732lje.88.1547888463852; Sat, 19 Jan 2019 01:01:03 -0800 (PST) Received: from jupiter.lan (18.158-248-194.customer.lyse.net. [158.248.194.18]) by smtp.gmail.com with ESMTPSA id h22-v6sm1254995lji.45.2019.01.19.01.01.02 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 19 Jan 2019 01:01:03 -0800 (PST) From: Sam Ravnborg To: Alexandre Belloni Cc: Alessandro Zummo , Andrew Jeffery , Fabio Estevam , Joel Stanley , Mark Rutland , Rob Herring , Russell King , Sascha Hauer , =?utf-8?q?Urs_F=C3=A4ssler?= , Shawn Guo , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rtc@vger.kernel.org, Sam Ravnborg Subject: [PATCH v3 2/6] dt-bindings: rtc: Add quartz-load-femtofarads property Date: Sat, 19 Jan 2019 10:00:27 +0100 Message-Id: <20190119090031.29147-3-sam@ravnborg.org> X-Mailer: git-send-email 2.12.0 In-Reply-To: <20190119090031.29147-1-sam@ravnborg.org> References: <20190119090031.29147-1-sam@ravnborg.org> Sender: linux-rtc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rtc@vger.kernel.org The quartz-load-femtofarads are relevant for several users. Add it as a common property in rtc. Note that valid values and default values must be documented. Signed-off-by: Sam Ravnborg Suggested-by: Rob Herring Cc: Alessandro Zummo Cc: Alexandre Belloni Cc: Rob Herring Cc: Mark Rutland Reviewed-by: Rob Herring --- Documentation/devicetree/bindings/rtc/rtc.txt | 16 ++++++++++------ 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/Documentation/devicetree/bindings/rtc/rtc.txt b/Documentation/devicetree/bindings/rtc/rtc.txt index 7c8da6926095..41eb335ea816 100644 --- a/Documentation/devicetree/bindings/rtc/rtc.txt +++ b/Documentation/devicetree/bindings/rtc/rtc.txt @@ -21,12 +21,16 @@ Optional properties The following properties may not be supported by all drivers. However, if a driver wants to support one of the below features, it should adapt the bindings below. -- trickle-resistor-ohms : Selected resistor for trickle charger. Should be given - if trickle charger should be enabled -- trickle-diode-disable : Do not use internal trickle charger diode Should be - given if internal trickle charger diode should be - disabled -- wakeup-source : Enables wake up of host system on alarm +- trickle-resistor-ohms : Selected resistor for trickle charger. Should be given + if trickle charger should be enabled +- trickle-diode-disable : Do not use internal trickle charger diode Should be + given if internal trickle charger diode should be + disabled +- wakeup-source : Enables wake up of host system on alarm +- quartz-load-femtofarads : The capacitive load of the quartz(x-tal), + expressed in femto Farad (fF). + The default value shall be listed (if optional), + and likewise all valid values. Trivial RTCs ------------ From patchwork Sat Jan 19 09:00:28 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Sam Ravnborg X-Patchwork-Id: 1027888 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=linux-rtc-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=ravnborg.org Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="fkk4BRzw"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 43hWyZ0SHdz9sBQ for ; Sat, 19 Jan 2019 20:01:42 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727942AbfASJBb (ORCPT ); Sat, 19 Jan 2019 04:01:31 -0500 Received: from mail-lj1-f194.google.com ([209.85.208.194]:42556 "EHLO mail-lj1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727733AbfASJBH (ORCPT ); Sat, 19 Jan 2019 04:01:07 -0500 Received: by mail-lj1-f194.google.com with SMTP id l15-v6so13586186lja.9; Sat, 19 Jan 2019 01:01:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=1pudjFZm7a1TG8b705J5+DLKWhWvGwPk11vg4nopYJk=; b=fkk4BRzw835xS+GyYaXXi+h/P94dO8Ss8mevsxlSA/BuAAe+GIf1U893vJhhNI2i02 tcfYFbcduwycjK/q5S7KZmBHuuNxwzAfF+ylj+OSTN9uLKhKQ0FP3AaqNHYs6i6aWH7w +oeG2g6DwoD0/R0Vpxs78yscBmPo/BXEFcGIwF5mMz5CTBAaosCOFZmhLdgnAlnhzSXr ghU/Ge9i4niAZrNSbDn2hT1iKItKHAeCT/ylusv29lbU6/pQL51noWX81ME0cZrsGiIF AJ6NrHgef9B95/O7FmFkR6th6Warm4g8kRd4VM/xoTQ6sQquFAa3HuIrWEBsmPL65z+g auUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=1pudjFZm7a1TG8b705J5+DLKWhWvGwPk11vg4nopYJk=; b=SOzRrlbxA5VjQxVw/F60VT5jlPqATXKVo6QDFQM5QyiFYauL//tOYOTccExvdRM1xX FERg4w3YoYuyJoA67qxWMQZWDSrmMfPbLocPns/8OEA7zHtYAt1h55aV7Kwnigczs07n 6WEk/8cRmjJ3TwQh1OS7A6aFn5BpaIeSf4m6A+47UWqW9QcXj7oYxT/KVO4RwGR0lZE9 on849aLBq+guHFjtxsYqNWmrXZtfeZfzIcMju1IoTPayFdxqzRZnHsVgLhFPZuc7FKov W4WFSYp0umSGdlAuFIpT4PIdY94Cq705qScJgpopJgLE6gV0v5T8HJUEdw/YGHTXfnh6 oXPg== X-Gm-Message-State: AJcUukcarmFwU8HhNWD/FRCVuIUUm8L1GtlhQxmNEr85xY4bKnj13PSs RZoLInpDvjUf2Bzc/DxIua4= X-Google-Smtp-Source: ALg8bN72OQaBPsFJgD/k6pNJAUvUZIOHB+1axILf3JhkGhzV7kUTLBkDdjcybobihzmmmf2UGGMZ/Q== X-Received: by 2002:a2e:5703:: with SMTP id l3-v6mr15189174ljb.106.1547888465056; Sat, 19 Jan 2019 01:01:05 -0800 (PST) Received: from jupiter.lan (18.158-248-194.customer.lyse.net. [158.248.194.18]) by smtp.gmail.com with ESMTPSA id h22-v6sm1254995lji.45.2019.01.19.01.01.03 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 19 Jan 2019 01:01:04 -0800 (PST) From: Sam Ravnborg To: Alexandre Belloni Cc: Alessandro Zummo , Andrew Jeffery , Fabio Estevam , Joel Stanley , Mark Rutland , Rob Herring , Russell King , Sascha Hauer , =?utf-8?q?Urs_F=C3=A4ssler?= , Shawn Guo , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rtc@vger.kernel.org, Sam Ravnborg , =?utf-8?q?S=C3=B8ren_Andersen?= Subject: [PATCH v3 3/6] dt-binding: pcf8523: add xtal load capacitance Date: Sat, 19 Jan 2019 10:00:28 +0100 Message-Id: <20190119090031.29147-4-sam@ravnborg.org> X-Mailer: git-send-email 2.12.0 In-Reply-To: <20190119090031.29147-1-sam@ravnborg.org> References: <20190119090031.29147-1-sam@ravnborg.org> MIME-Version: 1.0 Sender: linux-rtc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rtc@vger.kernel.org The NXP pcf8523 supports two different xtal load capacitance - 7000fF (7pF) HW default - 12500fF (12.5pF) Minimum power consumption, driver default To obtain a precise RTC the pcf8523 must be configured with the correct capacitance load of the xtal. Add a property to specify the xtal capacitance load. The default value matches that of the current Linux driver. With a dedicated binding remove the entry in rtc.txt Signed-off-by: Søren Andersen Signed-off-by: Sam Ravnborg Reviewed-by: Rob Herring Cc: Alessandro Zummo Cc: Alexandre Belloni Cc: Mark Rutland --- Documentation/devicetree/bindings/rtc/nxp,pcf8523.txt | 18 ++++++++++++++++++ Documentation/devicetree/bindings/rtc/rtc.txt | 1 - 2 files changed, 18 insertions(+), 1 deletion(-) create mode 100644 Documentation/devicetree/bindings/rtc/nxp,pcf8523.txt diff --git a/Documentation/devicetree/bindings/rtc/nxp,pcf8523.txt b/Documentation/devicetree/bindings/rtc/nxp,pcf8523.txt new file mode 100644 index 000000000000..0b1080c60f63 --- /dev/null +++ b/Documentation/devicetree/bindings/rtc/nxp,pcf8523.txt @@ -0,0 +1,18 @@ +* NXP PCF8523 Real Time Clock + +Required properties: +- compatible: Should contain "nxp,pcf8523". +- reg: I2C address for chip. + +Optional property: +- quartz-load-femtofarads: The capacitive load of the quartz(x-tal), + expressed in femto Farad (fF). Valid values are 7000 and 12500. + Default value (if no value is specified) is 12500fF. + +Example: + +pcf8523: rtc@68 { + compatible = "nxp,pcf8523"; + reg = <0x68>; + quartz-load-femtofarads = <7000>; +}; diff --git a/Documentation/devicetree/bindings/rtc/rtc.txt b/Documentation/devicetree/bindings/rtc/rtc.txt index 41eb335ea816..6d726a801d21 100644 --- a/Documentation/devicetree/bindings/rtc/rtc.txt +++ b/Documentation/devicetree/bindings/rtc/rtc.txt @@ -55,7 +55,6 @@ isil,isl12022 Intersil ISL12022 Real-time Clock microcrystal,rv3029 Real Time Clock Module with I2C-Bus nxp,pcf2127 Real-time clock nxp,pcf2129 Real-time clock -nxp,pcf8523 Real-time Clock nxp,pcf8563 Real-time clock/calendar nxp,pcf85063 Tiny Real-Time Clock pericom,pt7c4338 Real-time Clock Module From patchwork Sat Jan 19 09:00:29 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Sam Ravnborg X-Patchwork-Id: 1027886 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=linux-rtc-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=ravnborg.org Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="fwf2AI10"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 43hWyL4Gddz9sD9 for ; Sat, 19 Jan 2019 20:01:30 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727699AbfASJBJ (ORCPT ); Sat, 19 Jan 2019 04:01:09 -0500 Received: from mail-lj1-f193.google.com ([209.85.208.193]:42556 "EHLO mail-lj1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727766AbfASJBI (ORCPT ); Sat, 19 Jan 2019 04:01:08 -0500 Received: by mail-lj1-f193.google.com with SMTP id l15-v6so13586214lja.9; Sat, 19 Jan 2019 01:01:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=32aiRvmXizk/aT/C00Lbv4hCDOoBJNEluj0FNlfhB88=; b=fwf2AI10JNdBGLGUXNF/k/IqzIm+quhTewahx/73CowFsttaqciq5dTIDvGi8Esc9J CdbuN7E282OJHzYVwtk9/TzhPG9SiC93ZRfQD88VvkcrniDwLnDHJNxoVC6IkZ2LLZ7U 5mqgbIzj+QVE644dCorkVZWq2kV2qPenge/1jx9GAVSjMm5vgsMGOGiK8rIHhWNd58d/ qJN+znRyCubfUo0WokgRXoeZe/Sb87ryNflU2vXhSDVYPaZ51TNXFpUJywiGxz2BRloT kSyw1czIfRBpgaWSvEvkbrnVRoodD6O7Ed839queFMBjPtViBUtfU/aqN2T8SfI4mH/B Qw+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=32aiRvmXizk/aT/C00Lbv4hCDOoBJNEluj0FNlfhB88=; b=OkJeI2npnbRwobN5bFXNkzvw4VuRNh6zVjYI3EBABywchPwHHcD01B2kbO2Wy93FjV MMhrUjbF/ojvJqP1vFQHyr9verOEudH+lfktGfTrLRFdP/EioD3secY028AsMMI7uqD6 FebT/LUgmQYSMJ4vAKBXUgu2h0lugrDLCaDfJCKyTdVUnbX5TOdR4UrGgn8j9aORS7n9 EIVkx59qMwrvPYQwhvS137aP9LWPkKNIIUPRwpKpYtOGS5AlUt9eJrdftAWo1LU595Cl 5Dye1p+LQZIKqwVZ+BYWyw+SlWkENUxZYSKRqFfDNA1S4NrZOuvgzdicqKOdAMOWuN0x hYFA== X-Gm-Message-State: AJcUukfpMRNY7YscSSbqDSUmMeDZN+swfsKz63u7Zm+g2c8B70rqZy92 gvaQQCludC3twCSaL0FYGnM= X-Google-Smtp-Source: ALg8bN60Kyr9vJPWdA5vu6ykr6tRgENi50TfWCNF0Bq0qntG1DMbk2K8YRiCgxg7zEeFD8Ha4Hw4Ew== X-Received: by 2002:a2e:e02:: with SMTP id 2-v6mr12320366ljo.10.1547888466233; Sat, 19 Jan 2019 01:01:06 -0800 (PST) Received: from jupiter.lan (18.158-248-194.customer.lyse.net. [158.248.194.18]) by smtp.gmail.com with ESMTPSA id h22-v6sm1254995lji.45.2019.01.19.01.01.05 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 19 Jan 2019 01:01:05 -0800 (PST) From: Sam Ravnborg To: Alexandre Belloni Cc: Alessandro Zummo , Andrew Jeffery , Fabio Estevam , Joel Stanley , Mark Rutland , Rob Herring , Russell King , Sascha Hauer , =?utf-8?q?Urs_F=C3=A4ssler?= , Shawn Guo , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rtc@vger.kernel.org, Sam Ravnborg , =?utf-8?q?S=C3=B8ren_Andersen?= Subject: [PATCH v3 4/6] dt-binding: pcf85063: add xtal load capacitance Date: Sat, 19 Jan 2019 10:00:29 +0100 Message-Id: <20190119090031.29147-5-sam@ravnborg.org> X-Mailer: git-send-email 2.12.0 In-Reply-To: <20190119090031.29147-1-sam@ravnborg.org> References: <20190119090031.29147-1-sam@ravnborg.org> MIME-Version: 1.0 Sender: linux-rtc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rtc@vger.kernel.org The NXP pcf85063 supports two different xtal load capacitance - 7000fF (7pF) HW default, Linux driver default - 12500fF (12.5pF) Minimum power consumption To obtain a precise RTC the pcf85063 must be configured with the correct capacitance load of the xtal. Add a property to specify the xtal capacitance load. The default value matches that of the current Linux driver. With a dedicated binding remove the entry in rtc.txt Signed-off-by: Søren Andersen Signed-off-by: Sam Ravnborg Cc: Alessandro Zummo Cc: Alexandre Belloni Cc: Rob Herring Cc: Mark Rutland Cc: Urs Fässler Reviewed-by: Rob Herring --- Documentation/devicetree/bindings/rtc/nxp,pcf85063.txt | 18 ++++++++++++++++++ Documentation/devicetree/bindings/rtc/rtc.txt | 1 - 2 files changed, 18 insertions(+), 1 deletion(-) create mode 100644 Documentation/devicetree/bindings/rtc/nxp,pcf85063.txt diff --git a/Documentation/devicetree/bindings/rtc/nxp,pcf85063.txt b/Documentation/devicetree/bindings/rtc/nxp,pcf85063.txt new file mode 100644 index 000000000000..d3e380ad712d --- /dev/null +++ b/Documentation/devicetree/bindings/rtc/nxp,pcf85063.txt @@ -0,0 +1,18 @@ +* NXP PCF85063 Real Time Clock + +Required properties: +- compatible: Should contain "nxp,pcf85063". +- reg: I2C address for chip. + +Optional property: +- quartz-load-femtofarads: The capacitive load of the quartz(x-tal), + expressed in femto Farad (fF). Valid values are 7000 and 12500. + Default value (if no value is specified) is 7000fF. + +Example: + +pcf85063: rtc@51 { + compatible = "nxp,pcf85063"; + reg = <0x51>; + quartz-load-femtofarads = <12500>; +}; diff --git a/Documentation/devicetree/bindings/rtc/rtc.txt b/Documentation/devicetree/bindings/rtc/rtc.txt index 6d726a801d21..460c503e86c6 100644 --- a/Documentation/devicetree/bindings/rtc/rtc.txt +++ b/Documentation/devicetree/bindings/rtc/rtc.txt @@ -56,7 +56,6 @@ microcrystal,rv3029 Real Time Clock Module with I2C-Bus nxp,pcf2127 Real-time clock nxp,pcf2129 Real-time clock nxp,pcf8563 Real-time clock/calendar -nxp,pcf85063 Tiny Real-Time Clock pericom,pt7c4338 Real-time Clock Module ricoh,r2025sd I2C bus SERIAL INTERFACE REAL-TIME CLOCK IC ricoh,r2221tl I2C bus SERIAL INTERFACE REAL-TIME CLOCK IC From patchwork Sat Jan 19 09:00:30 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sam Ravnborg X-Patchwork-Id: 1027885 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=linux-rtc-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=ravnborg.org Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="GgDtiBdU"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 43hWyD3JMkz9sBn for ; Sat, 19 Jan 2019 20:01:24 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727724AbfASJBW (ORCPT ); Sat, 19 Jan 2019 04:01:22 -0500 Received: from mail-lj1-f193.google.com ([209.85.208.193]:33885 "EHLO mail-lj1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727796AbfASJBK (ORCPT ); Sat, 19 Jan 2019 04:01:10 -0500 Received: by mail-lj1-f193.google.com with SMTP id u89-v6so13624113lje.1; Sat, 19 Jan 2019 01:01:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=Gsad/wBToe+cmtNDHEYdNCur8rX+EzM0uvagphRxBvM=; b=GgDtiBdUwfAVCMRUZFT/cYdaRDT15Q90Aw7kFvRLf7pT3ggSVQOVNmqy3qMqQLLIhd bP89XL+haGdT8RZYSDUyLUPgDlECebFuL7hCPdLyDND0iAP7tqeC6dx1fjFlmqaEnTPj AGzt1qCYhdxsYNhNh8LAxk9JcaY/6pahAT1E+l4+oh9DZWg/b64OwjvZs7uN3euPwx1s fHlpklv1UOlIbZp1yGpfAff8+ikDchyvwXhcYjURgPtanLSRfpjhueqFSL0N6xoVU8l9 6hEO5V1QHNaBqNZEWrWmzF3y8vhtCuFl2ztB71T1k5WR9KNJkZMZU4ERTHgdDmBR0oAi LWGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=Gsad/wBToe+cmtNDHEYdNCur8rX+EzM0uvagphRxBvM=; b=gW7MD1gnr7JGy8qWJm1rYiP6xpbInZx3Uq5egLKS2cjCxoROSP40QM1zraZZn7dws3 NEAHFETvrqRR1Px4VsQth2KAlxEEQBY31VDxSd6g9FMacNyA6ctNyAhulp46/vD6ICN3 G2ugN247KJc/Eo6wuUADREms9qjgjn9mZqTA0sybkDhF1QTojHm71WrCy9+Mh7uWiwM4 jtpnz20zBrXWy+CQ85Bs0qR+k2pNkYWnExLHvhIFCuF8lch1SKy85kCoiMy0WSiFPfH1 OvJq9m4LciqpTm35o7zTye0GoOudWRHSFVEDUCAbDXQe1YtUowvvf4SaC8uIkgSVauNF xw9Q== X-Gm-Message-State: AJcUukfJly8rpUD41+9rm9OTe0ydbjntzVmondP7720IPvaOLna7WuJQ Nnem5a08DDOEOPk7BqtixQQ= X-Google-Smtp-Source: ALg8bN4w0xDZHt23MbaUSx8PRMigw70iS8f7jKTxfstac8yVlL6xceH9gF2m14GhKUn+ZoU1dYa0BQ== X-Received: by 2002:a2e:710a:: with SMTP id m10-v6mr13726595ljc.66.1547888467396; Sat, 19 Jan 2019 01:01:07 -0800 (PST) Received: from jupiter.lan (18.158-248-194.customer.lyse.net. [158.248.194.18]) by smtp.gmail.com with ESMTPSA id h22-v6sm1254995lji.45.2019.01.19.01.01.06 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 19 Jan 2019 01:01:06 -0800 (PST) From: Sam Ravnborg To: Alexandre Belloni Cc: Alessandro Zummo , Andrew Jeffery , Fabio Estevam , Joel Stanley , Mark Rutland , Rob Herring , Russell King , Sascha Hauer , =?utf-8?q?Urs_F=C3=A4ssler?= , Shawn Guo , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rtc@vger.kernel.org, Sam Ravnborg Subject: [PATCH v3 5/6] rtc: pcf8523: set xtal load capacitance from DT Date: Sat, 19 Jan 2019 10:00:30 +0100 Message-Id: <20190119090031.29147-6-sam@ravnborg.org> X-Mailer: git-send-email 2.12.0 In-Reply-To: <20190119090031.29147-1-sam@ravnborg.org> References: <20190119090031.29147-1-sam@ravnborg.org> Sender: linux-rtc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rtc@vger.kernel.org Add support for specifying the xtal load capacitance in the DT node. The pcf8523 supports xtal load capacitance of 7pF or 12.5pF. If the rtc has the wrong configuration the time will drift several hours/week. The driver use the default value 12.5pF. The DT may specify either 7000fF or 12500fF. (The DT uses femto Farad to avoid decimal numbers). Other values are warned and the driver uses the default value. Signed-off-by: Sam Ravnborg Cc: Alessandro Zummo Cc: Alexandre Belloni --- drivers/rtc/rtc-pcf8523.c | 28 ++++++++++++++++++++-------- 1 file changed, 20 insertions(+), 8 deletions(-) diff --git a/drivers/rtc/rtc-pcf8523.c b/drivers/rtc/rtc-pcf8523.c index 3fcd2cbafc84..2e03021f15d1 100644 --- a/drivers/rtc/rtc-pcf8523.c +++ b/drivers/rtc/rtc-pcf8523.c @@ -97,8 +97,9 @@ static int pcf8523_voltage_low(struct i2c_client *client) return !!(value & REG_CONTROL3_BLF); } -static int pcf8523_select_capacitance(struct i2c_client *client, bool high) +static int pcf8523_load_capacitance(struct i2c_client *client) { + u32 load; u8 value; int err; @@ -106,14 +107,24 @@ static int pcf8523_select_capacitance(struct i2c_client *client, bool high) if (err < 0) return err; - if (!high) - value &= ~REG_CONTROL1_CAP_SEL; - else + load = 12500; + of_property_read_u32(client->dev.of_node, "quartz-load-femtofarads", + &load); + + switch (load) { + default: + dev_warn(&client->dev, "Unknown quartz-load-femtofarads value: %d. Assuming 12500", + load); + /* fall through */ + case 12500: value |= REG_CONTROL1_CAP_SEL; + break; + case 7000: + value &= ~REG_CONTROL1_CAP_SEL; + break; + } err = pcf8523_write(client, REG_CONTROL1, value); - if (err < 0) - return err; return err; } @@ -347,9 +358,10 @@ static int pcf8523_probe(struct i2c_client *client, if (!pcf) return -ENOMEM; - err = pcf8523_select_capacitance(client, true); + err = pcf8523_load_capacitance(client); if (err < 0) - return err; + dev_warn(&client->dev, "failed to set xtal load capacitance: %d", + err); err = pcf8523_set_pm(client, 0); if (err < 0) From patchwork Sat Jan 19 09:00:31 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Sam Ravnborg X-Patchwork-Id: 1027884 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=linux-rtc-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=ravnborg.org Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="eiVKZPv6"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 43hWyC3mvYz9sD4 for ; Sat, 19 Jan 2019 20:01:23 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727856AbfASJBL (ORCPT ); Sat, 19 Jan 2019 04:01:11 -0500 Received: from mail-lf1-f66.google.com ([209.85.167.66]:35632 "EHLO mail-lf1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727811AbfASJBK (ORCPT ); Sat, 19 Jan 2019 04:01:10 -0500 Received: by mail-lf1-f66.google.com with SMTP id e26so12199492lfc.2; Sat, 19 Jan 2019 01:01:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=F+4crJRPxHtpzXBHJc8HDEgRsj27zduN5WVH8mp44vs=; b=eiVKZPv6zpF2tmPSUb4dlp/umUAwEJA0QO+ee7FoHY/R3vOI9WVYP2PE+ADKy0u8ZS yGVmLt+bPssXsMpASfvMM5s7L5YmcfRSozgJayflQXGOmcBfzWbpPRBnnswhczW6iKc/ BmVTuHlW8kB97dubxQZSs1gHFveyaKCWYpEXU7EC1Xbok2kFLwlvckFmiRHPpQXRJqMs hgfpovPtxnB5AyG9awD5zHvbf3yWQiqvegql4eCbto3b8F1BYMB5k0UWU7YHi50DWcM3 jHuthg1AFwJE6Ho2IdaB5rXpGTZlK1ETpd+qyAmasX41eZcUscX/3eJik8LQnT+W0NE5 hB/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=F+4crJRPxHtpzXBHJc8HDEgRsj27zduN5WVH8mp44vs=; b=JKSqwqkbA6gpQlr/dHDz2mdU2Jks/IGQ3lT9C7sutclZZWAZO08ScOjLgO/xEQOoaB hA4CAJhaz2VUsLdKUmNlVtiGWWqB7RtKflQWGGQsS3nZ5fO5E3yLDrDDaSvV217ndYIO laUyP0K2fReiwH1QBTHCrGMOhhPgqg4IzDNUZ7dIfgw3QTRBZSeWfm72GI9GTwJMBgP2 h1JfCasMWP/GusjIrjJrmlNwxJ4h6CCruDUDEWw+8ZHUkiEVWGtc65URjFIL5opUYMr7 FXcPdgnOhh8srcIAQ04iQ9WpRtL93OpAbmbmu7GY2GfjH2/PplKiUsO766wGn3bzCD6u 7T5w== X-Gm-Message-State: AJcUukem9mW0hk35tGX2iJPuxel2cEJICKIj7biSpefYytJVJBNzs5XO uUlgVfHJFg0QcPqGXy4/j9I= X-Google-Smtp-Source: ALg8bN6eG/BWG4SeJAjJv2PlwZYDnCRuW9fd/L60d077GzSmw0AECYULj7qI9UQ70Hb76saX2wqmZQ== X-Received: by 2002:a19:5059:: with SMTP id z25mr9983093lfj.120.1547888468482; Sat, 19 Jan 2019 01:01:08 -0800 (PST) Received: from jupiter.lan (18.158-248-194.customer.lyse.net. [158.248.194.18]) by smtp.gmail.com with ESMTPSA id h22-v6sm1254995lji.45.2019.01.19.01.01.07 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 19 Jan 2019 01:01:08 -0800 (PST) From: Sam Ravnborg To: Alexandre Belloni Cc: Alessandro Zummo , Andrew Jeffery , Fabio Estevam , Joel Stanley , Mark Rutland , Rob Herring , Russell King , Sascha Hauer , =?utf-8?q?Urs_F=C3=A4ssler?= , Shawn Guo , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rtc@vger.kernel.org, Sam Ravnborg Subject: [PATCH v3 6/6] rtc: pcf85063: set xtal load capacitance from DT Date: Sat, 19 Jan 2019 10:00:31 +0100 Message-Id: <20190119090031.29147-7-sam@ravnborg.org> X-Mailer: git-send-email 2.12.0 In-Reply-To: <20190119090031.29147-1-sam@ravnborg.org> References: <20190119090031.29147-1-sam@ravnborg.org> MIME-Version: 1.0 Sender: linux-rtc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rtc@vger.kernel.org Add support for specifying the xtal load capacitance in the DT node. The pcf85063 supports xtal load capacitance of 7pF or 12.5pF. If the rtc has the wrong configuration the time will drift several hours/week. The driver use the default value 7pF. The DT may specify either 7000fF or 12500fF. (The DT uses femto Farad to avoid decimal numbers). Other values are warned and the driver uses the default value. Signed-off-by: Sam Ravnborg Cc: Alessandro Zummo Cc: Alexandre Belloni Cc: Urs Fässler --- drivers/rtc/rtc-pcf85063.c | 39 +++++++++++++++++++++++++++++++++++++++ 1 file changed, 39 insertions(+) diff --git a/drivers/rtc/rtc-pcf85063.c b/drivers/rtc/rtc-pcf85063.c index 283c2335b01b..b79af6e96292 100644 --- a/drivers/rtc/rtc-pcf85063.c +++ b/drivers/rtc/rtc-pcf85063.c @@ -27,6 +27,7 @@ */ #define PCF85063_REG_CTRL1 0x00 /* status */ +#define PCF85063_REG_CTRL1_CAP_SEL BIT(0) #define PCF85063_REG_CTRL1_STOP BIT(5) #define PCF85063_REG_CTRL2 0x01 @@ -180,6 +181,39 @@ static const struct rtc_class_ops pcf85063_rtc_ops = { .set_time = pcf85063_rtc_set_time }; +static int pcf85063_load_capacitance(struct i2c_client *client) +{ + u32 load; + int rc; + u8 reg; + + rc = i2c_smbus_read_byte_data(client, PCF85063_REG_CTRL1); + if (rc < 0) + return rc; + + reg = rc; + load = 7000; + of_property_read_u32(client->dev.of_node, "quartz-load-femtofarads", + &load); + + switch (load) { + default: + dev_warn(&client->dev, "Unknown quartz-load-femtofarads value: %d. Assuming 7000", + load); + /* fall through */ + case 7000: + reg &= ~PCF85063_REG_CTRL1_CAP_SEL; + break; + case 12500: + reg |= PCF85063_REG_CTRL1_CAP_SEL; + break; + } + + rc = i2c_smbus_write_byte_data(client, PCF85063_REG_CTRL1, reg); + + return rc; +} + static int pcf85063_probe(struct i2c_client *client, const struct i2c_device_id *id) { @@ -197,6 +231,11 @@ static int pcf85063_probe(struct i2c_client *client, return err; } + err = pcf85063_load_capacitance(client); + if (err < 0) + dev_warn(&client->dev, "failed to set xtal load capacitance: %d", + err); + rtc = devm_rtc_device_register(&client->dev, pcf85063_driver.driver.name, &pcf85063_rtc_ops, THIS_MODULE);