From patchwork Tue Jan 15 10:15:16 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Korsgaard X-Patchwork-Id: 1025103 Return-Path: X-Original-To: incoming-buildroot@patchwork.ozlabs.org Delivered-To: patchwork-incoming-buildroot@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=busybox.net (client-ip=140.211.166.136; helo=silver.osuosl.org; envelope-from=buildroot-bounces@busybox.net; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=korsgaard.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="CHsWzmlm"; dkim-atps=neutral Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 43f5p42TMBz9sCr for ; Tue, 15 Jan 2019 21:15:56 +1100 (AEDT) Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id 2DD4923408; Tue, 15 Jan 2019 10:15:52 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id mV5AhRiE7n2P; Tue, 15 Jan 2019 10:15:50 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by silver.osuosl.org (Postfix) with ESMTP id 8681A2343B; Tue, 15 Jan 2019 10:15:49 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by ash.osuosl.org (Postfix) with ESMTP id 359AA1BF2A9 for ; Tue, 15 Jan 2019 10:15:46 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id 3048B23376 for ; Tue, 15 Jan 2019 10:15:46 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id w-4r7ioZCFJp for ; Tue, 15 Jan 2019 10:15:43 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-ed1-f65.google.com (mail-ed1-f65.google.com [209.85.208.65]) by silver.osuosl.org (Postfix) with ESMTPS id 6E163233B8 for ; Tue, 15 Jan 2019 10:15:42 +0000 (UTC) Received: by mail-ed1-f65.google.com with SMTP id o10so2040042edt.13 for ; Tue, 15 Jan 2019 02:15:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id; bh=T8xEOVyrWccu++/KW0ylZRlQ2rygkc3im3BATKVJ6Go=; b=CHsWzmlm/O0cWDaupN4jbwxw2ZyCNJqg0HFbKMQvGuMoP+xodEJ31MKeNIv3uzMzg5 qryx+odBd3m9KGYdHRSas5yZMjRm4GwFti6ePZjjIKPRSwgIpqP8vfEO7VbfGa9Z7Lo+ mrI0c1ci6YUo/5GRPnpeieo68pGhyTFGHV9L+IRBtUbA+bHyk3X58ycr8RkhRY9nTN3F KcWarGjofCFLnlYszIEKwkIWhfp8N8E1EGk2lhVqn4H1ppSJoJNk/OGuPeV1VSwUZmOa RDm+q2s4G1GTpAR5FRFIWbqx2aA7frpLM0SavGTG8FLpiChxPdycMrJ6Kb7wihrLFBHb +mvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id; bh=T8xEOVyrWccu++/KW0ylZRlQ2rygkc3im3BATKVJ6Go=; b=dkHkqO8R7Nx/BN3vT27kK0hcRKjuUg8XwhNtZkBk1cBNytzr26CahjOjadBjK+LOAL MJK7Fx9Atc5mXiOGjUQUbz+fPH9fGiArRrXJSnK1uRoZqw/whUcjhXPEx+T+U/RZiwux vCA+LOrbdWeiTrSkcuWTZoFO6+npOOJXYZd1/b4yFk1Pgo0hLYeQiU82RO/7RsQIOusC EpbxB/4mdwIntJasiYq+0u+mZnI8Ja2p3vxnQIDGyuqVUd1r9SNBpcsui1Fj9Jxd3S1H mrqcN8MVPd1J/vYqOigUODyPv5E8TnBzfko47LdKof9YoY1f6LpGq1hdsFPZvBrBIYUt ZFMw== X-Gm-Message-State: AJcUukfi8XSnNUT8vZxRg9D9Co5uubOGN2If7rzABK/CdO6r3g+GU/AT SvCdi6+wd80DpXZPrXDWXz7oDWPm X-Google-Smtp-Source: ALg8bN7Z4AtDvzHffgk23asQL7gU9YAmyUjHDW50V4idWf3+lJ23UbRRMSInVLG6GJMyZdu2exQtkw== X-Received: by 2002:a50:d84d:: with SMTP id v13mr2774082edj.103.1547547340437; Tue, 15 Jan 2019 02:15:40 -0800 (PST) Received: from dell.be.48ers.dk (d51a5bc31.access.telenet.be. [81.165.188.49]) by smtp.gmail.com with ESMTPSA id t15-v6sm2599085ejt.0.2019.01.15.02.15.39 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 15 Jan 2019 02:15:39 -0800 (PST) Received: from peko by dell.be.48ers.dk with local (Exim 4.89) (envelope-from ) id 1gjLks-0005UA-6C; Tue, 15 Jan 2019 11:15:34 +0100 From: Peter Korsgaard To: buildroot@buildroot.org Date: Tue, 15 Jan 2019 11:15:16 +0100 Message-Id: <20190115101522.21042-1-peter@korsgaard.com> X-Mailer: git-send-email 2.11.0 Subject: [Buildroot] [PATCH v2 1/7] tpm2-tss: do not enforce -fstack-protector-all X-BeenThere: buildroot@busybox.net X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Korsgaard MIME-Version: 1.0 Errors-To: buildroot-bounces@busybox.net Sender: "buildroot" Stack protection is now controlled buildroot wide with the BR2_SSP_* options, so disable the explicit -fstack-protector-all so the SSP logic in the toolchain wrapper is used instead. Signed-off-by: Peter Korsgaard --- package/tpm2-tss/tpm2-tss.mk | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/package/tpm2-tss/tpm2-tss.mk b/package/tpm2-tss/tpm2-tss.mk index f005e5d6b8..e2e58a092d 100644 --- a/package/tpm2-tss/tpm2-tss.mk +++ b/package/tpm2-tss/tpm2-tss.mk @@ -12,8 +12,9 @@ TPM2_TSS_INSTALL_STAGING = YES TPM2_TSS_DEPENDENCIES = liburiparser openssl host-pkgconf TPM2_TSS_CONF_OPTS = --with-crypto=ossl --disable-doxygen-doc -# configure.ac doesn't contain a link test, so it doesn't detect when -# libssp is missing. -TPM2_TSS_CONF_ENV = ax_cv_check_cflags___________Wall__Werror_______fstack_protector_all=$(if $(BR2_TOOLCHAIN_HAS_SSP),yes,no) +# -fstack-protector-all is used by default. Disable that so the +# BR2_SSP_* options in the toolchain wrapper are used instead +TPM2_TSS_CONF_ENV = \ + ax_cv_check_cflags___________Wall__Werror_______fstack_protector_all=no $(eval $(autotools-package)) From patchwork Tue Jan 15 10:15:18 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Korsgaard X-Patchwork-Id: 1025102 Return-Path: X-Original-To: incoming-buildroot@patchwork.ozlabs.org Delivered-To: patchwork-incoming-buildroot@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=busybox.net (client-ip=140.211.166.137; helo=fraxinus.osuosl.org; envelope-from=buildroot-bounces@busybox.net; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=korsgaard.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="Z7TxX0lN"; dkim-atps=neutral Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 43f5p13Bq9z9sDP for ; Tue, 15 Jan 2019 21:15:53 +1100 (AEDT) Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id BF4EF80D92; Tue, 15 Jan 2019 10:15:51 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id gD9E48lyFGHE; Tue, 15 Jan 2019 10:15:51 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by fraxinus.osuosl.org (Postfix) with ESMTP id 33E4E80D9D; Tue, 15 Jan 2019 10:15:51 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by ash.osuosl.org (Postfix) with ESMTP id 3E99A1BF5F4 for ; Tue, 15 Jan 2019 10:15:46 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id 3C4EA86C82 for ; Tue, 15 Jan 2019 10:15:46 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 2c7bzqbncinQ for ; Tue, 15 Jan 2019 10:15:43 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-ed1-f68.google.com (mail-ed1-f68.google.com [209.85.208.68]) by hemlock.osuosl.org (Postfix) with ESMTPS id 2672C861B0 for ; Tue, 15 Jan 2019 10:15:43 +0000 (UTC) Received: by mail-ed1-f68.google.com with SMTP id o10so2040085edt.13 for ; Tue, 15 Jan 2019 02:15:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=GTT3sHENDsIQAZvxceOPX1eRhBO0lpPHuRhHfV6rrvk=; b=Z7TxX0lN8PGsfDKhyqHw+NiqDsuQlBPumu0WpuZeMuJxBqgsgOWDFlEHITh4/sF302 qAodkuigpCYDqxPGdD0VWmSX5CBpLl9y931tHe7veQ9ieeet0ilulPkhPKNCmtxu4tHV F87uDBCS2kWLMkUj94ihsm7p/u4t1vFJogv3dhXFMZYfX2M1dTdB2r0JTe4sZDPl6brY 3mY4HqDZ+z9RMcEqn7URposMH3dDaz3jHzYZ9/1JrhbP/JWoDxFWf66gktaQEnIiBkiu TpIlKP24qtK/D35xMN33lNyKh1ExJFJOD7TH4g9oolp7jQOgmzDqxJqq+7TV0cx58t+Q gbbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=GTT3sHENDsIQAZvxceOPX1eRhBO0lpPHuRhHfV6rrvk=; b=OcU0Bg0AlJZV+W22TYUvs8M9YtaT7PPN6+ArNKJ0LRJQmtfcVen8E7eJotHjXtRl1m daDXzARjlPoYJQ2y0iYS3C0icsj/31ffTStZ81jhzLnMz6GM+ROkbFRF315LL0KR4H9U mMIzlPqvfaf4uOaZqeXaBYcU6tl3DkCTBOCdttT3zxVvdCvsgWncINUlOA/9Sov51H74 hcyp3QfZBOOzPZRkumExjInBtGey/aYzlnX3K27xzKAVSFdGM+kMTdY6Amy1bOksquvp RHuO62klpa1YwBBKxkj+UGhWy/divqmYCPSIqnfJvl3jMo7qSaATMbQqUBap+vHQXy9i ugEA== X-Gm-Message-State: AJcUukfN2/4si/d6bIwB8Hnod9+hxCYAcXFzEs40AQ1qGBdSuKoDddE+ YI04CHzNp3nCdBM7YVeAJatA1A/u X-Google-Smtp-Source: ALg8bN4/OZxTdzc2iGVYkiSNNtJSJWtlnxUwvTtoledYmoULrFXKuqRIIXzr5kRyOoLavo/1QiSuew== X-Received: by 2002:a17:906:4e14:: with SMTP id z20-v6mr2465679eju.187.1547547341192; Tue, 15 Jan 2019 02:15:41 -0800 (PST) Received: from dell.be.48ers.dk (d51a5bc31.access.telenet.be. [81.165.188.49]) by smtp.gmail.com with ESMTPSA id n10sm4700162edq.33.2019.01.15.02.15.39 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 15 Jan 2019 02:15:40 -0800 (PST) Received: from peko by dell.be.48ers.dk with local (Exim 4.89) (envelope-from ) id 1gjLks-0005UJ-LA; Tue, 15 Jan 2019 11:15:34 +0100 From: Peter Korsgaard To: buildroot@buildroot.org Date: Tue, 15 Jan 2019 11:15:18 +0100 Message-Id: <20190115101522.21042-3-peter@korsgaard.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20190115101522.21042-1-peter@korsgaard.com> References: <20190115101522.21042-1-peter@korsgaard.com> Subject: [Buildroot] [PATCH v2 3/7] tpm2-tools: always disable hardening options X-BeenThere: buildroot@busybox.net X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Korsgaard MIME-Version: 1.0 Errors-To: buildroot-bounces@busybox.net Sender: "buildroot" Building with --enable-hardening (the default), forces -fstack-protector-all / FORTIFY_SOURCE=2. These options are now controlled Buildroot wide with the BR2_SSP_* / BR2_FORTIFY_SOURCE_* options. Disable hardening so the ssp/fortify settings in the toolchain wrapper / CFLAGS is used instead. Signed-off-by: Peter Korsgaard --- package/tpm2-tools/tpm2-tools.mk | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/package/tpm2-tools/tpm2-tools.mk b/package/tpm2-tools/tpm2-tools.mk index 9c224018ce..f7e2f85228 100644 --- a/package/tpm2-tools/tpm2-tools.mk +++ b/package/tpm2-tools/tpm2-tools.mk @@ -10,8 +10,9 @@ TPM2_TOOLS_LICENSE = BSD-2-Clause TPM2_TOOLS_LICENSE_FILES = LICENSE TPM2_TOOLS_DEPENDENCIES = dbus libcurl libglib2 openssl tpm2-tss host-pkgconf -# configure.ac doesn't contain a link test, so it doesn't detect when -# libssp is missing. -TPM2_TOOLS_CONF_OPTS = $(if $(BR2_TOOLCHAIN_HAS_SSP),--enable-hardening,--disable-hardening) +# -fstack-protector-all and FORTIFY_SOURCE=2 is used by +# default. Disable that so the BR2_SSP_* / BR2_FORTIFY_SOURCE_* options +# in the toolchain wrapper and CFLAGS are used instead +TPM2_TOOLS_CONF_OPTS = --disable-hardening $(eval $(autotools-package)) From patchwork Tue Jan 15 10:15:19 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Korsgaard X-Patchwork-Id: 1025101 Return-Path: X-Original-To: incoming-buildroot@patchwork.ozlabs.org Delivered-To: patchwork-incoming-buildroot@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=busybox.net (client-ip=140.211.166.133; helo=hemlock.osuosl.org; envelope-from=buildroot-bounces@busybox.net; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=korsgaard.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="ggzleBCc"; dkim-atps=neutral Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 43f5nz6YfKz9sCs for ; Tue, 15 Jan 2019 21:15:51 +1100 (AEDT) Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id 9F975861B0; Tue, 15 Jan 2019 10:15:47 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id OkDCLyolzmxf; Tue, 15 Jan 2019 10:15:46 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by hemlock.osuosl.org (Postfix) with ESMTP id EA73586C4B; Tue, 15 Jan 2019 10:15:45 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by ash.osuosl.org (Postfix) with ESMTP id DEADB1BF2A9 for ; Tue, 15 Jan 2019 10:15:41 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id DA78B853FF for ; Tue, 15 Jan 2019 10:15:41 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id XoSVLyXcoQCS for ; Tue, 15 Jan 2019 10:15:39 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-ed1-f67.google.com (mail-ed1-f67.google.com [209.85.208.67]) by fraxinus.osuosl.org (Postfix) with ESMTPS id 8C45A853FD for ; Tue, 15 Jan 2019 10:15:39 +0000 (UTC) Received: by mail-ed1-f67.google.com with SMTP id y20so2067562edw.9 for ; Tue, 15 Jan 2019 02:15:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=Mtroobfh+Wvvi4Y2aOnei6Ncn9oZcu+ZxUAjxG1UlsI=; b=ggzleBCctTVW/h/sOJt8uY4JwPj3s5qml6CMSmyBnBE/6WDml2HTwggyLw6Zdxmnj2 tO7pjgW/F12Ldhz432EL4llegNLXEJrptGvEZMeZMlkFBfBMXLyw655KqrQICe/1M1RT wwcULOfPY1O8/HCvzxdU6fhkIneh9t4d0HyExPQOivmoRfcdFSHQxU6PVjo/7rXwX+NK 2094kAyAXksIvYKKyKLQANoDvBfu3B4O52hIDdDeSjlrF2CbS+wQvrjITXnVZ8vtboOU ab3IRfy3yklv8ylKzuO6xsd3k2J2r523kb/nY2Uudea+wwi9G0mhvXdopcG5ZS+vk8x2 oIKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=Mtroobfh+Wvvi4Y2aOnei6Ncn9oZcu+ZxUAjxG1UlsI=; b=TEUI9onS18PlJqxJ/bmSsdaVnGrjSkHxcc0SY3XXWCO0IgsHGKo9TfSXXtTV3HUjRl MsAGGfWJkzJK15ff6lb/VreN2mVTC6/57Ytpr64ytRqqZWRfJunfL7KwJ3DQapQAZ2s+ w2fBuMfcc4aZwjaNINHxwKKlvlll+X3cnIBbIN8Bcc3ddZ7bd6xJbxiE3tqllz5KVdEi njjyAliYbXkzCYjH9pSI/+/mutV8QXuf5Veu0Q99rG085vxW7L2aIuQs3xGwz5bllE3q OeAptyG4Oji+vZGaqNPWN05z1ZVowj5mUuDlb+7NRLubIYZs4grgWErGisszgAr134Lc lcqg== X-Gm-Message-State: AJcUukdZeeqU9taaB/vG0ycWJIas7ws2bus+2ywh8n+71+qWBsXpoVog rK/qleY+0xzjh+x1+DPmnarAta6n X-Google-Smtp-Source: ALg8bN7dkHzta5ZnF7ETdUrHxoSDLUN1ccGzFXDVFRl5qDbUJL4+NUKzg1oS6VA1zMvevd7Qq6Na0Q== X-Received: by 2002:a17:906:2ec6:: with SMTP id s6-v6mr2500998eji.93.1547547337212; Tue, 15 Jan 2019 02:15:37 -0800 (PST) Received: from dell.be.48ers.dk (d51a5bc31.access.telenet.be. [81.165.188.49]) by smtp.gmail.com with ESMTPSA id k24-v6sm2641308eja.60.2019.01.15.02.15.35 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 15 Jan 2019 02:15:35 -0800 (PST) Received: from peko by dell.be.48ers.dk with local (Exim 4.89) (envelope-from ) id 1gjLks-0005UN-SL; Tue, 15 Jan 2019 11:15:34 +0100 From: Peter Korsgaard To: buildroot@buildroot.org Date: Tue, 15 Jan 2019 11:15:19 +0100 Message-Id: <20190115101522.21042-4-peter@korsgaard.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20190115101522.21042-1-peter@korsgaard.com> References: <20190115101522.21042-1-peter@korsgaard.com> Subject: [Buildroot] [PATCH v2 4/7] tpm2-abrmd: do not enforce -fstack-protector-all X-BeenThere: buildroot@busybox.net X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Korsgaard MIME-Version: 1.0 Errors-To: buildroot-bounces@busybox.net Sender: "buildroot" Stack protection is now controlled Buildroot wide with the BR2_SSP_* options, so disable the explicit -fstack-protector-all so the SSP logic in the toolchain wrapper is used instead. Signed-off-by: Peter Korsgaard --- package/tpm2-abrmd/tpm2-abrmd.mk | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/package/tpm2-abrmd/tpm2-abrmd.mk b/package/tpm2-abrmd/tpm2-abrmd.mk index 74cc66ba20..2834615ac3 100644 --- a/package/tpm2-abrmd/tpm2-abrmd.mk +++ b/package/tpm2-abrmd/tpm2-abrmd.mk @@ -11,9 +11,10 @@ TPM2_ABRMD_LICENSE_FILES = LICENSE TPM2_ABRMD_INSTALL_STAGING = YES TPM2_ABRMD_DEPENDENCIES = dbus libglib2 tpm2-tss host-pkgconf -# configure.ac doesn't contain a link test, so it doesn't detect when -# libssp is missing. -TPM2_ABRMD_CONF_ENV = ax_cv_check_cflags___________Werror_______fstack_protector_all=$(if $(BR2_TOOLCHAIN_HAS_SSP),yes,no) +# -fstack-protector-all is used by default. Disable that so the +# BR2_SSP_* options in the toolchain wrapper are used instead +TPM2_ABRMD_CONF_ENV = \ + ax_cv_check_cflags___________Werror_______fstack_protector_all=no TPM2_ABRMD_CONF_OPTS += \ --with-systemdsystemunitdir=$(if $(BR2_INIT_SYSTEMD),/usr/lib/systemd/system,no) \ From patchwork Tue Jan 15 10:15:20 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Korsgaard X-Patchwork-Id: 1025100 Return-Path: X-Original-To: incoming-buildroot@patchwork.ozlabs.org Delivered-To: patchwork-incoming-buildroot@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=busybox.net (client-ip=140.211.166.136; helo=silver.osuosl.org; envelope-from=buildroot-bounces@busybox.net; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=korsgaard.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="LUiq7N4o"; dkim-atps=neutral Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 43f5nz6Yg4z9sD9 for ; Tue, 15 Jan 2019 21:15:51 +1100 (AEDT) Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id 4337D23469; Tue, 15 Jan 2019 10:15:50 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id w-DQM-UnbQeZ; Tue, 15 Jan 2019 10:15:48 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by silver.osuosl.org (Postfix) with ESMTP id BE2C32338F; Tue, 15 Jan 2019 10:15:48 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by ash.osuosl.org (Postfix) with ESMTP id 04AD11BF2A9 for ; Tue, 15 Jan 2019 10:15:45 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id 020688609F for ; Tue, 15 Jan 2019 10:15:45 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 1+aHVoxExOGD for ; Tue, 15 Jan 2019 10:15:44 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-ed1-f65.google.com (mail-ed1-f65.google.com [209.85.208.65]) by whitealder.osuosl.org (Postfix) with ESMTPS id BD83285DBB for ; Tue, 15 Jan 2019 10:15:43 +0000 (UTC) Received: by mail-ed1-f65.google.com with SMTP id o10so2040108edt.13 for ; Tue, 15 Jan 2019 02:15:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=QXmXP4PfmWhMxbrMHtp7VJ8XptrepfZ92L7DpIN++OU=; b=LUiq7N4oh0PqO7LZmgo+HTmZ8R6Z5W3SjQTn8rqVbZsdXLJ+QfnC02hypni6tO3jES GF4eIkCdQSLf4ybcWY5x0Gn9i+FNVYh5SzQ+sEId6A69hAOmTaUxvZwuruW5fPVM+SV9 dqtCUiL0fkr/tlQIf8ffygZOqQs+r5ymWIyPKCBOPKGnJgZMWM391QydeXGAq9w6VoNa /PwjhnUW+zVV9BZB6kMZ8iWPs4r77uIn+jUKJ9ezqGAcAyGtqSDZwa+PhmBh5ab0XOi2 BIO+idXULf39YfujgeUvM5FJqrvKe9XMHZUSpQCJ87hymF/DebqIm6neeqrbdJxyiAIv axrg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=QXmXP4PfmWhMxbrMHtp7VJ8XptrepfZ92L7DpIN++OU=; b=HjjN8ZIFbmpNH5RuS3SF3rz9sWZnhTnNbcArOYy0/zb+4vhMZ8Hs/htOlQG1RUWdZH kLgnE54z+1D6d3gtZ0JKEeJUg2XGOQCuYLK2gkAeP+k2lyAzwQxlOvVRaBwzf/BkwgAl u1gqhMisP91F8Rqus8KAoJNWltJF28hQ5sO3FRE3+RZCYZIF5a4pO67w0oTzt0nJ6+Q+ j3QYLEsYHF8hfNwdss/BLU3RkApNrCZYYXpe2Q4s6QM/PcuBMXLKVtmr1kFh3enTvQJs RYCpG3mp06WJ8Lw7JFQiMuaWzfOUhdibSOIvK2GB+/f85ima3WLqrlceB9kaR5fS6r2r epuw== X-Gm-Message-State: AJcUukcpaFnZ8jEFCEbHHi0euE6U2h1DuzZAoGNLEEM2Ih2oBmOt4cAi INDhhVu9pdV0PTa7SRgctlyBlheG X-Google-Smtp-Source: ALg8bN7FX4myiS5jM81e6SRdLjEgLVJ+PlLmXJFdrMeIbX82VQ9BBjy9+DhlSIuIO+mvDp4EGc2r0w== X-Received: by 2002:a17:906:5611:: with SMTP id f17-v6mr2438604ejq.30.1547547336458; Tue, 15 Jan 2019 02:15:36 -0800 (PST) Received: from dell.be.48ers.dk (d51a5bc31.access.telenet.be. [81.165.188.49]) by smtp.gmail.com with ESMTPSA id d15-v6sm2686476ejc.31.2019.01.15.02.15.35 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 15 Jan 2019 02:15:35 -0800 (PST) Received: from peko by dell.be.48ers.dk with local (Exim 4.89) (envelope-from ) id 1gjLkt-0005US-3A; Tue, 15 Jan 2019 11:15:35 +0100 From: Peter Korsgaard To: buildroot@buildroot.org Date: Tue, 15 Jan 2019 11:15:20 +0100 Message-Id: <20190115101522.21042-5-peter@korsgaard.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20190115101522.21042-1-peter@korsgaard.com> References: <20190115101522.21042-1-peter@korsgaard.com> Subject: [Buildroot] [PATCH v2 5/7] tpm2-abrmd: fix build with BR2_FORTIFY_SOURCE_1 X-BeenThere: buildroot@busybox.net X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Korsgaard MIME-Version: 1.0 Errors-To: buildroot-bounces@busybox.net Sender: "buildroot" The configure script passes -U FORTIFY_SOURCE -D FORTIFY_SOURCE=2 by default, which conflicts with BR2_FORTIFY_SOURCE_1 as -Werror is used: -gcc .. -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 .. -D_FORTIFY_SOURCE=1 :0:0: error: "_FORTIFY_SOURCE" redefined [-Werror] Disable this so the FORTIFY_SOURCE flags in TARGET_CFLAGS (if any) is used instead. Signed-off-by: Peter Korsgaard --- package/tpm2-abrmd/tpm2-abrmd.mk | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/package/tpm2-abrmd/tpm2-abrmd.mk b/package/tpm2-abrmd/tpm2-abrmd.mk index 2834615ac3..31f19f5d01 100644 --- a/package/tpm2-abrmd/tpm2-abrmd.mk +++ b/package/tpm2-abrmd/tpm2-abrmd.mk @@ -11,10 +11,13 @@ TPM2_ABRMD_LICENSE_FILES = LICENSE TPM2_ABRMD_INSTALL_STAGING = YES TPM2_ABRMD_DEPENDENCIES = dbus libglib2 tpm2-tss host-pkgconf -# -fstack-protector-all is used by default. Disable that so the -# BR2_SSP_* options in the toolchain wrapper are used instead +# -fstack-protector-all and FORTIFY_SOURCE=2 is used by +# default. Disable that so the BR2_SSP_* / BR2_FORTIFY_SOURCE_* options +# in the toolchain wrapper and CFLAGS are used instead TPM2_ABRMD_CONF_ENV = \ - ax_cv_check_cflags___________Werror_______fstack_protector_all=no + ax_cv_check_cflags___________Werror_______fstack_protector_all=no \ + ax_cv_check_ccppflags___________Werror_______U_FORTIFY_SOURCE=no \ + ax_cv_check_ccppflags___________Werror_______D_FORTIFY_SOURCE_2=no TPM2_ABRMD_CONF_OPTS += \ --with-systemdsystemunitdir=$(if $(BR2_INIT_SYSTEMD),/usr/lib/systemd/system,no) \ From patchwork Tue Jan 15 10:15:21 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Korsgaard X-Patchwork-Id: 1025098 Return-Path: X-Original-To: incoming-buildroot@patchwork.ozlabs.org Delivered-To: patchwork-incoming-buildroot@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=busybox.net (client-ip=140.211.166.137; helo=fraxinus.osuosl.org; envelope-from=buildroot-bounces@busybox.net; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=korsgaard.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="Qh/9EL+X"; dkim-atps=neutral Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 43f5nx0y3Hz9sDB for ; Tue, 15 Jan 2019 21:15:48 +1100 (AEDT) Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id 70EBF8545B; Tue, 15 Jan 2019 10:15:46 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id J6-DGXCnIVNi; Tue, 15 Jan 2019 10:15:44 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by fraxinus.osuosl.org (Postfix) with ESMTP id 66CE1853FF; Tue, 15 Jan 2019 10:15:44 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by ash.osuosl.org (Postfix) with ESMTP id 4E0A21BF2A9 for ; Tue, 15 Jan 2019 10:15:41 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id 49CD923376 for ; Tue, 15 Jan 2019 10:15:41 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id drPmRxdaMyFi for ; Tue, 15 Jan 2019 10:15:40 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-ed1-f65.google.com (mail-ed1-f65.google.com [209.85.208.65]) by silver.osuosl.org (Postfix) with ESMTPS id 42C8822660 for ; Tue, 15 Jan 2019 10:15:40 +0000 (UTC) Received: by mail-ed1-f65.google.com with SMTP id f23so2104833edb.3 for ; Tue, 15 Jan 2019 02:15:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=k2TnMd8/sgKDNTm3PVwBGAPifz+hk67i1/ZjKtB606M=; b=Qh/9EL+XSJyLEuCsf5ZxjVCZH/c5S6GoMPcUFtxhC3OI9kedSA1nrjr+7QZFHIy1rI L96bABKUg0CqCuaoFMKPpFfkS3QoPWmTD+I7k5s0rpCOhLaWpwWH1Xz6k1rrkq2FjHIZ IOkFukHV3FSJ34edjIXWPHcnoXBcOQ5/UbG0+DrMhjkt+YNI91r0hlH3F8Xv0y2OKMuO vhZluvxGSc/xMY4k/UikpA3oc4wxOTpZMiUqbyOaV1GSnqXNSjdR7zlbBOjWiljaIXpn im8d3scNxQUfAwRGLU5dWqHrxov7Pm5FY0FCS61ggS77mfV9XCq/stY2YrRCg6cM2kew 3wIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=k2TnMd8/sgKDNTm3PVwBGAPifz+hk67i1/ZjKtB606M=; b=bAboLNpfKPBJ+vf+WI7ORUQKzV9wza6W8SH87SsR0P14/zxZSeyHVK33P18Pxy9a4u +NvwWBRZMI2jd+nDUyjnk7+NGNjASBT4HchAmR94yeWfObW3TprKWXUk20zItNcA6Opw It2R+Ph+KUbMkvmWw9mvjrNXnMBNcNi9ORAOgoFekc/aEll31fQLaTw3cXKbPBP2MhsV YvNmyjAAbxgQ79L+qlfoApda1OYaKkjrjapRgZ89FJG2f0O8IJlNCy09LTbgi+r5LEOi wo32CmHzUeGx/1uKpNqv4owFGYIEDcy5b1bMKnmXOSFEUNI/goz9g/lMKJXFsDlLVl81 2S2Q== X-Gm-Message-State: AJcUukdAPJXr6E1SAwgOPG9vxend9DHZx4IKeodum5rpsPcv5Hf05vQg 3z4ZpD3u/aCIVLfGj8oyPlVQHImo X-Google-Smtp-Source: ALg8bN7X0U2HQtaKJ540HeBjsso2vf6ZjQIC/V5W2tsoYwMicqPYnVeMVPJHNehEROIId7uZuhfTxg== X-Received: by 2002:a17:906:2e4f:: with SMTP id r15-v6mr2515562eji.198.1547547338142; Tue, 15 Jan 2019 02:15:38 -0800 (PST) Received: from dell.be.48ers.dk (d51a5bc31.access.telenet.be. [81.165.188.49]) by smtp.gmail.com with ESMTPSA id s3sm4793488edm.31.2019.01.15.02.15.35 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 15 Jan 2019 02:15:35 -0800 (PST) Received: from peko by dell.be.48ers.dk with local (Exim 4.89) (envelope-from ) id 1gjLkt-0005UX-AU; Tue, 15 Jan 2019 11:15:35 +0100 From: Peter Korsgaard To: buildroot@buildroot.org Date: Tue, 15 Jan 2019 11:15:21 +0100 Message-Id: <20190115101522.21042-6-peter@korsgaard.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20190115101522.21042-1-peter@korsgaard.com> References: <20190115101522.21042-1-peter@korsgaard.com> Subject: [Buildroot] [PATCH v2 6/7] tpm2-tools: do not enforce dependency on tpm2-abrmd X-BeenThere: buildroot@busybox.net X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Korsgaard MIME-Version: 1.0 Errors-To: buildroot-bounces@busybox.net Sender: "buildroot" tpm2-tools is commonly used with the resource manager, tpm2-abrmd - But it CAN be used without, E.G. by setting the TPM2TOOLS_TCTI_NAME environment variable to communicate directly with the kernel driver: export TPM2TOOLS_TCTI_NAME=device For some use cases (E.G. initramfs) it makes sense to use tpm2-tools without abrmd, so downgrade the dependency from select to imply, so abrmd is enabled by default but can be explicitly disabled. Signed-off-by: Peter Korsgaard --- package/tpm2-tools/Config.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package/tpm2-tools/Config.in b/package/tpm2-tools/Config.in index cc87e2a1bf..f4622b4ec9 100644 --- a/package/tpm2-tools/Config.in +++ b/package/tpm2-tools/Config.in @@ -8,7 +8,7 @@ config BR2_PACKAGE_TPM2_TOOLS select BR2_PACKAGE_LIBCURL select BR2_PACKAGE_LIBGLIB2 select BR2_PACKAGE_OPENSSL - select BR2_PACKAGE_TPM2_ABRMD # run-time + imply BR2_PACKAGE_TPM2_ABRMD # run-time select BR2_PACKAGE_TPM2_TSS help TPM (Trusted Platform Module) 2.0 CLI tools based on system From patchwork Tue Jan 15 10:15:22 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Korsgaard X-Patchwork-Id: 1025099 Return-Path: X-Original-To: incoming-buildroot@patchwork.ozlabs.org Delivered-To: patchwork-incoming-buildroot@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=busybox.net (client-ip=140.211.166.138; helo=whitealder.osuosl.org; envelope-from=buildroot-bounces@busybox.net; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=korsgaard.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="H6DqlFDV"; dkim-atps=neutral Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 43f5ny06MXz9sCs for ; Tue, 15 Jan 2019 21:15:49 +1100 (AEDT) Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id 86D85860E1; Tue, 15 Jan 2019 10:15:46 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id vWFGbZqFmq4J; Tue, 15 Jan 2019 10:15:45 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by whitealder.osuosl.org (Postfix) with ESMTP id 28F8C8609F; Tue, 15 Jan 2019 10:15:45 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by ash.osuosl.org (Postfix) with ESMTP id 95F051BF2A9 for ; Tue, 15 Jan 2019 10:15:41 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id 93B4322660 for ; Tue, 15 Jan 2019 10:15:41 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id aDYXImfG-S1g for ; Tue, 15 Jan 2019 10:15:41 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-ed1-f44.google.com (mail-ed1-f44.google.com [209.85.208.44]) by silver.osuosl.org (Postfix) with ESMTPS id ED7452333F for ; Tue, 15 Jan 2019 10:15:40 +0000 (UTC) Received: by mail-ed1-f44.google.com with SMTP id f23so2104852edb.3 for ; Tue, 15 Jan 2019 02:15:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=NHJSX/n+Mzvdj+UbeFAz96R36RqHH/Owp1EUxhPzjeM=; b=H6DqlFDV0tyQBd3hxAFIWSDgjQWHi7iFpNph8Hu/qcqf8USDtZ8X9PUCFRQNuUDtgC cbhIttUcw/uIcmjFUQo5IKQ5ChR+O7BHM+YEvIRmKJzgeylrRXsB4wANqlY4Tgjh5nUB 0whnzIa0ORMWS378FV8aebP9+NCZwUy3acLxBvqeG2uhGCy0vnn6WuQ63eXmA4Kh1uD0 2ZOfJlamnv9JXcAnBeA20YJjM1+Kqnh3KYIEd0mjg87jFoIooN4gP35eg9NSsZVlQyAH myBn6eV9kQzg5FVwUPNVMVYgzWvAt1RG35Z8BYka3g18aZm/4xvke3v6SVZ1OF9+vV1o Tp+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=NHJSX/n+Mzvdj+UbeFAz96R36RqHH/Owp1EUxhPzjeM=; b=rZrJGzpxeQ5D6wMZp51/BHddplR112mwgC1jigH0/o0o/vZSbcav+m2x28hvqPhrBx 8deE2Zu2jQYS8zVmolq4PxKxV1jJpEOmHqUFEQzrhu7UrkHM6b90YCgwqqs1ZNbMUPSL 4JtYXe22xFJJL3gISJ+PJH6qoeGu+nDPfGQ9+UJJak7Ixu8+X8oThuJlmlRV4C2sHrPP drWMJwCMiHggVOnwoYzyFsZjZogJtVbbhaMxwBPq+88OjyUlouLJQDYEdSCxxpz8dpK9 V0Uzp2vaV1LQJWRSDLygZVa/6E7jUNUWFUKk7zHeVErgoIM1w5WuFPOZfFg2zacqPICE fOrQ== X-Gm-Message-State: AJcUukfnj2MRku+X5krx2uTqLD5+9ICOCQol9z9sVo6/NyTEM+zcRrBC JiCVkjIoLZkh/oxwUixA3QWmSn7F X-Google-Smtp-Source: ALg8bN68CO4yn3/JZlAEbeWeU6j6pm8+wIZM4t801TEszmwzMeymJpCp3U4kqbNpPMxSqYb/2FUClQ== X-Received: by 2002:a50:c2d9:: with SMTP id u25mr2858734edf.280.1547547338997; Tue, 15 Jan 2019 02:15:38 -0800 (PST) Received: from dell.be.48ers.dk (d51a5bc31.access.telenet.be. [81.165.188.49]) by smtp.gmail.com with ESMTPSA id y4-v6sm2652106ejc.10.2019.01.15.02.15.35 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 15 Jan 2019 02:15:38 -0800 (PST) Received: from peko by dell.be.48ers.dk with local (Exim 4.89) (envelope-from ) id 1gjLkt-0005Uc-He; Tue, 15 Jan 2019 11:15:35 +0100 From: Peter Korsgaard To: buildroot@buildroot.org Date: Tue, 15 Jan 2019 11:15:22 +0100 Message-Id: <20190115101522.21042-7-peter@korsgaard.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20190115101522.21042-1-peter@korsgaard.com> References: <20190115101522.21042-1-peter@korsgaard.com> Subject: [Buildroot] [PATCH v2 7/7] tpm2-abrmd: S80tpm2-abrmd: create pid file at startup X-BeenThere: buildroot@busybox.net X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Korsgaard MIME-Version: 1.0 Errors-To: buildroot-bounces@busybox.net Sender: "buildroot" The start-stop-daemon invocation to start abrmd was missing the -m (make pidfile) option, causing stop to fail. Signed-off-by: Peter Korsgaard --- package/tpm2-abrmd/S80tpm2-abrmd | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package/tpm2-abrmd/S80tpm2-abrmd b/package/tpm2-abrmd/S80tpm2-abrmd index cfa9d44771..6a0bef0a31 100755 --- a/package/tpm2-abrmd/S80tpm2-abrmd +++ b/package/tpm2-abrmd/S80tpm2-abrmd @@ -28,7 +28,7 @@ start() { printf "Starting tpm2-abrmd: " check_device rm_stale_pidfile /var/run/tpm2-abrmd.pid /usr/sbin/tpm2-abrmd - start-stop-daemon -S -q -o -b -p /var/run/tpm2-abrmd.pid -c tss:tss -x /usr/sbin/tpm2-abrmd -- ${DAEMON_OPTS} || { + start-stop-daemon -S -q -o -b -m -p /var/run/tpm2-abrmd.pid -c tss:tss -x /usr/sbin/tpm2-abrmd -- ${DAEMON_OPTS} || { echo "FAIL" exit 1 }