From patchwork Thu Jan 10 00:17:17 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Andreas K. Huettel" X-Patchwork-Id: 1022645 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=sourceware.org (client-ip=209.132.180.131; helo=sourceware.org; envelope-from=libc-alpha-return-99149-incoming=patchwork.ozlabs.org@sourceware.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gentoo.org Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.b="oG23Y9qU"; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=akhuettel.de header.i=@akhuettel.de header.b="tJbTVMT3"; dkim-atps=neutral Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 43Zmm70qcgz9sMM for ; Thu, 10 Jan 2019 11:17:42 +1100 (AEDT) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:cc:subject:date:message-id :mime-version:content-transfer-encoding; q=dns; s=default; b=S5v LeoM43fNKkz9E8wgTXp1y7OOfQRpqL1kkEgYvgppXSK1mikM+xsBse2RoeCp+qpJ G6X6u1eRR4Ij2tY6q031CUFnAY1y4F5qJi8lr44xSyZcEdg9sGnfflU5Y7kOmcxV 97HKZ8x1rXLr+QF1aaGrVfZvyYt58GbHGMW8fTr4= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:cc:subject:date:message-id :mime-version:content-transfer-encoding; s=default; bh=p6Eh6utWC PVGNMXx9IOMG43uuRg=; b=oG23Y9qUx4GxIdfa0dyNdAyalri4wC9FLRJxvBTMr oEjOtG7MsdEXtWqQTForR2CKBY3RrDtuTP6dsJUxPgh8vUSNS35fZ+dgXIVwilYn mzUDzM9vVEWyYn3c9isN/ep2gWoAGOWnmE1mwS/p7niV2cZ27wOv0pg7F3dazJ+h 8E= Received: (qmail 103246 invoked by alias); 10 Jan 2019 00:17:37 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 102866 invoked by uid 89); 10 Jan 2019 00:17:36 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-27.6 required=5.0 tests=BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_LOW, SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=HContent-Transfer-Encoding:8bit X-HELO: mo4-p00-ob.smtp.rzone.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1547079452; s=strato-dkim-0002; d=akhuettel.de; h=Message-Id:Date:Subject:Cc:To:From:X-RZG-CLASS-ID:X-RZG-AUTH:From: Subject:Sender; bh=yz+rj/aBem2lQBflCHFzPKx/W2ob9Np4Xv0nQzjq9eA=; b=tJbTVMT3t/GrYuwJkmq063r6vYO6SRocYg2ViGMMCJuV/QNouauI3V2Yes48dCkVJl pI6MtCg6uRrDLk6YM/cGXNU5TQ1WXVKfou4LcvIubbY4Gv6MsJOyMJVUwkK5zQZoT+J2 UwXfhfnKZdYq4PS7tNa8trUbyclkZOgqt++B9NHiiDQFkSoi2tnLk86ioLvv5PHB7Ozl 5xKO4s+/oo/Rfb3xqCdurll9JHcNKvMT6zZYSpujjp/Ac4S6YnE5VHpo7SjfEPE2bbD2 0aX/vJYLY+OMw+IH+DxL6k3IawoXR0M9b60yo5FqDMpkH1P9rg0m43tDNSVoWs586gLT yoeA== From: =?utf-8?q?Andreas_K=2E_H=C3=BCttel?= To: libc-alpha@sourceware.org Cc: =?utf-8?q?Andreas_K=2E_H=C3=BCttel?= Subject: [PATCH] resolv: AAAA (28) is valid, no fallthrough to default Date: Thu, 10 Jan 2019 01:17:17 +0100 Message-Id: <20190110001717.25717-1-dilfridge@gentoo.org> MIME-Version: 1.0 The test resolv/tst-resolv-ai_idn-nolibidn2 kept failing, with the puzzling output "invalid qtype: 28". Puzzling since 28 is an AAAA record. Turns out the switch statement is missing a break, so the "T_AAAA" case continues with "default". --- resolv/tst-resolv-ai_idn-common.c | 1 + 1 file changed, 1 insertion(+) diff --git a/resolv/tst-resolv-ai_idn-common.c b/resolv/tst-resolv-ai_idn-common.c index bb81c2ca23..61cc81b71f 100644 --- a/resolv/tst-resolv-ai_idn-common.c +++ b/resolv/tst-resolv-ai_idn-common.c @@ -241,6 +241,7 @@ response (const struct resolv_response_context *ctx, qname[0] }; resolv_response_add_data (b, &addr, sizeof (addr)); } + break; default: FAIL_EXIT1 ("invalid qtype: %d", qtype); }