From patchwork Mon Jan 7 09:22:35 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ye Li X-Patchwork-Id: 1021224 X-Patchwork-Delegate: trini@ti.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.denx.de (client-ip=81.169.180.215; helo=lists.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=nxp.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=nxp.com header.i=@nxp.com header.b="x3mYPrPT"; dkim-atps=neutral Received: from lists.denx.de (dione.denx.de [81.169.180.215]) by ozlabs.org (Postfix) with ESMTP id 43Y90S3m8Vz9sCX for ; Mon, 7 Jan 2019 20:22:48 +1100 (AEDT) Received: by lists.denx.de (Postfix, from userid 105) id 35ED9C21DA1; Mon, 7 Jan 2019 09:22:42 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=SPF_HELO_PASS, T_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.0 Received: from lists.denx.de (localhost [IPv6:::1]) by lists.denx.de (Postfix) with ESMTP id F4209C21D8E; Mon, 7 Jan 2019 09:22:39 +0000 (UTC) Received: by lists.denx.de (Postfix, from userid 105) id F1072C21CB6; Mon, 7 Jan 2019 09:22:37 +0000 (UTC) Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-eopbgr150040.outbound.protection.outlook.com [40.107.15.40]) by lists.denx.de (Postfix) with ESMTPS id 8801FC21C6A for ; Mon, 7 Jan 2019 09:22:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vQWakEWnShJJIx5Bne3NWZiGcfacdE7mA15/mpyGBZw=; b=x3mYPrPTFWYeb+JqOkBnUmtpSZDRkBg0InAsaPprt80AIS4/VBpsuCpi7Ap4d/9Xg3O6M4qjG5YiHZzBaODZVQvXuM+zU+fk4gE3CeXj03roLj8h2GJJEU1l34GGOXbc8ICb1t3EwHCEqs0GiuWGgfkvVz4jZY2lCk8Y7SptVI8= Received: from VI1PR04MB4414.eurprd04.prod.outlook.com (20.177.55.153) by VI1PR04MB2973.eurprd04.prod.outlook.com (10.170.228.27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1495.7; Mon, 7 Jan 2019 09:22:35 +0000 Received: from VI1PR04MB4414.eurprd04.prod.outlook.com ([fe80::f1e0:df54:f9c:b4b9]) by VI1PR04MB4414.eurprd04.prod.outlook.com ([fe80::f1e0:df54:f9c:b4b9%3]) with mapi id 15.20.1495.011; Mon, 7 Jan 2019 09:22:35 +0000 From: Ye Li To: "trini@konsulko.com" , "u-boot@lists.denx.de" Thread-Topic: [PATCH] env: sata: Fix saveenv issue Thread-Index: AQHUpmqG9YCSsc1ZlEaZWADytmQzWA== Date: Mon, 7 Jan 2019 09:22:35 +0000 Message-ID: <1546852938-24209-1-git-send-email-ye.li@nxp.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: git-send-email 2.7.4 x-clientproxiedby: HK0PR03CA0006.apcprd03.prod.outlook.com (2603:1096:203:2e::18) To VI1PR04MB4414.eurprd04.prod.outlook.com (2603:10a6:803:6e::25) authentication-results: spf=none (sender IP is ) smtp.mailfrom=ye.li@nxp.com; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [119.31.174.68] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; VI1PR04MB2973; 6:7JM720o1b5vNfi/UCW7Xh+LQva6wlsGjHa512I/DRaQHVN+TXWAoFebG7mKooq/+15cc3xbXdIOZiFmieFx8wXY4aaZR0xj/+gJJ+RkpkkBiZ/YMqQeC+gIO+atFVJ8UjZ8057nZviyUs20kd80Gf3W97g+XNaNMk2iUgvRCJCXpPGJjg+i9OiT+T5kfY8YqX/VuldYy2xhfeauT0DrAgxfcM7TcCfdH44tv7lLKdVRYOoqlU0FRDvuPUuQfy1Ec4WwgcMKqsFLPWQJeVD+JX21CNOd+2b3IGkhH2w1jHH7krR+lpTzqMYJqfl/hDG7YjEYUXDVO2Ctrtg7zcfjVOejWAZ8Z7M+Khil/lzgjHO36BUMOCcp0kBigFWhT0FVONP2/ha8qc4pO03zfX1sWQ3+Yo0qAyoSq1Gmaen57z22hLnQnWHX7deARqjllQVOREWLK6MUG6U9OdORjqduspg==; 5:as1a8e68xO9Ul9WLgH2D2Q/HkR21LzDE/aUzYLFyl985E3XGRqJN0grtruxrIYLPChraedwsmcdR8UnSIPZbiA7rhBotUUiCD3NmwgIrDzzdkPxt3VkPDplhE+OK/SkxCmlmcl6Pgp20YLqo6C3xA8D25hy8zMsIDzusdp5y+kYWQ50JDz+nZ/3vG9Bk3ciEc/JdQoEUWv8wl1UxPSrv+A==; 7:x8Vl1XezWM6OdMfMH9lGBtGkVaSK4DUkAWenAXdSNOfyc9DBVlO0JrcV1ZBUl2jG7qHUfWZWUtXMZEdu6MAPNViDec/gbXxvesMIm/uBIQSu0LaT19P/b13IMvIcqr5So/+b3+0aAuAbyBgwxZ9/5Q== x-ms-office365-filtering-correlation-id: 3a5a4a6b-6104-4234-2031-08d67481a8b1 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600109)(711020)(4618075)(2017052603328)(7153060)(7193020); SRVR:VI1PR04MB2973; x-ms-traffictypediagnostic: VI1PR04MB2973: x-microsoft-antispam-prvs: x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(3230021)(908002)(999002)(5005026)(6040522)(8220060)(2401047)(8121501046)(10201501046)(3002001)(3231475)(944501520)(52105112)(93006095)(93001095)(6055026)(6041310)(20161123562045)(20161123560045)(20161123558120)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123564045)(201708071742011)(7699051)(76991095); SRVR:VI1PR04MB2973; BCL:0; PCL:0; RULEID:; SRVR:VI1PR04MB2973; x-forefront-prvs: 0910AAF391 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(136003)(346002)(396003)(376002)(39860400002)(366004)(199004)(189003)(81166006)(81156014)(4326008)(2906002)(66066001)(36756003)(3846002)(6116002)(6436002)(110136005)(8676002)(186003)(6512007)(5660300001)(2501003)(8936002)(50226002)(71190400001)(7736002)(68736007)(305945005)(2616005)(476003)(316002)(14454004)(54906003)(386003)(6506007)(106356001)(71200400001)(26005)(102836004)(97736004)(52116002)(53936002)(256004)(478600001)(86362001)(486006)(105586002)(44832011)(99286004)(6486002)(25786009)(14444005); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR04MB2973; H:VI1PR04MB4414.eurprd04.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: qMxFyOCk1Y+dxQLGh6VxBQaltXKAe/0hgQAJIlbH7jrkMdDQuyQ7i1pGwYNF60ZKgeQhpPnSGcfFAh2OnA3sXMyv7tD3LpGtMNvDZ44pOPBqdHKWDhWtwan8Ho/8JhDlP5wRvPVRDJ+4apeHXv74IXt4Ry4JbJ0CURjKnTKWxsxy1YtZV4WDQL5FLQPRxdeuh1XOPVU32nUPUpHUmeT3pP9h10CIyXpX7nYmopUZBxH1Uax1OdIYMM6FUL/EM9RivhIBis/Ld0uSBzuwN6EA/JEdSaQakLT54DMnRXfLQt22o3mTM+Jo7UZvAVR1ZSEH spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3a5a4a6b-6104-4234-2031-08d67481a8b1 X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Jan 2019 09:22:32.4131 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB2973 Cc: Fabio Estevam , dl-uboot-imx Subject: [U-Boot] [PATCH] env: sata: Fix saveenv issue X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.18 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" Wrong env buffer was passed into sata write function, cause the saveenv not work. Signed-off-by: Ye Li --- env/sata.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/env/sata.c b/env/sata.c index 59aedf4..a2ff5c6 100644 --- a/env/sata.c +++ b/env/sata.c @@ -65,7 +65,7 @@ static int env_sata_save(void) return 1; printf("Writing to SATA(%d)...", env_sata); - if (write_env(sata, CONFIG_ENV_SIZE, CONFIG_ENV_OFFSET, &env_new)) { + if (write_env(sata, CONFIG_ENV_SIZE, CONFIG_ENV_OFFSET, (u_char *)env_new)) { puts("failed\n"); return 1; }