From patchwork Tue Jan 1 13:30:28 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: cgxu519 X-Patchwork-Id: 1019763 Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=linux-ext4-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=gmx.com Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 43TZnM2ps0z9s4s for ; Wed, 2 Jan 2019 00:30:47 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728803AbfAANaq (ORCPT ); Tue, 1 Jan 2019 08:30:46 -0500 Received: from mout.gmx.net ([212.227.17.21]:46953 "EHLO mout.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728493AbfAANap (ORCPT ); Tue, 1 Jan 2019 08:30:45 -0500 Received: from localhost.localdomain ([113.116.158.159]) by mail.gmx.com (mrgmx102 [212.227.17.174]) with ESMTPSA (Nemesis) id 0MeMOx-1gyL0k10pD-00QDfL; Tue, 01 Jan 2019 14:30:37 +0100 From: Chengguang Xu To: jack@suse.com Cc: linux-ext4@vger.kernel.org, Chengguang Xu Subject: [PATCH] ext2: set proper return code Date: Tue, 1 Jan 2019 21:30:28 +0800 Message-Id: <20190101133028.18021-1-cgxu519@gmx.com> X-Mailer: git-send-email 2.17.2 X-Provags-ID: V03:K1:q1WqxOD2Ld8UZ57ewyP6Yj+O5hpjMQbVomPf+KBi8vaCKGqXleg IGR9FOQZ4NOu8GH4gn/3Z/7Jh8+umRAtR2qdh0O0DL+ikLPRAMrm9MQ6/65XzeUZaY/Td/U zbvPEhF/3C9/+Lon8bAn7VayBmzEa0WTbKsR6JvUlEFg2PkLMGB72mMcfiNtVy+ytHMIer9 0whHQ7Hi+ox16CZT+o4qg== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1; V03:K0:iv2VLyrRkQs=:UcpAIG5P2xiq1hwr2Y68AE YFCyr/qtEiF3n1Tl24Exm6AQVV5VHociq3WRsFT1BvFrTj0pcnejvz8QpHnx0kKnMM1AcX0ti ii1TKgChIZ3qe8Ei5D56VTsRghG2tWQ925qJgSl+f+QTrhLnaFGSP2XhmTO+6KAtKA7QANKar W7FmemHzTPF4BTz/tLG0td9vom4ybySVZq6TEz8/JTLgyurZE8EDrpEVitZYsLPGmMpAILLmK RnON7dLfvYMjGBroZbTlatAM/+skQzX1yZvxdUKK1xPQRy1bmgV1h3l9zZirwPLbvMShyKjQB C3rTY2XYKnK4p1qCoK4VHODgbULclL6hnRObCm9ACklHmM1snIEjW4HYi8hQTfxl5UzmoxKNY 3OnJ/FM1hdP03mD4KkkxqygOcqEE57ZBMkq4zRYPTnIJ1sLswUEp68QC2Zn6NlnF9HVL4eAD5 EZ1J3481levsYgVxpWKz/Os/8WZdWtqAJ4h+rFdD+a8aZ/Ms7EHuAcKM/0nYEUaMjD7ZKBkHx lJDihKPaDt+90FDDCGITXgxV2mmRx8qdn3Bd3TgAZl7kWR3L10ye/8aVMCuLwjxiqS167nFTx kRxqQ51wLk6i3j9OGtDISjln7u81TRNi6xExxtl6kusepugKJ+/WVXRVZow4iBgTpLvSsThPA ZdjgnR9Z/R4BLtN2PUT8wANO619KHaTXUb+xijJk+x66Q9MgZWbhlGdRNQv40gSSE0kZt7H19 gCWJv6gSHjD6js9C8xeQtecf0AEVRnOyZjk+XMMK98qdYJFREa08Q6zSLb/z+DCQM5yYG/dAi DBuJqx1WF2DOLc0qifXtUldVIWvfes3NW3As0EBMMMmIfr4MNAr0WBLOeLgm+Z1N234f0H/ya lKaSxLAap0xRAyUOKD3qtjVk95VvaD1aICIlF0D3s= Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org Set proper return code when failing from allocating memory in ext2_fill_super(). Signed-off-by: Chengguang Xu --- fs/ext2/super.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/fs/ext2/super.c b/fs/ext2/super.c index 73b2d528237f..b6d8402f5c62 100644 --- a/fs/ext2/super.c +++ b/fs/ext2/super.c @@ -1087,12 +1087,14 @@ static int ext2_fill_super(struct super_block *sb, void *data, int silent) sizeof(struct buffer_head *), GFP_KERNEL); if (sbi->s_group_desc == NULL) { + ret = -ENOMEM; ext2_msg(sb, KERN_ERR, "error: not enough memory"); goto failed_mount; } bgl_lock_init(sbi->s_blockgroup_lock); sbi->s_debts = kcalloc(sbi->s_groups_count, sizeof(*sbi->s_debts), GFP_KERNEL); if (!sbi->s_debts) { + ret = -ENOMEM; ext2_msg(sb, KERN_ERR, "error: not enough memory"); goto failed_mount_group_desc; } @@ -1148,6 +1150,7 @@ static int ext2_fill_super(struct super_block *sb, void *data, int silent) #ifdef CONFIG_EXT2_FS_XATTR sbi->s_ea_block_cache = ext2_xattr_create_cache(); if (!sbi->s_ea_block_cache) { + ret = -ENOMEM; ext2_msg(sb, KERN_ERR, "Failed to create ea_block_cache"); goto failed_mount3; }