From patchwork Thu Dec 27 20:28:55 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Aditya Pakki X-Patchwork-Id: 1018998 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=linux-rtc-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=umn.edu Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=umn.edu header.i=@umn.edu header.b="oUuWXCTp"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 43QhJR2fBDz9s55 for ; Fri, 28 Dec 2018 07:29:11 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729818AbeL0U3K (ORCPT ); Thu, 27 Dec 2018 15:29:10 -0500 Received: from mta-p8.oit.umn.edu ([134.84.196.208]:36396 "EHLO mta-p8.oit.umn.edu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729751AbeL0U3K (ORCPT ); Thu, 27 Dec 2018 15:29:10 -0500 Received: from localhost (unknown [127.0.0.1]) by mta-p8.oit.umn.edu (Postfix) with ESMTP id C3248832 for ; Thu, 27 Dec 2018 20:29:08 +0000 (UTC) X-Virus-Scanned: amavisd-new at umn.edu Received: from mta-p8.oit.umn.edu ([127.0.0.1]) by localhost (mta-p8.oit.umn.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id kJcTsa6Af2V1 for ; Thu, 27 Dec 2018 14:29:08 -0600 (CST) Received: from mail-io1-f69.google.com (mail-io1-f69.google.com [209.85.166.69]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mta-p8.oit.umn.edu (Postfix) with ESMTPS id 959A683C for ; Thu, 27 Dec 2018 14:29:08 -0600 (CST) Received: by mail-io1-f69.google.com with SMTP id t13so17972614ioi.3 for ; Thu, 27 Dec 2018 12:29:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=umn.edu; s=google; h=from:to:cc:subject:date:message-id; bh=qjUzW9f7/4yeimAegS9XhZOTjFBdcEVLwOSIBSJ0prc=; b=oUuWXCTpnteBWnI7shWgSBR6/dafAmlge67rmMw8AoI0fYVSGB+vMFxmNnSDgZzBqW O8OiIPO7JuAvHiCDL6TmdY68CRnbQ6Ll3+GYvs0yq4DYHdMZ2Kn+Q/DwKoLGvyYsJIfH 8M82wut5lzjcXbYgCUEm3XpzccArpvpZtPq2SLUI0WJbDoJKcT62MI9+lvAqnMtgs/l7 ukGYreIYE/t55c0lqqEuSfTMLQNzHp+Ero8wAqSL0DO/M3/ydOeYP2pJpM+SkInJcfYf CfIslQ5mndO4jLwByaeZZGAen7TD6umUdBCJM5UoebdqJCJaym40Szuqlkxtgi4vt4a+ RM2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=qjUzW9f7/4yeimAegS9XhZOTjFBdcEVLwOSIBSJ0prc=; b=fac9QCt6EALrd/Ly++LkrGkG3LOWwk27hOsHDNpxTIfQ+bneMm2jtELK6GqLunj29+ hwkY78vS+x+LFFo/CFdSyw7ufmUhXVCDXHHk6JvNuqWx1Pd18RrlyliYbn4msLwx0fAo Uc2G5FAZcCIDU0GuFu/BUsgb2/D3oZMAqKeEEtI58qxwayB8m1uQB6g+L/tCCFVyD/U/ HWF3Y2EiaL3YXPyg7Kxukya7NClyHL/L7oASCyQLbk8JNZms5iEc6s2gjCwMSXHhjebZ 44kzcQZY/u6BFmB236nwxfUhpL5tBMry4jRpn8T3UKaGhVByIZ/JIC/GvcIltLUeMJQh n1EA== X-Gm-Message-State: AA+aEWZxvXNHJ3evxQsosG7xDjiB6kzxwwnvpkJyoGJ1qB9f+UJ7b+pM 7hH8Cz0rAP3VMpA5CfHDcGYAKjWoI8FoLieIVwnrvM2zSNJIrwwEn/m6NUU05aEJ9n2LuFwdvlZ vxtA4nO8COh9IcJvtowr05RaB X-Received: by 2002:a24:8e43:: with SMTP id h64mr15070161ite.26.1545942548193; Thu, 27 Dec 2018 12:29:08 -0800 (PST) X-Google-Smtp-Source: AFSGD/VD7S7scoxbvijQJ57zJIpbBZuVTH+RSgqsOE0jWcyAHMojgpEI41XBpcaw6fJooQyYfnvKeQ== X-Received: by 2002:a24:8e43:: with SMTP id h64mr15070154ite.26.1545942547933; Thu, 27 Dec 2018 12:29:07 -0800 (PST) Received: from cs-u-syssec1.cs.umn.edu (cs-u-syssec1.cs.umn.edu. [134.84.121.78]) by smtp.gmail.com with ESMTPSA id j129sm14939661itb.41.2018.12.27.12.29.07 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 27 Dec 2018 12:29:07 -0800 (PST) From: Aditya Pakki To: pakki001@umn.edu Cc: kjlu@umn.edu, Alessandro Zummo , Alexandre Belloni , linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] rtc: rv8803: Check return value of rv8803_write_reg Date: Thu, 27 Dec 2018 14:28:55 -0600 Message-Id: <20181227202856.27408-1-pakki001@umn.edu> X-Mailer: git-send-email 2.17.1 Sender: linux-rtc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rtc@vger.kernel.org In rv8803_handle_irq, rv8803_write_reg can return a failed return value when attempting to write to the bus. The fix checks the output and throws a dev_warn notifying of the failure. Signed-off-by: Aditya Pakki --- drivers/rtc/rtc-rv8803.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/drivers/rtc/rtc-rv8803.c b/drivers/rtc/rtc-rv8803.c index 450a0b831a2d..5a19d5ecbf57 100644 --- a/drivers/rtc/rtc-rv8803.c +++ b/drivers/rtc/rtc-rv8803.c @@ -180,8 +180,13 @@ static irqreturn_t rv8803_handle_irq(int irq, void *dev_id) if (events) { rtc_update_irq(rv8803->rtc, 1, events); - rv8803_write_reg(client, RV8803_FLAG, flags); - rv8803_write_reg(rv8803->client, RV8803_CTRL, rv8803->ctrl); + if (rv8803_write_reg(client, RV8803_FLAG, flags)) + dev_warn(&client->dev, "Failed to write RV8803 reg.\n"); + + if (rv8803_write_reg(rv8803->client, RV8803_CTRL, + rv8803->ctrl)) + dev_warn(&rv8803->client->dev, + "Failed to write RV8803_CTRL reg.\n"); } mutex_unlock(&rv8803->flags_lock);