From patchwork Wed Dec 26 18:04:06 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Aditya Pakki X-Patchwork-Id: 1018726 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=umn.edu Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=umn.edu header.i=@umn.edu header.b="MTWWNnHV"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 43Q1831xJCz9sCr for ; Thu, 27 Dec 2018 05:04:35 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727495AbeLZSES (ORCPT ); Wed, 26 Dec 2018 13:04:18 -0500 Received: from mta-p5.oit.umn.edu ([134.84.196.205]:60730 "EHLO mta-p5.oit.umn.edu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727358AbeLZSER (ORCPT ); Wed, 26 Dec 2018 13:04:17 -0500 Received: from localhost (unknown [127.0.0.1]) by mta-p5.oit.umn.edu (Postfix) with ESMTP id D9A23C50 for ; Wed, 26 Dec 2018 18:04:15 +0000 (UTC) X-Virus-Scanned: amavisd-new at umn.edu Received: from mta-p5.oit.umn.edu ([127.0.0.1]) by localhost (mta-p5.oit.umn.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id i1gV_TjPgfn9 for ; Wed, 26 Dec 2018 12:04:15 -0600 (CST) Received: from mail-it1-f198.google.com (mail-it1-f198.google.com [209.85.166.198]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mta-p5.oit.umn.edu (Postfix) with ESMTPS id A7129C2B for ; Wed, 26 Dec 2018 12:04:15 -0600 (CST) Received: by mail-it1-f198.google.com with SMTP id n124so19101914itb.7 for ; Wed, 26 Dec 2018 10:04:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=umn.edu; s=google; h=from:to:cc:subject:date:message-id; bh=pHDdXroo+ItPDxTlabWZU5oDTguS18rFy2uHl24kaBk=; b=MTWWNnHVzVJcy3d6X1krqUf0xkdTP07gw0MFCqqTK+ecXxQp7QgiNVwXRbaFEp6Gyu Yg48uUpSw246KkFw/h/UlFkbVXb4apSfQCTXfoTYWH5Is9GUi9/KHugK+Xz0uTvfrJP2 kyo7PwRncswsXbNwGFhcfHjYka0jT+d7FKu6C3jFCU1bZb7IUP20tWjLSluePmmXrw6V P/eA8xcxPc4OM3aLuwJmB+ibeJpfwIrmVgZ8tumOJLff7L/3ktiGvAA0JkgdaiJnf7vY lAhg0v+fI2Ck3wXugz3edIqzMBmBtsoeHc/yJdEvOdqqcTDzYT6hEUn95p2ikAGQns9l mOsg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=pHDdXroo+ItPDxTlabWZU5oDTguS18rFy2uHl24kaBk=; b=SXEDPuASNptxcJsRfJIecQ4m3NkM18A9/BkGChAIYMrkgBym77/b/c487Rb1yyaUwj gmXc84Pi87Q/lr/JiJ7P0dWump3F2N9K5YGdtHHEBmb6IKPq0wel7FFLV2lu8vf6VaOX xAz9UIqzSORdi5PT/E78lAuVzufaC8DS2Ti+GzLjNXD0hL+1y5HgjjeSe89IAoC3Hp/3 PbwxCt/MuvnsJBUQThlRbrJYsPUaxQqi3brr5yS7nIjkynX6cAdxMoJt1VYhqpfk3MVd XExyttxmalMIGvkTB3a2SjjeziHd/zQ380Yap8ddmVtxTWtmBuR3jxW5QxDnNu0YpqW2 Yz+A== X-Gm-Message-State: AA+aEWbapgzrCfj8/X8pAscq932GxqbnLxBMqN4ugWQWTbb9ktfyWKJb lCQSLI1C3KVIyL89YkuQuMd09S08UrbOZIu4XFx/SBRXIX4Ai/FbE6jG+iGicUz0DpcgaFdoSmN IuFTh5HU7ihhKi3IAs6aC X-Received: by 2002:a24:878c:: with SMTP id f134mr13397724ite.81.1545847455287; Wed, 26 Dec 2018 10:04:15 -0800 (PST) X-Google-Smtp-Source: ALg8bN41iqDw7l1lE9tyD8JsHbO2UsdnBdxKlFzT5Nglj6PYAUTwJZ0MbNFa8Xbw8dMxrbCc0VmzvQ== X-Received: by 2002:a24:878c:: with SMTP id f134mr13397707ite.81.1545847455022; Wed, 26 Dec 2018 10:04:15 -0800 (PST) Received: from cs-u-syssec1.cs.umn.edu (cs-u-syssec1.cs.umn.edu. [134.84.121.78]) by smtp.gmail.com with ESMTPSA id v189sm12935071itb.42.2018.12.26.10.04.13 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 26 Dec 2018 10:04:14 -0800 (PST) From: Aditya Pakki To: pakki001@umn.edu Cc: kjlu@umn.edu, Andrew Lunn , Florian Fainelli , Heiner Kallweit , "David S. Miller" , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] net: phy: phy: check return value of bus write Date: Wed, 26 Dec 2018 12:04:06 -0600 Message-Id: <20181226180406.7881-1-pakki001@umn.edu> X-Mailer: git-send-email 2.17.1 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org phy_mii_ioctl() could fail when writing to the bus via mdiobus_write(). The fix adds a check and returns an error in case of failure. Signed-off-by: Aditya Pakki --- drivers/net/phy/phy.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/net/phy/phy.c b/drivers/net/phy/phy.c index 1d73ac3309ce..1fbdaa96b36e 100644 --- a/drivers/net/phy/phy.c +++ b/drivers/net/phy/phy.c @@ -397,6 +397,7 @@ int phy_mii_ioctl(struct phy_device *phydev, struct ifreq *ifr, int cmd) struct mii_ioctl_data *mii_data = if_mii(ifr); u16 val = mii_data->val_in; bool change_autoneg = false; + int rc; switch (cmd) { case SIOCGMIIPHY: @@ -443,8 +444,10 @@ int phy_mii_ioctl(struct phy_device *phydev, struct ifreq *ifr, int cmd) } } - mdiobus_write(phydev->mdio.bus, mii_data->phy_id, - mii_data->reg_num, val); + rc = mdiobus_write(phydev->mdio.bus, mii_data->phy_id, + mii_data->reg_num, val); + if (rc) + return rc; if (mii_data->phy_id == phydev->mdio.addr && mii_data->reg_num == MII_BMCR &&