From patchwork Mon Dec 24 05:45:56 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Cong Wang X-Patchwork-Id: 1018199 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="pZG58gjn"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 43NSrr0Qb6z9sC7 for ; Mon, 24 Dec 2018 16:46:03 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725921AbeLXFqC (ORCPT ); Mon, 24 Dec 2018 00:46:02 -0500 Received: from mail-pf1-f195.google.com ([209.85.210.195]:45578 "EHLO mail-pf1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725849AbeLXFqB (ORCPT ); Mon, 24 Dec 2018 00:46:01 -0500 Received: by mail-pf1-f195.google.com with SMTP id g62so5392388pfd.12 for ; Sun, 23 Dec 2018 21:46:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=cv/l0LKgMyNxUQR3UZgRgeRHsNJLBuXbbuu4Zu2hDyM=; b=pZG58gjn2+y4RwGRM2z3WdBCSLj5/2kV+8PWxp5V3K5iaoRH7LXVZDYJVS00BkVgd2 70gfUwVbyqMvtPIrCO162DTISBxYR/snlncK57BRFh1EkOmbX/tPGLQPVpchPFh2oxJ5 9kmDcHGAJnLhI1CZi/ahyKnBzHDEO4d3JmExnIKxCSvMniaPbGAfoQ8n7p16b/CLVTVF NCMLGM9A4z206NFed/yJy2oKC2C+65JW6gZvhHZ7VAfteQ2qA59mwAcItdJcFLga2cZH A6mFrf6YC4xArRfrfRtqckdO3II7RIL07ycv2JCA+qQf+5tzS7uFLwDyQn9LifoXELdy Pu0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=cv/l0LKgMyNxUQR3UZgRgeRHsNJLBuXbbuu4Zu2hDyM=; b=jtjNfpUwJlDssvvL5u09UqpTcLJVCM88M5KAcDNebCqZmKSToawtgEsc0/iF4Z7Br8 Y3hSolr87mHhxK1tx3h9uW3G/xZIW9M7KPZpoc/8Yx8rMH9Gp9fnN6iaXrFGo3o2ACzn r4OH4DnaBit8EZr9w7vU2iBHwEZEm6qDuxhqJ4Um31Ut8hva5XlOFDtAhawCLBnQ52an iuX9uOHNqOvwDi8weZBNUDfBQeXDKqCLn3HvDmLAfEVC4A5k6cdTYSQLJf2SBBbp93e2 69Ia6Fof/V36DmvguriCFXuKZREZ1mrj9qwBmRaJY/zqj9YrenH/DV+u26HgEdcgT+d9 S87g== X-Gm-Message-State: AJcUukfd6t2stx/QNq74Okv3BHt5vUQ+95uu88PM+J2v31JLCXogEgC7 Y4WAb2wAgaffsse2usgLVjYAXbhN X-Google-Smtp-Source: ALg8bN7wB+bQylTNQFy7tBX/b5UesmpNiaOwr8sxxk+6flvRTPxvmKufGoI9Oqx6TBaTJPdwPDb2bA== X-Received: by 2002:a63:7b06:: with SMTP id w6mr11261730pgc.288.1545630360049; Sun, 23 Dec 2018 21:46:00 -0800 (PST) Received: from tw-172-25-17-123.office.twttr.net ([8.25.197.27]) by smtp.gmail.com with ESMTPSA id h134sm53142734pfe.27.2018.12.23.21.45.58 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 23 Dec 2018 21:45:59 -0800 (PST) From: Cong Wang To: netdev@vger.kernel.org Cc: Cong Wang , Ying Xue , Jon Maloy Subject: [Patch net] tipc: fix a double free in tipc_enable_bearer() Date: Sun, 23 Dec 2018 21:45:56 -0800 Message-Id: <20181224054556.32167-1-xiyou.wangcong@gmail.com> X-Mailer: git-send-email 2.19.2 MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org bearer_disable() already calls kfree_rcu() to free struct tipc_bearer, we don't need to call kfree() again. Fixes: cb30a63384bc ("tipc: refactor function tipc_enable_bearer()") Reported-by: syzbot+b981acf1fb240c0c128b@syzkaller.appspotmail.com Cc: Ying Xue Cc: Jon Maloy Signed-off-by: Cong Wang --- net/tipc/bearer.c | 1 - 1 file changed, 1 deletion(-) diff --git a/net/tipc/bearer.c b/net/tipc/bearer.c index fb2c0d8f359f..d27f30a9a01d 100644 --- a/net/tipc/bearer.c +++ b/net/tipc/bearer.c @@ -319,7 +319,6 @@ static int tipc_enable_bearer(struct net *net, const char *name, res = tipc_disc_create(net, b, &b->bcast_addr, &skb); if (res) { bearer_disable(net, b); - kfree(b); errstr = "failed to create discoverer"; goto rejected; }