From patchwork Mon Dec 24 01:42:38 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Aditya Pakki X-Patchwork-Id: 1018167 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=umn.edu Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=umn.edu header.i=@umn.edu header.b="hMbAyp8i"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 43NMT71JTrz9sML for ; Mon, 24 Dec 2018 12:43:39 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726664AbeLXBnH (ORCPT ); Sun, 23 Dec 2018 20:43:07 -0500 Received: from mta-p8.oit.umn.edu ([134.84.196.208]:35246 "EHLO mta-p8.oit.umn.edu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726580AbeLXBnH (ORCPT ); Sun, 23 Dec 2018 20:43:07 -0500 Received: from localhost (unknown [127.0.0.1]) by mta-p8.oit.umn.edu (Postfix) with ESMTP id 9494CBF0 for ; Mon, 24 Dec 2018 01:43:05 +0000 (UTC) X-Virus-Scanned: amavisd-new at umn.edu Received: from mta-p8.oit.umn.edu ([127.0.0.1]) by localhost (mta-p8.oit.umn.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id EG7fus7ovmK4 for ; Sun, 23 Dec 2018 19:43:05 -0600 (CST) Received: from mail-io1-f72.google.com (mail-io1-f72.google.com [209.85.166.72]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mta-p8.oit.umn.edu (Postfix) with ESMTPS id 66F10B50 for ; Sun, 23 Dec 2018 19:43:05 -0600 (CST) Received: by mail-io1-f72.google.com with SMTP id d20so5445541iom.0 for ; Sun, 23 Dec 2018 17:43:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=umn.edu; s=google; h=from:to:cc:subject:date:message-id; bh=GDY+yyiTc4iAkD2RK776jtb4Jp65q05AypXUayKQSdM=; b=hMbAyp8iMBgmuVV9aeDXgoeIKbm9I0bPxVeo62YjK4AAbxBgnBRjt7QMzgPpr69idL ukIatS/nOO5nisDVDzOdQOH1DuqmXQmYZ4RPtXimwWMYA2E3iJcbj5LG6OVzCzz7B3xM pxvggwS0A8+ULe3xyKn+Sqsafeqr9jyxiwDT3doq1QHDZP24CrepwAud/90j/0QD4iWZ 85fMvzLRJVOTZDShNAiuom8d/f7Xtc6w6lCD6CUGZPcuWM6BLPqDVM9ZL86fR1n+qndA zydNt6CpW6bIOOVDbt4EQgYQrheuRFMPDqLI5RnSj6M5wo4sTtEIBAcHgYMe3PENkCsu 3Flg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=GDY+yyiTc4iAkD2RK776jtb4Jp65q05AypXUayKQSdM=; b=c4+gX0be06+bApHc/FsNloWlr2ELUDsRiZkTSqZOtcglFHw82su6Y28Q3Ke4pMh2n+ NJ4jMgKl9m4dZWKV4fuQPcRRxyy3tFYaCJIqJVMmMNgcqfzX/KT2v0hd4YKIJCb1g/jV yj2T6LQmx0P1f9lrRW/KiIbNKdRCWTx/ZRaZmyizfoiFzCMr+SC6e8wio0PZTH95V+5T MZBpWhZZvBKOGIQo/er0cUYLTuvx4eRkaSLLytzpA+jrofjkUks7fT4PoaR/D/Yc4i/q Pv4DUYbKcDhVhSaZiQEdm8OGM53hUQx5h0nXtsd4hwMkf/n2xDNOtaRZHOsnGzMSdFcv tOYg== X-Gm-Message-State: AJcUukdSYr66fN4fZHKUxJxH05YgMP2H0B6Rx2KOFZozFkGes4k+7qdm qhfsgvsORyw4RSfTrJiWIORrYC9qwVzpJf67EWLwq37+cVjosPrTe6lfmCgX0ympFETuuLQGCSs MFSBaVwmHa3fGuj6s0zoi X-Received: by 2002:a6b:c402:: with SMTP id y2mr8352566ioa.77.1545615785028; Sun, 23 Dec 2018 17:43:05 -0800 (PST) X-Google-Smtp-Source: ALg8bN7qdfO+tsaCZqwQlNxOTQpaFg2kV+VZ/TKavtDGrEGmEubbr/Xpo79CCYyLClZ49aF5c9vtgg== X-Received: by 2002:a6b:c402:: with SMTP id y2mr8352558ioa.77.1545615784756; Sun, 23 Dec 2018 17:43:04 -0800 (PST) Received: from cs-u-syssec1.cs.umn.edu (cs-u-syssec1.cs.umn.edu. [134.84.121.78]) by smtp.gmail.com with ESMTPSA id m186sm9070345ita.2.2018.12.23.17.43.03 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 23 Dec 2018 17:43:04 -0800 (PST) From: Aditya Pakki To: pakki001@umn.edu Cc: kjlu@umn.edu, "David S. Miller" , Kirill Tkhai , Andrei Vagin , Tyler Hicks , Matthew Wilcox , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] net/net_namespace: Check the return value of register_pernet_subsys() Date: Sun, 23 Dec 2018 19:42:38 -0600 Message-Id: <20181224014239.11601-1-pakki001@umn.edu> X-Mailer: git-send-email 2.17.1 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org In net_ns_init(), register_pernet_subsys() could fail while registering network namespace subsystems. The fix checks the return value and sends a panic() on failure. Signed-off-by: Aditya Pakki Reviewed-by: Kirill Tkhai --- net/core/net_namespace.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/net/core/net_namespace.c b/net/core/net_namespace.c index fefe72774aeb..af8849a7a9c3 100644 --- a/net/core/net_namespace.c +++ b/net/core/net_namespace.c @@ -917,7 +917,8 @@ static int __init net_ns_init(void) init_net_initialized = true; up_write(&pernet_ops_rwsem); - register_pernet_subsys(&net_ns_ops); + if (register_pernet_subsys(&net_ns_ops)) + panic("Could not register network namespace subsystems"); rtnl_register(PF_UNSPEC, RTM_NEWNSID, rtnl_net_newid, NULL, RTNL_FLAG_DOIT_UNLOCKED);