From patchwork Fri Dec 14 15:47:28 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fabrice Fontaine X-Patchwork-Id: 1013615 Return-Path: X-Original-To: incoming-buildroot@patchwork.ozlabs.org Delivered-To: patchwork-incoming-buildroot@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=busybox.net (client-ip=140.211.166.133; helo=hemlock.osuosl.org; envelope-from=buildroot-bounces@busybox.net; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="s622Cge2"; dkim-atps=neutral Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 43GZhD6YcBz9s3C for ; Sat, 15 Dec 2018 02:48:12 +1100 (AEDT) Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id B3FC087E60; Fri, 14 Dec 2018 15:48:10 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id sRlbTaDTcZ3L; Fri, 14 Dec 2018 15:48:10 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by hemlock.osuosl.org (Postfix) with ESMTP id 3E67587E3D; Fri, 14 Dec 2018 15:48:10 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by ash.osuosl.org (Postfix) with ESMTP id 58FD41BF398 for ; Fri, 14 Dec 2018 15:48:08 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id 5655287E2E for ; Fri, 14 Dec 2018 15:48:08 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 2Ppn7eF3mqqD for ; Fri, 14 Dec 2018 15:48:06 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-wm1-f65.google.com (mail-wm1-f65.google.com [209.85.128.65]) by hemlock.osuosl.org (Postfix) with ESMTPS id 049D587E78 for ; Fri, 14 Dec 2018 15:48:06 +0000 (UTC) Received: by mail-wm1-f65.google.com with SMTP id g67so6246048wmd.2 for ; Fri, 14 Dec 2018 07:48:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=njbrgv47RetP4DBLkgNoKfQRMgiGxqxP0qgdnFTicAE=; b=s622Cge2gNhpfmzOuVIk/jUFxTjbrnexpeeFLLQ99HpNSV7k/0HwWiD18acnxMdrxR Q5qULDUS8NbZGzFe9TntM2lxuU1bUytINkt1sJwNIjC+zrcyy4d5FkAxNGbGtwATIFVq 9YtDABD0wTM+tiEqmY5vmXSZExRD+1Q6QyJKE2dbn2SQKPYhO3uScgCIeAidP2ywyKTf 8uDmnvr+cos+m84ZL8PlHuo8ULWbDkDCIucBR+ZF6PV01DpSMApOJWRrDspBJ0tOWExf xk2kKT5td9awVrOKGqTO176v7G7XZN8Z914xTPRMSvTFpetIJLlwMW4ToRawekcxJy7m u6WQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=njbrgv47RetP4DBLkgNoKfQRMgiGxqxP0qgdnFTicAE=; b=nkMtj6hq6IRjxkF8uOsT3ogOguS/kRbk2hjxGOs5geGq/yiFftrckt3uCYPoNO0UFX Pme80CAeWJ8HJysKpNs895mcstBK6RcNi2SPyn0j6spGWj2LEi3u02X1f+Xd2as01asG YDjSx8Hbu34wv655m60aUkrwyeowfvUcU5FQif9l7ctmJcB63HBEQtqbfzPeC/LWKnNr rKuB6SpcIw5MxhJ07QBJAEDtX11An2ShNWoKv8wt9MHQ0HuBHE8cohTUpo/plhBXGWx6 myUsllGyVrnnYERSsV2PXAWmhsD4MxV32gNgkoVhL5xtGdWqfaf7dF29tHS+v9rtdGE0 ujdA== X-Gm-Message-State: AA+aEWZAXC/KhenD6CqG8O3sShBBKnfozyuymGwx8APSLKgQEyR/Y4C5 QLPR9TNoMYwRUqRrDtGIDS2wRm9r X-Google-Smtp-Source: AFSGD/XpfcsZL3vC51WysrlGvsXZ78kwWliVLbmFw7pxZ1ZHq4neMjHksD8De7YT/sE9APvL6j8acw== X-Received: by 2002:a1c:e513:: with SMTP id c19mr3879288wmh.101.1544802483763; Fri, 14 Dec 2018 07:48:03 -0800 (PST) Received: from localhost.localdomain ([80.12.34.7]) by smtp.gmail.com with ESMTPSA id h12sm9847354wma.48.2018.12.14.07.48.02 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 14 Dec 2018 07:48:03 -0800 (PST) From: Fabrice Fontaine To: buildroot@buildroot.org Date: Fri, 14 Dec 2018 16:47:28 +0100 Message-Id: <20181214154728.30189-1-fontaine.fabrice@gmail.com> X-Mailer: git-send-email 2.14.1 Subject: [Buildroot] [PATCH 1/1] kmod: fix build with pkgconf 1.5.3 X-BeenThere: buildroot@busybox.net X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Fabrice Fontaine MIME-Version: 1.0 Errors-To: buildroot-bounces@busybox.net Sender: "buildroot" Since the bump to 1.5.3, pkgconf prepends the sysroot to all absolute paths found in the .pc file. This is correct when the paths refer to something in STAGING_DIR (e.g. libdir, includedir), but not when it refers to something used for the target. kmod uses the completionsdir variable from bash-completions.pc to decide where to install things. Since DESTDIR is prepended to the install destination, this will end up in the wrong location. Until a better solution is found in pkgconf, pass the appdefaultdir to use explicitly instead of relying on bash-completions.pc. Fixes: - http://autobuild.buildroot.org/results/f8a1f956333062027294e766ff0ddab5c35d5887 Signed-off-by: Fabrice Fontaine --- package/kmod/kmod.mk | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/package/kmod/kmod.mk b/package/kmod/kmod.mk index c165ea3020..ea5d291133 100644 --- a/package/kmod/kmod.mk +++ b/package/kmod/kmod.mk @@ -28,6 +28,10 @@ KMOD_CONF_OPTS = --disable-static --enable-shared KMOD_CONF_OPTS += --disable-manpages HOST_KMOD_CONF_OPTS = --disable-manpages +ifeq ($(BR2_PACKAGE_BASH_COMPLETION),y) +KMOD_CONF_OPTS += --with-bashcompletiondir=/usr/share/bash-completion/completions +endif + ifeq ($(BR2_PACKAGE_ZLIB),y) KMOD_DEPENDENCIES += zlib KMOD_CONF_OPTS += --with-zlib