From patchwork Thu Dec 13 21:48:01 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fabrice Fontaine X-Patchwork-Id: 1013180 Return-Path: X-Original-To: incoming-buildroot@patchwork.ozlabs.org Delivered-To: patchwork-incoming-buildroot@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=busybox.net (client-ip=140.211.166.137; helo=fraxinus.osuosl.org; envelope-from=buildroot-bounces@busybox.net; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="Exq2nHl1"; dkim-atps=neutral Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 43G6kC3n8xz9rxp for ; Fri, 14 Dec 2018 08:48:19 +1100 (AEDT) Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id 1C3C485065; Thu, 13 Dec 2018 21:48:17 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id pOVYqAh-bzXI; Thu, 13 Dec 2018 21:48:16 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by fraxinus.osuosl.org (Postfix) with ESMTP id 95F908506E; Thu, 13 Dec 2018 21:48:16 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by ash.osuosl.org (Postfix) with ESMTP id BC2CC1BF3B8 for ; Thu, 13 Dec 2018 21:48:15 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id B9AA286421 for ; Thu, 13 Dec 2018 21:48:15 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id QNNpALplWa49 for ; Thu, 13 Dec 2018 21:48:15 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-wr1-f67.google.com (mail-wr1-f67.google.com [209.85.221.67]) by hemlock.osuosl.org (Postfix) with ESMTPS id 0AD23860C9 for ; Thu, 13 Dec 2018 21:48:15 +0000 (UTC) Received: by mail-wr1-f67.google.com with SMTP id t6so3342246wrr.12 for ; Thu, 13 Dec 2018 13:48:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=Sw8AvFgAhTpJk+Ali6DBy1sinfR15yTpcvy4g9SNlio=; b=Exq2nHl17jAazeZRDzCASKsS6EBBYiZze4BByhnXGSorZsQ8p7eEl1j7+aDGI/yxM6 k0M2/RnqyoHFORxort0lmYdGfRtpu3UDzZWpeMW2/o5KRJlv+Ze8jHMpnUUPYISTgzaj OqlksLhJo+ePrybA2rRI89xSlm+4yBV+2wIzfxTMAE186xwyc+LpqrSFHRnS5Myd6eGH FZusgp2bt6pG7Y75rMz9IbOLIj7fqJ6bvetNwKLubD525YImwpT/KLk+O3+JEwXlCvRS DgxkIuQajA4CgNc8SQ0WTnMshzCF7JTiiQqTFr00igd4r64YQ5hCm0gBZ7vXVUg8IiGN 7nOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=Sw8AvFgAhTpJk+Ali6DBy1sinfR15yTpcvy4g9SNlio=; b=dhcpKdYMrQwYVD3OawvSatLM/MZkNhJKduvwN/MU9N8kxXwl9+eKGnuL/ymeJnivZm nTQXYLXswZVvQuosgpo50T0KqmYU07H6QIlmqsRCRvztc1AEmUXJF8jP9BKiU8AacYMl t7rBTHk+4hcMn2VhROakAdOtuxqGxk4QXz5SAQ9gBbppxJuFxqwUCY9smTleLhnXrd5+ XDumb41t+LbVod77Xpt+JWZ8u+nYTtL79b6siA1TvDs7pXkHCDVfyTMHuIN4v0lheXWL 6vRIZ93c2mBttGbH241X6+n7CsbnRoJ3IJNrW+LJz03SaJ9lOBy6NCnsudutW4KIcIH2 vGyA== X-Gm-Message-State: AA+aEWZv+vUvABI5yAEAX1NnIa4eojGg1h+k5HlS6Y+iAfOnjFuElNfT LsLj/xU/GsbVoeuZJhf/dzz+tsW3 X-Google-Smtp-Source: AFSGD/VqNvNHV3om9zoJ8uXOoOGr7Cb/w5XMe/1y9QznZguC/or4fHUE0QbgdSrLmJY6mb/C7DMhXw== X-Received: by 2002:adf:9d85:: with SMTP id p5mr390869wre.41.1544737692900; Thu, 13 Dec 2018 13:48:12 -0800 (PST) Received: from localhost.localdomain ([80.12.33.74]) by smtp.gmail.com with ESMTPSA id n20sm2183735wmi.11.2018.12.13.13.48.11 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 13 Dec 2018 13:48:12 -0800 (PST) From: Fabrice Fontaine To: buildroot@buildroot.org Date: Thu, 13 Dec 2018 22:48:01 +0100 Message-Id: <20181213214802.7730-1-fontaine.fabrice@gmail.com> X-Mailer: git-send-email 2.14.1 Subject: [Buildroot] [PATCH 1/2] alsa-utils: add udev optional dependency X-BeenThere: buildroot@busybox.net X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Bernd Kuhls , Fabrice Fontaine MIME-Version: 1.0 Errors-To: buildroot-bounces@busybox.net Sender: "buildroot" Add udev optional dependency and fix build with pkgconf 1.5.3 Since the bump to 1.5.3, pkgconf prepends the sysroot to all absolute paths found in the .pc file. This is correct when the paths refer to something in STAGING_DIR (e.g. libdir, includedir), but not when it refers to something used for the target. alsa-utils uses the udevdir variable from udev.pc to decide where to install things. Since DESTDIR is prepended to the install destination, this will end up in the wrong location. Until a better solution is found in pkgconf, pass the udevrulesdir to use explicitly instead of relying on udev.pc. Fixes: - http://autobuild.buildroot.org/results/d8ad140ae52b4fe8e153de3835f3f17e92b58e53 Signed-off-by: Fabrice Fontaine --- package/alsa-utils/alsa-utils.mk | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/package/alsa-utils/alsa-utils.mk b/package/alsa-utils/alsa-utils.mk index 0bf2b432bd..422318796f 100644 --- a/package/alsa-utils/alsa-utils.mk +++ b/package/alsa-utils/alsa-utils.mk @@ -28,6 +28,11 @@ ALSA_UTILS_CONF_OPTS = \ --disable-rst2man \ --with-curses=$(if $(BR2_PACKAGE_NCURSES_WCHAR),ncursesw,ncurses) +ifeq ($(BR2_PACKAGE_HAS_UDEV),y) +ALSA_UTILS_CONF_OPTS += --with-udev-rules-dir=/usr/lib/udev/rules.d +ALSA_UTILS_DEPENDENCIES += udev +endif + ifeq ($(BR2_PACKAGE_ALSA_UTILS_ALSALOOP),y) ALSA_UTILS_CONF_OPTS += --enable-alsaloop else From patchwork Thu Dec 13 21:48:02 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fabrice Fontaine X-Patchwork-Id: 1013181 Return-Path: X-Original-To: incoming-buildroot@patchwork.ozlabs.org Delivered-To: patchwork-incoming-buildroot@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=busybox.net (client-ip=140.211.166.138; helo=whitealder.osuosl.org; envelope-from=buildroot-bounces@busybox.net; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="M7uKtNkC"; dkim-atps=neutral Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 43G6kN5Nrtz9s1c for ; Fri, 14 Dec 2018 08:48:28 +1100 (AEDT) Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id 48BA086E26; Thu, 13 Dec 2018 21:48:24 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id CVrtNrBsUFPP; Thu, 13 Dec 2018 21:48:21 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by whitealder.osuosl.org (Postfix) with ESMTP id 6BBF785074; Thu, 13 Dec 2018 21:48:21 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by ash.osuosl.org (Postfix) with ESMTP id 3251A1BF3B8 for ; Thu, 13 Dec 2018 21:48:20 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id 2FE1886421 for ; Thu, 13 Dec 2018 21:48:20 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id qaWnregOhLFc for ; Thu, 13 Dec 2018 21:48:19 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-wm1-f65.google.com (mail-wm1-f65.google.com [209.85.128.65]) by hemlock.osuosl.org (Postfix) with ESMTPS id 84001860C9 for ; Thu, 13 Dec 2018 21:48:19 +0000 (UTC) Received: by mail-wm1-f65.google.com with SMTP id n190so3874023wmd.0 for ; Thu, 13 Dec 2018 13:48:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=lsPdWEL1GiQ3nTZS3owxw8Q1i55lzUZxuX0mee944Zs=; b=M7uKtNkCcd0oXSTlof9sRudp3jM6jaCeEtWZJsc2q5+XhT8c9gKDtvhwHGAYUQPRoZ OiSNqOP67pl+hRG5CJcx5fCGqhIF2g5x1ci7AQOCQzz4NZ87iUnz1TFAY69pPR9EclQw k7lCTeM2t8UXN7fGtLd9UGnBsQiwWuaN5Y1IMhOAoZiLEfhc6+cPAyks74SdJB4XUqnn kZ9X5iN/81ZfoP+VKdnh4lBJk4yG9i+4rXpOWieoft76lyvjOVYiFL38t5PyDkhL5oB+ n+0Rf/ZNDlMQcJlUQAeoitSqicacRY9+LcSuFZy0o7q1MFmb2+29LzeeafKM8xlSxbRe C4xA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=lsPdWEL1GiQ3nTZS3owxw8Q1i55lzUZxuX0mee944Zs=; b=GzAD5xji1BQpaf4VmVKdRTZvhs6Nq0vtSyx9l+1g21c9Gz0F8aAYu0dXI+2fAN3hla DF4r+0TCmpxDVB8zC1/oGSOluOOGcEhMRZMgHVwZeeO80OAeRq6zaU3oDCPflcNKSAhk Z6rz16vPDgUVaKYyUzM+rZdOouagnL3cFB8ncZotfTxnc7MeQ991JstCVg9y/S78gBNM aNwPvvaIh2QJXwcp4oYWGE1wWJ+IAHKgDaMx3jF0oEMhCWG4tu4mpgp0f3OWZraGqezu Dr1QiGWrl8L0gd6VoJoCn2XKQYH1pCyZL0blut0oAKkK0ayZvHEC4xW0UU/4CEslUFCB nJ6w== X-Gm-Message-State: AA+aEWb3XWzdufyYpHQv2KwljKD4cJuBSrYTgW1NhwkEX0H8ITSNGzWD Xxg4R7IGYOxXCpvR1GcQd71yllc3 X-Google-Smtp-Source: AFSGD/WIJDA+E3f81LFjrQiZKDxxFdn9GTL0VlWxwCIYmFEhwkwdOn5C40jCquadoFJoigKiUVlTaA== X-Received: by 2002:a1c:e58c:: with SMTP id c134mr1001055wmh.124.1544737697766; Thu, 13 Dec 2018 13:48:17 -0800 (PST) Received: from localhost.localdomain ([80.12.33.74]) by smtp.gmail.com with ESMTPSA id n20sm2183735wmi.11.2018.12.13.13.48.16 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 13 Dec 2018 13:48:17 -0800 (PST) From: Fabrice Fontaine To: buildroot@buildroot.org Date: Thu, 13 Dec 2018 22:48:02 +0100 Message-Id: <20181213214802.7730-2-fontaine.fabrice@gmail.com> X-Mailer: git-send-email 2.14.1 In-Reply-To: <20181213214802.7730-1-fontaine.fabrice@gmail.com> References: <20181213214802.7730-1-fontaine.fabrice@gmail.com> Subject: [Buildroot] [PATCH 2/2] alsa-utils: fix systemd build with pkgconf 1.5.3 X-BeenThere: buildroot@busybox.net X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Bernd Kuhls , Fabrice Fontaine MIME-Version: 1.0 Errors-To: buildroot-bounces@busybox.net Sender: "buildroot" Since the bump to 1.5.3, pkgconf prepends the sysroot to all absolute paths found in the .pc file. This is correct when the paths refer to something in STAGING_DIR (e.g. libdir, includedir), but not when it refers to something used for the target. alsa-utils uses the systemdsystemunitdir variable from systemd.pc to decide where to install things. Since DESTDIR is prepended to the install destination, this will end up in the wrong location. Until a better solution is found in pkgconf, pass the systemdsystemunitdir to use explicitly instead of relying on systemd.pc. Fixes: - http://autobuild.buildroot.org/results/d8ad140ae52b4fe8e153de3835f3f17e92b58e53 Signed-off-by: Fabrice Fontaine --- package/alsa-utils/alsa-utils.mk | 1 + 1 file changed, 1 insertion(+) diff --git a/package/alsa-utils/alsa-utils.mk b/package/alsa-utils/alsa-utils.mk index 422318796f..d4b21837e1 100644 --- a/package/alsa-utils/alsa-utils.mk +++ b/package/alsa-utils/alsa-utils.mk @@ -89,6 +89,7 @@ endef ifeq ($(BR2_PACKAGE_ALSA_UTILS_ALSACTL)$(BR2_INIT_SYSTEMD),yy) ALSA_UTILS_DEPENDENCIES += systemd +ALSA_UTILS_CONF_OPTS += --with-systemdsystemunitdir=/usr/lib/systemd/system define ALSA_UTILS_INSTALL_INIT_SYSTEMD $(INSTALL) -D -m 0644 $(@D)/alsactl/alsa-restore.service \ $(TARGET_DIR)/usr/lib/systemd/system/alsa-restore.service