From patchwork Tue Dec 11 15:30:05 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas Petazzoni X-Patchwork-Id: 1011151 Return-Path: X-Original-To: incoming-buildroot@patchwork.ozlabs.org Delivered-To: patchwork-incoming-buildroot@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=busybox.net (client-ip=140.211.166.133; helo=hemlock.osuosl.org; envelope-from=buildroot-bounces@busybox.net; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=bootlin.com Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 43DkR61Vf1z9s7T for ; Wed, 12 Dec 2018 02:30:26 +1100 (AEDT) Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id 0419487A43; Tue, 11 Dec 2018 15:30:24 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 2NQvyr05sFxN; Tue, 11 Dec 2018 15:30:23 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by hemlock.osuosl.org (Postfix) with ESMTP id 87BA887A4F; Tue, 11 Dec 2018 15:30:23 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by ash.osuosl.org (Postfix) with ESMTP id E4CED1BF39A for ; Tue, 11 Dec 2018 15:30:22 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id E1DAA87A4F for ; Tue, 11 Dec 2018 15:30:22 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id fDmECaVMXA+V for ; Tue, 11 Dec 2018 15:30:22 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail.bootlin.com (mail.bootlin.com [62.4.15.54]) by hemlock.osuosl.org (Postfix) with ESMTP id E537287A43 for ; Tue, 11 Dec 2018 15:30:21 +0000 (UTC) Received: by mail.bootlin.com (Postfix, from userid 110) id BDF76208E3; Tue, 11 Dec 2018 16:30:19 +0100 (CET) Received: from localhost (aaubervilliers-681-1-89-7.w90-88.abo.wanadoo.fr [90.88.30.7]) by mail.bootlin.com (Postfix) with ESMTPSA id 8ACF5206A1; Tue, 11 Dec 2018 16:30:09 +0100 (CET) From: Thomas Petazzoni To: buildroot@buildroot.org Date: Tue, 11 Dec 2018 16:30:05 +0100 Message-Id: <20181211153005.300-1-thomas.petazzoni@bootlin.com> X-Mailer: git-send-email 2.19.2 MIME-Version: 1.0 Subject: [Buildroot] [PATCH] package/intel-microcode: don't use install -D -t X-BeenThere: buildroot@busybox.net X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Thomas Petazzoni , Maxime Hadjinlian Errors-To: buildroot-bounces@busybox.net Sender: "buildroot" Commit 1f0beaf9a8e2b8f0bb6e53694b38d70900b9128f ("intel-microcode: bump to version 20180807a") introduced the use of "install -D -t" to the intel-microcode package. The intent is that install will create the full destination directory, including all components leading to it, before copying the files. Unfortunately, "install -D -t" is only supported since coreutils since v8.23. Several of the build systems we support have older coreutils versions, such as Debian 7, which uses coreutils 8.13. Ubuntu 14.04 also doesn't have a recent enough coreutils. So let's create the directory explicitly first, and then use a more regular "install -t". Fixes: http://autobuild.buildroot.net/results/aa44f9ff90f296f886be6309b3355ed075494fb2/ Note: the "gzip: stdout: Broken pipe" messages in those failures seem unrelated. We have been able to reproduce the installation failure without those "Broken pipe" issues, and we have not been able to reproduce those "Broken pipe" problems. Signed-off-by: Thomas Petazzoni Tested-by: Carlos Santos --- package/intel-microcode/intel-microcode.mk | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/package/intel-microcode/intel-microcode.mk b/package/intel-microcode/intel-microcode.mk index 2113873509..ed4ad628dd 100644 --- a/package/intel-microcode/intel-microcode.mk +++ b/package/intel-microcode/intel-microcode.mk @@ -13,7 +13,8 @@ INTEL_MICROCODE_LICENSE_FILES = license INTEL_MICROCODE_REDISTRIBUTE = NO define INTEL_MICROCODE_INSTALL_TARGET_CMDS - $(INSTALL) -D -m 0644 -t $(TARGET_DIR)/lib/firmware/intel-ucode \ + mkdir -p $(TARGET_DIR)/lib/firmware/intel-ucode + $(INSTALL) -m 0644 -t $(TARGET_DIR)/lib/firmware/intel-ucode \ $(@D)/intel-ucode/* endef