From patchwork Fri Dec 7 17:12:41 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ryan Barnett X-Patchwork-Id: 1009575 Return-Path: X-Original-To: incoming-buildroot@patchwork.ozlabs.org Delivered-To: patchwork-incoming-buildroot@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=busybox.net (client-ip=140.211.166.137; helo=fraxinus.osuosl.org; envelope-from=buildroot-bounces@busybox.net; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=rockwellcollins.com Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 43BJvH1jxMz9s7W for ; Sat, 8 Dec 2018 04:12:58 +1100 (AEDT) Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id 9D2B586DC0; Fri, 7 Dec 2018 17:12:56 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id GqLITbuwZpOK; Fri, 7 Dec 2018 17:12:56 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by fraxinus.osuosl.org (Postfix) with ESMTP id 06FD886DAF; Fri, 7 Dec 2018 17:12:56 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by ash.osuosl.org (Postfix) with ESMTP id C8FB21BF3F7 for ; Fri, 7 Dec 2018 17:12:54 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id C581387E56 for ; Fri, 7 Dec 2018 17:12:54 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id JjOBGhtbUkf2 for ; Fri, 7 Dec 2018 17:12:54 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from ch3vs03.rockwellcollins.com (ch3vs03.rockwellcollins.com [205.175.226.47]) by hemlock.osuosl.org (Postfix) with ESMTPS id E42D687E55 for ; Fri, 7 Dec 2018 17:12:53 +0000 (UTC) Received: from ofwch3n02.rockwellcollins.com (HELO dtulimr01.rockwellcollins.com) ([205.175.226.14]) by ch3vs03.rockwellcollins.com with ESMTP; 07 Dec 2018 11:12:53 -0600 X-Received: from bacon.rockwellcollins.com (unknown [192.168.6.146]) by dtulimr01.rockwellcollins.com (Postfix) with ESMTP id 84A24601A6; Fri, 7 Dec 2018 11:12:52 -0600 (CST) From: Ryan Barnett To: buildroot@buildroot.org Date: Fri, 7 Dec 2018 11:12:41 -0600 Message-Id: <20181207171241.27832-1-ryan.barnett@rockwellcollins.com> X-Mailer: git-send-email 2.18.0 Subject: [Buildroot] [PATCH 1/1] package/grpc: add explicitly link with libatomic X-BeenThere: buildroot@busybox.net X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Ryan Barnett , Robert Rose MIME-Version: 1.0 Errors-To: buildroot-bounces@busybox.net Sender: "buildroot" On some architectures, you must link with libatomic, on some other architectures, they are available built-in, but in all cases, linking against libatomic does not harm. Fixes: http://autobuild.buildroot.org/results/2f2/2f208fbfe4e9da94be5b9c030dbd278cb8ba053c/ Signed-off-by: Ryan Barnett Reviewed-by: Robert Rose Signed-off-by: Ryan Barnett <ryan.barnett@rockwellcollins.com>
--- package/grpc/grpc.mk | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/package/grpc/grpc.mk b/package/grpc/grpc.mk index 6ca6536fff..527c7fa7e2 100644 --- a/package/grpc/grpc.mk +++ b/package/grpc/grpc.mk @@ -23,6 +23,12 @@ GRPC_CONF_OPTS = \ -DgRPC_ZLIB_PROVIDER=package \ -DgRPC_NATIVE_CPP_PLUGIN=$(HOST_DIR)/bin/grpc_cpp_plugin +# grpc can uses __atomic builtins, so we need to link with +# libatomic for the architectures who need libatomic. +ifeq ($(BR2_TOOLCHAIN_HAS_LIBATOMIC),y) +GRPC_CONF_OPTS += -DCMAKE_C_STANDARD_LIBRARIES="-latomic" +endif + HOST_GRPC_CONF_OPTS = \ -D_gRPC_CARES_LIBRARIES=cares \ -DgRPC_CARES_PROVIDER=none \