From patchwork Fri Dec 7 14:00:11 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Igor Russkikh X-Patchwork-Id: 1009431 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=aquantia.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=AQUANTIA1COM.onmicrosoft.com header.i=@AQUANTIA1COM.onmicrosoft.com header.b="c5i7hcof"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 43BDcw716xz9s3q for ; Sat, 8 Dec 2018 01:00:16 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726061AbeLGOAP (ORCPT ); Fri, 7 Dec 2018 09:00:15 -0500 Received: from mail-eopbgr780045.outbound.protection.outlook.com ([40.107.78.45]:10848 "EHLO NAM03-BY2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726034AbeLGOAN (ORCPT ); Fri, 7 Dec 2018 09:00:13 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=AQUANTIA1COM.onmicrosoft.com; s=selector1-aquantia-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=w5SVj+VogCQDa0mce8GvsoxZm7RIf8G7PbbkmNYJLtE=; b=c5i7hcofAE03yO9Y85/Ezu9g5iKhcvJaj/7RlVlCzFvSr9fAoIxuPaflRCykgw2mRa3aHSWzOFM2q89FMH1yNbPK2rZbsaje/aRFIDqctNqXaW6AmcI1y6Sowl1bgcQZLI4PA0pbLvmD8cbyUS7cyzzcrEwqB0fuZlGR0qS3jJE= Received: from DM6PR07MB6220.namprd07.prod.outlook.com (20.179.55.97) by DM6PR07MB5787.namprd07.prod.outlook.com (20.178.3.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1404.19; Fri, 7 Dec 2018 14:00:11 +0000 Received: from DM6PR07MB6220.namprd07.prod.outlook.com ([fe80::9d23:ba09:343:4aaa]) by DM6PR07MB6220.namprd07.prod.outlook.com ([fe80::9d23:ba09:343:4aaa%4]) with mapi id 15.20.1404.021; Fri, 7 Dec 2018 14:00:11 +0000 From: Igor Russkikh To: "David S . Miller" CC: Dmitry Bogdanov , "netdev@vger.kernel.org" , Igor Russkikh Subject: [PATCH v2 net-next 1/4] net: aquantia: fix RSS table and key sizes Thread-Topic: [PATCH v2 net-next 1/4] net: aquantia: fix RSS table and key sizes Thread-Index: AQHUjjUrFEUOvHaYv0W5AdqekwpCiQ== Date: Fri, 7 Dec 2018 14:00:11 +0000 Message-ID: <6b8c5dff2c46073cd7c00960b6ac5b2c3a5fade4.1544190020.git.igor.russkikh@aquantia.com> References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: AM5PR06CA0006.eurprd06.prod.outlook.com (2603:10a6:206:2::19) To DM6PR07MB6220.namprd07.prod.outlook.com (2603:10b6:5:17d::33) authentication-results: spf=none (sender IP is ) smtp.mailfrom=Igor.Russkikh@aquantia.com; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [95.79.108.179] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; DM6PR07MB5787; 6:TJVr2NFvUtasj5V4uGzWrAPkqKMUYsJIwDsa78QGirlLQLrpMb5h/B+vWec4A/IVByM+wMmqfqtKUvncy3b3PeK3X6Q8fzLP87p3WzDUmOO1ebjIMLVHOBBphMUykqPVGPVBNYSJ1cN4ShJvHGCws4WeiwUe7Pl8hmlDLqNy9OHWU+d2xpKgp1IYugFadWLa+FQmjwp5XjDVW2yNZ+tv8PcYOhz2xNgi4GLba+UPrgZX6OETUMkUV9PPPlmXY9GvAZhQcKDRfUJP7m3rM3wzPoRvA0l+scAF+nWfmTcmZJBeWw9zexL+URHTzpelz/n7cCp2MCWrecJWjhsh9L/UPc2P0v/EeDizGa8q6sQ2QvhP0oew7lAHfstsiEbm34N1BmKAx6LnHWafRlRhttVioI28rF0FuUah7VQOnksnsqfID2eQoWcTWCHGIX/rHA10JPiqw/2t0/oW3g8WbIpTwg==; 5:6ce6sWP3n66YKu+FwQODAdudzsw3YY5KJvj2d72LgazTyy74Yc9JQttGzBB6TgjXkZsb6JUz8UO97zRMj7iClC6mJOrJ5Nof6waK/keMHkg4wnVCIkO+32WCyvauzKbeXCuTvuxs6IBvCWHodpRSoJDU+agSXqU6WaXdLkQPDsI=; 7:8170X8ggHtgZPC6xDEyEQb5XFu1UuvlBOPVo5ggi5Op70vfawnOuRDdKxY/A34Si+mJMn1zDP+3/5Fm5JFAcWbWHUdydJcJ1+0GeMFB8AQl7RhNLPKTxoWrxvQtQieMJj2TcUnX10xSHZjQy0Pgy+A== x-ms-office365-filtering-correlation-id: c00f12aa-da0c-4b7e-38d1-08d65c4c4dd5 x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390098)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600074)(711020)(2017052603328)(7153060)(7193020); SRVR:DM6PR07MB5787; x-ms-traffictypediagnostic: DM6PR07MB5787: x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(6040522)(2401047)(8121501046)(5005006)(10201501046)(93006095)(93001095)(3002001)(3231455)(999002)(944501520)(52105112)(148016)(149066)(150057)(6041310)(20161123558120)(20161123564045)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(201708071742011)(7699051)(76991095); SRVR:DM6PR07MB5787; BCL:0; PCL:0; RULEID:; SRVR:DM6PR07MB5787; x-forefront-prvs: 0879599414 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(136003)(39850400004)(366004)(396003)(346002)(376002)(189003)(199004)(486006)(386003)(6506007)(102836004)(2616005)(476003)(44832011)(36756003)(446003)(11346002)(4326008)(52116002)(118296001)(76176011)(107886003)(186003)(71200400001)(7736002)(305945005)(256004)(71190400001)(106356001)(54906003)(316002)(66066001)(105586002)(86362001)(575784001)(97736004)(6916009)(25786009)(6486002)(81166006)(81156014)(5660300001)(3846002)(72206003)(478600001)(2906002)(6436002)(8676002)(68736007)(8936002)(26005)(53936002)(6512007)(14454004)(99286004)(6116002); DIR:OUT; SFP:1101; SCL:1; SRVR:DM6PR07MB5787; H:DM6PR07MB6220.namprd07.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: aquantia.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: Iob1CAVnm6FaI1veLWg/VkVrTeAp7fXNsmfif1v6uzEkhpW2I+oa04jdSjVCG/nm8e6Y1BemSAcrx1N1olaTn0BI90LfdRMElrwYhEnBZ6oQAzRzan+rnUyQ4XFQalgIzRiykiFJP6VP5djvPQSKR9r4Mgbwe5VJubiNCziLLHmz1QaU7cuf7Q4h9/7zStGRN5sh3qi0RxZbNMXXyRAZR2bOa5ZIl3XbctXG43ccbY897JIfM+V/jp5Sjzjk8Sh+uai6iFAEZ+MN8GQPnjBfybpIdv3mIjNGSp0Mm6N4GI1Wvw7rbm5h3CFY9l30zRl/5AGCmOjapHzsom7W9idVrhci2XCyFKkFifvMV+Ocm2Y= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: aquantia.com X-MS-Exchange-CrossTenant-Network-Message-Id: c00f12aa-da0c-4b7e-38d1-08d65c4c4dd5 X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Dec 2018 14:00:11.5485 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 83e2e134-991c-4ede-8ced-34d47e38e6b1 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR07MB5787 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Dmitry Bogdanov Set RSS indirection table and RSS hash key sizes to their real size. Signed-off-by: Dmitry Bogdanov Signed-off-by: Igor Russkikh --- drivers/net/ethernet/aquantia/atlantic/aq_cfg.h | 4 ++-- drivers/net/ethernet/aquantia/atlantic/aq_nic.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/aquantia/atlantic/aq_cfg.h b/drivers/net/ethernet/aquantia/atlantic/aq_cfg.h index 91eb8910b1c9..90a0e1d0d622 100644 --- a/drivers/net/ethernet/aquantia/atlantic/aq_cfg.h +++ b/drivers/net/ethernet/aquantia/atlantic/aq_cfg.h @@ -42,8 +42,8 @@ #define AQ_CFG_IS_LRO_DEF 1U /* RSS */ -#define AQ_CFG_RSS_INDIRECTION_TABLE_MAX 128U -#define AQ_CFG_RSS_HASHKEY_SIZE 320U +#define AQ_CFG_RSS_INDIRECTION_TABLE_MAX 64U +#define AQ_CFG_RSS_HASHKEY_SIZE 40U #define AQ_CFG_IS_RSS_DEF 1U #define AQ_CFG_NUM_RSS_QUEUES_DEF AQ_CFG_VECS_DEF diff --git a/drivers/net/ethernet/aquantia/atlantic/aq_nic.c b/drivers/net/ethernet/aquantia/atlantic/aq_nic.c index 279ea58f4a9e..d617289d95f7 100644 --- a/drivers/net/ethernet/aquantia/atlantic/aq_nic.c +++ b/drivers/net/ethernet/aquantia/atlantic/aq_nic.c @@ -44,7 +44,7 @@ static void aq_nic_rss_init(struct aq_nic_s *self, unsigned int num_rss_queues) struct aq_rss_parameters *rss_params = &cfg->aq_rss; int i = 0; - static u8 rss_key[40] = { + static u8 rss_key[AQ_CFG_RSS_HASHKEY_SIZE] = { 0x1e, 0xad, 0x71, 0x87, 0x65, 0xfc, 0x26, 0x7d, 0x0d, 0x45, 0x67, 0x74, 0xcd, 0x06, 0x1a, 0x18, 0xb6, 0xc1, 0xf0, 0xc7, 0xbb, 0x18, 0xbe, 0xf8, From patchwork Fri Dec 7 14:00:15 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Igor Russkikh X-Patchwork-Id: 1009432 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=aquantia.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=AQUANTIA1COM.onmicrosoft.com header.i=@AQUANTIA1COM.onmicrosoft.com header.b="QsNwl7TP"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 43BDd06T2zz9rxp for ; Sat, 8 Dec 2018 01:00:20 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726069AbeLGOAT (ORCPT ); Fri, 7 Dec 2018 09:00:19 -0500 Received: from mail-eopbgr780085.outbound.protection.outlook.com ([40.107.78.85]:28937 "EHLO NAM03-BY2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726034AbeLGOAR (ORCPT ); Fri, 7 Dec 2018 09:00:17 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=AQUANTIA1COM.onmicrosoft.com; s=selector1-aquantia-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RxMsvhoniSo9S5UdD6OV3jRTJabWVFSGiIQL9wF0ZTI=; b=QsNwl7TPKWTPkuvQXdwpCZ7yUzM6px5t9m724FQRHJMdftvkCllj2ill5BDUYg5KVWaUPP0njiq0bZ/IoLVHVbRB7j0XuOorA0RAJBYTcngL+2uM3p6BmEjOHyek+fw36d8sSiRQb9HBr/RBIIkJhGgPdd669HYylGGYGwQha4s= Received: from DM6PR07MB6220.namprd07.prod.outlook.com (20.179.55.97) by DM6PR07MB5787.namprd07.prod.outlook.com (20.178.3.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1404.19; Fri, 7 Dec 2018 14:00:15 +0000 Received: from DM6PR07MB6220.namprd07.prod.outlook.com ([fe80::9d23:ba09:343:4aaa]) by DM6PR07MB6220.namprd07.prod.outlook.com ([fe80::9d23:ba09:343:4aaa%4]) with mapi id 15.20.1404.021; Fri, 7 Dec 2018 14:00:15 +0000 From: Igor Russkikh To: "David S . Miller" CC: Dmitry Bogdanov , "netdev@vger.kernel.org" , Igor Russkikh Subject: [PATCH v2 net-next 2/4] net: aquantia: increase max number of hw queues Thread-Topic: [PATCH v2 net-next 2/4] net: aquantia: increase max number of hw queues Thread-Index: AQHUjjUtvF9H6V/Z4UuvHQ2v9n/CpA== Date: Fri, 7 Dec 2018 14:00:15 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: AM5PR06CA0006.eurprd06.prod.outlook.com (2603:10a6:206:2::19) To DM6PR07MB6220.namprd07.prod.outlook.com (2603:10b6:5:17d::33) authentication-results: spf=none (sender IP is ) smtp.mailfrom=Igor.Russkikh@aquantia.com; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [95.79.108.179] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; DM6PR07MB5787; 6:vmOCjLjD9cb78Bg3weefOsUwLnNuYJ3/gtc52ERVteTdrIXmt48CBj+2hbg29zDeMN59k2YikfGy20wctpMGUWutS7oVqfYHYjLY5I6j/Hfn59pHhLSEXn6MqpZRZ2A9JxRkeDtD+Zlb3wx2NM/a2DkfUtYOGnSNB8s01ZBXplHhcwT108hJLXsAK37dpEVpkmQuddbhZEwx0iw1sPmBWb68ub94fInczt5iqbVWhCqslHPuZnG668gq1ZxTHg326vKzG35vLsOFyigKKA/XC/Ot+8D1rCZixfTnmBTLQpImjkFrSKzTgseD5IvOSvJZJ4KjGwYR1OxwC/7QgYwP1WIWPt7lHx6OxGe9h9Fi4oUM9BDQ3qJYBmiFh1qqfMGLZXSwb7u3EdeqvBqyh/LScnyWi+Owje22D2JiOVdafjdIzQFL1akOBAFrW666IUSc+DgniIjGjJeE6XlToX64fQ==; 5:V1lSCdgmmqvJ8luisWACmSmCPpkTkjvRhF6uzfhdI+lG1AkKFy/fU00unK24HDDZ1flqbTPaV5d0xKo4zP05zd5YsURISt4mz0xYLl0oKbH1zYOBi08DNzFE6kyyO7xCj4++qq53O4DEsf4oYkW6AhxEappYgXiib5TxEGP8voY=; 7:Np9ltmqoZUIkGCsmsZSauTVsqb3YlGzZAa8uHAH8pYPkZN5N9hq2XRAJJjBUolgclKuWHpGhlmzqx8uFq/FbPWjlKKuzFZ1myWtfbMf2P9InR14Q5QZH/Ym9b5Qv1ptt5k9l4CfcETgk5FRPFXMuEA== x-ms-office365-filtering-correlation-id: 55930044-c74b-4b64-fd78-08d65c4c4ff0 x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390098)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600074)(711020)(2017052603328)(7153060)(7193020); SRVR:DM6PR07MB5787; x-ms-traffictypediagnostic: DM6PR07MB5787: x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(6040522)(2401047)(8121501046)(5005006)(10201501046)(93006095)(93001095)(3002001)(3231455)(999002)(944501520)(52105112)(148016)(149066)(150057)(6041310)(20161123558120)(20161123564045)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(201708071742011)(7699051)(76991095); SRVR:DM6PR07MB5787; BCL:0; PCL:0; RULEID:; SRVR:DM6PR07MB5787; x-forefront-prvs: 0879599414 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(136003)(39850400004)(366004)(396003)(346002)(376002)(189003)(199004)(486006)(386003)(6506007)(102836004)(2616005)(476003)(44832011)(36756003)(446003)(11346002)(4326008)(52116002)(118296001)(76176011)(107886003)(186003)(71200400001)(7736002)(305945005)(256004)(71190400001)(14444005)(106356001)(54906003)(316002)(66066001)(105586002)(86362001)(575784001)(97736004)(6916009)(25786009)(6486002)(81166006)(81156014)(5660300001)(3846002)(72206003)(478600001)(2906002)(6436002)(8676002)(68736007)(8936002)(26005)(53936002)(6512007)(14454004)(99286004)(6116002); DIR:OUT; SFP:1101; SCL:1; SRVR:DM6PR07MB5787; H:DM6PR07MB6220.namprd07.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: aquantia.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: p3dYEIZwbOesycWd6oyuUqUcgw/uJOAIMo30naKgbajAmJNl2jQV9h9nJlX7sI9PYWNnlQrqOeuRQ9pLTk6DESowrgMJLzw9+/PsGJbBrNpQjJHsPr5kW4Dcm5n7hth+P9MtnLtqG2GQtW7+J6VYhdpjmkH4xU8Spb//wPysLy6vijvI7db14B8RlYC9CjwXGZhJfyRgRQV54Ws5nuyt8vH4jnd2bITHNlm1ZBlbEXU6Ec30+S0r5Gz+yy4I9agiwULoMWeDzxglc5VCWhcfRaMAW2APa+lIS8qu2ttkOE1MUifxCT2egTor/zN/QI9mJJNKaXcUVDOW11813ft24SgdVv7Y0HCN4bBex+zH1FM= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: aquantia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 55930044-c74b-4b64-fd78-08d65c4c4ff0 X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Dec 2018 14:00:15.1169 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 83e2e134-991c-4ede-8ced-34d47e38e6b1 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR07MB5787 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Dmitry Bogdanov Increase the upper limit of the hw queues up to 8. This makes RSS better on multiheaded cpus. This is a maximum AQC hardware supports in one traffic class. The actual value is still limited by a number of available cpu cores. Signed-off-by: Dmitry Bogdanov Signed-off-by: Igor Russkikh --- drivers/net/ethernet/aquantia/atlantic/aq_cfg.h | 2 +- drivers/net/ethernet/aquantia/atlantic/hw_atl/hw_atl_b0.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/aquantia/atlantic/aq_cfg.h b/drivers/net/ethernet/aquantia/atlantic/aq_cfg.h index 90a0e1d0d622..3944ce7f0870 100644 --- a/drivers/net/ethernet/aquantia/atlantic/aq_cfg.h +++ b/drivers/net/ethernet/aquantia/atlantic/aq_cfg.h @@ -12,7 +12,7 @@ #ifndef AQ_CFG_H #define AQ_CFG_H -#define AQ_CFG_VECS_DEF 4U +#define AQ_CFG_VECS_DEF 8U #define AQ_CFG_TCS_DEF 1U #define AQ_CFG_TXDS_DEF 4096U diff --git a/drivers/net/ethernet/aquantia/atlantic/hw_atl/hw_atl_b0.c b/drivers/net/ethernet/aquantia/atlantic/hw_atl/hw_atl_b0.c index 6af7d7f0cdca..08596a7a6486 100644 --- a/drivers/net/ethernet/aquantia/atlantic/hw_atl/hw_atl_b0.c +++ b/drivers/net/ethernet/aquantia/atlantic/hw_atl/hw_atl_b0.c @@ -21,7 +21,7 @@ #define DEFAULT_B0_BOARD_BASIC_CAPABILITIES \ .is_64_dma = true, \ - .msix_irqs = 4U, \ + .msix_irqs = 8U, \ .irq_mask = ~0U, \ .vecs = HW_ATL_B0_RSS_MAX, \ .tcs = HW_ATL_B0_TC_MAX, \ From patchwork Fri Dec 7 14:00:17 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Igor Russkikh X-Patchwork-Id: 1009433 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=aquantia.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=AQUANTIA1COM.onmicrosoft.com header.i=@AQUANTIA1COM.onmicrosoft.com header.b="ZDdM6Ceu"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 43BDd41tG9z9rxp for ; Sat, 8 Dec 2018 01:00:24 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726090AbeLGOAX (ORCPT ); Fri, 7 Dec 2018 09:00:23 -0500 Received: from mail-eopbgr780085.outbound.protection.outlook.com ([40.107.78.85]:28937 "EHLO NAM03-BY2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726059AbeLGOAV (ORCPT ); Fri, 7 Dec 2018 09:00:21 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=AQUANTIA1COM.onmicrosoft.com; s=selector1-aquantia-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FuiNi/qt7wan/yxDKu1QI5PoZ6riIMnMmPjsZlJqQ+Q=; b=ZDdM6CeuC7hgjGtwpQgPF86M74Px/S6kWHRwwVpL7de0XhzrMmPMAzNsIqnNkSUMR5VipkHWpahQKLO1BHrwndZiU8CKo9YlDu7OvvDDx4NiXUYPaXGEDPQqGE2iA5e4lp2W0a5N3kGOG6EXVB4us9lNjPiMZmz4qU3obd0jcso= Received: from DM6PR07MB6220.namprd07.prod.outlook.com (20.179.55.97) by DM6PR07MB5787.namprd07.prod.outlook.com (20.178.3.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1404.19; Fri, 7 Dec 2018 14:00:17 +0000 Received: from DM6PR07MB6220.namprd07.prod.outlook.com ([fe80::9d23:ba09:343:4aaa]) by DM6PR07MB6220.namprd07.prod.outlook.com ([fe80::9d23:ba09:343:4aaa%4]) with mapi id 15.20.1404.021; Fri, 7 Dec 2018 14:00:17 +0000 From: Igor Russkikh To: "David S . Miller" CC: Dmitry Bogdanov , "netdev@vger.kernel.org" , Igor Russkikh Subject: [PATCH v2 net-next 3/4] net: aquantia: fix initialization of RSS table Thread-Topic: [PATCH v2 net-next 3/4] net: aquantia: fix initialization of RSS table Thread-Index: AQHUjjUvrlBohAXmD0iKvxJLY4q5HQ== Date: Fri, 7 Dec 2018 14:00:17 +0000 Message-ID: <34f49bc5e9b591b727ac99bb6afe2e7a41848d04.1544190020.git.igor.russkikh@aquantia.com> References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: AM5PR06CA0006.eurprd06.prod.outlook.com (2603:10a6:206:2::19) To DM6PR07MB6220.namprd07.prod.outlook.com (2603:10b6:5:17d::33) authentication-results: spf=none (sender IP is ) smtp.mailfrom=Igor.Russkikh@aquantia.com; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [95.79.108.179] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; DM6PR07MB5787; 6:L4wd7AbA3Co2uvI/J9brOTVvS3SSH+Agkxxu7fR0kdeQFfqR5nWS+IHK0Tipf92eTo6VGiUdir9n5QkPtx5+mQm+wWLE/Ew245tT1C4n+gF8vqYyrrOQOBTHi4IjdLo0XbzBRZ/K4Hqr7IZqd0xR1E+bDMTYIwZE1ljPeMPDRsa3raKtEm/2K6Wh2WKGPc9Zx6FZPUSlfYeYgyVAKGTxpRnGHVce0ao2MVN+9rijQodWBd5H6y2KBrh5m8xWQSP7qjXAB8JOER4sZZkHGFp1QIguNR6rSaWe3yuD7aPSKADYRxcdSkC+Lalq1WHhDm7KZK9dIaYfDsm1raPziKoAI5hp846auw1UXU8qfQgX8QEppsqCoWSOkPot6rD9MW/vELyhTWhLyPsPLhzaaNwehTIj2cp3LAPkFfVv9ZKyUaxyDaw/uhztaclty6Pj3UGc26uPuJRHPpFMxs4jRi97gw==; 5:PY62tNh+xBSl/+xY2Pb0WrcrwZ5Je9rQJqF/reWrKpc2PihH+qZowoy9SpL0o9kms0UQoijjYILZgZO7ncevDbPY0VqG/NHGqvUFUQglrM2fu55e5gIr0FI3oINoLyJ/AzwT+iPcne07pdDjSznRDWanqWlZbETlAdIK2AUShGM=; 7:PbDrvBHcnTV8laEqdyxSwDHTG29QhhDJfx0UTahgPLtWLlVyqdxFU1NRK6PWP8o349MCEY+HVokRloIwqhsn683Stj62W3J4CY7QQJnh4oA8eGlW2hYgtBvnmc1cfzEjMiSMiouCrZGso1FDw9FC7g== x-ms-office365-filtering-correlation-id: 4120c355-02af-4676-3115-08d65c4c5159 x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390098)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600074)(711020)(2017052603328)(7153060)(7193020); SRVR:DM6PR07MB5787; x-ms-traffictypediagnostic: DM6PR07MB5787: x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(6040522)(2401047)(8121501046)(5005006)(10201501046)(93006095)(93001095)(3002001)(3231455)(999002)(944501520)(52105112)(148016)(149066)(150057)(6041310)(20161123558120)(20161123564045)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(201708071742011)(7699051)(76991095); SRVR:DM6PR07MB5787; BCL:0; PCL:0; RULEID:; SRVR:DM6PR07MB5787; x-forefront-prvs: 0879599414 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(136003)(39850400004)(366004)(396003)(346002)(376002)(189003)(199004)(486006)(386003)(6506007)(102836004)(2616005)(476003)(44832011)(36756003)(446003)(11346002)(4326008)(52116002)(118296001)(76176011)(107886003)(186003)(71200400001)(7736002)(305945005)(256004)(71190400001)(106356001)(54906003)(316002)(66066001)(105586002)(86362001)(97736004)(6916009)(25786009)(6486002)(81166006)(81156014)(5660300001)(3846002)(72206003)(478600001)(2906002)(6436002)(8676002)(68736007)(8936002)(26005)(53936002)(6512007)(14454004)(99286004)(6116002); DIR:OUT; SFP:1101; SCL:1; SRVR:DM6PR07MB5787; H:DM6PR07MB6220.namprd07.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: aquantia.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: W/F0YP3z/4bj50Kmdq9w0mVQCBw2mX0QSgUDVGsRYinu1Z+RfkPy/frGa2gIWb7fvDvdocvSz95yZ4O8OoYT60uFESeNM9bgb0XHuCLO7pZ6BkDO9pC+YVf+K23o9nA3PhKgVs74CbT3L0HW9Uy9VUODNtY+lOlof9Qf+RpnlUh+NRKrOG41ElfjRHyRgShB1IU6iQdSUGPriEeEHoWOhb+3F8KShVsKpTVw0oHzj8Z26imXFY3OvfGVBqIBQqYQYzjrPXnpedt0L/MNzoNwBiK+590s92FkiynfuE5NMbSWIAipRdjlP36XGPgwlzbk7JH6qfhCkSLlCOsjA6riPzM/0mFmqpyGBQS5/I8ME84= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: aquantia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4120c355-02af-4676-3115-08d65c4c5159 X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Dec 2018 14:00:17.4725 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 83e2e134-991c-4ede-8ced-34d47e38e6b1 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR07MB5787 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Dmitry Bogdanov Now RSS indirection table is initialized before setting up the number of hw queues, consequently the table may be filled by non existing queues. This patch moves the initialization when the number of hw queues is known. Signed-off-by: Dmitry Bogdanov Signed-off-by: Igor Russkikh --- drivers/net/ethernet/aquantia/atlantic/aq_nic.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/aquantia/atlantic/aq_nic.c b/drivers/net/ethernet/aquantia/atlantic/aq_nic.c index d617289d95f7..0147c037ca96 100644 --- a/drivers/net/ethernet/aquantia/atlantic/aq_nic.c +++ b/drivers/net/ethernet/aquantia/atlantic/aq_nic.c @@ -84,8 +84,6 @@ void aq_nic_cfg_start(struct aq_nic_s *self) cfg->is_lro = AQ_CFG_IS_LRO_DEF; - aq_nic_rss_init(self, cfg->num_rss_queues); - /*descriptors */ cfg->rxds = min(cfg->aq_hw_caps->rxds_max, AQ_CFG_RXDS_DEF); cfg->txds = min(cfg->aq_hw_caps->txds_max, AQ_CFG_TXDS_DEF); @@ -106,6 +104,8 @@ void aq_nic_cfg_start(struct aq_nic_s *self) cfg->num_rss_queues = min(cfg->vecs, AQ_CFG_NUM_RSS_QUEUES_DEF); + aq_nic_rss_init(self, cfg->num_rss_queues); + cfg->irq_type = aq_pci_func_get_irq_type(self); if ((cfg->irq_type == AQ_HW_IRQ_LEGACY) || From patchwork Fri Dec 7 14:00:22 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Igor Russkikh X-Patchwork-Id: 1009434 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=aquantia.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=AQUANTIA1COM.onmicrosoft.com header.i=@AQUANTIA1COM.onmicrosoft.com header.b="eJ6n8WuP"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 43BDd66TL4z9rxp for ; Sat, 8 Dec 2018 01:00:26 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726117AbeLGOA0 (ORCPT ); Fri, 7 Dec 2018 09:00:26 -0500 Received: from mail-eopbgr820054.outbound.protection.outlook.com ([40.107.82.54]:25379 "EHLO NAM01-SN1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726041AbeLGOAZ (ORCPT ); Fri, 7 Dec 2018 09:00:25 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=AQUANTIA1COM.onmicrosoft.com; s=selector1-aquantia-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=y6vCsFBhz4RuAJvFfh10gd22EI8Hl5onB84qEUrvNEI=; b=eJ6n8WuPDs64oyfV+ze0tI1T4uDmvsXwHXWOeWS67RqxsQhCTj6Yr1UuFYTg86GRAEgAmMnvjf1hkvHx6nXdgKCY+EL6jehYh8mIqivG94QFRCHRpMQOLnRLs1eQ74uYrpBOwLfOnyqs7iWnQ3YbD6zEtX1UYbGpB6o45YtBrIo= Received: from DM6PR07MB6220.namprd07.prod.outlook.com (20.179.55.97) by DM6PR07MB5787.namprd07.prod.outlook.com (20.178.3.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1404.19; Fri, 7 Dec 2018 14:00:23 +0000 Received: from DM6PR07MB6220.namprd07.prod.outlook.com ([fe80::9d23:ba09:343:4aaa]) by DM6PR07MB6220.namprd07.prod.outlook.com ([fe80::9d23:ba09:343:4aaa%4]) with mapi id 15.20.1404.021; Fri, 7 Dec 2018 14:00:22 +0000 From: Igor Russkikh To: "David S . Miller" CC: Dmitry Bogdanov , "netdev@vger.kernel.org" , Igor Russkikh Subject: [PATCH v2 net-next 4/4] net: aquantia: add support of RSS configuration Thread-Topic: [PATCH v2 net-next 4/4] net: aquantia: add support of RSS configuration Thread-Index: AQHUjjUyFZCaT202sEOIp2kFyl2pxw== Date: Fri, 7 Dec 2018 14:00:22 +0000 Message-ID: <10322d5bea074a446822e3913d3a4b49812557ae.1544190020.git.igor.russkikh@aquantia.com> References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: AM5PR06CA0006.eurprd06.prod.outlook.com (2603:10a6:206:2::19) To DM6PR07MB6220.namprd07.prod.outlook.com (2603:10b6:5:17d::33) authentication-results: spf=none (sender IP is ) smtp.mailfrom=Igor.Russkikh@aquantia.com; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [95.79.108.179] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; DM6PR07MB5787; 6:nRZuoT31CgEydaKIOuKJcuS2U1lhGQA+8+2Otu8dGv8t2d8shzxcy1oDlC46doto7YIWbwLNQ8dzm1XYVSO8nxYivyF8A/SOEtjz+Lj9/pcjbpmYjzKBQy1p3AxsM69XPSm2E+WBw0ySufZmGoKMWVrjxpXO6S+Ik7SEbNQoTNc1rUq3hn9SCjqGb/9KSc+edIhNlFFbK8EPeg4BbXfF3BBg8DoxwL99DzClGhubE//m6h5Bz4aGUe1+fSefz420WKHau51J2GqWQ9E7haW1hMGstzUk1dPri0hOi+pM6Zm0mmnydHCw7Hw9MIfAYzQHVOZa7epf2q5oFlJ6uJWzTjmc4VXJxBYFiIUQv3Y7mG1IGQpVHJqdRQUUZPnAnQeQmXI2+6FDZw8sFgVJnFaqst3ltWtKXxHoyZEwVpOEH2ucAmINUlPjtmKdyA5V6VPomPvrasFFywHOdTgoxR849w==; 5:CwXKrrLibx8oT6W183T/Z/zZ9FylTiRjm1wDosjLyMhS3Y820EYWVqOX5oChDbQpmfL50LePs1c0BtOXpOaDaMs1X9vOh1b21qXolI5nmJ9iCzGbXGTSV7HUXhr4uWjlQckmGHlNe+HD4Jd8TqGfQHNrfPaPWga44c2Ls15RH5I=; 7:22buxJD1DZOnCQmM6dKhZ++Qvxa4CGUUUCOgsqnpdB0l+2oUwzbgBnSPvM0pwbmADv0O0E0CtkGna7y05+1o38C78btjV3yRKXbF4pZEXsNWk1C0neKEmPQWN5E4nk80HAQtXeHYjv7bwdfs0NxjDg== x-ms-office365-filtering-correlation-id: 03b08c26-94f8-4663-4dad-08d65c4c548d x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390098)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600074)(711020)(2017052603328)(7153060)(7193020); SRVR:DM6PR07MB5787; x-ms-traffictypediagnostic: DM6PR07MB5787: x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(6040522)(2401047)(8121501046)(5005006)(10201501046)(93006095)(93001095)(3002001)(3231455)(999002)(944501520)(52105112)(148016)(149066)(150057)(6041310)(20161123558120)(20161123564045)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(201708071742011)(7699051)(76991095); SRVR:DM6PR07MB5787; BCL:0; PCL:0; RULEID:; SRVR:DM6PR07MB5787; x-forefront-prvs: 0879599414 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(136003)(39850400004)(366004)(396003)(346002)(376002)(189003)(199004)(486006)(386003)(6506007)(102836004)(2616005)(476003)(44832011)(36756003)(446003)(11346002)(4326008)(52116002)(118296001)(76176011)(107886003)(186003)(71200400001)(7736002)(305945005)(256004)(71190400001)(106356001)(54906003)(316002)(66066001)(105586002)(86362001)(97736004)(6916009)(25786009)(6486002)(81166006)(81156014)(5660300001)(3846002)(72206003)(478600001)(2906002)(6436002)(8676002)(68736007)(8936002)(26005)(53936002)(6512007)(14454004)(99286004)(6116002); DIR:OUT; SFP:1101; SCL:1; SRVR:DM6PR07MB5787; H:DM6PR07MB6220.namprd07.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: aquantia.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: 329yDcQPs8SFoUeJI2qJzCjLV4nuX1OS1gA3jG44jjrvnI657owR2vSBby0B7WSw6Lc5QehPIcj+rfHJN+SpqwhBRvzLKmDyhdRCM1RESwMMkb5oj/eaiChNw49my4+9mrRMKDamqmtE2D+4rjlsDoKdL1XTKNmkTKnxcr7buvtjcmhPkcufXcspRwkK5+Rp0dXCgPtW6UOdstjhOXwncvdVm9OizR1X1LZst/jfOywycxqAeqaEzYnPQF4xq8lfOyuoFMz4f/hfbP7LdxaZ2k5xA2iBEBPSr+LOm2zPa4cNTt0Aj476lBc6qKFFoOMOZd0Dkr5p9bjm2/bTUr7QeKqsVJcU5syJEBjdxyCUzmE= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: aquantia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 03b08c26-94f8-4663-4dad-08d65c4c548d X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Dec 2018 14:00:22.8542 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 83e2e134-991c-4ede-8ced-34d47e38e6b1 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR07MB5787 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Dmitry Bogdanov Add support of configuration of RSS hash key and RSS indirection table. Signed-off-by: Dmitry Bogdanov Signed-off-by: Igor Russkikh --- .../ethernet/aquantia/atlantic/aq_ethtool.c | 36 +++++++++++++++++++ 1 file changed, 36 insertions(+) diff --git a/drivers/net/ethernet/aquantia/atlantic/aq_ethtool.c b/drivers/net/ethernet/aquantia/atlantic/aq_ethtool.c index a5fd71692c8b..fcbfecf41c45 100644 --- a/drivers/net/ethernet/aquantia/atlantic/aq_ethtool.c +++ b/drivers/net/ethernet/aquantia/atlantic/aq_ethtool.c @@ -202,6 +202,41 @@ static int aq_ethtool_get_rss(struct net_device *ndev, u32 *indir, u8 *key, return 0; } +static int aq_ethtool_set_rss(struct net_device *netdev, const u32 *indir, + const u8 *key, const u8 hfunc) +{ + struct aq_nic_s *aq_nic = netdev_priv(netdev); + struct aq_nic_cfg_s *cfg; + unsigned int i = 0U; + u32 rss_entries; + int err = 0; + + cfg = aq_nic_get_cfg(aq_nic); + rss_entries = cfg->aq_rss.indirection_table_size; + + /* We do not allow change in unsupported parameters */ + if (hfunc != ETH_RSS_HASH_NO_CHANGE && hfunc != ETH_RSS_HASH_TOP) + return -EOPNOTSUPP; + /* Fill out the redirection table */ + if (indir) + for (i = 0; i < rss_entries; i++) + cfg->aq_rss.indirection_table[i] = indir[i]; + + /* Fill out the rss hash key */ + if (key) { + memcpy(cfg->aq_rss.hash_secret_key, key, + sizeof(cfg->aq_rss.hash_secret_key)); + err = aq_nic->aq_hw_ops->hw_rss_hash_set(aq_nic->aq_hw, + &cfg->aq_rss); + if (err) + return err; + } + + err = aq_nic->aq_hw_ops->hw_rss_set(aq_nic->aq_hw, &cfg->aq_rss); + + return err; +} + static int aq_ethtool_get_rxnfc(struct net_device *ndev, struct ethtool_rxnfc *cmd, u32 *rule_locs) @@ -549,6 +584,7 @@ const struct ethtool_ops aq_ethtool_ops = { .set_pauseparam = aq_ethtool_set_pauseparam, .get_rxfh_key_size = aq_ethtool_get_rss_key_size, .get_rxfh = aq_ethtool_get_rss, + .set_rxfh = aq_ethtool_set_rss, .get_rxnfc = aq_ethtool_get_rxnfc, .set_rxnfc = aq_ethtool_set_rxnfc, .get_sset_count = aq_ethtool_get_sset_count,