From patchwork Wed Dec 5 19:50:25 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rob Herring X-Patchwork-Id: 1008421 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=linux-ide-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 4398Yn4DTkz9sBQ for ; Thu, 6 Dec 2018 06:53:49 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728584AbeLETxf (ORCPT ); Wed, 5 Dec 2018 14:53:35 -0500 Received: from mail-oi1-f196.google.com ([209.85.167.196]:43180 "EHLO mail-oi1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728664AbeLETvC (ORCPT ); Wed, 5 Dec 2018 14:51:02 -0500 Received: by mail-oi1-f196.google.com with SMTP id u18so18623373oie.10; Wed, 05 Dec 2018 11:51:01 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=SJ9ws45Vv3vAPydB9eOaRCa8LnZGc1t7yjxAlBirVB0=; b=a7SEdWWKb7lD1EA4Ekt+36TeN74a0F9+ZfvPbHtJovekSXt4tFRC53UITgZn58IxJx 8q0hP7CGo3fUe/c7kq+5oIeKn00bf8Q/+5XuyQ4crZbUQYUnG518JMt+D4aWa/I8xdHz bwY/d/NxWnLNxmjvWC8TeGUhQ6Z7VJvQQJK+6hwJIzbKYxTwYW6LLe+ODuElhnwlJShP oEYcPgFN6+rbTW308KtDJ4flpzsByIIF+oRIamG8+W0oFVLgqL9YR0447zFXLxLHz2wY LSinGTd7guD00VOhHbXbL8SrJcp+ADg2ZzVTXdy8H0DnodORn8CzjYD3h0U2+XVebSQ7 IgSQ== X-Gm-Message-State: AA+aEWbe+SomKoVD+AdyiJfhafz1DDq1HTCGqSRXGaGIfKKLh+rktTwn INbhoApkWbAMbBTB5lpr7tRwiqY= X-Google-Smtp-Source: AFSGD/X7aKQeZVng8JR2Bng8ewJcNCzuYa1uBshwFTyi0QJEfHBCA2uykUhLxJDIWg2UCxw4bvZniA== X-Received: by 2002:aca:da02:: with SMTP id r2mr15033923oig.66.1544039461139; Wed, 05 Dec 2018 11:51:01 -0800 (PST) Received: from xps15.herring.priv (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.googlemail.com with ESMTPSA id k13sm25759879otj.19.2018.12.05.11.51.00 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 05 Dec 2018 11:51:00 -0800 (PST) From: Rob Herring To: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: "David S. Miller" , Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , linux-ide@vger.kernel.org, linuxppc-dev@lists.ozlabs.org Subject: [PATCH] ide: Use of_node_name_eq for node name comparisons Date: Wed, 5 Dec 2018 13:50:25 -0600 Message-Id: <20181205195050.4759-9-robh@kernel.org> X-Mailer: git-send-email 2.19.1 MIME-Version: 1.0 Sender: linux-ide-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ide@vger.kernel.org Convert string compares of DT node names to use of_node_name_eq helper instead. This removes direct access to the node name pointer. Cc: "David S. Miller" Cc: Benjamin Herrenschmidt Cc: Paul Mackerras Cc: Michael Ellerman Cc: linux-ide@vger.kernel.org Cc: linuxppc-dev@lists.ozlabs.org Signed-off-by: Rob Herring --- drivers/ide/pmac.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/ide/pmac.c b/drivers/ide/pmac.c index c5b902b86b44..ec46aa84d18d 100644 --- a/drivers/ide/pmac.c +++ b/drivers/ide/pmac.c @@ -1045,7 +1045,7 @@ static int pmac_ide_setup_device(pmac_ide_hwif_t *pmif, struct ide_hw *hw) d.port_ops = &pmac_ide_ata4_port_ops; d.udma_mask = ATA_UDMA5; } else if (of_device_is_compatible(np, "keylargo-ata")) { - if (strcmp(np->name, "ata-4") == 0) { + if (of_node_name_eq(np, "ata-4")) { pmif->kind = controller_kl_ata4; d.port_ops = &pmac_ide_ata4_port_ops; d.udma_mask = ATA_UDMA4;