From patchwork Thu Oct 12 21:16:06 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christian Lamparter X-Patchwork-Id: 825109 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.infradead.org (client-ip=65.50.211.133; helo=bombadil.infradead.org; envelope-from=lede-dev-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="doeGKHhz"; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="tPRrhXrV"; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3yCkF514XYz9sNc for ; Fri, 13 Oct 2017 08:16:50 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Subject:Message-Id: Date:To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=oKpcU1b6rfymaSvr6UzqB27+/QGQeQTYlbzi/25X5QY=; b=doeGKHhz4VMM8b cH7vWAdZgrtvAeECmSwlm2jSKRr0VzflqJm5nxRKdLE5AF5GtnihVw+oNeJydH6bhLczw8Ox+tpn7 2V94pWXItQZMt1j8EUoIv+4poCC0YWz4mZ/YszFz8R7njz4y8mYM/y3p9EjyWl/07pF0qZ3SpC0RN pL1VcU/RSYmgCy1/MqIZYnPHgyJN5DjfPQFFmr5+2aoaxtCzzSh5Vcy5BsWnkSHlx15zOCdAw4t91 7n0+TIbTmgoPeAePOuQADJ3iH61Spr7O0G1QPmX2zRb3pxEusV+4nC3htPgGj2dmJ00hLIJIjIybb y/hnUARtmJ+/T7zR2/vA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux)) id 1e2kqV-0004me-RD; Thu, 12 Oct 2017 21:16:47 +0000 Received: from mail-wm0-x241.google.com ([2a00:1450:400c:c09::241]) by bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1e2kqH-0004Os-OU for lede-dev@lists.infradead.org; Thu, 12 Oct 2017 21:16:35 +0000 Received: by mail-wm0-x241.google.com with SMTP id m72so16510633wmc.1 for ; Thu, 12 Oct 2017 14:16:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=GkMiEsjj8JKP3oDEFlcHt8yvDP7o11Px+xyHv7oz3U8=; b=tPRrhXrVRkRZhvBalRaLJ510muXwj/Xvgs4wi/WIaT2CExogVre/IyKrIs+ecsReUh X2HkYUr/x8YBR71rUBpbKtxhVVSV1iFt42bb6ZQHOjXNWx37lGN6tQTXcR2FoJt1m7z8 y7iziKZJUM5rETv06Lg8bhy8TIzlkkcCAADhLtdVmSqGANACQuC+K2CiMQKNAe/sJWkK 38BruP8m4jqb+fvSsveQrLfgKSJDSSaxBBxUiPlZabu5WSGDNbsQtcZzOSTYwuewphXv ByGcjBA8tXNDzS4vncFfcx6vMSMtlsqpDE2NkwPqx6HosXOxUZrdwxDXkBCDi9/PRnfH aG8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=GkMiEsjj8JKP3oDEFlcHt8yvDP7o11Px+xyHv7oz3U8=; b=rSiaWQ75Kqe84dNjiEQCLLigBqAnY/Sove+dUFqJw+kSc0y8wGii3MnLAi8GKQuHGh eBWIQn7cccmk2jTCl0PqJUFRrUP6fZ1XOHPvPlS1EqQOJwWIA2BYR5uRKPS46ceX5U+k 4IJBd05ilqAA4a9fjKOvWLWadTn6Z2fEc9BCoVnflSzA6n9Cxmd3IxZvpVPNvrIOC65P Zl5mU1LiEr7MIsop7QyHt4cVlpgNKjlxcsUL7NTWgmBRnMP7PiWNqnQ5nLcWHgXRCDOJ Rs4iD8lQbjFAfsRRznfW/YO0k8D/1MHXB7cNsoqJxls9nMMdMM3VtMe/RrRJD9ZkDEsN Y7UA== X-Gm-Message-State: AMCzsaXbRy+sNEdB5ou0AxF+vdzbl8jSHZx5UXhWEU7T+Rz4Rk5ISER7 tS4BFrz0Xkjoew+08sIiCwVWHk5k X-Google-Smtp-Source: AOwi7QANDdoW2uy/sJ/fCjWUlUBSNTLVpkJbeS8dxLYAEqOxuTXgG7l3peo5WR8AStXQfudWywL0Iw== X-Received: by 10.28.238.73 with SMTP id m70mr2692435wmh.23.1507842971755; Thu, 12 Oct 2017 14:16:11 -0700 (PDT) Received: from debian64.daheim (p200300D5FBC0EBFCA1A13610D2D4289E.dip0.t-ipconnect.de. [2003:d5:fbc0:ebfc:a1a1:3610:d2d4:289e]) by smtp.gmail.com with ESMTPSA id o18sm11039644wrc.45.2017.10.12.14.16.09 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 12 Oct 2017 14:16:09 -0700 (PDT) Received: from chuck by debian64.daheim with local (Exim 4.89) (envelope-from ) id 1e2kps-0007ra-PI; Thu, 12 Oct 2017 23:16:08 +0200 From: Christian Lamparter To: lede-dev@lists.infradead.org Date: Thu, 12 Oct 2017 23:16:06 +0200 Message-Id: <20171012211608.30184-1-chunkeey@gmail.com> X-Mailer: git-send-email 2.15.0.rc0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20171012_141633_961570_2BD18953 X-CRM114-Status: UNSURE ( 8.79 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -2.0 (--) X-Spam-Report: SpamAssassin version 3.4.1 on bombadil.infradead.org summary: Content analysis details: (-2.0 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_PASS SPF: sender matches SPF record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (chunkeey[at]gmail.com) -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [2a00:1450:400c:c09:0:0:0:241 listed in] [list.dnswl.org] Subject: [LEDE-DEV] [PATCH] dnsmasq: add listen_address parameter X-BeenThere: lede-dev@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Hans Dedecker MIME-Version: 1.0 Sender: "Lede-dev" Errors-To: lede-dev-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org This patch adds a parser for the uci representation of dnsmasq's "-a | --listen-address" option. In summary, this option forces dnsmasq to listen on the given IP address(es). Both interface and listen-address options may be given, in which case the set of both interfaces and addresses is used. Note that if no interface option is given, but listen_address is, dnsmasq will not automatically listen on the loopback interface. To achieve this, the loopback IP addresses, 127.0.0.1 and/or ::1 must be explicitly added. This option is useful for ujailed dnsmasq instances, that would otherwise fail to work properly, because listening to the "This host on this network" address (aka 0.0.0.0 see rfc1700 page 4) may not be allowed. Signed-off-by: Christian Lamparter --- package/network/services/dnsmasq/files/dnsmasq.init | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/package/network/services/dnsmasq/files/dnsmasq.init b/package/network/services/dnsmasq/files/dnsmasq.init index 0149643959..3d3d83334e 100644 --- a/package/network/services/dnsmasq/files/dnsmasq.init +++ b/package/network/services/dnsmasq/files/dnsmasq.init @@ -142,6 +142,10 @@ append_interface() { xappend "--interface=$ifname" } +append_listenaddress() { + xappend "--listen-address=$1" +} + append_notinterface() { network_get_device ifname "$1" || ifname="$1" xappend "--except-interface=$ifname" @@ -835,6 +839,7 @@ dnsmasq_start() append_parm "$cfg" "maxport" "--max-port" append_parm "$cfg" "domain" "--domain" append_parm "$cfg" "local" "--server" + config_list_foreach "$cfg" "listen_address" append_listenaddress config_list_foreach "$cfg" "server" append_server config_list_foreach "$cfg" "rev_server" append_rev_server config_list_foreach "$cfg" "address" append_address