From patchwork Wed Nov 14 20:54:33 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexander Sverdlin X-Patchwork-Id: 997870 Return-Path: X-Original-To: incoming-buildroot@patchwork.ozlabs.org Delivered-To: patchwork-incoming-buildroot@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=busybox.net (client-ip=140.211.166.136; helo=silver.osuosl.org; envelope-from=buildroot-bounces@busybox.net; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="sWsrbe7g"; dkim-atps=neutral Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 42wGw83yS3z9s8J for ; Thu, 15 Nov 2018 07:55:04 +1100 (AEDT) Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id C191030229; Wed, 14 Nov 2018 20:54:59 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id vqIinU077rXz; Wed, 14 Nov 2018 20:54:56 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by silver.osuosl.org (Postfix) with ESMTP id D553D30141; Wed, 14 Nov 2018 20:54:56 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by ash.osuosl.org (Postfix) with ESMTP id 9C2D01BF2CC for ; Wed, 14 Nov 2018 20:54:55 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id 99A0C81E57 for ; Wed, 14 Nov 2018 20:54:55 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id sQrviGdgEtgx for ; Wed, 14 Nov 2018 20:54:52 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-wr1-f66.google.com (mail-wr1-f66.google.com [209.85.221.66]) by hemlock.osuosl.org (Postfix) with ESMTPS id 860F381B37 for ; Wed, 14 Nov 2018 20:54:52 +0000 (UTC) Received: by mail-wr1-f66.google.com with SMTP id v18-v6so18817029wrt.8 for ; Wed, 14 Nov 2018 12:54:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=9ePcFu1NlPpbhbRXUx6D61wJiiGpGnwuI3pmlz+z6UM=; b=sWsrbe7guDE0NGnIlOJLYN0oCsZTBYljWCFnrzvukrzlnEqdQH9lCJzTl/KeKZFQcT gktXguZlAcw4jmdnvcgayVYqXHDe2yTVZpCgdwGXZOlNFQnJGa8Eif62XifIlwV5paEp 0Uve8ESj1wkFacsVWnO9aoGW8hoAY8Mra7intI2oB8nw0FXsa7C4JAXeCmhnq2WCg/b9 voVJ/sqhwITUWw1+HjeNQdXfYe7SguCLFd3IuV94aVlx0+nfWL1ejwJIbrdQCVHWtUwF E6YopLGSrbOVklfDwCASm9h/QvVhPcwmRlTsdhPcxIq8BlRY7NVUhXl0PljtSBeiHnzw rS2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=9ePcFu1NlPpbhbRXUx6D61wJiiGpGnwuI3pmlz+z6UM=; b=VbA7mVu8wi7JZCZgFDlHmfg8Id5Nne302kvDMUZRDwRCZPPlnZWOkepoZ8FmWVKFOQ m1W/u9DI1EPbZW2vubhsffwqevPzsKO5KEi+2//uMoIjSIlzHA2Qmn26H+U1hrTP7B9w KyaiWWl7J+IPDn/fLG+n89RlwP437C0pSqO4Q8bylQR922dIrktNS1T3ktE+mgn10MDx 2X3iOF0h65v/Bf5lcPoddZpaMNmxlGYq/OWabQ/L8W9rC0opxPEJJcUGpTnfgZj/Rank oA6/gOjqoU4cgfBIzzdwBD10RynaLw8OX2ZqeNBUBugBrDfaroNso6+/BTfVh0zewD+F SYwA== X-Gm-Message-State: AGRZ1gJuHXB/s9qz3LFHHV28XfRP+LhRfDRFWwhIWmBPnFqtACoSyGXY 7KZa8eelH1wsR0/gaxCXUOgzM+1mChc= X-Google-Smtp-Source: AJdET5eUbEDLhTsw0g4CJOwSDiW4uZWfXInnNAtRyZR2lDW7QrwdPFlXZpdFRwFhbK0c5L9koa8nLg== X-Received: by 2002:a5d:68d1:: with SMTP id p17-v6mr2269604wrw.34.1542228890475; Wed, 14 Nov 2018 12:54:50 -0800 (PST) Received: from giga-mm.localdomain ([195.245.39.242]) by smtp.gmail.com with ESMTPSA id g5-v6sm12118596wmf.34.2018.11.14.12.54.49 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 14 Nov 2018 12:54:49 -0800 (PST) From: Alexander Sverdlin To: buildroot@buildroot.org Date: Wed, 14 Nov 2018 21:54:33 +0100 Message-Id: <20181114205433.3233-1-alexander.sverdlin@gmail.com> X-Mailer: git-send-email 2.19.1 MIME-Version: 1.0 Subject: [Buildroot] [PATCH v2] boot/syslinux: Fix build with glibc 2.28+ X-BeenThere: buildroot@busybox.net X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Alexander Sverdlin , Thomas Petazzoni Errors-To: buildroot-bounces@busybox.net Sender: "buildroot" When building with glibc 2.28+, the "major", "minor" and "makedev" functions are defined in "sys/sysmacros.h". The patch "extlinux: pull in sys/sysmacros.h for major/minor/makedev", applied to Syslinux during 2016Apr, should help. Please note that not only Syslinux is affected by this change in glibc. Link: https://www.syslinux.org/wiki/index.php?title=Building Signed-off-by: Alexander Sverdlin --- Changelog: v2: - Commit message: 2.23 -> 2.28 ...-sysmacros-h-for-major-minor-makedev.patch | 34 +++++++++++++++++++ 1 file changed, 34 insertions(+) create mode 100644 boot/syslinux/0012-pull-in-sys-sysmacros-h-for-major-minor-makedev.patch diff --git a/boot/syslinux/0012-pull-in-sys-sysmacros-h-for-major-minor-makedev.patch b/boot/syslinux/0012-pull-in-sys-sysmacros-h-for-major-minor-makedev.patch new file mode 100644 index 0000000000..beba5cc245 --- /dev/null +++ b/boot/syslinux/0012-pull-in-sys-sysmacros-h-for-major-minor-makedev.patch @@ -0,0 +1,34 @@ +From 1a74985b2a404639b08882c57f3147229605dfd5 Mon Sep 17 00:00:00 2001 +From: Mike Frysinger +Date: Tue, 19 Apr 2016 06:50:31 -0400 +Subject: [PATCH] extlinux: pull in sys/sysmacros.h for major/minor/makedev + +These functions are defined in sys/sysmacros.h, so add the include to +main.c. This is already handled correctly in mountinfo.c. Otherwise +we get build failures like: + +main.o: In function 'find_device_sysfs': +extlinux/main.c:1131: undefined reference to 'minor' + +Signed-off-by: Mike Frysinger +Signed-off-by: Gene Cumm +Signed-off-by: Alexander Sverdlin +--- + extlinux/main.c | 1 + + 1 file changed, 1 insertion(+) + +diff --git a/extlinux/main.c b/extlinux/main.c +index a7ebd49..ebff7ea 100644 +--- a/extlinux/main.c ++++ b/extlinux/main.c +@@ -38,6 +38,7 @@ + #include + #include + #include ++#include + #include + #include + #include +-- +2.10.5.GIT +