From patchwork Wed Nov 14 14:21:46 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Cristian Marussi X-Patchwork-Id: 997772 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=lists.linux.it (client-ip=2001:1418:10:5::2; helo=picard.linux.it; envelope-from=ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=arm.com Received: from picard.linux.it (picard.linux.it [IPv6:2001:1418:10:5::2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 42w6C42LgFz9s3q for ; Thu, 15 Nov 2018 01:22:23 +1100 (AEDT) Received: from picard.linux.it (localhost [IPv6:::1]) by picard.linux.it (Postfix) with ESMTP id 37F3C3E65EB for ; Wed, 14 Nov 2018 15:22:17 +0100 (CET) X-Original-To: ltp@lists.linux.it Delivered-To: ltp@picard.linux.it Received: from in-4.smtp.seeweb.it (in-4.smtp.seeweb.it [IPv6:2001:4b78:1:20::4]) by picard.linux.it (Postfix) with ESMTP id A79803E65C4 for ; Wed, 14 Nov 2018 15:22:15 +0100 (CET) Received: from foss.arm.com (usa-sjc-mx-foss1.foss.arm.com [217.140.101.70]) by in-4.smtp.seeweb.it (Postfix) with ESMTP id DE9281002056 for ; Wed, 14 Nov 2018 15:22:13 +0100 (CET) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 09D9BA78 for ; Wed, 14 Nov 2018 06:22:12 -0800 (PST) Received: from e120937-lin.cambridge.arm.com (e120937-lin.cambridge.arm.com [10.1.197.50]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 86C913F5BD for ; Wed, 14 Nov 2018 06:22:11 -0800 (PST) From: Cristian Marussi To: ltp@lists.linux.it Date: Wed, 14 Nov 2018 14:21:46 +0000 Message-Id: <20181114142147.38221-1-cristian.marussi@arm.com> X-Mailer: git-send-email 2.17.1 X-Virus-Scanned: clamav-milter 0.99.2 at in-4.smtp.seeweb.it X-Virus-Status: Clean X-Spam-Status: No, score=-0.0 required=7.0 tests=SPF_PASS autolearn=disabled version=3.4.0 X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on in-4.smtp.seeweb.it Subject: [LTP] [PATCH 1/2] [PATCH] cpuset_hotplug: fix cpuset_list_compute X-BeenThere: ltp@lists.linux.it X-Mailman-Version: 2.1.18 Precedence: list List-Id: Linux Test Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it Sender: "ltp" cpuset_hotplug failed with: Usage : cpuset_list_compute [-a|s] list1 [list2] -a|s list1 add/subtract list2.[default: -a] -h Help. cpuset_hotplug 1 TFAIL: root group's cpus isn't expected(Result: 0,2-5, Expect: ). It turned out that helper cpuset_list_compute was always failing because it was improperly handling getopt retval. Signed-off-by: Cristian Marussi --- .../cpuset/cpuset_hotplug_test/cpuset_list_compute.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/testcases/kernel/controllers/cpuset/cpuset_hotplug_test/cpuset_list_compute.c b/testcases/kernel/controllers/cpuset/cpuset_hotplug_test/cpuset_list_compute.c index 1b55f4b30..b9f176af4 100644 --- a/testcases/kernel/controllers/cpuset/cpuset_hotplug_test/cpuset_list_compute.c +++ b/testcases/kernel/controllers/cpuset/cpuset_hotplug_test/cpuset_list_compute.c @@ -29,8 +29,7 @@ static void usage(char *prog_name, int status) static void checkopt(int argc, char **argv) { - char c = '\0'; - int optc = 0; + int c, optc = 0; while ((c = getopt(argc, argv, "ahs")) != -1) { switch (c) { From patchwork Wed Nov 14 14:21:47 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Cristian Marussi X-Patchwork-Id: 997773 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=lists.linux.it (client-ip=2001:1418:10:5::2; helo=picard.linux.it; envelope-from=ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=arm.com Received: from picard.linux.it (picard.linux.it [IPv6:2001:1418:10:5::2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 42w6CF1cB4z9s3q for ; Thu, 15 Nov 2018 01:22:33 +1100 (AEDT) Received: from picard.linux.it (localhost [IPv6:::1]) by picard.linux.it (Postfix) with ESMTP id 947BE3E65EE for ; Wed, 14 Nov 2018 15:22:30 +0100 (CET) X-Original-To: ltp@lists.linux.it Delivered-To: ltp@picard.linux.it Received: from in-2.smtp.seeweb.it (in-2.smtp.seeweb.it [217.194.8.2]) by picard.linux.it (Postfix) with ESMTP id 87B3A3E65C4 for ; Wed, 14 Nov 2018 15:22:28 +0100 (CET) Received: from foss.arm.com (foss.arm.com [217.140.101.70]) by in-2.smtp.seeweb.it (Postfix) with ESMTP id E670C6022CE for ; Wed, 14 Nov 2018 15:22:27 +0100 (CET) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id B7AB6A78 for ; Wed, 14 Nov 2018 06:22:26 -0800 (PST) Received: from e120937-lin.cambridge.arm.com (e120937-lin.cambridge.arm.com [10.1.197.50]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 41F203F5BD for ; Wed, 14 Nov 2018 06:22:26 -0800 (PST) From: Cristian Marussi To: ltp@lists.linux.it Date: Wed, 14 Nov 2018 14:21:47 +0000 Message-Id: <20181114142147.38221-2-cristian.marussi@arm.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20181114142147.38221-1-cristian.marussi@arm.com> References: <20181114142147.38221-1-cristian.marussi@arm.com> X-Virus-Scanned: clamav-milter 0.99.2 at in-2.smtp.seeweb.it X-Virus-Status: Clean X-Spam-Status: No, score=-0.0 required=7.0 tests=SPF_PASS autolearn=disabled version=3.4.0 X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on in-2.smtp.seeweb.it Subject: [LTP] [PATCH 2/2] [PATCH] cpuset_list_compute fix exit value X-BeenThere: ltp@lists.linux.it X-Mailman-Version: 2.1.18 Precedence: list List-Id: Linux Test Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it Sender: "ltp" Internal usage() helper was meant to use a custom exit value provided by the caller, so use it. Signed-off-by: Cristian Marussi --- .../cpuset/cpuset_hotplug_test/cpuset_list_compute.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/testcases/kernel/controllers/cpuset/cpuset_hotplug_test/cpuset_list_compute.c b/testcases/kernel/controllers/cpuset/cpuset_hotplug_test/cpuset_list_compute.c index b9f176af4..1c66b863a 100644 --- a/testcases/kernel/controllers/cpuset/cpuset_hotplug_test/cpuset_list_compute.c +++ b/testcases/kernel/controllers/cpuset/cpuset_hotplug_test/cpuset_list_compute.c @@ -24,7 +24,7 @@ int convert; static void usage(char *prog_name, int status) { fprintf(stderr, USAGE, prog_name); - exit(1); + exit(status); } static void checkopt(int argc, char **argv)