From patchwork Mon Nov 12 14:10:28 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Johan Hovold X-Patchwork-Id: 996444 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=linux-gpio-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="LhropB8l"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 42tt3l3mBfz9s3Z for ; Tue, 13 Nov 2018 01:11:47 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727530AbeKMAFN (ORCPT ); Mon, 12 Nov 2018 19:05:13 -0500 Received: from mail-lj1-f195.google.com ([209.85.208.195]:45591 "EHLO mail-lj1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727103AbeKMAFM (ORCPT ); Mon, 12 Nov 2018 19:05:12 -0500 Received: by mail-lj1-f195.google.com with SMTP id s5-v6so7705762ljd.12; Mon, 12 Nov 2018 06:11:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=kNbJKObl4Tq1U1sfmTZWYIQLrVWBJAR23Hj9Dp7uhbM=; b=LhropB8l8dWi7ecioV/IYdDDHw/3zqktKsslRTGWMsxx5Qusxr/3Xr0qwQ9Qk9JSx8 KGO94CGE4FIYHtrKh9gSdBxuBZVFuv9f+hANOX3ZnOq6D+jd4g3bkygl+9LWaF9mo0kp MMx1IA/jvqcarhARieXDHc4PNGedrzZgbww/ZhOjrMb68vTtg3TYhoqemYcTE+SHg1Ta /QTd18yWuFe+UfPebaJ/49lWTCI/+6tHGUorOZxXzTaBD32c3Ai37uU7TudGIl6JQ1UI CMNsiZPrGbV8DFeES0L72vhxHtIETkAy3TdnNySs8P8yydOD0VUJZ5ib8TNaEW5G1HTH Vk9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :mime-version:content-transfer-encoding; bh=kNbJKObl4Tq1U1sfmTZWYIQLrVWBJAR23Hj9Dp7uhbM=; b=eApBgUK1M0w9IRLfyJb4zsf/w756daKAGMUaPG+AB2yHehvu9KeOr1g5YdQSp0PHa/ xLGZrxgav0x9V2G62lwzglz0+U1OW1MJ2oXa32fUf3iV2xIkmEQKoimacH0lrOtvjRU7 UEx9koLvMZSrILlhP0YzXjMHOWf+kyFIFeltakF8Gi6r5+VyzX2ukA5ofSaWbVgX70SE YfsE0bSj8IQbbt8ep8zjz3VNR8WdmxFz2UotBaRUc4RdO9Xbe+UdcPb2aXefmQLbVkXy 7deW5mtSaWKY0AnwqIIekZO2KgR96IiGgbNRZ21ZLinQmRCtxemf5qL1oBBfjemwaFN5 ykig== X-Gm-Message-State: AGRZ1gJjsCRf149eBdc9+Jrkse3gR3rd+9PQ3Bls1RpTsQI2OHqBBObj HskLtKMeV4ysTr6X6i8mvfw= X-Google-Smtp-Source: AJdET5dKOJ3ifHNggjdUH79sOvP68IEL7u9RooGVzg0Fc32XNLOL80JAMsnrn3gnAFHyqDKcQoYXHw== X-Received: by 2002:a2e:824c:: with SMTP id j12-v6mr763690ljh.168.1542031904629; Mon, 12 Nov 2018 06:11:44 -0800 (PST) Received: from xi.terra (c-74bee655.07-184-6d6c6d4.bbcust.telenor.se. [85.230.190.116]) by smtp.gmail.com with ESMTPSA id n3sm2906079lfl.44.2018.11.12.06.11.43 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 12 Nov 2018 06:11:43 -0800 (PST) Received: from johan by xi.terra with local (Exim 4.91) (envelope-from ) id 1gMCwF-0002fZ-H2; Mon, 12 Nov 2018 15:11:39 +0100 From: Johan Hovold To: Linus Walleij Cc: Bartosz Golaszewski , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Johan Hovold , Thierry Reding , Grygorii Strashko Subject: [PATCH] gpio: drop broken to_gpio_irq_chip() helper Date: Mon, 12 Nov 2018 15:10:28 +0100 Message-Id: <20181112141028.10213-1-johan@kernel.org> X-Mailer: git-send-email 2.19.1 MIME-Version: 1.0 Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org Drop the broken to_gpio_irq_chip() container_of() helper, which would break the build for anyone who tries to use it. Specifically, struct gpio_irq_chip only holds a pointer to a struct irq_chip so using container_of() on an irq-chip pointer makes no sense. Fixes: da80ff81a8f5 ("gpio: Move irqchip into struct gpio_irq_chip") Cc: Thierry Reding Cc: Grygorii Strashko Signed-off-by: Johan Hovold Reviewed-by: Bartosz Golaszewski --- include/linux/gpio/driver.h | 5 ----- 1 file changed, 5 deletions(-) diff --git a/include/linux/gpio/driver.h b/include/linux/gpio/driver.h index 2db62b550b95..21bff1f14fde 100644 --- a/include/linux/gpio/driver.h +++ b/include/linux/gpio/driver.h @@ -166,11 +166,6 @@ struct gpio_irq_chip { */ void (*irq_disable)(struct irq_data *data); }; - -static inline struct gpio_irq_chip *to_gpio_irq_chip(struct irq_chip *chip) -{ - return container_of(chip, struct gpio_irq_chip, chip); -} #endif /**