From patchwork Thu Nov 8 16:52:53 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bartosz Golaszewski X-Patchwork-Id: 995019 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=linux-gpio-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=bgdev-pl.20150623.gappssmtp.com header.i=@bgdev-pl.20150623.gappssmtp.com header.b="2CWEW0LS"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 42rTqt1N4qz9s8J for ; Fri, 9 Nov 2018 03:53:14 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727158AbeKIC3d (ORCPT ); Thu, 8 Nov 2018 21:29:33 -0500 Received: from mail-wr1-f67.google.com ([209.85.221.67]:46222 "EHLO mail-wr1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727155AbeKIC3c (ORCPT ); Thu, 8 Nov 2018 21:29:32 -0500 Received: by mail-wr1-f67.google.com with SMTP id 74-v6so21980678wrb.13 for ; Thu, 08 Nov 2018 08:53:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=GwZ4kCn0pUIbC4Baifciq+tWo366hhq+7YU9gxlpjWY=; b=2CWEW0LSLbtDykunbHCkuFxjCRA5vxuhJKV8ZS3QfMfy6QPJHzB7zC/5BdlWkEQ3Be W6TVaUB/cKyilVRz0vdxNiliTTnP/WxbokNm2pNzyN07VQ7fEspGoPwAulFU92wz2Qkr vMwrTuRSEhq9enJsgex8Ffd7qgwDbYxTkmf2GoqSNyJxTPYgtafGeO+JrkA22nf+XI6b NzZaxPE2emQNZq93Lh5V78gqk6Q9gZqV8P3BEPaB8DWcPbyxuxvFXkU3mKa+C3vDlUXZ hZG3AdDOYv3xbEQVjnKUMd7XtGHFp0Us0dJle15pwK62pMrOlrCDa+9vm3FvTg2ywEtf WTIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=GwZ4kCn0pUIbC4Baifciq+tWo366hhq+7YU9gxlpjWY=; b=kPUOe6ey+EGoUvexDvRP/WCxqiCp7ot8pWR4+EjIiBKKRc7x2HZ2w/sX4U/cNIy0vG aTwM5pckxBDNbDNFpd66CURWPBU19NkhUfVxeMbOrg/MtZj2xS2tc2J/9ZtCIA+LfLkC a6S/DhsugtXvUQYXaGEZaAnTWZRTkPEGyGazcJQi7JtEQ6LfLQXKamBm0Ow8uMLCifLD 7WY6kG0UOaEmEkX6T5YZfC335tKS+qfhTigE2208LG2cUK91wOm13TOSyZiEON8N8/r6 r2OaLhEckbSJJ4nfSIxUbUseNFoIjFsMAz7skGPBGrl+epyvbc8N4nFccGs2biajsTTB fAqw== X-Gm-Message-State: AGRZ1gJEgEfk3QXqEao8DSwrzv1kLUy7zVxxeEHNv3HEeuso2sdd58Vc jGqWn0tyXejXn/GM6QjS6VxapQ== X-Google-Smtp-Source: AJdET5ee5cpAXJcVHKhW/HPr3CcHrfLQt8SErOFqsrV9SVEkZRbZsbCfwxcjG2iMpYjcTovoMP7Aeg== X-Received: by 2002:adf:f148:: with SMTP id y8-v6mr4989094wro.303.1541695989486; Thu, 08 Nov 2018 08:53:09 -0800 (PST) Received: from debian-brgl.lan ([2a01:cb1d:af:5b00:6d6c:8493:1ab5:dad7]) by smtp.gmail.com with ESMTPSA id h5-v6sm7815987wrs.51.2018.11.08.08.53.08 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 08 Nov 2018 08:53:08 -0800 (PST) From: Bartosz Golaszewski To: Bamvor Jian Zhang , Linus Walleij , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Bartosz Golaszewski Subject: [PATCH 1/3] gpio: mockup: fix indicated direction Date: Thu, 8 Nov 2018 17:52:53 +0100 Message-Id: <20181108165255.9940-2-brgl@bgdev.pl> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20181108165255.9940-1-brgl@bgdev.pl> References: <20181108165255.9940-1-brgl@bgdev.pl> MIME-Version: 1.0 Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org Commit 3edfb7bd76bd ("gpiolib: Show correct direction from the beginning") fixed an existing issue but broke libgpiod tests by changing the default direction of dummy lines to output. We don't break user-space so make gpio-mockup behave as before. Signed-off-by: Bartosz Golaszewski --- drivers/gpio/gpio-mockup.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpio/gpio-mockup.c b/drivers/gpio/gpio-mockup.c index 8269cffc2967..6a50f9f59c90 100644 --- a/drivers/gpio/gpio-mockup.c +++ b/drivers/gpio/gpio-mockup.c @@ -35,8 +35,8 @@ #define gpio_mockup_err(...) pr_err(GPIO_MOCKUP_NAME ": " __VA_ARGS__) enum { - GPIO_MOCKUP_DIR_OUT = 0, - GPIO_MOCKUP_DIR_IN = 1, + GPIO_MOCKUP_DIR_IN = 0, + GPIO_MOCKUP_DIR_OUT = 1, }; /* @@ -131,7 +131,7 @@ static int gpio_mockup_get_direction(struct gpio_chip *gc, unsigned int offset) { struct gpio_mockup_chip *chip = gpiochip_get_data(gc); - return chip->lines[offset].dir; + return !chip->lines[offset].dir; } static int gpio_mockup_to_irq(struct gpio_chip *gc, unsigned int offset) From patchwork Thu Nov 8 16:52:54 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Bartosz Golaszewski X-Patchwork-Id: 995021 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=linux-gpio-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=bgdev-pl.20150623.gappssmtp.com header.i=@bgdev-pl.20150623.gappssmtp.com header.b="xkYPOaJ4"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 42rTrC1sTsz9sBZ for ; Fri, 9 Nov 2018 03:53:31 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727078AbeKIC3v (ORCPT ); Thu, 8 Nov 2018 21:29:51 -0500 Received: from mail-wr1-f68.google.com ([209.85.221.68]:38009 "EHLO mail-wr1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726980AbeKIC3d (ORCPT ); Thu, 8 Nov 2018 21:29:33 -0500 Received: by mail-wr1-f68.google.com with SMTP id d10-v6so22007072wrs.5 for ; Thu, 08 Nov 2018 08:53:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=rPCJyVZmDOYNeLsc4tgwn2k4YrO+TQOoxPdkXRVHMuI=; b=xkYPOaJ4V8RNsgpz0tDtm4p+U0NWEW9+nWXirBy1Bhu2gPeDveN+LbP2NDngyt+ond m0nOnZDw/dfv6N+Xd8YKWgxvFphMBQmAcfXFDx+3amii5D82a9z9lbyXaNok4cUQMxQY wCMisU7MGSTAXECi05MKUUPzvUACJ0Htqd7JT0FndBKmFrZgiz0+OI69cARp5OLHs0+3 BOTmJdJPWe+3jzv8W1+iko6JZyArfJ6GqPngsV1KJSaMTHif3kJRn/k7+goDReqYD2e5 G17IjOcybrcN/TQrrgEbQYQyyA0C9ihMj89Paqb6yeWC2AvKGKO8z1c8b4WMMzU4lrkc YFQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=rPCJyVZmDOYNeLsc4tgwn2k4YrO+TQOoxPdkXRVHMuI=; b=XtfSLB5LL2uwA3B3UGubF+PaBUCMZz2Bs6V0Sz35oG8x8Xl58phAM95vxEXAbuvRfg 4x7m/K8e+BrRB7sqkQurzr4/86t0F7rg38udm2XBq7PrKJssGyg0xYZcHLtGwn4xkvPO a8XYAKpJM+3dP/l5MQweIgKljWNd+0rnjlTxccur/O4wd8EqqABDHb2MyCbUA653UtK7 d2fmAfB8auZ372St9uQXZ41WB4equeGL4gsPTpYnmrjS8HbPzk3GqkFQBhO8LUVqQyCT A7sJxkhwmjkMZ6lDmAielt073WO7aqvYOQri0w4hj+08CaZchsOBtdz/ZwekrxC4LML6 00Vg== X-Gm-Message-State: AGRZ1gIFLIlx3giptYDqiAa+k0Q6QgRd+pEBZ4sOUO0/mRLtiu5ALD9h kgsYNUn8fQzIW+tlHPjs/DXrwQ== X-Google-Smtp-Source: AJdET5cBtnZnbUITLW6R327dO/QhDlm05sTKDZlugw4OeXA+SnFseJ5bepo1tRkUHk8R5Z4IajcnsA== X-Received: by 2002:adf:b716:: with SMTP id l22-v6mr5224333wre.157.1541695990620; Thu, 08 Nov 2018 08:53:10 -0800 (PST) Received: from debian-brgl.lan ([2a01:cb1d:af:5b00:6d6c:8493:1ab5:dad7]) by smtp.gmail.com with ESMTPSA id h5-v6sm7815987wrs.51.2018.11.08.08.53.09 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 08 Nov 2018 08:53:10 -0800 (PST) From: Bartosz Golaszewski To: Bamvor Jian Zhang , Linus Walleij , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Bartosz Golaszewski Subject: [PATCH 2/3] gpio: mockup: add locking Date: Thu, 8 Nov 2018 17:52:54 +0100 Message-Id: <20181108165255.9940-3-brgl@bgdev.pl> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20181108165255.9940-1-brgl@bgdev.pl> References: <20181108165255.9940-1-brgl@bgdev.pl> MIME-Version: 1.0 Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org While no user reported any race condition problems with gpio-mockup, let's be on the safe side and use a mutex when performing any changes on the dummy chip structures. Suggested-by: Uwe Kleine-König Signed-off-by: Bartosz Golaszewski Acked-by: Uwe Kleine-König --- drivers/gpio/gpio-mockup.c | 50 ++++++++++++++++++++++++++++++++------ 1 file changed, 43 insertions(+), 7 deletions(-) diff --git a/drivers/gpio/gpio-mockup.c b/drivers/gpio/gpio-mockup.c index 6a50f9f59c90..3cd92912c414 100644 --- a/drivers/gpio/gpio-mockup.c +++ b/drivers/gpio/gpio-mockup.c @@ -54,6 +54,7 @@ struct gpio_mockup_chip { struct gpio_mockup_line_status *lines; struct irq_sim irqsim; struct dentry *dbg_dir; + struct mutex lock; }; struct gpio_mockup_dbgfs_private { @@ -82,29 +83,53 @@ static int gpio_mockup_range_ngpio(unsigned int index) return gpio_mockup_ranges[index * 2 + 1]; } -static int gpio_mockup_get(struct gpio_chip *gc, unsigned int offset) +static int __gpio_mockup_get(struct gpio_chip *gc, unsigned int offset) { struct gpio_mockup_chip *chip = gpiochip_get_data(gc); return chip->lines[offset].value; } -static void gpio_mockup_set(struct gpio_chip *gc, - unsigned int offset, int value) +static int gpio_mockup_get(struct gpio_chip *gc, unsigned int offset) +{ + struct gpio_mockup_chip *chip = gpiochip_get_data(gc); + int val; + + mutex_lock(&chip->lock); + val = __gpio_mockup_get(gc, offset); + mutex_unlock(&chip->lock); + + return val; +} + +static void __gpio_mockup_set(struct gpio_chip *gc, + unsigned int offset, int value) { struct gpio_mockup_chip *chip = gpiochip_get_data(gc); chip->lines[offset].value = !!value; } +static void gpio_mockup_set(struct gpio_chip *gc, + unsigned int offset, int value) +{ + struct gpio_mockup_chip *chip = gpiochip_get_data(gc); + + mutex_lock(&chip->lock); + __gpio_mockup_set(gc, offset, value); + mutex_unlock(&chip->lock); +} + static void gpio_mockup_set_multiple(struct gpio_chip *gc, unsigned long *mask, unsigned long *bits) { + struct gpio_mockup_chip *chip = gpiochip_get_data(gc); unsigned int bit; + mutex_lock(&chip->lock); for_each_set_bit(bit, mask, gc->ngpio) - gpio_mockup_set(gc, bit, test_bit(bit, bits)); - + __gpio_mockup_set(gc, bit, test_bit(bit, bits)); + mutex_unlock(&chip->lock); } static int gpio_mockup_dirout(struct gpio_chip *gc, @@ -112,8 +137,10 @@ static int gpio_mockup_dirout(struct gpio_chip *gc, { struct gpio_mockup_chip *chip = gpiochip_get_data(gc); - gpio_mockup_set(gc, offset, value); + mutex_lock(&chip->lock); + __gpio_mockup_set(gc, offset, value); chip->lines[offset].dir = GPIO_MOCKUP_DIR_OUT; + mutex_unlock(&chip->lock); return 0; } @@ -122,7 +149,9 @@ static int gpio_mockup_dirin(struct gpio_chip *gc, unsigned int offset) { struct gpio_mockup_chip *chip = gpiochip_get_data(gc); + mutex_lock(&chip->lock); chip->lines[offset].dir = GPIO_MOCKUP_DIR_IN; + mutex_unlock(&chip->lock); return 0; } @@ -130,8 +159,13 @@ static int gpio_mockup_dirin(struct gpio_chip *gc, unsigned int offset) static int gpio_mockup_get_direction(struct gpio_chip *gc, unsigned int offset) { struct gpio_mockup_chip *chip = gpiochip_get_data(gc); + int direction; - return !chip->lines[offset].dir; + mutex_lock(&chip->lock); + direction = !chip->lines[offset].dir; + mutex_unlock(&chip->lock); + + return direction; } static int gpio_mockup_to_irq(struct gpio_chip *gc, unsigned int offset) @@ -283,6 +317,8 @@ static int gpio_mockup_probe(struct platform_device *pdev) return -ENOMEM; } + mutex_init(&chip->lock); + gc = &chip->gc; gc->base = base; gc->ngpio = ngpio; From patchwork Thu Nov 8 16:52:55 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Bartosz Golaszewski X-Patchwork-Id: 995020 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=linux-gpio-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=bgdev-pl.20150623.gappssmtp.com header.i=@bgdev-pl.20150623.gappssmtp.com header.b="JHo+tAVD"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 42rTr12fh1z9sBh for ; Fri, 9 Nov 2018 03:53:21 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727440AbeKIC3f (ORCPT ); Thu, 8 Nov 2018 21:29:35 -0500 Received: from mail-wr1-f66.google.com ([209.85.221.66]:44100 "EHLO mail-wr1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727369AbeKIC3e (ORCPT ); Thu, 8 Nov 2018 21:29:34 -0500 Received: by mail-wr1-f66.google.com with SMTP id j17-v6so16878511wrq.11 for ; Thu, 08 Nov 2018 08:53:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=RTop1/ZKpMeTxQR7kMHNViu+sfNC80EGmmamdx7DZuY=; b=JHo+tAVD4pfManEDrMkNfiShzpIH5mVzw4R69EvVR6l0eMG8pV3VlfdRiNJd31vmo+ CER3ae4qjtIaRBO1PmPjisZ2E60gQrD8hdu0EBdnJm+k+tDiZeVLhpDMofVg0qFfL6r6 5Y+URFdiLC7cg5ArKmGZFs2SHoo+L8BAax8xWOCJACH+EnhqvnJdxL4QAPwDfaOqzbjm X+XcBPbJDbmZ6SI5byASnWR2OATucBdRN+4WaAnhhEdd1uAWk/+jrI7wJkXF12kSv4pe k6oMpM2lwUMRk+tp9uhnIfuWHiFnCG2Ei/RDYB1PVkfvgEwAg/3rAoRre3QZnztTX4AC DUqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=RTop1/ZKpMeTxQR7kMHNViu+sfNC80EGmmamdx7DZuY=; b=JOwMtDT2T5LnG+Us5WtVIZeSjmfKAk7egUDqIE5m2fRD0h597iQSZhTaMBB11ULP1L gWauegbhcZdw+ZYLgsDSwPv53F9OEUtrlUNOFWkMh8QQFqmCcHe7C1HClmOcZ5kQq9fQ iA2oPtzDUNGNC8Mn+sXoqpqfx687mzjhwkOW/5bWBzeAYYO97NlkA+Fcl8ZQaG2a0kaB Ih9AZUGM8QtShxDNztriG0G1fxZ0+2VpfFUF4AGpOgrajtiFMY7n99hymI1h5od72S5/ McW45W45Z9UMb0WiqNDGXj6aF5Jn81yaE9Z5F6fSbnTJWqNwECQabRF9BwNE1vDdSijG fdnQ== X-Gm-Message-State: AGRZ1gIqe5Al8BaNKu/1YBMidqA8WVjoThiHJ9myWwx1LLxfAaE0k8j7 CYTz0XfidjwHYKVcicme7eOG6g== X-Google-Smtp-Source: AJdET5dGnFkZmPm5esPCxIyjBPPuX5HDB6qhW1s3k5075VfTeijcBxr56tE7NkQXQzel/XpmquXkZQ== X-Received: by 2002:adf:c189:: with SMTP id x9-v6mr4773949wre.233.1541695992007; Thu, 08 Nov 2018 08:53:12 -0800 (PST) Received: from debian-brgl.lan ([2a01:cb1d:af:5b00:6d6c:8493:1ab5:dad7]) by smtp.gmail.com with ESMTPSA id h5-v6sm7815987wrs.51.2018.11.08.08.53.10 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 08 Nov 2018 08:53:11 -0800 (PST) From: Bartosz Golaszewski To: Bamvor Jian Zhang , Linus Walleij , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Bartosz Golaszewski Subject: [PATCH 3/3] gpio: mockup: implement get_multiple() Date: Thu, 8 Nov 2018 17:52:55 +0100 Message-Id: <20181108165255.9940-4-brgl@bgdev.pl> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20181108165255.9940-1-brgl@bgdev.pl> References: <20181108165255.9940-1-brgl@bgdev.pl> MIME-Version: 1.0 Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org We already support set_multiple(). Implement get_multiple() as well. Signed-off-by: Bartosz Golaszewski Acked-by: Uwe Kleine-König --- drivers/gpio/gpio-mockup.c | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) diff --git a/drivers/gpio/gpio-mockup.c b/drivers/gpio/gpio-mockup.c index 3cd92912c414..a4c054cf9c5f 100644 --- a/drivers/gpio/gpio-mockup.c +++ b/drivers/gpio/gpio-mockup.c @@ -102,6 +102,22 @@ static int gpio_mockup_get(struct gpio_chip *gc, unsigned int offset) return val; } +static int gpio_mockup_get_multiple(struct gpio_chip *gc, + unsigned long *mask, unsigned long *bits) +{ + struct gpio_mockup_chip *chip = gpiochip_get_data(gc); + unsigned int bit, val; + + mutex_lock(&chip->lock); + for_each_set_bit(bit, mask, gc->ngpio) { + val = __gpio_mockup_get(gc, bit); + __assign_bit(bit, bits, val); + } + mutex_unlock(&chip->lock); + + return 0; +} + static void __gpio_mockup_set(struct gpio_chip *gc, unsigned int offset, int value) { @@ -327,6 +343,7 @@ static int gpio_mockup_probe(struct platform_device *pdev) gc->parent = dev; gc->get = gpio_mockup_get; gc->set = gpio_mockup_set; + gc->get_multiple = gpio_mockup_get_multiple; gc->set_multiple = gpio_mockup_set_multiple; gc->direction_output = gpio_mockup_dirout; gc->direction_input = gpio_mockup_dirin;