From patchwork Thu Nov 1 01:52:28 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marcel Ziswiler X-Patchwork-Id: 991793 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=linux-tegra-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=ziswiler.com Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 42lpBh1nwfz9sDG for ; Thu, 1 Nov 2018 12:53:16 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726095AbeKAKxm (ORCPT ); Thu, 1 Nov 2018 06:53:42 -0400 Received: from mout.perfora.net ([74.208.4.194]:55997 "EHLO mout.perfora.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725955AbeKAKxm (ORCPT ); Thu, 1 Nov 2018 06:53:42 -0400 Received: from localhost.localdomain.ziswiler.net ([188.155.129.42]) by mrelay.perfora.net (mreueus001 [74.208.5.2]) with ESMTPA (Nemesis) id 0MTQGn-1gA1WM0UC7-00SPSj; Thu, 01 Nov 2018 02:52:45 +0100 Received: from localhost.localdomain.ziswiler.net ([188.155.129.42]) by mrelay.perfora.net (mreueus001 [74.208.5.2]) with ESMTPA (Nemesis) id 0MTQGn-1gA1WM0UC7-00SPSj; Thu, 01 Nov 2018 02:52:45 +0100 From: Marcel Ziswiler To: linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Marcel Ziswiler , Thierry Reding , Stephen Boyd , Prashant Gaikwad , Peter De Schrijver , Jonathan Hunter , Michael Turquette , linux-clk@vger.kernel.org Subject: [PATCH v1 1/3] clk: tegra: get rid of duplicate defines Date: Thu, 1 Nov 2018 02:52:28 +0100 Message-Id: <20181101015230.27310-2-marcel@ziswiler.com> X-Mailer: git-send-email 2.14.5 In-Reply-To: <20181101015230.27310-1-marcel@ziswiler.com> References: <20181101015230.27310-1-marcel@ziswiler.com> X-Provags-ID: V03:K1:3wnizd8A0OqzJ27J54EHPOgL0BJzUY4k5AjZoTTCvBFgV4i91X+ YHknjiKozGqI5gjaE5K+X2CCwEMOyMQZ28aTQdtKw8gDj2Ox1NXVPw+tg3loiVBdsUXLSon BNUJ3AVbCLxWG2etcGpUiuB/ncv4jyenC5YvBlZKm3KopARy5p7zYzICJs0oWOZlntzwf9G tM4EA+JUxbjyt7+dqghMQ== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1; V01:K0:EMQYdtALUoQ=:H3s/EthkZrwCIdJ926409g zXae8gsgDlStiRK+9illoDEKv86cx6g6p53bQ7tyOs/r+pvA3k+y7ikyUSAUIwWd2axMJLA6m g+I9yDINLh/pC+xpziMmFi4/zuZ2vpPKYZiuQZnzulyN0Vm6fREtGdD9SvP35wTZIQ7C2f/xe YwNYHmEzPFazVPLk8d0yhYPbblY1Ib0aRvyHQxDH4Jd/EpQNVUismIscavVADbDhxNaeNoOR2 MGb74iYkbcIRJiJ9+ijx8mGgnMZMRI7y9hVrOlBO2q+d7N5nBFgHlSqYJjlwqhi/+EogNpBPL AkDhhd6qvXmEmIZ3r2VonSrk14gjn0E3tMeCc9D6GR4ZX6tA6/Zl5SiwG4++10JEhHGWxdc3w OHCL/aYwT9dmkV8hYpNS/8Wx34K48mJGyNossIMzXtDps/QVWTsoZtmrlsHfBGEsWbaoV9sy8 zFXyskgdv/tdRZJM7FTbEcr8UOsdF+wjeWSDPrqTLxHtyS+dXtzwc1EIWUUp7M/Ip1DpyIeWZ kLLgCfnsCXdzXMbJOGDsSGRazwi9cmnsvmrF9aMP+nhH5Rm5hAweBZPEs2Uiw9oJpf47IAG5X bQStMC9igSJUZXvtQf2mgQVFXlOSmpBRf4Qq1oFK8U3u4WcCVpc2k75oliTXbPrRoEpl4CYGD S9CiRPnuIvbF/dSPAnfwcqmIIQm9YCKbISibD0tt47mgHg8BIZRIZFjy9bE/Pf9sqPv4= Sender: linux-tegra-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-tegra@vger.kernel.org From: Marcel Ziswiler Get rid of 3 duplicate defines. Signed-off-by: Marcel Ziswiler Acked-by: Thierry Reding --- drivers/clk/tegra/clk-tegra-periph.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/clk/tegra/clk-tegra-periph.c b/drivers/clk/tegra/clk-tegra-periph.c index 38c4eb28c8bf..cc5275ec2c01 100644 --- a/drivers/clk/tegra/clk-tegra-periph.c +++ b/drivers/clk/tegra/clk-tegra-periph.c @@ -79,7 +79,6 @@ #define CLK_SOURCE_3D 0x158 #define CLK_SOURCE_2D 0x15c #define CLK_SOURCE_MPE 0x170 -#define CLK_SOURCE_UARTE 0x1c4 #define CLK_SOURCE_VI_SENSOR 0x1a8 #define CLK_SOURCE_VI 0x148 #define CLK_SOURCE_EPP 0x16c @@ -117,8 +116,6 @@ #define CLK_SOURCE_ISP 0x144 #define CLK_SOURCE_SOR0 0x414 #define CLK_SOURCE_DPAUX 0x418 -#define CLK_SOURCE_SATA_OOB 0x420 -#define CLK_SOURCE_SATA 0x424 #define CLK_SOURCE_ENTROPY 0x628 #define CLK_SOURCE_VI_SENSOR2 0x658 #define CLK_SOURCE_HDMI_AUDIO 0x668 From patchwork Thu Nov 1 01:52:29 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marcel Ziswiler X-Patchwork-Id: 991791 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=linux-tegra-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=ziswiler.com Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 42lpBX1r8Tz9sDQ for ; Thu, 1 Nov 2018 12:53:08 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727552AbeKAKxo (ORCPT ); Thu, 1 Nov 2018 06:53:44 -0400 Received: from mout.perfora.net ([74.208.4.197]:38407 "EHLO mout.perfora.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725970AbeKAKxn (ORCPT ); Thu, 1 Nov 2018 06:53:43 -0400 Received: from localhost.localdomain.ziswiler.net ([188.155.129.42]) by mrelay.perfora.net (mreueus001 [74.208.5.2]) with ESMTPA (Nemesis) id 0M0BFi-1fQC3P243I-00uMgE; Thu, 01 Nov 2018 02:52:48 +0100 Received: from localhost.localdomain.ziswiler.net ([188.155.129.42]) by mrelay.perfora.net (mreueus001 [74.208.5.2]) with ESMTPA (Nemesis) id 0M0BFi-1fQC3P243I-00uMgE; Thu, 01 Nov 2018 02:52:48 +0100 From: Marcel Ziswiler To: linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Marcel Ziswiler , Thierry Reding , Stephen Boyd , Prashant Gaikwad , Peter De Schrijver , Jonathan Hunter , Michael Turquette , linux-clk@vger.kernel.org Subject: [PATCH v1 2/3] clk: tegra: ignore unused vfir clock shared with uartb Date: Thu, 1 Nov 2018 02:52:29 +0100 Message-Id: <20181101015230.27310-3-marcel@ziswiler.com> X-Mailer: git-send-email 2.14.5 In-Reply-To: <20181101015230.27310-1-marcel@ziswiler.com> References: <20181101015230.27310-1-marcel@ziswiler.com> X-Provags-ID: V03:K1:e1CqOHOEs4M1SEgX2DGOkF4v5MBlnjgBGN6pOrvzsFMZau68mgk I3MOAy0uxuM/gvReS6pEuk3A8GgCGWbQbLjBBmn6xhcRRmYVhiSNzxuDf4Z1JUzNqbUl0Lu R8UnMNUPtTBGOgmvzC8KIApvwsner9n2bUvD2AF2WFldL5SXH95Qftj6UIotxBwDhwNjNyO AJb3qusc7vmymucHWpddA== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1; V01:K0:Mqa6rCbUyBA=:bDJjKru8mG+HIh4wwtJ0nS 4ulkAJWNMo5Tb8NJ2kwuSUTOXD/Vyj/i1XDpjK+lykndj9wg7KVLGqj9w9U1wMXR2a5nwkbEj W0aIhksC46hSi8/eBZOzH3W4CvF8r5EZ18qDNZYadWlOPc4XkVNYZxHTCDqZrAyXnqKzyHg79 4eMt500TOsWSwhPjk7iej77lh73Y5ddXsk4PO+fR+kQ4QhkN6DBAn3bMPttjBzUm6z4VKONbq oz2XYu2noMNcK89zP8kifFboY5+y5EZVOMG0gcTSwcXz99fujtiqCDdXzcuGKaE5Q+o9EQGwU BpnVEgKzWbXvMFF87FMRLVToNCF9cmhP+6K9NVmUSDiMph8neEXowGYZFAwiWp//34/BV8LGw h3vl0Rgqf5Hslt/NycWn1SHxajRBoRBafzMg1PLdqam4sXFZajSUz6kwBuggDVHGUBbHTsIT0 i8ckuWQIb079NmG6y6mbkZMJy2NtHTnLO/y5dl+PD+u4QW3XY9LJ6FR6ijCX0tFloPbwJXyFk dfcXaDWY2/m7Jg3YSw3Zizg9PMqcTFtrUb1jH4eIIxKpIkq7jCFKASPqYKOBreeStJit6Dtpp 3+6DAyjZELspdhtEljK+wYDDrh3Mpf6k2G6JjSPMTYbVOYDn14TQAi85mocHqcDYRIiKV1tzI pF2YMyNOmlBimziafvdyQeSwt0tPfyD2aJpTG/eQ8MCtR22rlUddDCC2vEdYcEOZE6Ng= Sender: linux-tegra-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-tegra@vger.kernel.org From: Marcel Ziswiler As UARTB and VFIR share their clock enable bit it is rather unwise for the kernel to turn off the VFIR one should that be unused (and potentially vice versa but so far there anyway is no VFIR driver). Without this patch trying to use UARTB with the regular 8250 driver will freeze as soon as ttyS1 is accessed after boot. Luckily, using the high-speed Tegra serial driver won't exhibit the issue as clocks are dynamically enabled/disabled on every access. This has been reproduced both on Apalis T30 as well as Apalis TK1 but may be an issue on all Tegra UARTB's which share the clock enable with VFIR. Reported-by: Kory Swain Signed-off-by: Marcel Ziswiler --- drivers/clk/tegra/clk-tegra-periph.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/clk/tegra/clk-tegra-periph.c b/drivers/clk/tegra/clk-tegra-periph.c index cc5275ec2c01..116c74340fb7 100644 --- a/drivers/clk/tegra/clk-tegra-periph.c +++ b/drivers/clk/tegra/clk-tegra-periph.c @@ -668,7 +668,7 @@ static struct tegra_periph_init_data periph_clks[] = { MUX("hda", mux_pllp_pllc_clkm, CLK_SOURCE_HDA, 125, TEGRA_PERIPH_ON_APB, tegra_clk_hda_8), MUX("hda2codec_2x", mux_pllp_pllc_pllm_clkm, CLK_SOURCE_HDA2CODEC_2X, 111, TEGRA_PERIPH_ON_APB, tegra_clk_hda2codec_2x), MUX8("hda2codec_2x", mux_pllp_pllc_plla_clkm, CLK_SOURCE_HDA2CODEC_2X, 111, TEGRA_PERIPH_ON_APB, tegra_clk_hda2codec_2x_8), - MUX("vfir", mux_pllp_pllc_pllm_clkm, CLK_SOURCE_VFIR, 7, TEGRA_PERIPH_ON_APB, tegra_clk_vfir), + MUX_FLAGS("vfir", mux_pllp_pllc_pllm_clkm, CLK_SOURCE_VFIR, 7, TEGRA_PERIPH_ON_APB, tegra_clk_vfir, CLK_IGNORE_UNUSED), MUX("sdmmc1", mux_pllp_pllc_pllm_clkm, CLK_SOURCE_SDMMC1, 14, TEGRA_PERIPH_ON_APB, tegra_clk_sdmmc1), MUX("sdmmc2", mux_pllp_pllc_pllm_clkm, CLK_SOURCE_SDMMC2, 9, TEGRA_PERIPH_ON_APB, tegra_clk_sdmmc2), MUX("sdmmc3", mux_pllp_pllc_pllm_clkm, CLK_SOURCE_SDMMC3, 69, TEGRA_PERIPH_ON_APB, tegra_clk_sdmmc3), From patchwork Thu Nov 1 01:52:30 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marcel Ziswiler X-Patchwork-Id: 991790 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=linux-tegra-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=ziswiler.com Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 42lpBW27F4z9sDG for ; Thu, 1 Nov 2018 12:53:07 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727627AbeKAKxt (ORCPT ); Thu, 1 Nov 2018 06:53:49 -0400 Received: from mout.perfora.net ([74.208.4.194]:35161 "EHLO mout.perfora.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727608AbeKAKxs (ORCPT ); Thu, 1 Nov 2018 06:53:48 -0400 Received: from localhost.localdomain.ziswiler.net ([188.155.129.42]) by mrelay.perfora.net (mreueus001 [74.208.5.2]) with ESMTPA (Nemesis) id 0LqBsM-1feYbp2u36-00dm8M; Thu, 01 Nov 2018 02:52:50 +0100 Received: from localhost.localdomain.ziswiler.net ([188.155.129.42]) by mrelay.perfora.net (mreueus001 [74.208.5.2]) with ESMTPA (Nemesis) id 0LqBsM-1feYbp2u36-00dm8M; Thu, 01 Nov 2018 02:52:50 +0100 From: Marcel Ziswiler To: linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Marcel Ziswiler , Thierry Reding , Jiri Slaby , Jonathan Hunter , linux-serial@vger.kernel.org, Laxman Dewangan , Greg Kroah-Hartman Subject: [PATCH v1 3/3] serial: tegra: fix some spelling mistakes Date: Thu, 1 Nov 2018 02:52:30 +0100 Message-Id: <20181101015230.27310-4-marcel@ziswiler.com> X-Mailer: git-send-email 2.14.5 In-Reply-To: <20181101015230.27310-1-marcel@ziswiler.com> References: <20181101015230.27310-1-marcel@ziswiler.com> X-Provags-ID: V03:K1:hKj1LNPrmR2PtZRtqfLLnesEuw2sTQ5Ibd0wz0egqOv3aUEFi9n 6oRTQYdzVnVU1ZZpui+4woe03Q0wb6i2sPiMi50IruvBzbhEY2Rbmt3I5flXPPXy6NOmV7C q7jNCRniCsSz+9Hpfzl+0TSPmDrhqyF1GFdU/Q14GqUgui6bXJClT0S4w6ZheRFdHcgDsZn AtvJ4J7fMA9+coWPTVOcA== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1; V01:K0:hxY/ToO7yss=:0jjnHLy0PaqauCJZJJ1Vh/ /Op5QocBUb2HTv3i3PP1J3Xk0JoVhDQyawuf5xwgjYsVmd60qI8De+KbMjOSTYqBhRycj9Xsg G3YXq5TR4Rq2SoSkqO0nLJyeb/UgzvIWf53j9/WVzIRkFWj4iSoUNRKMrhyt8YuW1N8XjqYVX KmFEPjjW9MPXpQh9qJHYakO+iW3l269Htcky2fOCtKa1W//uJg3g3PMj44pEHBf7sNidk9h+4 ZWZVXTPtHkBHMTABPnWGJ71TVGwvbvHln+TfMuBP5Ce1ch6ERnwcDsWRkIY3hFxtyflITQncV Wx2145Aw+W48Om3yQc0PIwzma126n2NS0reWlJ61C26sTRHiiCYnCfzKH1sHfILig6IKOKMNr 0qvWhWcIVbyZJ8qe40mHXxt2bjt7t6JzusqIcBXMVrrXZmzO0T66kyXzUd+87Y79B6FLwJSRN ov0FjTRFfkFF41xPyfkYPoPELGZEgGHkeFPuXj7ep57xe0buUgh6WcukQH+fuyGD0gcIriC2i xUGlW0lBbjaa+NiU2pu1ECaPB8COakbXuZV1qSaf3y2+Fai09QuvPtnyrsA+nbM+BgtOTVqYf CQHUG9hpKro3d2JluZ5fD1c+LUPT65yhyjlsYGktaDh1FlFMcj1Zc6rz3aHUEmonc9j6TTlq5 bKK7R6v3HtfejPGEcVUFEsGd9Y4M2yQs14ZX1aUMZKVYO23HYB344rzwT6z+MnGteFdM= Sender: linux-tegra-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-tegra@vger.kernel.org From: Marcel Ziswiler Fix a few spelling mistakes I stumbled upon while debugging a customers UART issues. Signed-off-by: Marcel Ziswiler Acked-by: Thierry Reding --- drivers/tty/serial/serial-tegra.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/tty/serial/serial-tegra.c b/drivers/tty/serial/serial-tegra.c index af2a29cfbbe9..d5269aaaf9b2 100644 --- a/drivers/tty/serial/serial-tegra.c +++ b/drivers/tty/serial/serial-tegra.c @@ -746,7 +746,7 @@ static void tegra_uart_stop_rx(struct uart_port *u) if (!tup->rx_in_progress) return; - tegra_uart_wait_sym_time(tup, 1); /* wait a character interval */ + tegra_uart_wait_sym_time(tup, 1); /* wait one character interval */ ier = tup->ier_shadow; ier &= ~(UART_IER_RDI | UART_IER_RLSI | UART_IER_RTOIE | @@ -887,7 +887,7 @@ static int tegra_uart_hw_init(struct tegra_uart_port *tup) * * EORD is different interrupt than RX_TIMEOUT - RX_TIMEOUT occurs when * the DATA is sitting in the FIFO and couldn't be transferred to the - * DMA as the DMA size alignment(4 bytes) is not met. EORD will be + * DMA as the DMA size alignment (4 bytes) is not met. EORD will be * triggered when there is a pause of the incomming data stream for 4 * characters long. * @@ -1079,7 +1079,7 @@ static void tegra_uart_set_termios(struct uart_port *u, if (tup->rts_active) set_rts(tup, false); - /* Clear all interrupts as configuration is going to be change */ + /* Clear all interrupts as configuration is going to be changed */ tegra_uart_write(tup, tup->ier_shadow | UART_IER_RDI, UART_IER); tegra_uart_read(tup, UART_IER); tegra_uart_write(tup, 0, UART_IER); @@ -1165,10 +1165,10 @@ static void tegra_uart_set_termios(struct uart_port *u, /* update the port timeout based on new settings */ uart_update_timeout(u, termios->c_cflag, baud); - /* Make sure all write has completed */ + /* Make sure all writes have completed */ tegra_uart_read(tup, UART_IER); - /* Reenable interrupt */ + /* Re-enable interrupt */ tegra_uart_write(tup, tup->ier_shadow, UART_IER); tegra_uart_read(tup, UART_IER);