From patchwork Tue Oct 10 06:42:14 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jeff Law X-Patchwork-Id: 823722 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=gcc.gnu.org (client-ip=209.132.180.131; helo=sourceware.org; envelope-from=gcc-patches-return-463844-incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.b="sboIoCKf"; dkim-atps=neutral Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3yB6x26CHrz9sPr for ; Tue, 10 Oct 2017 17:42:29 +1100 (AEDT) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:to :from:subject:message-id:date:mime-version:content-type; q=dns; s=default; b=I003Syt6XHmMOMgm6L9IfQOIUbBFozhSJzwapYvhATyk52dylz npmqKMbNHrGU6AAWHUzSxM/xn1uVK7Y3D7pHE6SJVtOvJ1M9kMCq1YKxjXJt/Fxm U+8V+mbb2nQw3aaq7H9ZJ1zcH8YQMaOT5Akw83moBNO5KwImBxHO93Zmw= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:to :from:subject:message-id:date:mime-version:content-type; s= default; bh=702Hns3k7Lk1eYCncZRTV1z7Bj0=; b=sboIoCKfGUW+VjwR1eAq GFbCsgXUbxVbGHcskVSoC3Zi+gdjdwClhXdbdOorJm7c/GeJtD1an+p38GhCpYFT ZGT7vh1g6bBdWsrSmjXQB/KjemS6E8xPxZJjzeDV+mj1t2iYOAi+fiPCNkCDFj4c ta3/mCdtGHMKNJ/To1w597E= Received: (qmail 17830 invoked by alias); 10 Oct 2017 06:42:20 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 17810 invoked by uid 89); 10 Oct 2017 06:42:18 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RP_MATCHES_RCVD, SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:1433 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 10 Oct 2017 06:42:17 +0000 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 8BA9981DE1 for ; Tue, 10 Oct 2017 06:42:16 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 8BA9981DE1 Authentication-Results: ext-mx01.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx01.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=law@redhat.com Received: from localhost.localdomain (ovpn-112-5.rdu2.redhat.com [10.10.112.5]) by smtp.corp.redhat.com (Postfix) with ESMTP id 1DD256155C for ; Tue, 10 Oct 2017 06:42:15 +0000 (UTC) To: gcc-patches From: Jeff Law Subject: [committed] Fix return type on stack clash protection hook Message-ID: Date: Tue, 10 Oct 2017 00:42:14 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 X-IsSubscribed: yes Pointed out in IRC. The intent as well as the docs and prototype had the return type as a bool, but the default implementation used HOST_WIDE_INT. Opps. This fixes the default implementation to match the intent, docs & prototype. Bootstrapped and regression tested. Installing on the trunk as obvious. Jeff commit fdc63db3b0343eaa3cdde6d5c143fbd80a851da6 Author: Jeff Law Date: Mon Oct 9 17:29:58 2017 -0400 * targhooks.c (default_stack_clash_protection_final_dynamic_probe): Fix return type to match prototype and documentation. diff --git a/gcc/ChangeLog b/gcc/ChangeLog index 202dd89b957..30bbeb5ad82 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,3 +1,8 @@ +2017-10-09 Jeff Law + + * targhooks.c (default_stack_clash_protection_final_dynamic_probe): Fix + return type to match prototype and documentation. + 2010-10-09 Segher Boessenkool * config/rs6000/rs6000.c (processor_costs): Move to ... diff --git a/gcc/targhooks.c b/gcc/targhooks.c index d56f53d35d8..8dbf8a14970 100644 --- a/gcc/targhooks.c +++ b/gcc/targhooks.c @@ -2235,7 +2235,7 @@ default_excess_precision (enum excess_precision_type ATTRIBUTE_UNUSED) return FLT_EVAL_METHOD_PROMOTE_TO_FLOAT; } -HOST_WIDE_INT +bool default_stack_clash_protection_final_dynamic_probe (rtx residual ATTRIBUTE_UNUSED) { return 0;