From patchwork Thu Oct 25 07:00:27 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stewart Smith X-Patchwork-Id: 988922 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 42gdLj0TQbz9sBk for ; Thu, 25 Oct 2018 18:00:45 +1100 (AEDT) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=linux.ibm.com Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 42gdLh64c0zDrWQ for ; Thu, 25 Oct 2018 18:00:44 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=linux.ibm.com X-Original-To: skiboot@lists.ozlabs.org Delivered-To: skiboot@lists.ozlabs.org Authentication-Results: lists.ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=linux.ibm.com (client-ip=148.163.156.1; helo=mx0a-001b2d01.pphosted.com; envelope-from=stewart@linux.ibm.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=linux.ibm.com Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 42gdLd3qByzDrTP for ; Thu, 25 Oct 2018 18:00:40 +1100 (AEDT) Received: from pps.filterd (m0098394.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w9P6xZXp020706 for ; Thu, 25 Oct 2018 03:00:37 -0400 Received: from e31.co.us.ibm.com (e31.co.us.ibm.com [32.97.110.149]) by mx0a-001b2d01.pphosted.com with ESMTP id 2nb8de9v2v-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 25 Oct 2018 03:00:36 -0400 Received: from localhost by e31.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 25 Oct 2018 01:00:35 -0600 Received: from b03cxnp08025.gho.boulder.ibm.com (9.17.130.17) by e31.co.us.ibm.com (192.168.1.131) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Thu, 25 Oct 2018 01:00:34 -0600 Received: from b03ledav003.gho.boulder.ibm.com (b03ledav003.gho.boulder.ibm.com [9.17.130.234]) by b03cxnp08025.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id w9P70XH017104912 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Thu, 25 Oct 2018 07:00:33 GMT Received: from b03ledav003.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 24F5C6A05A for ; Thu, 25 Oct 2018 07:00:33 +0000 (GMT) Received: from b03ledav003.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id AA36C6A057 for ; Thu, 25 Oct 2018 07:00:32 +0000 (GMT) Received: from birb.localdomain (unknown [9.81.194.140]) by b03ledav003.gho.boulder.ibm.com (Postfix) with SMTP for ; Thu, 25 Oct 2018 07:00:32 +0000 (GMT) Received: by birb.localdomain (Postfix, from userid 1000) id 809914EC62E; Thu, 25 Oct 2018 18:00:28 +1100 (AEDT) From: Stewart Smith To: skiboot@lists.ozlabs.org Date: Thu, 25 Oct 2018 18:00:27 +1100 X-Mailer: git-send-email 2.17.2 X-TM-AS-GCONF: 00 x-cbid: 18102507-8235-0000-0000-00000E1B457E X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00009931; HX=3.00000242; KW=3.00000007; PH=3.00000004; SC=3.00000268; SDB=6.01107653; UDB=6.00573704; IPR=6.00887737; MB=3.00023900; MTD=3.00000008; XFM=3.00000015; UTC=2018-10-25 07:00:35 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 18102507-8236-0000-0000-0000431EEA65 Message-Id: <20181025070027.26823-1-stewart@linux.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:, , definitions=2018-10-25_02:, , signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=1 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1807170000 definitions=main-1810250065 Subject: [Skiboot] [PATCH] Quieten 'warnings' now that SIO is disabled X-BeenThere: skiboot@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Mailing list for skiboot development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: skiboot-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org Sender: "Skiboot" Signed-off-by: Stewart Smith --- core/pci-quirk.c | 3 ++- platforms/astbmc/common.c | 11 +++++++++-- 2 files changed, 11 insertions(+), 3 deletions(-) diff --git a/core/pci-quirk.c b/core/pci-quirk.c index 3a8583633d8a..1007e9621d71 100644 --- a/core/pci-quirk.c +++ b/core/pci-quirk.c @@ -34,7 +34,8 @@ static void quirk_astbmc_vga(struct phb *phb __unused, mcr_scu_mpll = ast_ahb_readl(MCR_SCU_MPLL); mcr_scu_strap = ast_ahb_readl(MCR_SCU_STRAP); } else { - prlog(PR_WARNING, "Assumed platform default parameters for %s\n", + /* Previously we would warn, now SIO disabled by design */ + prlog(PR_INFO, "Assumed platform default parameters for %s\n", __func__); revision = bmc_platform->hw->scu_revision_id; mcr_configuration = bmc_platform->hw->mcr_configuration; diff --git a/platforms/astbmc/common.c b/platforms/astbmc/common.c index 10aed3f72901..64eba9a41e2c 100644 --- a/platforms/astbmc/common.c +++ b/platforms/astbmc/common.c @@ -413,8 +413,15 @@ void astbmc_early_init(void) prerror("PLAT: AST IO initialisation failed!\n"); ast_setup_sio_mbox(MBOX_IO_BASE, MBOX_LPC_IRQ); - } else - prlog(PR_WARNING, "PLAT: AST SIO unavailable!\n"); + } else { + /* + * This may or may not be an error depending on if we set up + * hiomap or not. In the old days it *was* an error, but now + * with the way we configure the BMC hardware, this is actually + * the not error case. + */ + prlog(PR_INFO, "PLAT: AST SIO unavailable!\n"); + } /* Setup UART and use it as console */ uart_init();