From patchwork Sat Oct 20 02:36:00 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Steve French X-Patchwork-Id: 987113 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=linux-cifs-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="E2Vbjosf"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 42cRjq1gZKz9s7T for ; Sat, 20 Oct 2018 13:36:15 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726609AbeJTKpA (ORCPT ); Sat, 20 Oct 2018 06:45:00 -0400 Received: from mail-pg1-f194.google.com ([209.85.215.194]:39877 "EHLO mail-pg1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726502AbeJTKpA (ORCPT ); Sat, 20 Oct 2018 06:45:00 -0400 Received: by mail-pg1-f194.google.com with SMTP id r9-v6so16524689pgv.6 for ; Fri, 19 Oct 2018 19:36:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=xNeVaPgcrXsBSO5F70tA1A2V5P1mFAf/KbCme8+ceWI=; b=E2VbjosfwYFmi+HyihzP9cyyykk7FhFhChBqbLNBTTH81RWaA4GMeZt/vIzf/UElol E5kNPrHWEOI4tz01wDF+wkvyALBIdytsXKgO0XySbrtkb4thBL3QyuCjW+xeqc+/VFOb U1pHWzVLQhpNZUBjQU1jWB5uPlRppbcUx7ldfo1EtO90OUG7NpVVwCPfIUwcGstU1Vuq 3nSNjtmbldnrsUNczWrp9Bfig/N9Hj/ZAEX64kFYC5T7SGZ7SqL/7lSld/c/xYP3Ogut iRhXKU+XjJG04XRvCvw/lRneL4mD2OA2bruHNapmKIooFSGYTgcyjZyHYBGrYjL7K9bC OF2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=xNeVaPgcrXsBSO5F70tA1A2V5P1mFAf/KbCme8+ceWI=; b=GEOFfQl4LMaG+UkxTSxQKcEodfiu0yh4liw2MCcMcckIqSNuA0e9gYYixjUqrCzzDo LkhKy7zFLo21jw1pflhFy15dOXBVcnY/6AmvPdplWO2NvT5SQaebzgvrrVljmhz3FyRK 18mjtTGIH6mfgTzvl9lrgNxTeZZB5InWxRLyHHARqGB2SYderqMpbyBLS9kzvAFMPp+r 9NkhiqE7ka/1gGst65ZHeXWatdgE+T95Zg9IGlZ9k28Gqbt4mp6RNvCLEuWk0R8Pb5SZ UHOCplUa7gNUWzb7UFj63X88PPxLsE1WPqeYYkbsS9o9WpANdrFcoBbgEOnCNf5CTTgM G5vQ== X-Gm-Message-State: ABuFfoifQakngYqlBvPHhploU6j8t0PW+JWQSdjjO3AMmak+jECKccWp 42peq/7rIrX8I0ebsAqBRUAnLT+ws+TKT0pBE98RKqRN X-Google-Smtp-Source: ACcGV60dJaz+DXICpd5kVdeW4N2+jQ1hRDq484oXuwU0I0H/AXFZGgHHbmXORpignzG0nHbV0zJj8DAdk377eIPEfMU= X-Received: by 2002:a65:668a:: with SMTP id b10-v6mr9202643pgw.55.1540002972594; Fri, 19 Oct 2018 19:36:12 -0700 (PDT) MIME-Version: 1.0 From: Steve French Date: Fri, 19 Oct 2018 21:36:00 -0500 Message-ID: Subject: [PATCH] smb3 - clean up debug output displaying network interfaces To: CIFS Sender: linux-cifs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-cifs@vger.kernel.org Make the output of /proc/fs/cifs/DebugData a little easier to read by cleaning up the listing of network interfaces removing a wasted line break. Here is a comparison of the network interface information that from be viewed at the end of output from "cat /proc/fs/cifs/DebugData" Before: Server interfaces: 8 0) Speed: 10000000000 bps Capabilities: rss IPv6: fe80:0000:0000:0000:2cf5:407e:84b0:21dd 1) Speed: 1000000000 bps Capabilities: IPv6: fe80:0000:0000:0000:61cd:6147:3d0c:f484 vs. after: Server interfaces: 11 0) Speed: 10000000000 bps Capabilities: rss IPv6: fe80:0000:0000:0000:2cf5:407e:84b0:21dd 1) Speed: 2000000000 bps Capabilities: IPv6: fe80:0000:0000:0000:3d76:2d05:dcf8:ed10 Signed-off-by: Steve French --- fs/cifs/cifs_debug.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) seq_puts(m, "rdma "); @@ -354,7 +354,7 @@ static int cifs_debug_data_proc_show(struct seq_file *m, void *v) seq_printf(m, "\n\tServer interfaces: %zu\n", ses->iface_count); for (j = 0; j < ses->iface_count; j++) { - seq_printf(m, "\t%d)\n", j); + seq_printf(m, "\t%d)", j); cifs_dump_iface(m, &ses->iface_list[j]); } spin_unlock(&ses->iface_lock); From 966aa81ed697955effd1ddba457c73b3d1490845 Mon Sep 17 00:00:00 2001 From: Steve French Date: Fri, 19 Oct 2018 21:21:37 -0500 Subject: [PATCH] smb3 - clean up debug output displaying network interfaces Make the output of /proc/fs/cifs/DebugData a little easier to read by cleaning up the listing of network interfaces removing a wasted line break. Here is a comparison of the network interface information that from be viewed at the end of output from "cat /proc/fs/cifs/DebugData" Before: Server interfaces: 8 0) Speed: 10000000000 bps Capabilities: rss IPv6: fe80:0000:0000:0000:2cf5:407e:84b0:21dd 1) Speed: 1000000000 bps Capabilities: IPv6: fe80:0000:0000:0000:61cd:6147:3d0c:f484 vs. after: Server interfaces: 11 0) Speed: 10000000000 bps Capabilities: rss IPv6: fe80:0000:0000:0000:2cf5:407e:84b0:21dd 1) Speed: 2000000000 bps Capabilities: IPv6: fe80:0000:0000:0000:3d76:2d05:dcf8:ed10 Signed-off-by: Steve French --- fs/cifs/cifs_debug.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/cifs/cifs_debug.c b/fs/cifs/cifs_debug.c index 3ae62ec74c8d..3e812428ac8d 100644 --- a/fs/cifs/cifs_debug.c +++ b/fs/cifs/cifs_debug.c @@ -132,7 +132,7 @@ cifs_dump_iface(struct seq_file *m, struct cifs_server_iface *iface) struct sockaddr_in *ipv4 = (struct sockaddr_in *)&iface->sockaddr; struct sockaddr_in6 *ipv6 = (struct sockaddr_in6 *)&iface->sockaddr; - seq_printf(m, "\t\tSpeed: %zu bps\n", iface->speed); + seq_printf(m, "\tSpeed: %zu bps\n", iface->speed); seq_puts(m, "\t\tCapabilities: "); if (iface->rdma_capable) seq_puts(m, "rdma "); @@ -354,7 +354,7 @@ static int cifs_debug_data_proc_show(struct seq_file *m, void *v) seq_printf(m, "\n\tServer interfaces: %zu\n", ses->iface_count); for (j = 0; j < ses->iface_count; j++) { - seq_printf(m, "\t%d)\n", j); + seq_printf(m, "\t%d)", j); cifs_dump_iface(m, &ses->iface_list[j]); } spin_unlock(&ses->iface_lock); -- 2.17.1