From patchwork Thu Oct 18 19:51:38 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heinrich Schuchardt X-Patchwork-Id: 986188 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.denx.de (client-ip=81.169.180.215; helo=lists.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=gmx.de Received: from lists.denx.de (dione.denx.de [81.169.180.215]) by ozlabs.org (Postfix) with ESMTP id 42bfnv3k6Vz9sBq for ; Fri, 19 Oct 2018 06:52:03 +1100 (AEDT) Received: by lists.denx.de (Postfix, from userid 105) id 2781FC21C27; Thu, 18 Oct 2018 19:52:00 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=FREEMAIL_FROM, RCVD_IN_DNSWL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from lists.denx.de (localhost [IPv6:::1]) by lists.denx.de (Postfix) with ESMTP id B3922C21C27; Thu, 18 Oct 2018 19:51:56 +0000 (UTC) Received: by lists.denx.de (Postfix, from userid 105) id 659A8C21C27; Thu, 18 Oct 2018 19:51:55 +0000 (UTC) Received: from mout.gmx.net (mout.gmx.net [212.227.15.19]) by lists.denx.de (Postfix) with ESMTPS id 12A09C21BE5 for ; Thu, 18 Oct 2018 19:51:55 +0000 (UTC) Received: from workstation4.fritz.box ([95.222.187.17]) by mail.gmx.com (mrgmx003 [212.227.17.184]) with ESMTPSA (Nemesis) id 0MDhGw-1gPrvC415a-00H3S0; Thu, 18 Oct 2018 21:51:53 +0200 Received: from workstation4.fritz.box ([95.222.187.17]) by mail.gmx.com (mrgmx003 [212.227.17.184]) with ESMTPSA (Nemesis) id 0MDhGw-1gPrvC415a-00H3S0; Thu, 18 Oct 2018 21:51:53 +0200 From: Heinrich Schuchardt To: Alexander Graf Date: Thu, 18 Oct 2018 21:51:38 +0200 Message-Id: <20181018195138.13922-1-xypron.glpk@gmx.de> X-Mailer: git-send-email 2.19.1 MIME-Version: 1.0 X-Provags-ID: V03:K1:6+KCCuWjRqfPkdF3O4R8ZM/uiv6vIMn0kloKpe1KWPSP/jc0UCZ Ygrc0e3JgYSoRSpeoqfmHcJPgCdj94JLbnSwkRrtomxk3Eq+STZQZexsZ4dSX8EFQ4vGXg0 9e6TBH9T1/ozJAkDRlu1Ie9/u57mHfAWk5j/dSw0l9QK9Bo63sHQjr7gX/rsf8V0Ey0vO3A UEnUecedeL5v411LvD6RA== X-UI-Out-Filterresults: notjunk:1; V01:K0:NKBNcCVEbcM=:Myy6FMgSm9CHi2YlLaRbTC GEWciTEShA4DY0Rp6Q3J2KwMUrkiq/dbjT+S4THVKa6befgB7Se11wjXrZJl3lRA+0pm64aAl SCCEbSTS0a3DIK0gM2mqlAC45p2byE4QmjzCIwk2Vgw/iI3xh4d0oJ/2Ndd2YRU+xUSPnMH0o 0+nD+p1aHW5taBMiaujyrN5E7Y/gdp5HEPntF1hWNIWc/bbyQyezbsJLJ9EXhKCO8kl6xH702 0MWOM5ZqvMBcskGCg1oyCAnINW0nudq3lmQ35gBc3XFeZIdgjiNm6jYYw/+IagiZW7eR1rW9t yUKCpj5kA4xekiAB0SrYNQkVCTM8okWGIFtJg6hEtV0m7iVAxIlIS0SQ24zxvhBXJbOwKH3zx fzCgUnVhpLF3x2FdX6CID4sLIgC14AmIkefKKMfxL1r4yc8eZVkGhSnGeTVM10ktDlrIOKjWy 9RdTBzIuxEsaKWxwbv9gcNfEez1kJSGVlms1ELlv9X/kU4ClxGUz9B3HrvF3UJseyuFFk1N5Q uCR/r5PYCbNJzlnbuLTNN3akElYtb3ExzYl9Vb8wZ7s7irSie1eSvGnbRyoNzgcbwxJyazuvY abqs5CqFISrC9vPjbcmjZiqEb9WSQyvNS2Z2dzwCQUdJcbSK7/HYFIkkDvJ8rttwoJy+zsPHb EhJUWtZx8Ute4kBTRzGcW3I6nSFP/rbB/NxH/kwPF9MklJKLaRgkyCzAZtxkbMhhwQegPNU0q slriF6NeBw4bKuvuiVhKuXbiQVueiuRQnqgkur/R9pu3iIXzah07YOEB/1PkUI8DJ7I+e6Ij+ fMIjrus7OB/F3HZ0H9+WXKAWv0roQ== Cc: u-boot@lists.denx.de, Heinrich Schuchardt Subject: [U-Boot] [PATCH 1/1] efi_loader: fix typos X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.18 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" Fix typos in EFI subsystem comments. Signed-off-by: Heinrich Schuchardt --- cmd/bootefi.c | 2 +- lib/efi_loader/efi_bootmgr.c | 2 +- lib/efi_loader/efi_console.c | 4 ++-- lib/efi_loader/efi_device_path_to_text.c | 8 ++++---- lib/efi_loader/efi_gop.c | 11 +++++++---- lib/efi_loader/efi_net.c | 8 ++++---- 6 files changed, 19 insertions(+), 16 deletions(-) diff --git a/cmd/bootefi.c b/cmd/bootefi.c index 78f126f1c6..3605c3ff96 100644 --- a/cmd/bootefi.c +++ b/cmd/bootefi.c @@ -354,7 +354,7 @@ static efi_status_t do_bootefi_exec(void *efi, /* * Special case for efi payload not loaded from disk, such as * 'bootefi hello' or for example payload loaded directly into - * memory via jtag, etc: + * memory via JTAG, etc: */ if (!device_path && !image_path) { printf("WARNING: using memory device/image path, this may confuse some payloads!\n"); diff --git a/lib/efi_loader/efi_bootmgr.c b/lib/efi_loader/efi_bootmgr.c index 0c5764db12..2aae12e154 100644 --- a/lib/efi_loader/efi_bootmgr.c +++ b/lib/efi_loader/efi_bootmgr.c @@ -1,6 +1,6 @@ // SPDX-License-Identifier: GPL-2.0+ /* - * EFI utils + * EFI boot manager * * Copyright (c) 2017 Rob Clark */ diff --git a/lib/efi_loader/efi_console.c b/lib/efi_loader/efi_console.c index 7274d75204..66c33a551d 100644 --- a/lib/efi_loader/efi_console.c +++ b/lib/efi_loader/efi_console.c @@ -205,7 +205,7 @@ static int query_console_serial(int *rows, int *cols) /* * Not all terminals understand CSI [18t for querying the console size. * We should adhere to escape sequences documented in the console_codes - * manpage and the ECMA-48 standard. + * man page and the ECMA-48 standard. * * So here we follow a different approach. We position the cursor to the * bottom right and query its position. Before leaving the function we @@ -480,7 +480,7 @@ void set_shift_mask(int mod, struct efi_key_state *key_state) * * This gets called when we have already parsed CSI. * - * @modifiers: bitmask (shift, alt, ctrl) + * @modifiers: bit mask (shift, alt, ctrl) * @return: the unmodified code */ static int analyze_modifiers(struct efi_key_state *key_state) diff --git a/lib/efi_loader/efi_device_path_to_text.c b/lib/efi_loader/efi_device_path_to_text.c index 0082236359..e219f84b28 100644 --- a/lib/efi_loader/efi_device_path_to_text.c +++ b/lib/efi_loader/efi_device_path_to_text.c @@ -269,9 +269,9 @@ static char *efi_convert_single_device_node_to_text( * for details. * * device_node device node to be converted - * display_only true if the shorter text represenation shall be used + * display_only true if the shorter text representation shall be used * allow_shortcuts true if shortcut forms may be used - * @return text represenation of the device path + * @return text representation of the device path * NULL if out of memory of device_path is NULL */ static uint16_t EFIAPI *efi_convert_device_node_to_text( @@ -302,9 +302,9 @@ out: * for details. * * device_path device path to be converted - * display_only true if the shorter text represenation shall be used + * display_only true if the shorter text representation shall be used * allow_shortcuts true if shortcut forms may be used - * @return text represenation of the device path + * @return text representation of the device path * NULL if out of memory of device_path is NULL */ static uint16_t EFIAPI *efi_convert_device_path_to_text( diff --git a/lib/efi_loader/efi_gop.c b/lib/efi_loader/efi_gop.c index fbd5d97de9..d62ce45912 100644 --- a/lib/efi_loader/efi_gop.c +++ b/lib/efi_loader/efi_gop.c @@ -243,12 +243,12 @@ static efi_uintn_t gop_get_bpp(struct efi_gop *this) } /* - * Gcc can't optimize our BLT function well, but we need to make sure that + * GCC can't optimize our BLT function well, but we need to make sure that * our 2-dimensional loop gets executed very quickly, otherwise the system * will feel slow. * * By manually putting all obvious branch targets into functions which call - * our generic blt function with constants, the compiler can successfully + * our generic BLT function with constants, the compiler can successfully * optimize for speed. */ static efi_status_t gop_blt_video_fill(struct efi_gop *this, @@ -452,7 +452,7 @@ efi_status_t efi_gop_register(void) ret = efi_add_protocol(&gopobj->header, &efi_gop_guid, &gopobj->ops); if (ret != EFI_SUCCESS) { - printf("ERROR: Failure adding gop protocol\n"); + printf("ERROR: Failure adding GOP protocol\n"); return ret; } gopobj->ops.query_mode = gop_query_mode; @@ -470,7 +470,10 @@ efi_status_t efi_gop_register(void) if (bpix == LCD_COLOR32) #endif { - /* With 32bit color space we can directly expose the fb */ + /* + * With 32bit color space we can directly expose the frame + * buffer + */ gopobj->mode.fb_base = fb_base; gopobj->mode.fb_size = fb_size; } diff --git a/lib/efi_loader/efi_net.c b/lib/efi_loader/efi_net.c index c4f35cd50d..a64c603ed3 100644 --- a/lib/efi_loader/efi_net.c +++ b/lib/efi_loader/efi_net.c @@ -269,7 +269,7 @@ static efi_status_t EFIAPI efi_net_receive(struct efi_simple_network *this, if (protocol) *protocol = protlen; if (*buffer_size < net_rx_packet_len) { - /* Packet doesn't fit, try again with bigger buf */ + /* Packet doesn't fit, try again with bigger buffer */ *buffer_size = net_rx_packet_len; return EFI_EXIT(EFI_BUFFER_TOO_SMALL); } @@ -319,11 +319,11 @@ efi_status_t efi_net_register(void) efi_status_t r; if (!eth_get_dev()) { - /* No eth device active, don't expose any */ + /* No network device active, don't expose any */ return EFI_SUCCESS; } - /* We only expose the "active" eth device, so one is enough */ + /* We only expose the "active" network device, so one is enough */ netobj = calloc(1, sizeof(*netobj)); if (!netobj) { printf("ERROR: Out of memory\n"); @@ -397,7 +397,7 @@ efi_status_t efi_net_register(void) printf("ERROR: Failed to register network event\n"); return r; } - /* Network is time critical, create event in every timer cyle */ + /* Network is time critical, create event in every timer cycle */ r = efi_set_timer(network_timer_event, EFI_TIMER_PERIODIC, 0); if (r != EFI_SUCCESS) { printf("ERROR: Failed to set network timer\n");