From patchwork Mon Oct 9 10:11:51 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Prabhakar Kushwaha X-Patchwork-Id: 823161 X-Patchwork-Delegate: yorksun@freescale.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.denx.de (client-ip=81.169.180.215; helo=lists.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Received: from lists.denx.de (dione.denx.de [81.169.180.215]) by ozlabs.org (Postfix) with ESMTP id 3y9bdn1TxRz9tXx for ; Mon, 9 Oct 2017 21:12:29 +1100 (AEDT) Received: by lists.denx.de (Postfix, from userid 105) id E9536C21D56; Mon, 9 Oct 2017 10:12:21 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=BAD_ENC_HEADER, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from lists.denx.de (localhost [IPv6:::1]) by lists.denx.de (Postfix) with ESMTP id 51BEFC21C45; Mon, 9 Oct 2017 10:12:18 +0000 (UTC) Received: by lists.denx.de (Postfix, from userid 105) id 52D54C21C45; Mon, 9 Oct 2017 10:12:17 +0000 (UTC) Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-sn1nam02on0067.outbound.protection.outlook.com [104.47.36.67]) by lists.denx.de (Postfix) with ESMTPS id 918A6C21C40 for ; Mon, 9 Oct 2017 10:12:16 +0000 (UTC) Received: from MWHPR03CA0040.namprd03.prod.outlook.com (10.174.173.157) by BN3PR03MB2355.namprd03.prod.outlook.com (10.166.74.150) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.77.7; Mon, 9 Oct 2017 10:12:14 +0000 Received: from BN1BFFO11FD032.protection.gbl (2a01:111:f400:7c10::1:119) by MWHPR03CA0040.outlook.office365.com (2603:10b6:301:3b::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.77.7 via Frontend Transport; Mon, 9 Oct 2017 10:12:14 +0000 Authentication-Results: spf=fail (sender IP is 192.88.158.2) smtp.mailfrom=nxp.com; nxp.com; dkim=none (message not signed) header.d=none;nxp.com; dmarc=fail action=none header.from=nxp.com; Received-SPF: Fail (protection.outlook.com: domain of nxp.com does not designate 192.88.158.2 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.158.2; helo=az84smr01.freescale.net; Received: from az84smr01.freescale.net (192.88.158.2) by BN1BFFO11FD032.mail.protection.outlook.com (10.58.144.95) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.20.77.10 via Frontend Transport; Mon, 9 Oct 2017 10:12:13 +0000 Received: from VirtualBox.ap.freescale.net (B32579-16.ap.freescale.net [10.232.40.136]) by az84smr01.freescale.net (8.14.3/8.14.0) with ESMTP id v99AC9sc015961; Mon, 9 Oct 2017 03:12:10 -0700 From: Prabhakar Kushwaha To: Date: Mon, 9 Oct 2017 15:41:51 +0530 Message-ID: <1507543911-22268-1-git-send-email-prabhakar.kushwaha@nxp.com> X-Mailer: git-send-email 2.7.4 X-EOPAttributedMessage: 0 X-Matching-Connectors: 131520175339910906; (91ab9b29-cfa4-454e-5278-08d120cd25b8); () X-Forefront-Antispam-Report: CIP:192.88.158.2; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(336005)(39380400002)(376002)(346002)(39860400002)(2980300002)(1110001)(1109001)(339900001)(199003)(189002)(33646002)(106466001)(316002)(5660300001)(6666003)(54906003)(97736004)(189998001)(5003940100001)(16586007)(85426001)(77096006)(50226002)(104016004)(68736007)(53936002)(356003)(4326008)(105606002)(6916009)(81166006)(2906002)(8936002)(8676002)(69596002)(305945005)(86362001)(47776003)(8656003)(48376002)(50466002)(81156014)(50986999)(2351001)(36756003)(498600001); DIR:OUT; SFP:1101; SCL:1; SRVR:BN3PR03MB2355; H:az84smr01.freescale.net; FPR:; SPF:Fail; PTR:InfoDomainNonexistent; A:1; MX:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BN1BFFO11FD032; 1:1Rdvy0x8UaCdMyNXUhcxxaKRWfBYJJDYivV25NK0KEIvZuLB56KQseVoHllZnOYQH1lZBEpZhLgBracQtc5f/SjMYTcdbXoFQqpSJYGT6u/Sb9yh2CliGeuJVsmtjey9 MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: f39813dc-a811-43bd-5599-08d50efe3663 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(2017052603199)(201703131430075)(201703131517081); SRVR:BN3PR03MB2355; X-Microsoft-Exchange-Diagnostics: 1; BN3PR03MB2355; 3:e6cnV6Xh0awtVl6vjgr8G4wNwZmyfv97D6a5bIlSehdNMvhlwTrXHFvJuaU4wrChxspENfpUbXrpzk3BFsPWcgsn4vT7a8RvE9/fiB62bkah4H8SPT6TJX6K/xqX1nWYGygVWSlq0INie058XpQUoUN66X8AujRM82npFmJTybV85uMMURGbeW4Dx1PUz0DnK5XU+xyOKlPHSc8MR+/j3429st8tjdZIJAwVcYxoLIJwe4RCg6YSO9UJP6ypeF5MfwiILglSlYLFUgdMvVMiaHO6YuGIoUU4b8VLLffdIyadc45dp57vAEEf4cC+h14U1v33pP8tozNZdaMQ6ZpSoNYpRrblPIg7fmOqyInwiBI=; 25:whtIq3G4vuoV4d2zmkdyibirMAiUMFy+v1JVZdhKPLUbNqsNpr9ZHWcD3FWcTTQhOwTKy0YJ2BxGYn+/EGOvdhsn+vhU7pEXw7VN7a9UB7VPHY4scgfifTs21z7TMGdFUdnEY9h3hcuqolAvvJ8iPsZ/u9cu/tYzpqG2Kp2AYQmZmLBEKyPCuPRZzNgYtYYV92AB9NQPz61X6PXNFVNcvc++AWq0Q66cwqWBt37ZJrM600aINYF6oZYWboYsRo1FYiQoQ6JjHRrzICIFCsKqDxs++9/Jo/ugY8nigLjId/xLiL3zCwSJb8i44GuKRscaDHjn+i94efxPJv1VU3ncjg== X-MS-TrafficTypeDiagnostic: BN3PR03MB2355: X-Microsoft-Exchange-Diagnostics: 1; BN3PR03MB2355; 31:ZH9969EdhBnEkRdyK2t9loNKosBI8hqYYVaS10EHwNvoGawiFKbZUXPg5L/ujEJ49xS4Nn+bRHAPkr/Uza+qTRenk0orazMXRq7QuE3a6MQU/DNYxvv0yl0g3Hq+9nQ9hvPU7YmeTMe9ph3pUrfOWthJOVmjfq9/3DSqgdGZt7ENb9Hr6x8syI0z8GVyzdyX0PDkYhbIgCKY1EIVS7/8msTEiuTV51dXmueKdphMgt4=; 4:o4NP7QS0fsXKZrqIHfPjFIGtTuVG0a0JdYz9n0nhAz663FscKPXhArixR9B7SSehSmieoAq7VeVKoLCRO7/9iwGJph/TVL5qEJ8UKQaXvxV8lwz84+BTLIQORKxM7JBl2xFxw0abk6fytH6AYfD+9fKgaF/LmrqU3kLq5zaX5CZUqGoIBBnCDNcTGnbmPLd1cFVWIozgOdUkxkRWgYD/4L0ERHlz/xsUzkD0XG+mRcNrNBM28Zm325oRIjseJULEVkwQnQ25C0MObRtisXJA+KNufT7Kxpgfa67H28TLTy9w3tD3Ahs5M+hsQKjJNjZi9BN8X/O0Z0VrtptGOwjakA== X-Exchange-Antispam-Report-Test: UriScan:(185117386973197)(275809806118684); X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6095135)(2401047)(5005006)(8121501046)(100000703101)(100105400095)(10201501046)(3002001)(93006095)(93001095)(6055026)(6096035)(20161123561025)(20161123556025)(20161123565025)(20161123563025)(201703131430075)(201703131433075)(201703131448075)(201703161259150)(201703151042153)(20161123559100)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:BN3PR03MB2355; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(400006)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:BN3PR03MB2355; X-Forefront-PRVS: 045584D28C X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BN3PR03MB2355; 23:+DZJ/KAn78gC4wDFHVhkORkvsMF2Q9Cn1IGt360x5?= t/IhXPptynDZBUhEvA9SePu38bpaZSUzuFPcxGk2Ft4ZZrDnA2ud353i51JlbKY2RxDH4+FJFKTGHrjbUh1dKBZrNfV0Z+7oWRorpQ9Vq9vNpE2q+4AHbvgeaAmjIdhXt+swnms5qYEBeFX1wZngq/wC2a2UwlzU+PY6DnwlCUStXpycfuOGIuwdPSY/UCXLjksmaHx9CL0BekWU9/a4jNPJNe/5pUEx9SPg3rTF3VgxNXBgl7DotS1tZ41EECSOM6HEw8C/+0a+fyIhQsU8wxNxTC0HRhVrheypI7KvW5PP3SwmjRxYNDBccDRmPRWa4oSPDWncKVUdp1jnSJWLOhQGfQD9ohBOR0El5Q3WjIh6ntfczfG046584DXf/Rv2ooeZAwCa3uzPTHr6OmQCMWm+5Sx0v5d407lbMVIvkEx6wzVlEwt/bdAgOS6d9MqVTcQeeUJIaKOhDlnQnghuW/Fh4UVk7tGT5y30Algp58ZqxFenUrSTpk6tmwQIF6y891N0a6Rsu7nY1OyPzl4MJi46azIGA82KL5Upw7kIsShWpbyT+oT+kU/pUmgpfZ7wqpfV3wM/ryrRrXSbaDc9e2HF2rSawrl22YGuXIJZeWXwD9CsYPKUzJcVYJG54SjVRFFwYGz4VoGrcqzSrUT55CPDCpcSMo4vVtgmacfENcge1zO8qhmSQy5gpta8+B5fsYaVuSfIZrNvWtbmk2f5A+NjtTOktSgN5R17rmvqRl3DjkDR5gLxZRg9r22JqYfnubt0AGMUtRKBiLpFYRCc6RgzdLpnBJ+TQ43KSklallfI919/Nu/fht/HQt0i+SuNnOvXNaWL/WAhcEg+s4FOWAf49TdlUKYf3R5g9k8ziBTAZmJr/Xn7mx+KqwBZSeNpgI5o5C2Iq2PNMfTLdcnCljOnhOGSnHA8LeLeu3bWEspJZL4ObQCNbuR5f7aDMKzHDRj9L4sYYKCMlUX6S5vi34a2AwTdswq/Jh0F4qXd2iPkCWaL5B5IQceYCqYcNKRkTBEO0kxCttllW9vi9O+x4WLqCXLucpNmPzQQTfzKH3BRXhDj7OullazKlM8YuZrPaVUMPe0IyQsYzuj+gkBJKWh X-Microsoft-Exchange-Diagnostics: 1; BN3PR03MB2355; 6:YTzjSCBTzgFmLznlseq7JyBzePjjI+UalWXa2WhcEq8TVsCFTf2CNkTNMIXfwmi81Uwf9uogfcfD/g8L62Z57OvaYRgWkYMN+rjqWAD7tmUz33Ug/xs6WhRFF8VlUrLmfu2kF8O+YHm6+bQ798g5dDu1cE9poCAUrMjM4V9fQKd3MLIWpqo29DuvikNTDJYFdM3PxlYOa0V2robWC8/RKk/QRQrCRB1JGsuFvspY5CrwapcApTCgJ5pyPSL5aqkCswZuKU2rhNDVuWXQ/fS57E5RWnQHRaCaZ4VRoqR6fBnNdKQrpOA0CFDtqISjPzqj7XQmSmXIH9GYMMbl925udQ==; 5:GIKc6eiA/sS9+tCy35xsFWffUem9TktyLzGx94t9euthPqp4sUZorg5AnCwPCjuYeiEaPFGTYUzBRBaFb5KX/HZMQykxGNhikcqV2Spfw2Y/y1pXYcLMpVz0/hWCr+PMFAD186h/VgFghHa7WrZHkQ==; 24:EWEL5CLZCp3NGMPJxgEq6bXgTqlBGQgiEiwQrEkgNoH/0YvEwtKKR3QetFPhhcjqWst5h27MMWxCF9WhZyRyPiqYUUtg/6ofw3UFYJrv7ZI=; 7:hJXd+TNQYQv13rD9FhrV+MzQ/b+maREyoCyoZlpj8HAWVx3j10xcMxQseuc/Nc5IflZmbnJuDqg80O9pOqACrYbt4F8OCXyBZr1Ql25hPTJ/Ezxny/znBdDO79IWpIfrGWI+kKtwM5GA4/qyPe50CuSEui4X0+r3LZSqghXQwVAgJ4CX2FrFY8wRIgrSsCwIenzdccYSneTCeX6rAdYXloTMEk03Cy971+H0wN6Y0LQ= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Oct 2017 10:12:13.7414 (UTC) X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.158.2]; Helo=[az84smr01.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN3PR03MB2355 Cc: joe.hershberger@ni.com Subject: [U-Boot] [PATCH][v3] driver: fsl-mc: memset pointers after malloc X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.18 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" Memory allocated via malloc is not guaranteed to be zeroized. So explicitly use calloc instead of malloc. Signed-off-by: Prabhakar Kushwaha --- Changes for v2: Replaced malloc/memset with calloc Changes for v3: Updated patch description drivers/net/fsl-mc/mc.c | 39 +++++++++++++++++++++------------------ 1 file changed, 21 insertions(+), 18 deletions(-) diff --git a/drivers/net/fsl-mc/mc.c b/drivers/net/fsl-mc/mc.c index 458c458..05d3358 100644 --- a/drivers/net/fsl-mc/mc.c +++ b/drivers/net/fsl-mc/mc.c @@ -725,9 +725,9 @@ int mc_init(u64 mc_fw_addr, u64 mc_dpc_addr) * Initialize the global default MC portal * And check that the MC firmware is responding portal commands: */ - root_mc_io = (struct fsl_mc_io *)malloc(sizeof(struct fsl_mc_io)); + root_mc_io = (struct fsl_mc_io *)calloc(sizeof(struct fsl_mc_io), 1); if (!root_mc_io) { - printf(" No memory: malloc() failed\n"); + printf(" No memory: calloc() failed\n"); return -ENOMEM; } @@ -877,11 +877,12 @@ static int dpio_init(void) struct dpio_cfg dpio_cfg; int err = 0; - dflt_dpio = (struct fsl_dpio_obj *)malloc(sizeof(struct fsl_dpio_obj)); + dflt_dpio = (struct fsl_dpio_obj *)calloc( + sizeof(struct fsl_dpio_obj), 1); if (!dflt_dpio) { - printf("No memory: malloc() failed\n"); + printf("No memory: calloc() failed\n"); err = -ENOMEM; - goto err_malloc; + goto err_calloc; } dpio_cfg.channel_mode = DPIO_LOCAL_CHANNEL; @@ -946,7 +947,7 @@ err_get_attr: dpio_destroy(dflt_mc_io, MC_CMD_NO_FLAGS, dflt_dpio->dpio_handle); err_create: free(dflt_dpio); -err_malloc: +err_calloc: return err; } @@ -1028,11 +1029,11 @@ static int dprc_init(void) goto err_create; } - dflt_mc_io = (struct fsl_mc_io *)malloc(sizeof(struct fsl_mc_io)); + dflt_mc_io = (struct fsl_mc_io *)calloc(sizeof(struct fsl_mc_io), 1); if (!dflt_mc_io) { err = -ENOMEM; - printf(" No memory: malloc() failed\n"); - goto err_malloc; + printf(" No memory: calloc() failed\n"); + goto err_calloc; } child_portal_id = MC_PORTAL_OFFSET_TO_PORTAL_ID(mc_portal_offset); @@ -1057,7 +1058,7 @@ static int dprc_init(void) return 0; err_child_open: free(dflt_mc_io); -err_malloc: +err_calloc: dprc_destroy_container(root_mc_io, MC_CMD_NO_FLAGS, root_dprc_handle, child_dprc_id); err_create: @@ -1108,11 +1109,12 @@ static int dpbp_init(void) struct dpbp_attr dpbp_attr; struct dpbp_cfg dpbp_cfg; - dflt_dpbp = (struct fsl_dpbp_obj *)malloc(sizeof(struct fsl_dpbp_obj)); + dflt_dpbp = (struct fsl_dpbp_obj *)calloc( + sizeof(struct fsl_dpbp_obj), 1); if (!dflt_dpbp) { - printf("No memory: malloc() failed\n"); + printf("No memory: calloc() failed\n"); err = -ENOMEM; - goto err_malloc; + goto err_calloc; } dpbp_cfg.options = 512; @@ -1162,7 +1164,7 @@ err_get_attr: dpbp_close(dflt_mc_io, MC_CMD_NO_FLAGS, dflt_dpbp->dpbp_handle); dpbp_destroy(dflt_mc_io, MC_CMD_NO_FLAGS, dflt_dpbp->dpbp_handle); err_create: -err_malloc: +err_calloc: return err; } @@ -1204,11 +1206,12 @@ static int dpni_init(void) struct dpni_extended_cfg dpni_extended_cfg; struct dpni_cfg dpni_cfg; - dflt_dpni = (struct fsl_dpni_obj *)malloc(sizeof(struct fsl_dpni_obj)); + dflt_dpni = (struct fsl_dpni_obj *)calloc( + sizeof(struct fsl_dpni_obj), 1); if (!dflt_dpni) { - printf("No memory: malloc() failed\n"); + printf("No memory: calloc() failed\n"); err = -ENOMEM; - goto err_malloc; + goto err_calloc; } memset(&dpni_extended_cfg, 0, sizeof(dpni_extended_cfg)); @@ -1270,7 +1273,7 @@ err_get_attr: err_create: err_prepare_extended_cfg: free(dflt_dpni); -err_malloc: +err_calloc: return err; }