From patchwork Thu Oct 4 21:40:36 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Leonardo Sandoval X-Patchwork-Id: 979233 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=sourceware.org (client-ip=209.132.180.131; helo=sourceware.org; envelope-from=libc-alpha-return-96262-incoming=patchwork.ozlabs.org@sourceware.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=linux.intel.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.b="lppjJacv"; dkim-atps=neutral Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 42R5st2cSNz9s5c for ; Fri, 5 Oct 2018 07:40:50 +1000 (AEST) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:cc:subject:date:message-id :mime-version:content-transfer-encoding; q=dns; s=default; b=ivx Iia5uEnDrZVYk3Pnbv7kJUB/ybd6yUtTzFOvK37wNoeC1/KkO8+g1gzUxfHs7RtD 4hw7MoNwDV4VMez1/IwYy0lvxZycstWs3j3x306phYwGmRZTySk2S6vrnQEva8d0 wLiAUqTiTmWo9RmadJ+yQWu5vQd1lbk/AO7WahB0= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:cc:subject:date:message-id :mime-version:content-transfer-encoding; s=default; bh=cBdu+L2xY p95sXdxopTwNNFy9Zc=; b=lppjJacv2VKTgfswFwnd7et5WEtO1KxVG+1Yv2PcQ odZ1OXyPowhmS9OHilnzFFKpuK88vIdNLq4YyjjCN401+ZZ37VQYStD+F4YoVU3D K376gtzIOJoDdDSVKnxphxvcgS/L05opVCxXtHa3pMoNza7TnW1rH8nhilLy9+gD fA= Received: (qmail 52027 invoked by alias); 4 Oct 2018 21:40:44 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 51496 invoked by uid 89); 4 Oct 2018 21:40:43 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-25.9 required=5.0 tests=BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, KAM_LAZY_DOMAIN_SECURITY autolearn=ham version=3.3.2 spammy=HContent-Transfer-Encoding:8bit X-HELO: mga06.intel.com From: leonardo.sandoval.gonzalez@linux.intel.com To: libc-alpha@sourceware.org Cc: Leonardo Sandoval Subject: [PATCH] benchtests: Set float type on --threshold argument Date: Thu, 4 Oct 2018 16:40:36 -0500 Message-Id: <20181004214036.6611-1-leonardo.sandoval.gonzalez@linux.intel.com> MIME-Version: 1.0 From: Leonardo Sandoval Otherwise, we see the following runtime error when using the parameter: File "./glibc/benchtests/scripts/compare_bench.py", line 46, in do_compare if d > threshold: TypeError: '>' not supported between instances of 'float' and 'str' * benchtests/scripts/compare_bench.py (main): set float type on threshold argument. --- benchtests/scripts/compare_bench.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/benchtests/scripts/compare_bench.py b/benchtests/scripts/compare_bench.py index 88e8911d812..f4b7742f903 100755 --- a/benchtests/scripts/compare_bench.py +++ b/benchtests/scripts/compare_bench.py @@ -175,7 +175,7 @@ if __name__ == '__main__': parser.add_argument('--schema', default=os.path.join(os.path.dirname(os.path.realpath(__file__)),'benchout.schema.json'), help='JSON file to validate source/dest files (default: %(default)s)') - parser.add_argument('--threshold', default=10.0, help='Only print those with equal or higher threshold (default: %(default)s)') + parser.add_argument('--threshold', default=10.0, type=float, help='Only print those with equal or higher threshold (default: %(default)s)') args = parser.parse_args()