From patchwork Thu Oct 4 09:06:54 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Linus Walleij X-Patchwork-Id: 978715 Return-Path: X-Original-To: incoming-dt@patchwork.ozlabs.org Delivered-To: patchwork-incoming-dt@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=devicetree-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="gDnJUGkJ"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 42Qn8J2xrsz9s7h for ; Thu, 4 Oct 2018 19:07:12 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727030AbeJDP7X (ORCPT ); Thu, 4 Oct 2018 11:59:23 -0400 Received: from mail-lj1-f195.google.com ([209.85.208.195]:35101 "EHLO mail-lj1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727150AbeJDP7W (ORCPT ); Thu, 4 Oct 2018 11:59:22 -0400 Received: by mail-lj1-f195.google.com with SMTP id o14-v6so7697521ljj.2 for ; Thu, 04 Oct 2018 02:07:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=H/Kp78sd2+saCthpS30T8q1sq16alrR47c9IyCHdoi8=; b=gDnJUGkJLqvoqTk4gpo6pSkKCDWvUKZwCro3F/VkeY9tuPVFV71VFIsJbXMrrfEd6p tPqA7i1CxKhVqECIWuA6edrlczropnT858U0BiP6IToyFij2RSaQUNff4DsSQt2CUhVc Sr1Kjp7CoaZhcCjop429pibFweeX3C9NCe4qA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=H/Kp78sd2+saCthpS30T8q1sq16alrR47c9IyCHdoi8=; b=L/ScRYRC32T/IWfx5lC2lv4FWfCUbRY/wmHm577FoEhIxKBT5ySgRk0ruCTTHY/vyL lDrsaPwO/ost8qA+hEAPwSWbr/qEKVdExJkdyJUKW0ZUxzDh2hOwrfI9+Ev20CJE46lp JXs7BRYR7XT7bB4mEC8YwyivEtecF9r6UQXY6eDAbToN71ZBL028X+IODxT876R2m3xQ 7bCfrY+ZTKtmoWr3ENmEZIOqEAOWNT5OlU+O+jwuSQEqUiR80LG+vcSrXeqLRRiYZDsA DE6tZZDsHfhK6ENCpFHmxq4b7mPdEcY1qoTCKYdDW2v1WrRXHs+q+pj5tUldFL5v23Qq ed7A== X-Gm-Message-State: ABuFfoi8rXTUueho0SxfeuVMSME/6Uoab0gfGi5A+BHt0qaRDAoUEjOk PzNrtEZ10NabuYVYcKKeRCGtBA== X-Google-Smtp-Source: ACcGV62paG5o3AA1o2P/1bGa+BYBPSxy9yrNdbHgdyqsUbXliPo7ycYZcCNTuRL0+dJCx/Twp+ysTw== X-Received: by 2002:a2e:7d10:: with SMTP id y16-v6mr3432476ljc.37.1538644022985; Thu, 04 Oct 2018 02:07:02 -0700 (PDT) Received: from genomnajs.ideon.se ([85.235.10.227]) by smtp.gmail.com with ESMTPSA id n16-v6sm902218lji.28.2018.10.04.02.07.01 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 04 Oct 2018 02:07:01 -0700 (PDT) From: Linus Walleij To: Liam Girdwood , Mark Brown Cc: linux-kernel@vger.kernel.org, Linus Walleij , devicetree@vger.kernel.org, Leonard Crestez Subject: [PATCH] regulator: fixed: Use more standard GPIO binding Date: Thu, 4 Oct 2018 11:06:54 +0200 Message-Id: <20181004090654.32233-1-linus.walleij@linaro.org> X-Mailer: git-send-email 2.17.1 Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org The fixed regulator uses "gpio" (singularis) for the GPIO line but the standard GPIO bindings recommend "gpios" (pluralis). We have augmented the Linux kernel to handle both, so recommend the best practice and deprecate the singularis variant. Cc: devicetree@vger.kernel.org Cc: Leonard Crestez Suggested-by: Leonard Crestez Signed-off-by: Linus Walleij --- .../devicetree/bindings/regulator/fixed-regulator.txt | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/regulator/fixed-regulator.txt b/Documentation/devicetree/bindings/regulator/fixed-regulator.txt index 0c2a6c8a1536..a0d7f15ef5ca 100644 --- a/Documentation/devicetree/bindings/regulator/fixed-regulator.txt +++ b/Documentation/devicetree/bindings/regulator/fixed-regulator.txt @@ -5,7 +5,7 @@ Required properties: - regulator-name: Defined in regulator.txt as optional, but required here. Optional properties: -- gpio: gpio to use for enable control +- gpios: gpio to use for enable control - startup-delay-us: startup time in microseconds - enable-active-high: Polarity of GPIO is Active high If this property is missing, the default assumed is Active low. @@ -13,6 +13,10 @@ If this property is missing, the default assumed is Active low. If this property is missing then default assumption is false. -vin-supply: Input supply name. +Deprecated properties: +- gpio: singularis variant of "gpios" is allowed in accordance with the + GPIO bindings specification, but not recommended. + Any property defined as part of the core regulator binding, defined in regulator.txt, can also be used. However a fixed voltage regulator is expected to have the @@ -26,7 +30,7 @@ Example: regulator-name = "fixed-supply"; regulator-min-microvolt = <1800000>; regulator-max-microvolt = <1800000>; - gpio = <&gpio1 16 0>; + gpios = <&gpio1 16 0>; startup-delay-us = <70000>; enable-active-high; regulator-boot-on;