From patchwork Tue Sep 25 12:49:56 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Petr Vorel X-Patchwork-Id: 974391 X-Patchwork-Delegate: shemminger@vyatta.com Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=suse.cz Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 42KLWl6f18z9s47 for ; Tue, 25 Sep 2018 22:50:11 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729066AbeIYS5e (ORCPT ); Tue, 25 Sep 2018 14:57:34 -0400 Received: from mx2.suse.de ([195.135.220.15]:36666 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728289AbeIYS5e (ORCPT ); Tue, 25 Sep 2018 14:57:34 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 7EA3BB090; Tue, 25 Sep 2018 12:50:08 +0000 (UTC) From: Petr Vorel To: netdev@vger.kernel.org Cc: Petr Vorel , Stephen Hemminger Subject: [PATCH iproute2 1/1] DEBUG: Fix make check when need build generate_nlmsg Date: Tue, 25 Sep 2018 14:49:56 +0200 Message-Id: <20180925124956.10565-1-pvorel@suse.cz> X-Mailer: git-send-email 2.19.0 MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org make check from top level Makefile defines several flags which break building generate_nlmsg: $ make check make -C tools gcc -Wall -Wstrict-prototypes -Wmissing-prototypes -Wmissing-declarations -Wold-style-definition -Wformat=2 -O2 -I../include -I../include/uapi -DRESOLVE_HOSTNAMES -DLIBDIR=\"/usr/lib\" -DCONFDIR=\"/etc/iproute2\" -DNETNS_RUN_DIR=\"/var/run/netns\" -DNETNS_ETC_DIR=\"/etc/netns\" -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -DHAVE_SETNS -DHAVE_SELINUX -DHAVE_ELF -DHAVE_LIBMNL -I/usr/include/libmnl -DNEED_STRLCPY -DHAVE_LIBCAP ../lib/libutil.a ../lib/libnetlink.a -lselinux -lelf -lmnl -lcap -I../../include -include../../include/uapi/linux/netlink.h -o generate_nlmsg generate_nlmsg.c ../../lib/libnetlink.c -lmnl gcc: error: ../lib/libutil.a: No such file or directory gcc: error: ../lib/libnetlink.a: No such file or directory make[2]: *** [Makefile:5: generate_nlmsg] Error 1 make[1]: *** [Makefile:40: generate_nlmsg] Error 2 To fix it reset CFLAGS in sub Makefile and remove LDLIBS entirely (as required -lmnl flag was specified in 5dc2204c ("testsuite: add libmnl"). Fixes: 8804a8c0 ("Makefile: Add check target") Signed-off-by: Petr Vorel --- Hi Stephen, I'm sorry for this regression. Kind regards, Petr --- testsuite/tools/Makefile | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/testsuite/tools/Makefile b/testsuite/tools/Makefile index 7d53d226..e1d9bfef 100644 --- a/testsuite/tools/Makefile +++ b/testsuite/tools/Makefile @@ -1,8 +1,9 @@ # SPDX-License-Identifier: GPL-2.0 +CFLAGS= include ../../config.mk generate_nlmsg: generate_nlmsg.c ../../lib/libnetlink.c - $(CC) $(CPPFLAGS) $(CFLAGS) $(LDLIBS) $(EXTRA_CFLAGS) -I../../include -include../../include/uapi/linux/netlink.h -o $@ $^ -lmnl + $(CC) $(CPPFLAGS) $(CFLAGS) $(EXTRA_CFLAGS) -I../../include -include../../include/uapi/linux/netlink.h -o $@ $^ -lmnl clean: rm -f generate_nlmsg